From patchwork Thu Jul 6 15:45:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 13303975 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8A17EB64DC for ; Thu, 6 Jul 2023 15:48:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55F7F8D0007; Thu, 6 Jul 2023 11:48:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5107C8D0003; Thu, 6 Jul 2023 11:48:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FF1C8D0007; Thu, 6 Jul 2023 11:48:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3074A8D0003 for ; Thu, 6 Jul 2023 11:48:31 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 05972120434 for ; Thu, 6 Jul 2023 15:48:30 +0000 (UTC) X-FDA: 80981619222.02.CFCF896 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id AEB1518001F for ; Thu, 6 Jul 2023 15:48:27 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NcMKb6vg; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688658507; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HWqxM4GZuS9Wh/EiDlklJiCP+B1QvwXEzK3M+6mNoD4=; b=4FLFCvn18ot2ZiqVxExGh3i678yff2yWonYb39YuWbHYrFXzppWqf84iNl5LWOrWOUuv8S p5iwGsVWR36bLHKAS7HnntlChGVWM9Q4gryvnDF7pu5uqmglogODjX871X0Mi11VALAWX/ Z6iA/xAMOfj03ZIU+jQJNpTn7jazN3o= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NcMKb6vg; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688658507; a=rsa-sha256; cv=none; b=LeO/V761Z1igDeT/Xdat87shUfbOD/iT9TbUxrZ9NpDp84pjyVMtgKWD24fn9cvDPY+DOp fQVD4vo3qnxQvWIG2eVJU9VQbZYIJ0zXnsSPRIULRpHQcXVxjEAhhsove7v5OnKjJq3Rfo nqhXo+s5VUCI1XtMjsTPTUQ8P+uvSA8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688658507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HWqxM4GZuS9Wh/EiDlklJiCP+B1QvwXEzK3M+6mNoD4=; b=NcMKb6vg6rGTuRuAVqGtT/JNPWzwrfOPMCnR8O4c59UgCLIP6w3kvn07I7OHz9ffJUmBZ+ IlbHGQ7uUXerX9K6e6F0q2hq7/RgHSqMqhJh3SLCBNpr5rNrgBl0Qsok08oK5k+dK66Cjy DoKWbSKw0jP30aZfSgqM2ZkniFMYm3Q= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-132-UuzblcGlOgKAFhNrs83w1g-1; Thu, 06 Jul 2023 11:48:15 -0400 X-MC-Unique: UuzblcGlOgKAFhNrs83w1g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C74BE2815E25; Thu, 6 Jul 2023 15:48:14 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-39.pek2.redhat.com [10.72.12.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9200EF6401; Thu, 6 Jul 2023 15:48:05 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, arnd@arndb.de, hch@lst.de, christophe.leroy@csgroup.eu, rppt@kernel.org, willy@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, shorne@gmail.com, David.Laight@ACULAB.COM, deller@gmx.de, nathan@kernel.org, glaubitz@physik.fu-berlin.de, Baoquan He , Michael Ellerman , Nicholas Piggin , linuxppc-dev@lists.ozlabs.org Subject: [PATCH v8 17/19] powerpc: mm: Convert to GENERIC_IOREMAP Date: Thu, 6 Jul 2023 23:45:18 +0800 Message-Id: <20230706154520.11257-18-bhe@redhat.com> In-Reply-To: <20230706154520.11257-1-bhe@redhat.com> References: <20230706154520.11257-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: AEB1518001F X-Stat-Signature: e1f9qwazzbzitbhjurgwjsooq43j6tf6 X-HE-Tag: 1688658507-485999 X-HE-Meta: U2FsdGVkX1/FDJGEvHQvlngfGKQAhtigN/UZsccAS9z4jIjXL9xZKt2hsDo/JbCNBEENSyiu+H5rMKj9NkdjJ+kdC0w2t3wiuY1gQOWv6zR9JnE8IPAfwYgctd7wVjE4WstsngG5hAftL09x7QW7hndwNtxP2BI9HNJzs3NBTgnveYToDMVsoN5qOjZeeAAhF5Ut72WiUepV3FVWxXrLNlZjCbrFhYZCypHItWjFjBuIq3bj3lhnBmbm8hB+NA//hYZuJNoewAGIhtdeixxCylsgmNaC0jClgnAPp8uKzT9iU+ExQtqZBudkp7qteGmLi1I2xhGHh953fLCwsSw4SIVnMnJ6P6P3UWRxCLyKPyaRXSQEcjs2zHQGrvm77VNhoqYSrRxdo+GEpvmVEjmn98j1Pd8CAw5Mq3Dod2ttztM4VU6v72Q0YuABc3ewYA3tmVYYICEC6DX5BmwLR20CcN4s1Imqre6MDAUhkq0vbPURZxIHPeJq9EziEPgF/xsjbJOWxLI9/Jm4UdbwdVGNGRCjNuLi7INgphhkU5gTjGoPVrnjtvoTjrOIKiZCU6vNf9Xe28cy0omgw+MNpHp8QUecy+6skf96aQS7eweMG/sNIjUChzG7pgig1Sw1wnoeQE66sSmDcRzi7/rwQeOGxP8DebmjbUt7a/dJdAj/ZqJHcwG5L8i7OTBy2PHYC+LWK6g3t0X+OT5XWDkdeSHbdi3+/DEGFRL4opp8dL9xJXDoByMl9cymMhD058fU3vPtFHjGpMi7+390qPcjfknvfErbIuBilWwfpiP2OEIWapeRF7KDqa7X3GFr5oydq9oY7hK/tY/YO3xIFa/QybTFnatoXnn2qDK3RI17nL0M6tJJfNOO/TaYTL6IbuKZcDzwCFz4DL1BZkfc+YSCFVcGXeFMSDF5zlh2f/IW1fYGyQBgFSY8Tj0LIRei/4iVWTEzbmDuVf5ldq1tG63BJVZ Eg1frfCi hIZ6GF+Wo+hdI21leLXwAsX7Fqihj1WvY6pFEskiVojb8pWKJVl9qh7kjrmfVBMcprHkoJYAyRiRX2ibB4f4OLN6twfPL0Q6gVWASFnHtqbViITadGIHZdjdDuFl3qJ394Sz22LWZe6jcv9OWh5/oeniu/ErNjvxqhuTWh88EdH1vnXut3Yw//ap/cJ+tHdHT1Ms+2Gartq4HNePXo9OVQ4LjUT8fxseW4V4QIf4n0VZTVWbWoyhRlDVxjD5rpPtBDgWw/GH8OB2ZZaKewQm/NGk56zphnA+oObpA14G/l29SSR+uWKBiKnzRFrIZCphq19EunES5JJwBp1ZZqBidfZQl5vRIuYR5DRu7M40YsHJLG7ucxHx0OIYHWLBCtUUd9OcC0QPrPIJPQJdUEAOc5hCNsJ8PEwO5dhwp3/vsr0rAWGw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Christophe Leroy By taking GENERIC_IOREMAP method, the generic generic_ioremap_prot(), generic_iounmap(), and their generic wrapper ioremap_prot(), ioremap() and iounmap() are all visible and available to arch. Arch needs to provide wrapper functions to override the generic versions if there's arch specific handling in its ioremap_prot(), ioremap() or iounmap(). This change will simplify implementation by removing duplicated code with generic_ioremap_prot() and generic_iounmap(), and has the equivalent functioality as before. Here, add wrapper functions ioremap_prot() and iounmap() for powerpc's special operation when ioremap() and iounmap(). Signed-off-by: Christophe Leroy Signed-off-by: Baoquan He Reviewed-by: Christoph Hellwig Reviewed-by: Mike Rapoport (IBM) Cc: Michael Ellerman Cc: Nicholas Piggin Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/io.h | 8 +++----- arch/powerpc/mm/ioremap.c | 26 +------------------------- arch/powerpc/mm/ioremap_32.c | 19 +++++++++---------- arch/powerpc/mm/ioremap_64.c | 12 ++---------- 5 files changed, 16 insertions(+), 50 deletions(-) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 0b1172cbeccb..9222c138c457 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -193,6 +193,7 @@ config PPC select GENERIC_CPU_VULNERABILITIES if PPC_BARRIER_NOSPEC select GENERIC_EARLY_IOREMAP select GENERIC_GETTIMEOFDAY + select GENERIC_IOREMAP select GENERIC_IRQ_SHOW select GENERIC_IRQ_SHOW_LEVEL select GENERIC_PCI_IOMAP if PCI diff --git a/arch/powerpc/include/asm/io.h b/arch/powerpc/include/asm/io.h index 67a3fb6de498..0732b743e099 100644 --- a/arch/powerpc/include/asm/io.h +++ b/arch/powerpc/include/asm/io.h @@ -889,8 +889,8 @@ static inline void iosync(void) * */ extern void __iomem *ioremap(phys_addr_t address, unsigned long size); -extern void __iomem *ioremap_prot(phys_addr_t address, unsigned long size, - unsigned long flags); +#define ioremap ioremap +#define ioremap_prot ioremap_prot extern void __iomem *ioremap_wc(phys_addr_t address, unsigned long size); #define ioremap_wc ioremap_wc @@ -904,14 +904,12 @@ void __iomem *ioremap_coherent(phys_addr_t address, unsigned long size); #define ioremap_cache(addr, size) \ ioremap_prot((addr), (size), pgprot_val(PAGE_KERNEL)) -extern void iounmap(volatile void __iomem *addr); +#define iounmap iounmap void __iomem *ioremap_phb(phys_addr_t paddr, unsigned long size); int early_ioremap_range(unsigned long ea, phys_addr_t pa, unsigned long size, pgprot_t prot); -void __iomem *do_ioremap(phys_addr_t pa, phys_addr_t offset, unsigned long size, - pgprot_t prot, void *caller); extern void __iomem *__ioremap_caller(phys_addr_t, unsigned long size, pgprot_t prot, void *caller); diff --git a/arch/powerpc/mm/ioremap.c b/arch/powerpc/mm/ioremap.c index 4f12504fb405..705e8e8ffde4 100644 --- a/arch/powerpc/mm/ioremap.c +++ b/arch/powerpc/mm/ioremap.c @@ -41,7 +41,7 @@ void __iomem *ioremap_coherent(phys_addr_t addr, unsigned long size) return __ioremap_caller(addr, size, prot, caller); } -void __iomem *ioremap_prot(phys_addr_t addr, unsigned long size, unsigned long flags) +void __iomem *ioremap_prot(phys_addr_t addr, size_t size, unsigned long flags) { pte_t pte = __pte(flags); void *caller = __builtin_return_address(0); @@ -74,27 +74,3 @@ int early_ioremap_range(unsigned long ea, phys_addr_t pa, return 0; } - -void __iomem *do_ioremap(phys_addr_t pa, phys_addr_t offset, unsigned long size, - pgprot_t prot, void *caller) -{ - struct vm_struct *area; - int ret; - unsigned long va; - - area = __get_vm_area_caller(size, VM_IOREMAP, IOREMAP_START, IOREMAP_END, caller); - if (area == NULL) - return NULL; - - area->phys_addr = pa; - va = (unsigned long)area->addr; - - ret = ioremap_page_range(va, va + size, pa, prot); - if (!ret) - return (void __iomem *)area->addr + offset; - - vunmap_range(va, va + size); - free_vm_area(area); - - return NULL; -} diff --git a/arch/powerpc/mm/ioremap_32.c b/arch/powerpc/mm/ioremap_32.c index 9d13143b8be4..ca5bc6be3e6f 100644 --- a/arch/powerpc/mm/ioremap_32.c +++ b/arch/powerpc/mm/ioremap_32.c @@ -21,6 +21,13 @@ __ioremap_caller(phys_addr_t addr, unsigned long size, pgprot_t prot, void *call phys_addr_t p, offset; int err; + /* + * If the address lies within the first 16 MB, assume it's in ISA + * memory space + */ + if (addr < SZ_16M) + addr += _ISA_MEM_BASE; + /* * Choose an address to map it to. * Once the vmalloc system is running, we use it. @@ -31,13 +38,6 @@ __ioremap_caller(phys_addr_t addr, unsigned long size, pgprot_t prot, void *call offset = addr & ~PAGE_MASK; size = PAGE_ALIGN(addr + size) - p; - /* - * If the address lies within the first 16 MB, assume it's in ISA - * memory space - */ - if (p < 16 * 1024 * 1024) - p += _ISA_MEM_BASE; - #ifndef CONFIG_CRASH_DUMP /* * Don't allow anybody to remap normal RAM that we're using. @@ -63,7 +63,7 @@ __ioremap_caller(phys_addr_t addr, unsigned long size, pgprot_t prot, void *call return (void __iomem *)v + offset; if (slab_is_available()) - return do_ioremap(p, offset, size, prot, caller); + return generic_ioremap_prot(addr, size, prot); /* * Should check if it is a candidate for a BAT mapping @@ -87,7 +87,6 @@ void iounmap(volatile void __iomem *addr) if (v_block_mapped((unsigned long)addr)) return; - if (addr > high_memory && (unsigned long)addr < ioremap_bot) - vunmap((void *)(PAGE_MASK & (unsigned long)addr)); + generic_iounmap(addr); } EXPORT_SYMBOL(iounmap); diff --git a/arch/powerpc/mm/ioremap_64.c b/arch/powerpc/mm/ioremap_64.c index 3acece00b33e..d24e5f166723 100644 --- a/arch/powerpc/mm/ioremap_64.c +++ b/arch/powerpc/mm/ioremap_64.c @@ -29,7 +29,7 @@ void __iomem *__ioremap_caller(phys_addr_t addr, unsigned long size, return NULL; if (slab_is_available()) - return do_ioremap(paligned, offset, size, prot, caller); + return generic_ioremap_prot(addr, size, prot); pr_warn("ioremap() called early from %pS. Use early_ioremap() instead\n", caller); @@ -49,17 +49,9 @@ void __iomem *__ioremap_caller(phys_addr_t addr, unsigned long size, */ void iounmap(volatile void __iomem *token) { - void *addr; - if (!slab_is_available()) return; - addr = (void *)((unsigned long __force)PCI_FIX_ADDR(token) & PAGE_MASK); - - if ((unsigned long)addr < ioremap_bot) { - pr_warn("Attempt to iounmap early bolted mapping at 0x%p\n", addr); - return; - } - vunmap(addr); + generic_iounmap(PCI_FIX_ADDR(token)); } EXPORT_SYMBOL(iounmap);