From patchwork Tue Jul 11 05:50:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaohe Lin X-Patchwork-Id: 13308139 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E77AFEB64DC for ; Tue, 11 Jul 2023 05:50:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E5508E0002; Tue, 11 Jul 2023 01:50:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC86E8E0006; Tue, 11 Jul 2023 01:50:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A81D58E0008; Tue, 11 Jul 2023 01:50:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 40C7F8E0005 for ; Tue, 11 Jul 2023 01:50:11 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0F19080123 for ; Tue, 11 Jul 2023 05:50:11 +0000 (UTC) X-FDA: 80998255422.17.E51D947 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf11.hostedemail.com (Postfix) with ESMTP id B650540005 for ; Tue, 11 Jul 2023 05:50:08 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689054609; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LAkEVE24Qv+BBjIU19L5nrF8dLgTZ+0ofSIBY6kqzZM=; b=vscnAJf1YUasWWZeHcAn44iS9ZiVFDKRq2XveAM57iVhzytmoWPSuEBQZofmOPMVGy8IWH JlP+Zk32u5iidLyu+vn+DpV5bCjWuT0L+tLF2BasWyF+oNya8HsOHJy8M92xKyNaDeHiUL +jE8WHev4LU2UhGer+QJ5F/DNRNY6As= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689054609; a=rsa-sha256; cv=none; b=sDt9SPSZ9lIP62UqlSZdlK05+DNM1ofWKEcpVmOgiRH/U08BZY4OavGbwwqEWwJFJNJdo1 /QNhBBCA7/3irBsL+zYTfl/K8DqnZygML6m0B1q0HzqhUssa52iA0EWNyBezThJcf0VwNG BvtMILLq6sKkUcaQSfWoqKgjvYRO/uU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4R0VLc1cl3zqSHf; Tue, 11 Jul 2023 13:49:28 +0800 (CST) Received: from huawei.com (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 11 Jul 2023 13:50:01 +0800 From: Miaohe Lin To: , CC: , , Subject: [PATCH v2 1/8] mm: memory-failure: remove unneeded PageHuge() check Date: Tue, 11 Jul 2023 13:50:09 +0800 Message-ID: <20230711055016.2286677-2-linmiaohe@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20230711055016.2286677-1-linmiaohe@huawei.com> References: <20230711055016.2286677-1-linmiaohe@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: B650540005 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: u93dausogz4wcmr1abh364hfajebqsaj X-HE-Tag: 1689054608-404715 X-HE-Meta: U2FsdGVkX1891ASlTqCDjkuDhD3JdyRuPMvJTM02kwr0vl+FX6OSBJTzv+7Hb3wxTqzrFf5qsEIgJpYddAGuH9S8M6wTMBw1UwbWT0tj8nNZoAFSSKzr2UzhblFxOmCn2staXqeNHl3QZ/Bs3NiEj+lf6ghiXBkYxCSZ0M6JpanecM7y4ycKj93lRMBWrkA9EYrVM2B20/U3vSwC/IYA8dif0vgHQlmWwKisexVH84BMl/RZdLdOiIMmFVnaAkc3iKv9W2jFX+mjuZjjf3wYtd/2R9UNEc1cMCXoCEgabuYvia+azu0Qq9DH+LNeP6szYxsLd5LFF5Tv1B2zdKM8Na3yhaXeUBRI9KsgygyyjOJXBhgeESNz4E8n0zgYmYyps3+8gxhKp1dpaH1hbmargiVy93kPowdQInuOAAH9Rq0I6E18Rwd9Rv05AzYZsAgtOYawZqVrrCID7hmXp7sF+87No7hcVZD429a4a4frXnWy8/tPLPa0MNMmT9W8Rvap6MWRrYi+AZUOiOGSURznmiAzIDXJj7XeRTGteRORxaN35CQsCN418GN0cl94wmc1JteiAecwmzbLU6B7ARQKatn/nvWvYEOewSa5DKuQYB2A/oeadCQR/cDTahUI3Zd8ra1DXB6k+YBzJs9DRRnLyso0WeKaLaDx1RDPUqTwQsTunzc6hhCzIL+ePRIWovx+dpW6umO+DQpFQZV6CkfGrD4HayE9aG7Y2lfIwDnYUwyF7z28aqqXig5096bKWgQJ95p7Cbfkcm0jqHHJcv6nItmlVue/E/R9ms/lGVxOUu54w667b2Lmj/A96DnHskvkfhuLE9cYDGUZ3TsExBoHVhUEFCnKi/3hQg+0rNY2Z+zVy8uN4gnt8v6TuzN+B8e3VsUsLEw2aiGsEmIW4SO85PR9eG6Hd69g7ejt6cWigOySx95iadvNVc0dh3TqG3LbawazyLoBnTJxIyUQArQ MdNvWFie JlpB5uCuRF5NhKK+34MiWV2Wy6/QyqOMzT3D3sVUHVhU1V7Vz3JQRPjL2UqmtyL/dvxOdNWd7AYv+brveDs3KK0OzHo0IEs95OPUjSncPtpWTUPt390tyTYgWrgwRkHlB7y+hK6LGuIolclY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: PageHuge() check in me_huge_page() is just for potential problems. Remove it as it's actually dead code and won't catch anything. Signed-off-by: Miaohe Lin Acked-by: Naoya Horiguchi --- mm/memory-failure.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index 64d7d34c177a..913fcf02ad38 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -1187,9 +1187,6 @@ static int me_huge_page(struct page_state *ps, struct page *p) struct address_space *mapping; bool extra_pins = false; - if (!PageHuge(hpage)) - return MF_DELAYED; - mapping = page_mapping(hpage); if (mapping) { res = truncate_error_page(hpage, page_to_pfn(p), mapping);