From patchwork Wed Jul 12 03:16:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: bibo mao X-Patchwork-Id: 13309544 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2358FC0015E for ; Wed, 12 Jul 2023 03:16:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F33506B0072; Tue, 11 Jul 2023 23:16:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE0E48D0001; Tue, 11 Jul 2023 23:16:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9868D6B0072; Tue, 11 Jul 2023 23:16:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 623026B0078 for ; Tue, 11 Jul 2023 23:16:29 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3329BB03D1 for ; Wed, 12 Jul 2023 03:16:29 +0000 (UTC) X-FDA: 81001496898.16.01630BA Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by imf30.hostedemail.com (Postfix) with ESMTP id 30F2A80010 for ; Wed, 12 Jul 2023 03:16:25 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of maobibo@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=maobibo@loongson.cn; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689131787; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NBAGQU2ubKyI1+YBwA1SLOrKSa0seSj8mfFvDVfCZBQ=; b=winDS8aB4cjkWg08Z/bfD3JGX8i4iQXIZFbHJHuFbpWjiFjpH3ZDCzRA1mdjkG0OiPlufn F+ImnIz+lsiwvAOhgqO9L0YPeYud4UbfqTZkFCeerhN3patPixReut0tkf5pOjW824NUfX 0gnlkTKIhAZvQH5dWcYvzs67AUIjPc0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of maobibo@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=maobibo@loongson.cn; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689131787; a=rsa-sha256; cv=none; b=Iz49v2mLy9gOe/WvYuGjmob5/w6LHXaJuG1knS38EZ6Y0nkBYBpqj/4okkZrX3YAWUEDIw yZXZp7+EhGz654k4pjTVkIMrq7/j1YUe1jnchpBENb/TzgZ/XJxg13Cc2xOVhz83xWGfDe Ww7lKlqk+aTjWNPE3Hgmz229CmYppe4= Received: from loongson.cn (unknown [10.2.9.158]) by gateway (Coremail) with SMTP id _____8DxqOoGG65kescDAA--.1201S3; Wed, 12 Jul 2023 11:16:22 +0800 (CST) Received: from kvm-1-158.loongson.cn (unknown [10.2.9.158]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxWM0GG65kA7cpAA--.53483S3; Wed, 12 Jul 2023 11:16:22 +0800 (CST) From: Bibo Mao To: Huacai Chen , Dennis Zhou , Tejun Heo , Christoph Lameter Cc: Andrew Morton , loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, WANG Xuerui Subject: [PATCH 1/3] mm/percpu: Remove some local variables in pcpu_populate_pte Date: Wed, 12 Jul 2023 11:16:20 +0800 Message-Id: <20230712031622.1888321-2-maobibo@loongson.cn> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20230712031622.1888321-1-maobibo@loongson.cn> References: <20230712031622.1888321-1-maobibo@loongson.cn> MIME-Version: 1.0 X-CM-TRANSID: AQAAf8CxWM0GG65kA7cpAA--.53483S3 X-CM-SenderInfo: xpdruxter6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBj93XoW7uFWrCr1UWw4fXrWUJr13trc_yoW8Xr4Up3 93W3s29r4fJwnrGan3Gas8Wr17Xw4rta4Fk3srXr1rZ3W3ZrnxWr4jyw42ga42yFWfZF1x Jr45Ja9rAan0v3cCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUkYb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6r4j6r4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI0UMc 02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUAVWUtwAv7VC2z280aVAF wI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JMxAIw28IcxkI7V AKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCj r7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6x IIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAI w20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x 0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU82g43UUUUU== X-Rspamd-Queue-Id: 30F2A80010 X-Rspam-User: X-Stat-Signature: kexjptry9eu1h4kt4x9dsx7reydwshor X-Rspamd-Server: rspam01 X-HE-Tag: 1689131785-578827 X-HE-Meta: U2FsdGVkX19JQivvAfqCARCMOYhnFgU6L3FDxaEW3TI4gulST/qIY9TaC1yrfedTBmBjJXIhmyVG08gYd11aaxOUze3dYvLFHGRnq4XIZ5Ok0TEDIS8vCq3mUhQi9pQKdObqsl0AlxEiy0ET6BczZDOzw/g/gaoa7Vpu560Z0IBvERDJEN1Fzx9JqmDq+PeuFlb58Ni/oRoRrRh1wJAgemgHl9US9ZJhSJSrTDCxVvvP0OM9Xo/eZVX5xR48qVqCdjxGS5+gau3sugu3fdji3PB/U46E/vSm8iFRX3N5ry/4igR5y5RRisrBbjsjNjs/N8hoHBcF+8C2Sxux8gkV76URnlW+xU91/ukx0rx2MuYFM5of4nk9Dpbmc3oUeRqilOCF2efqnlKzkDhSAaG3bQ4Q2WyWdt8rydi7DyZsvcDMAzgNqqn9yXMNiS/RkEaxNHvBU8o4wdFJkdkL2LoPMjZ2od6QUM0jDD8AWmohiPdMNXSswhSd6dyiDnHiH7P838+QSLvqSVVSbgPMMklXQ/G7pKYEzYzizspCpKwJrncXLZ4Z8GQKH+C8fKDVxCftbEYOvPDhdrxRM1JtxjccNEkwwBqTcYqrrrGP5SQNhHSRInGtHKfkjMDfz/lwXEJuT4be5SvBHZ7uJRiLgVElkQ1DL26KckhP6ilOb2XO5XXspNupJIz7qKmJCl2Q3DpjeHQDRtdFa86DpibhUT4Obicg7NpvUI4GjvxrwUICz/I9aVLWShYlvlMMGdu9K1RtKeNpZf2W/Xgf7Buy9BEWMnfAX7x3BrtPjqteAWVA+QrYbjkKSH/xNNUYI29nuB7Z4/Y3RhdSX/IClc3tVzFx36oEaqcOjgpvi9ehLqiRwkAyPGJ8Jqw1db3qPKW32XsMcNv40y8PbQzZA0fYJFriA95H59pZ2n2DT1Y2FZetVRaYNwkdFr4ypKAwzHITUDMxHalbMJ6m3va5/JlCV/w Sz8KQxuO j+l/4VpDB7ZT4QC50P6K9Qm+L1q1bdBSV2I4RHCmwea3vUnNpeXRB6hODwjxe6nwV/R8rBRtf0OLSDIKLxOlSN2kUhg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In function pcpu_populate_pte there are already variable defined, it can be reused for later use, here remove duplicated local variables. Signed-off-by: Bibo Mao --- mm/percpu.c | 24 +++++++++--------------- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/mm/percpu.c b/mm/percpu.c index 28e07ede46f6..85e3f9b2a61f 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -3189,32 +3189,26 @@ void __init __weak pcpu_populate_pte(unsigned long addr) pmd_t *pmd; if (pgd_none(*pgd)) { - p4d_t *new; - - new = memblock_alloc(P4D_TABLE_SIZE, P4D_TABLE_SIZE); - if (!new) + p4d = memblock_alloc(P4D_TABLE_SIZE, P4D_TABLE_SIZE); + if (!p4d) goto err_alloc; - pgd_populate(&init_mm, pgd, new); + pgd_populate(&init_mm, pgd, p4d); } p4d = p4d_offset(pgd, addr); if (p4d_none(*p4d)) { - pud_t *new; - - new = memblock_alloc(PUD_TABLE_SIZE, PUD_TABLE_SIZE); - if (!new) + pud = memblock_alloc(PUD_TABLE_SIZE, PUD_TABLE_SIZE); + if (!pud) goto err_alloc; - p4d_populate(&init_mm, p4d, new); + p4d_populate(&init_mm, p4d, pud); } pud = pud_offset(p4d, addr); if (pud_none(*pud)) { - pmd_t *new; - - new = memblock_alloc(PMD_TABLE_SIZE, PMD_TABLE_SIZE); - if (!new) + pmd = memblock_alloc(PMD_TABLE_SIZE, PMD_TABLE_SIZE); + if (!pmd) goto err_alloc; - pud_populate(&init_mm, pud, new); + pud_populate(&init_mm, pud, pmd); } pmd = pmd_offset(pud, addr);