From patchwork Thu Jul 13 04:20:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Harry (Hyeonggon) Yoo" <42.hyeyoo@gmail.com> X-Patchwork-Id: 13311284 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E4AFEB64DD for ; Thu, 13 Jul 2023 04:21:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7CC0900003; Thu, 13 Jul 2023 00:21:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E066D900002; Thu, 13 Jul 2023 00:21:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C580C900003; Thu, 13 Jul 2023 00:21:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B0B1A900002 for ; Thu, 13 Jul 2023 00:21:54 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 95E9C1C7404 for ; Thu, 13 Jul 2023 04:21:54 +0000 (UTC) X-FDA: 81005290548.01.3AF26A7 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) by imf05.hostedemail.com (Postfix) with ESMTP id D3CA4100017 for ; Thu, 13 Jul 2023 04:21:52 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=nSXeqS1v; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.167.172 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689222112; a=rsa-sha256; cv=none; b=eS/bqm9JoserQrZBdFvl1TNTo08j30X9gX9tfqonE9onNp987ckiY+NuqQcLZqI3ESdlNc Q3HNBR5lLZ9SzJLxW5K/vHWp9DEwdiIr18MN3cO6mP/z6Emc7mzXfr91Qj+uUF3Rm6j8mX 1hXExLI2ZlrAu7vrD6Jv6wrEntDMMyY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=nSXeqS1v; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.167.172 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689222112; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4hVswznnlp2brrsm/2WMROw2zFXU8NWv1b1UdYi0jsE=; b=auKcOMjMr7XMRVzgx48SVFSiNzduyRekHYDYg9EmYUm3gXfWbN1jRFsE/k3MWeqd0DWe08 RF6ui7jaCH5zlQJVOS3Nez3YhHZ1WKSmDpXdMZ4AAgg8kOJDg1xYYQd6WyuGkyMbxRzXg2 RsKAqGYwDBBCDdfkKVu73vcbO+8vJEA= Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3a1d9b64837so299108b6e.0 for ; Wed, 12 Jul 2023 21:21:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689222112; x=1691814112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4hVswznnlp2brrsm/2WMROw2zFXU8NWv1b1UdYi0jsE=; b=nSXeqS1vrLvki3hjRv3NHB0p0a6UYVrNvFV2Ii6YiscGVqtFX14ZQ7AlPeB7kVWfuT Ge3ZUTVOIbie5qSVnUIDRYK5ZuZRUShCVLtmwACUe12u+/VK0t8Wp7Wyie//lJZ6R3P3 ATBNfotR8SP0Km7iZBgdEp7E4T3Q/MMP79/aoXMAyAaawvkpdXL9NDHFTJv4mWqtWThH OXQNsrsDF8u9uBkZ6MjB8IRe64HCUUOxL1HZfUNT4M+aL4cre5gN9Lnsazz5jvXtXeIq rnP3AWKopqiW/8n5yl4b6sivZEy7PdI4jDL8+0SxDcQChTGYh9PyxFfUWVcjO8flw1zE QaPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689222112; x=1691814112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4hVswznnlp2brrsm/2WMROw2zFXU8NWv1b1UdYi0jsE=; b=B+N74+VpUqdN2SmbOdlS8xCRl86Bt4tmAH6lGFMaVWWYnl5cXh2O3zWHvgEmlGh1Ns cYsb1XtL7D7NYeqlAF/Srq+CP0Gw2TNDo4WJca4PhMNlBUCXZrQKaC/iDMOUX2uvBWVR ljCKmUGEtngO9OPes9ZNwGtblhsMBCITDGX4OG5phFT499RM7RUDqhVkAB+xkCFBNcLW hySvqG4WHBwRhpH7ezxQLPQMAgSfhdhUX1kls+oeUMxMGdBU/xtrs3+UokJ7yhanmwYy R4FNIX9U+JGmpB24FFa+0g2dH08utiUreAQxqnhoKUWfTZB28+gwRZP3wKOvtH9a6rQb 1/1Q== X-Gm-Message-State: ABy/qLap5nDbLD+qTDzSH6ObZHe8UtHDEbtc+rqto1qXwkuEObGicR7d DAphwzvH8QVLIFFvdTlJXKs= X-Google-Smtp-Source: APBJJlEsoCbaP98J11wpcHR6OQ0qKz+6eqfKR+c0anBTnosUkA3m/LCnjzPgDTpVgsvmVh0LYSoiSQ== X-Received: by 2002:a05:6808:1802:b0:3a2:ee9b:4262 with SMTP id bh2-20020a056808180200b003a2ee9b4262mr595232oib.52.1689222111920; Wed, 12 Jul 2023 21:21:51 -0700 (PDT) Received: from fedora.. ([1.245.179.104]) by smtp.gmail.com with ESMTPSA id u18-20020aa78392000000b006827c26f147sm4346601pfm.138.2023.07.12.21.21.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jul 2023 21:21:51 -0700 (PDT) From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Minchan Kim , Sergey Senozhatsky Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Mike Rapoport , Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: [RFC PATCH v2 20/21] mm/zsmalloc: remove now unused helper functions Date: Thu, 13 Jul 2023 13:20:35 +0900 Message-ID: <20230713042037.980211-21-42.hyeyoo@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230713042037.980211-1-42.hyeyoo@gmail.com> References: <20230713042037.980211-1-42.hyeyoo@gmail.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D3CA4100017 X-Stat-Signature: 4ebpbpr3szcsroc5jz6xthd7xmgukdbx X-HE-Tag: 1689222112-19766 X-HE-Meta: U2FsdGVkX18TTPK8t6YsJCtOczAixV6Rf7S8KC/Z5rl83vd/oYu/qz4FpvZ/NT80pZhgP2ye5S5io6I1KoZVDKGQhX6abM7LHMS1qWZNz0uWi2IA/Fx+Y2iTEzcigoOPTBxt5FmTnqwF6lak/7yMW6TLB+34ZxxZf1wkjc3bhMDdzKEM32aEvZ4rvceUNtn/Pkgv6GMRK5EWtNgES9gKsndcweqToeQuCx2El0acJ2W+CO+scuSqE63pH13UUy4PGrLH3gplcr8R8NMLGzAwVnIgB6U0NzgxWoMhgbe5GbbzIJNxau7hdvC1CFsvZfPHqdFSGNInlnNPAzyUltUekxTUxhiFFNJQ3Gg7KTkfpWGmVsQu5E19uSSh9+qCJa+XMCYyTY1Tk+fULCgpRTTVuJLFhVRz+K7uI2v48vY31oBN4LPaiMbQyK8QX7R1GId36qlBxl+dtdHMYW63TTjZ0Y+ff0ENSIaDSUw+cqK30kmrlPMWH++pKhmdrT1Y4CDtRHUAkQjH7Q727BtOaA2QDvOsDFeQZ9SZaWgxTkOCa0ZeoQZj0r8JejT81hurbez1GyhotmUC0fN1xoWfYdf0Z1IHBl55Ts7VqiqZa22tTln85G6lsjLmzwJY6rg5ymDzvHF+lewevXtvGIAR16rh+874xfnnTgL/l6YqMBiKN5J42REdOfG2iaxpnVZF5Fj51S0H5nPwOtwSbPJuIrXFiD2rq8b+D1fFq2rYTxZeWg/tBxYOR528qb8W7R2qfozo1rQoijt4JoelxEVYCNbbSEY9Pt7Cy1SEhjJTwVJwrmuTQuxRIAdF2nXKVdfn632aEM5ZDEriGIwtzJ1OMr3KBaBSroqNpv6CdsPDSrq1lCUSL+MOOJLInqX9wm7x9faXPOgCVHo1rGPvmPKv+3zzm1bJlznN+/LvlmdonCHqOLeBIBTTzlfttMDfbLo7vZ60opQ7TWRiu+03ZzkM2hq kBIeTLM0 afU1VJRBeZBLzC2qdLNnM66ESqGIqTd4U5DtdYruof5IIetwlVL2G1Sp43i1/YKpsGRdmBhwt2ZA33llapemNsHIvu7NdLS/23pfg0NGUMw+XB3SqnYqUft5sxYgyFwp77sM3IFvSmW6qznOPmN4PYQmp9MQ+YjRfrWBqR23qAS4AN4/f1fPRkQU8fXSm8YRwKk+LWyPBNwN0qsjMB9prH5knHIhWWY9dT6lKN4Th7fpx85XINwdNpRfn3NmdK1J18YFekL7tiaYxrLTvNhiSHpng0SecO8kvdSuJ3pMEdr1OT9SkDzSnHZHWj4q2CEhB8gNgpIVu8b35oGinTsVbcUYG41uVFFsUNzOSJA4YmEaTMyq5l+rAH8qpfgHJXNJDgI1ugYr+5dBFTQ3/IGys6lh4kyGtbUi+gZS81wZGa6OGZ6KLdd+v9U2EivYQaNNQKmi/Ui+m+gJYegqZCMOw0GYuiHEdgB+9laNM+s83582WZiklch/xG5R/W1RB96TaHwuCOTYaEHd9CUu5+BVF92JGLvTSViLk1i3VEVw5b0eqBFY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: All users of is_first_page(), get_first_page(), get_next_page() are now converted to use new helper functions that takes zsdesc. Remove now unused helper functions. Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> --- mm/zsmalloc.c | 29 +++-------------------------- 1 file changed, 3 insertions(+), 26 deletions(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 5f07e3d92a99..3933c023c3c9 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -581,12 +581,7 @@ static DEFINE_PER_CPU(struct mapping_area, zs_map_area) = { .lock = INIT_LOCAL_LOCK(lock), }; -static __maybe_unused int is_first_page(struct page *page) -{ - return PagePrivate(page); -} - -static __maybe_unused int is_first_zsdesc(struct zsdesc *zsdesc) +static int is_first_zsdesc(struct zsdesc *zsdesc) { return PagePrivate(zsdesc_page(zsdesc)); } @@ -603,15 +598,7 @@ static inline void mod_zspage_inuse(struct zspage *zspage, int val) zspage->inuse += val; } -static __maybe_unused inline struct page *get_first_page(struct zspage *zspage) -{ - struct page *first_page = zsdesc_page(zspage->first_zsdesc); - - VM_BUG_ON_PAGE(!is_first_page(first_page), first_page); - return first_page; -} - -static __maybe_unused struct zsdesc *get_first_zsdesc(struct zspage *zspage) +static struct zsdesc *get_first_zsdesc(struct zspage *zspage) { struct zsdesc *first_zsdesc = zspage->first_zsdesc; @@ -907,17 +894,7 @@ static struct zspage *get_zspage(struct zsdesc *zsdesc) return zspage; } -static __maybe_unused struct page *get_next_page(struct page *page) -{ - struct zspage *zspage = get_zspage(page_zsdesc(page)); - - if (unlikely(ZsHugePage(zspage))) - return NULL; - - return (struct page *)page->index; -} - -static __maybe_unused struct zsdesc *get_next_zsdesc(struct zsdesc *zsdesc) +static struct zsdesc *get_next_zsdesc(struct zsdesc *zsdesc) { struct zspage *zspage = get_zspage(zsdesc);