From patchwork Fri Jul 14 19:55:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Liam R. Howlett" X-Patchwork-Id: 13314193 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46A1AC001B0 for ; Fri, 14 Jul 2023 19:56:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BEE8C8D0003; Fri, 14 Jul 2023 15:56:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9E186B0075; Fri, 14 Jul 2023 15:56:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A18C38D0003; Fri, 14 Jul 2023 15:56:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8FEBF6B0074 for ; Fri, 14 Jul 2023 15:56:38 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 68E1AA0395 for ; Fri, 14 Jul 2023 19:56:38 +0000 (UTC) X-FDA: 81011274876.17.AEE10FD Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf08.hostedemail.com (Postfix) with ESMTP id DF05416000A for ; Fri, 14 Jul 2023 19:56:33 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-03-30 header.b=OFrs5lDp; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=edwosIxv; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf08.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689364594; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t5gb/T3w432joNG/2gI1QE1Bp6jtHJ86EE12igifPPA=; b=bBKhWvheSkI3vsKhW14fCP7WuzzAMuUVUre3N7oO17YKXD5bXRp+ONcXqBXaPOhjisYuAi 61Ln0DMLcMQFf1jDA27aAQ2F+Uw6/I8VMAha/IUzNRkAF2dCHu4Amloivv17D22kxO5CrO FrGm7INHtLlFuujixbNfDd700Y4KYPk= ARC-Authentication-Results: i=2; imf08.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-03-30 header.b=OFrs5lDp; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=edwosIxv; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf08.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1689364594; a=rsa-sha256; cv=pass; b=8Vvw4UVjnSKsXkyUNq6YZs3lkN1Yk56dhdbOw8IBpqBHCELSn5ZUdoKtzKRrpTB6W8OEUs kL0TxBNabBLrXkMqYcqZRFrIgT1Rnt/BEZqygkaSu6lOy/MGP/hS0rnlhVYvmi9PKGeNlY pNwsHd8TkO4p+8mGVOgKCHrOYZRAO68= Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36EDQexe029776; Fri, 14 Jul 2023 19:56:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2023-03-30; bh=t5gb/T3w432joNG/2gI1QE1Bp6jtHJ86EE12igifPPA=; b=OFrs5lDp41gPQxhWpITgpfrYdOBC8G3kEnb3xBZKcEHiT0oTZL8ufwmD+XERCHnSskdT u9Ng8vr7Z817tAmNFr1D13w5AmH8mUzP2Cu301S5cbO1cSqNNC4tT99pt+eQLWFTWFDX tahm3mCiXBKJf6eGkPLL745OlUP9/A/gdzIR+r20xcJ5OO4W+CnT3y4Aft3LAAN/kvTt iN7tORAYNQYLsnMhci79gnuyfO9A2otlJk5ihKgIzCTOLNcDheftAeK4C+WhBBkoGnHZ 8obyxnso7bpT72SSXvPwFJEdsdUyVOTlKr2Wk6eSnzDxqs5B5pxMSOZbxCwsLMEd0C3T ZA== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3rtq9ta7w8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 Jul 2023 19:56:03 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 36EJnhnQ013820; Fri, 14 Jul 2023 19:56:02 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2169.outbound.protection.outlook.com [104.47.56.169]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3rtpvs5c4v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 Jul 2023 19:56:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=itDPUJ2qCPHK5ks9sCAwl6d9gimOdXDZ/m0POltgJefoEVws37ngTWHUfC/GNOUsyjkWW51f1rmym3U4261qro1XJu31pZ3ifT5XNudKkPAqL2gC9DJ37fBqZDI17uJlrMotlYyGgD7sLu0/xuQmrWnmEE8vmO+oYEHEZRfPvbLiscY5O0H2Ik2x6q3LEA64O2ndmxfrY57sP+04SKZkn6WXh826tsAg59aOmZQLtVn85DGF4hlCKGaEjY+eIMgFy/B5smKUgceKeX3TED3seYOZl5/M2L1Go5MqSubWTMtaXKieqcOzoI2tOvL7tVZ+RYTCkcJTnP2bP0EbmtBiwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t5gb/T3w432joNG/2gI1QE1Bp6jtHJ86EE12igifPPA=; b=lsEHITJNOoKVHPaaw+ig5odknVUGuEYUgZS+TXvVJsJh74J2jmos4v0BqLEUGSvl5zC64SKUHSPomGUe8e8lPAcRVS/dTNaVM28KIcmKVgdyhZ8ECwybrRSDz5TndfuiPKrFzYf+Srx9+LRFQ0lBMvNXJD3HOIorXoTgL+03zEZ3Nb8NEgWRVHadMMmPK6d4rPMyOgd7PoCnXEoT24huD7pzuUjUI2bfR1k5cXxiMgVD9G2/DFhvwr1GMz8WtI21T90HiJjS8TB2ZRaR/CplzL/nL0f9ABx/ZyBCWTznxOMBBfQsjiJohCOxSQq3khYyVJHXJ35Obee0qLX9hA7S+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t5gb/T3w432joNG/2gI1QE1Bp6jtHJ86EE12igifPPA=; b=edwosIxv+KS6TWXltU5J1JQtk5DpqqSe7r9SK74YGI57bA/6xoSHYMR68MqncOjkwG2TukpW2AqO1A451MLbG0B2oMWWhghULRRnzAODe7h/2c+tlo4/CworvYrGZ0T2AQDUlq6QH1WSUGOr4153H8vXO8wAKI+Cx8am6OLS4ag= Received: from SN6PR10MB3022.namprd10.prod.outlook.com (2603:10b6:805:d8::25) by IA1PR10MB5922.namprd10.prod.outlook.com (2603:10b6:208:3d6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.27; Fri, 14 Jul 2023 19:55:59 +0000 Received: from SN6PR10MB3022.namprd10.prod.outlook.com ([fe80::c370:eff7:9ddc:f188]) by SN6PR10MB3022.namprd10.prod.outlook.com ([fe80::c370:eff7:9ddc:f188%4]) with mapi id 15.20.6588.027; Fri, 14 Jul 2023 19:55:59 +0000 From: "Liam R. Howlett" To: Andrew Morton Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Linus Torvalds , "Liam R. Howlett" , Oliver Sang Subject: [PATCH v2 1/4] mm/mmap: Clean up validate_mm() calls Date: Fri, 14 Jul 2023 15:55:48 -0400 Message-Id: <20230714195551.894800-2-Liam.Howlett@oracle.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230714195551.894800-1-Liam.Howlett@oracle.com> References: <20230714195551.894800-1-Liam.Howlett@oracle.com> X-ClientProxiedBy: BL0PR02CA0031.namprd02.prod.outlook.com (2603:10b6:207:3c::44) To SN6PR10MB3022.namprd10.prod.outlook.com (2603:10b6:805:d8::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR10MB3022:EE_|IA1PR10MB5922:EE_ X-MS-Office365-Filtering-Correlation-Id: b093ebc8-040b-4183-b662-08db84a45866 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kMx1/ZX/tHMUpMRzohSMRIgxklAjOi7eKNFoxT20aUdzYEpRmUMnGBVpqo7HMehSRUafbQVNkj6ZSWqBHFW2APzbfByt+HYuiVTS3PFIiuzYut5J7ynXw2ZUK8GcN+eG2zDnC2sDK3+0umzjGS9EVMShNluWsTtqNBw3XwVm8mxlfkt+2dB7GW55zFZeG5ez3Q3p0llHJqCZnV/2jxPuoVsimzp/2TmD9yCX31AuKhDCIus8V/ZEqsA8q1F1kWQoaWxhPkO8VOKI0r+NjNrCdG4ZIKUFu5iCTAgi45T3wqDHE4PuZB5gaJvpyTrMw6BiCDrcGirna9b4gkmo3GHF5DGYU/FVIEhufVGqa0YF2XuguKHhDRkvtOFyEs03LBpRoY2rFLusvC7DMr0lmMcHeATkMJ/JVtGJr+DG/rxEe3YmrXW5H3Od9jL8KlMQg1qWaMvGXOmYY2g2dZ6y5SW0uuo3rvJ4dmczrIaQ2+9ELtBTW8OAoV1LI/8yD08nvmoYPxWDhpj7I790Xjpw5T3BgGfm57nSYq3MOBVHF7rSPlss+QYr8N+/vid5JAnqTDLm X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR10MB3022.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(136003)(366004)(39860400002)(376002)(346002)(451199021)(83380400001)(2906002)(15650500001)(2616005)(6486002)(66476007)(66556008)(4326008)(6916009)(66946007)(316002)(6512007)(478600001)(1076003)(5660300002)(6666004)(54906003)(186003)(6506007)(41300700001)(26005)(8676002)(8936002)(86362001)(36756003)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 14AKRdrBYrNKBpzYUHNrt4Sal3k2k1cPfHeVy4bcQGK37wxidessCqUPO/CC9iJS4iD4yaF2uRdsm4Oa+QlufyX3aq4vXWeuyQLZWHCZuHEd5Va3ia7KXXDGBsLju352tY+5pAYTx80QyB+DTM7vv5kl+vvvwcoYI/ALhBqV5LChkwywOQje7xbvyEJwO/3ZdRg2b1DxbxK1DlSCI7grsixKqLfIq/CzexStTWFklNmbt2sgzkazrAUwZqRuBI7zDTE5YtaJ8DYmIdEmQuJWs5GZv4q0cSFtxYc790OGLpHkHuCoXrfembFrBuXX1oh92Kz0q5UuWNDFE5vUYnjVNADnb9hGDLKOnPGGKBRsSvfGhxZvJ3CBkoGJjA/OmfbsmY66RBKYFlctyvAZUI2x6xEVL1Jy+R4BaJd8IfOJQN9Nlvl1dpeiP+W2bx4dYBTdNUuazJd9jz5/AeEFHN8KypuJxIENAnjmm+ZIhr5H3agoCi1IvxCGbRFxqsJadEcfjiXbX5SU8oBEjaYmlar5+jMPT+CFhL4U0cvj+UElW5Smqpe2qsCp7w6E9fEY1UDRMqtXaohz6GXUd9gUmQvFdkU5PSCmgVWDjSMeUyvTlBH1NT5EXVo4sruojjh18FPzp78MlsNPGY+lxKs+L4/zSY+AWji6vFv+poaOV2xngFOUCp90+VOolcNwlkdb+N9s0M7W6gnTqb6+/SV4nMSXGSrp0z4oPAo9uD/4eZYyMl/lN/SXCsQdBFkWRddiRDgKjiTBDg2CHIBQC8SerqiGW2rE+HYVoNgDAowuvvblNwgKvRt6qVKaXZSp470atQpzx3yMDl82YfytK9K/WRuqacZezU9AzBOZ49dk5/VTeAXGHsWJHLMTzXsUY1ya53AKkE4qQl7aRDR2DjRy4iqXE5jMMVfGZnM+ezkpTwXc9Sb7GCKHVa8XiLTxzSlyiK+UxaSbR4prv/eYHVb0gUFdTibkrDWObyIykohmi05wfBkWrBEi/vTkXzHeXhoSmYULXsd8q1IyW0MVW8u+4oQaogWQMMqBu94RsFch8SB1xQ0pwAMGwXEW1mMW3nNe48nHe9p+cigIX66+oa8LTdanfkH18nUruYiATFmXCCsfl5slM6PcfMUQwv7RNgk2VYFLjOdOrloeJoZ9wcs852uYfxvSq7MtfGJb+iJPxEw4DCuA8Zr68ht652pTVO2MjpOb7xk7UYUmX7c3Q9zcG34uocAEUp0/0YwWx00OztUhMZmuA7MToNSHkLK7x7woId3eH1ss75pNumtVaYrfI998emJ5hbdmYSWyZIvRYG/tI3q0IKqkUQbGxcHYwAHJT6wSMNlhjvxATAtEw613e6Lk8w6OV13ujUfB6Fl/q1aJBYJydvG/73KwBei9UMRPez2v4kubP++gYSRGmJtyxxa1WNOVZIDm7uCKHkGO8WggpRWiQc4mrmxmtOPbPKMkcx1GypL/3rd2TvB72u+kXguMcqZ2qbucPm9ns/kNh7T9HOmC9ODHeyEhEe9a4V5kgyLLhSH8fZjvZGGkmFBvuDrimbSNZBCU/cUfsH79/TIb5URcU5lnefBoBzuIBART8lz7CRHmpywxAjOMVtNR/RKQug== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: fP0W9FQrhAuPXGTP1eNjXq+TYGaLW5nZtxJ3zhhtCa2XRx+lrjuRDEFUsPxNVLlrwfTAFVtYlMEW4IdCjMZpAH6OMdnLsiiN4JEGKWtW/kkjzToZYAnV03y3hSViqp+leWdk6I6kr/q7PUa9Jhl3gLK+724AdoxX8s7HLogi2VNDU48LK3b9lSG1DeZDBymYo/yvZ/2TxfB8nqDFHX7Fgfil4s2AQvm+tObf5lLhX+F2P6M/yLXf2rVzOLInmXESYzhGeDKteEzTDSL+1geQHx64v168GFS8sT78hiJwVS52zFTJiDRvsIhDIyOFfGSPa/0giiRUG5eNsuoyOPPVDGRsfp+WHluhNvGP/DmX1RoFM0KWmqs0gFexIk8jXGkxmVMnfZVz7RDyjZlM7uERyRJfj1C1scXaK5P1YM4H5Qd9WPM8NdCQHYp+ZrBXyzxYIK0devVchxIFMCtxGPQ78PT0qd7rOzoVkfRyAZaZ3QVTM8E0XgAx4Dyl9GZt1hXybHYtoUsrWf4cR+Ol+lSkz9FhQgUEYbHW7vwTw7hoRuhJOlXlPetCTscxw4yLSvt895bS7rIKUb7scMFzy0lvUTl+8zHgK66Otv6MfXU4zUeaBc7llAao59VU9QrDrBiJr78XmFh9hGdi47kZjL/i5K/L5p3djOY2/wv9MWSo/Glkyd2b75gP0+m7I6dpkWyDpDe+uuNTrJPaBYYT4f2DNvD/reZWItsP7xAMQ410S+lJNNcV5EoBzDr9NdkXBl35InqusIZvzBGCRsjxm14njEE2B2y8Ax7kaJq26Bma73+t7mnqpMJ8T0srGmwDJil98zLnNQRgPL6irO8Uu+akqGXgl3m2ESmcTVXvm4ZqB27kDDAnOZpCiSsVe2hICRhLYUegvVFjkIB4mjPOPwhkfjq4p953Yy81QsFKnyu75dU= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b093ebc8-040b-4183-b662-08db84a45866 X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2023 19:55:59.7888 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w+W7m2LgoP+7z8wpEhe1YFDTgyMNPdRYtVM8CdD7hyhnoxrqCafQtMwBHIrItdKM6TwAudQfIfSmWc+lMtUXBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB5922 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-14_10,2023-07-13_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307140182 X-Proofpoint-ORIG-GUID: MZT5doZm4xE9tiSDqPsZem_KvUM6ya-7 X-Proofpoint-GUID: MZT5doZm4xE9tiSDqPsZem_KvUM6ya-7 X-Rspamd-Queue-Id: DF05416000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: n44pjbqk84n4nxifie586roxqwy4o7hj X-HE-Tag: 1689364593-551936 X-HE-Meta: U2FsdGVkX19TIpxTQTsxLlv8C6HO/x9bsiPOiYdp0J4nlhTHnJdJfVvkDeJLBMmB0qhQ6aWIa7JtvubFE0k61kEy6c+UMgoLaHV6ILe8GAepQCrJ1IhbOX++r8ZudqCZ/AHGH9PrpLupgRba1Ovh06oPN/r+xbC/OK5NlI8g2L6GqcbYqwuuby61AYK3MvsmJ3MW4tDGVY04qBIdxeBz64r2pLzSYadXYUEft+gjCnsclNfgtn9jxyyvh5STmKBwnRUXkTy/HzyjTKUKzbetJ3+ZbvH4EYrrwQOflsqvxIq1KWRhty/MA5oDkezxz7wXLojupSsU/SM6ugwevmd0wMZhHqO2dPuWSgADLv9W7Y1MqBIE8FTq7Bo/MFMfsnouw4TIUcsjjrs4z9gnzWZLa/aLYuzEIxBEO4DG6SH0ulDhE5IZQG9rcKkH1pkbTntPheQNJY2mRrko9TwxQ6+S8bPsdOV8cMMQGqLB5s82AdnlLgZr209ndcsWywpEeSeRqYU9ho/CxsgceVtMeQCMzQR2L2AqolKmlDmbXibKNU8UdO1CHve/IjrR7p8l3MD2Vuh93+R80I0CMMVyWhBZPrPJeyBDvqGNcM65FiE+WGQz74DZhfliM9E2U9LJM+EH+tXEVF1Dh9SzAxrHWbmAVr2hHFzkJ/8XRHl/FK+4RLyj0yy7xR0UYKS9y07w2smUKwI+Dnuo36RE8CKAVncX+FsfQdSeUrYiEfs21uCGGG3Lz8IBWtSuh34xaopYBY+nVpriJ5PnJfLWP1wCoWeYd/11XFyr/TbE10ng+XdRDLFNRBQO7fSyHnj4o8FdNhNL4yYLiX+kQBrp4eOUZPegPcypqjW0Jp47TGOyE/FpWDAXaWdR0bdvjSEYOJW9t+3sx3sx4z7GHxj6Yapj1gcpn7bX8ApBAlBNox8zJuob5xQQRJbRpBY+8qOff3UNoCUPI2RcvhCjw4c/dydOf8x nPGJdjly KANgs+0CO1arWHCKew6kuBJhzZFF4fmzjMJhdNHq64fJmzm2zeehI358eHvAAyJyjSoDNDf9S36P93z6AAI4Gf5+/UaBUzm+sfwurFSd+kWKIOmRCOXmEDlv8V1zibLkKDYuaGoPE+lhGZ29/xkkFGmy31NsrEZcLhkzC5MjivLDwZame+24VAbz2nJ3mxQFW/NV7Os89V/VSeVZWZCmWsxqhaC4zwjmIcRzOd6eXq9ROkli1iXb5l/9oh3UuetdweI6DmZXGMEgXnh65gnnJUuKcogmm7SgbkQh87+5PmNHdXXXBUK8+Kvxv8HoNssjvICYhWj/Gok+2vNJYzspKGjOsT7FCgRjQ2SHbyiTJjI8ddXRrIA7vwROOERtSiBSjdpM+iFhD683lhu4YHM5/cAUn2LHcjrvIhd0ZLFP4imyvkKpsa7UqlJfm5fgB17blFBcrm4vG3QmMe7XOO/0JZmfFNUTSWwVCZRmQ2vZfnjkYdM+a+yZkKJTVx49+yTSwzqLL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: validate_mm() calls are too spread out and duplicated in numerous locations. Also, now that the stack write is done under the write lock, it is not necessary to validate the mm prior to write operations. Add a validate_mm() to the stack expansions, and to vma_complete() so that numerous others may be dropped. Note that vma_link() (and also insert_vm_struct() by call path) already call validate_mm(). vma_merge() also had an unnecessary call to vma_iter_free() since the logic change to abort earlier if no merging is necessary. Drop extra validate_mm() calls at the start of functions and error paths which won't write to the tree. Relocate the validate_mm() call in the do_brk_flags() to avoid re-running the same test when vma_complete() is used. The call within the error path of mmap_region() is left intentionally because of the complexity of the function and the potential of drivers modifying the tree. Cc: Linus Torvalds Cc: Oliver Sang Signed-off-by: Liam R. Howlett --- mm/mmap.c | 24 ++++-------------------- 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index ce31aec82e82..7b70379a8b3e 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -594,6 +594,7 @@ static inline void vma_complete(struct vma_prepare *vp, } if (vp->insert && vp->file) uprobe_mmap(vp->insert); + validate_mm(mm); } /* @@ -675,7 +676,6 @@ int vma_expand(struct vma_iterator *vmi, struct vm_area_struct *vma, vma_iter_store(vmi, vma); vma_complete(&vp, vmi, vma->vm_mm); - validate_mm(vma->vm_mm); return 0; nomem: @@ -715,7 +715,6 @@ int vma_shrink(struct vma_iterator *vmi, struct vm_area_struct *vma, vma->vm_end = end; vma->vm_pgoff = pgoff; vma_complete(&vp, vmi, vma->vm_mm); - validate_mm(vma->vm_mm); return 0; } @@ -888,7 +887,6 @@ struct vm_area_struct *vma_merge(struct vma_iterator *vmi, struct mm_struct *mm, pgoff_t pglen = (end - addr) >> PAGE_SHIFT; long adj_start = 0; - validate_mm(mm); /* * We later require that vma->vm_flags == vm_flags, * so this tests vma->vm_flags & VM_SPECIAL, too. @@ -1015,10 +1013,7 @@ struct vm_area_struct *vma_merge(struct vma_iterator *vmi, struct mm_struct *mm, } vma_complete(&vp, vmi, mm); - vma_iter_free(vmi); - validate_mm(mm); khugepaged_enter_vma(res, vm_flags); - return res; } @@ -1193,7 +1188,6 @@ unsigned long do_mmap(struct file *file, unsigned long addr, vm_flags_t vm_flags; int pkey = 0; - validate_mm(mm); *populate = 0; if (!len) @@ -2022,6 +2016,7 @@ static int expand_upwards(struct vm_area_struct *vma, unsigned long address) anon_vma_unlock_write(vma->anon_vma); khugepaged_enter_vma(vma, vma->vm_flags); mas_destroy(&mas); + validate_mm(mm); return error; } #endif /* CONFIG_STACK_GROWSUP || CONFIG_IA64 */ @@ -2112,6 +2107,7 @@ int expand_downwards(struct vm_area_struct *vma, unsigned long address) anon_vma_unlock_write(vma->anon_vma); khugepaged_enter_vma(vma, vma->vm_flags); mas_destroy(&mas); + validate_mm(mm); return error; } @@ -2289,7 +2285,6 @@ static inline void remove_mt(struct mm_struct *mm, struct ma_state *mas) remove_vma(vma, false); } vm_unacct_memory(nr_accounted); - validate_mm(mm); } /* @@ -2326,8 +2321,6 @@ int __split_vma(struct vma_iterator *vmi, struct vm_area_struct *vma, struct vm_area_struct *new; int err; - validate_mm(vma->vm_mm); - WARN_ON(vma->vm_start >= addr); WARN_ON(vma->vm_end <= addr); @@ -2384,7 +2377,6 @@ int __split_vma(struct vma_iterator *vmi, struct vm_area_struct *vma, /* Success. */ if (new_below) vma_next(vmi); - validate_mm(vma->vm_mm); return 0; out_free_mpol: @@ -2393,7 +2385,6 @@ int __split_vma(struct vma_iterator *vmi, struct vm_area_struct *vma, vma_iter_free(vmi); out_free_vma: vm_area_free(new); - validate_mm(vma->vm_mm); return err; } @@ -3044,7 +3035,6 @@ static int do_brk_flags(struct vma_iterator *vmi, struct vm_area_struct *vma, struct mm_struct *mm = current->mm; struct vma_prepare vp; - validate_mm(mm); /* * Check against address space limits by the changed size * Note: This happens *after* clearing old mappings in some code paths. @@ -3096,6 +3086,7 @@ static int do_brk_flags(struct vma_iterator *vmi, struct vm_area_struct *vma, goto mas_store_fail; mm->map_count++; + validate_mm(mm); ksm_add_vma(vma); out: perf_event_mmap(vma); @@ -3104,7 +3095,6 @@ static int do_brk_flags(struct vma_iterator *vmi, struct vm_area_struct *vma, if (flags & VM_LOCKED) mm->locked_vm += (len >> PAGE_SHIFT); vm_flags_set(vma, VM_SOFTDIRTY); - validate_mm(mm); return 0; mas_store_fail: @@ -3285,7 +3275,6 @@ struct vm_area_struct *copy_vma(struct vm_area_struct **vmap, bool faulted_in_anon_vma = true; VMA_ITERATOR(vmi, mm, addr); - validate_mm(mm); /* * If anonymous vma has not yet been faulted, update new pgoff * to match new location, to increase its chance of merging. @@ -3344,7 +3333,6 @@ struct vm_area_struct *copy_vma(struct vm_area_struct **vmap, goto out_vma_link; *need_rmap_locks = false; } - validate_mm(mm); return new_vma; out_vma_link: @@ -3360,7 +3348,6 @@ struct vm_area_struct *copy_vma(struct vm_area_struct **vmap, out_free_vma: vm_area_free(new_vma); out: - validate_mm(mm); return NULL; } @@ -3497,7 +3484,6 @@ static struct vm_area_struct *__install_special_mapping( int ret; struct vm_area_struct *vma; - validate_mm(mm); vma = vm_area_alloc(mm); if (unlikely(vma == NULL)) return ERR_PTR(-ENOMEM); @@ -3520,12 +3506,10 @@ static struct vm_area_struct *__install_special_mapping( perf_event_mmap(vma); - validate_mm(mm); return vma; out: vm_area_free(vma); - validate_mm(mm); return ERR_PTR(ret); }