From patchwork Tue Jul 18 08:26:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vivek Kasireddy X-Patchwork-Id: 13316887 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A115C0015E for ; Tue, 18 Jul 2023 08:47:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8F876B0074; Tue, 18 Jul 2023 04:47:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3EE16B0075; Tue, 18 Jul 2023 04:47:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B05CE8D0001; Tue, 18 Jul 2023 04:47:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A38126B0074 for ; Tue, 18 Jul 2023 04:47:06 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 718661A020E for ; Tue, 18 Jul 2023 08:47:06 +0000 (UTC) X-FDA: 81024102852.09.07C3392 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf21.hostedemail.com (Postfix) with ESMTP id 6BBC61C0012 for ; Tue, 18 Jul 2023 08:47:04 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=cagsDpod; spf=pass (imf21.hostedemail.com: domain of vivek.kasireddy@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689670024; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WsGYn2c/eEAPeH/JykCDNX8SNi5wJfclHk6vj/X5w/w=; b=Z2QfPncwBO8IDw0nONTS5+qzWHx5BjmrdShCe+/dO3Y3l6Z9ztmttJrIe/3xrNK5nnf0fT YMf4mLg1spCmJK78N4GaqQBCfAPAornIgC1NakfG3XcwuydMpOwCdt2J4CThiAVlqHIA0D Aiye+Oj0kQ0EjjaoD4IMoVPIMc319RA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689670024; a=rsa-sha256; cv=none; b=DDo8ccRvyEaJtye0V5Dq9PQ6q4A+gw4LgNm5GL4uuZIsWANoNYs9zW7OMl9UfBGkeSdf+p e18JO2FxxFDF6YHbsVde5MUfK1COXNzEoRDH9tzgmHO8U0jNLGsP8V1Wthj5qVbgGydY4W LAeLaRr+c9ozMGI9vC/EhMZrdW+O19A= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=cagsDpod; spf=pass (imf21.hostedemail.com: domain of vivek.kasireddy@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689670024; x=1721206024; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fBC94lrie8PzdotV65iT7IktTjrsFKLJMPmD1wjnkfY=; b=cagsDpodp0H5xO2sdp30KF/3Jo6VgP9qahU6tEz3ShVmQki19QcMnQky nwckEks0C2vN8O5qOekL4Suau2kr+MTnGF1EVOMmsAJYspO6Yi8N9PEMm fSRkqHcluwCdel3UFOD7vI96fAkdcIVhLTocVr+tMMZASmvEA/rInguaH +MLc1w3hAYlYoWTEZBL9Zkt+9hTq/8830/iKkYi5de+LT9lUWE1KM55PZ B8aijHkiOLa2ZjzFRE8iYdCwFtXn8SaUg8j3EnQQ9iQkarvd/eAJswihu U1xLdWbAHWDviF2Ktj88RTcKzZGKdgH9/Bk1mmYS0gT+iEr1tA9me3p+D g==; X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="366191289" X-IronPort-AV: E=Sophos;i="6.01,213,1684825200"; d="scan'208";a="366191289" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2023 01:46:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="723532670" X-IronPort-AV: E=Sophos;i="6.01,213,1684825200"; d="scan'208";a="723532670" Received: from vkasired-desk2.fm.intel.com ([10.105.128.127]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2023 01:46:58 -0700 From: Vivek Kasireddy To: dri-devel@lists.freedesktop.org, linux-mm@kvack.org Cc: Vivek Kasireddy , David Hildenbrand , Mike Kravetz , Hugh Dickins , Peter Xu , Jason Gunthorpe , Gerd Hoffmann , Dongwon Kim , Junxiao Chang Subject: [PATCH v2 1/2] udmabuf: Use vmf_insert_pfn and VM_PFNMAP for handling mmap Date: Tue, 18 Jul 2023 01:26:04 -0700 Message-Id: <20230718082605.1570740-2-vivek.kasireddy@intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230718082605.1570740-1-vivek.kasireddy@intel.com> References: <20230718082605.1570740-1-vivek.kasireddy@intel.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 6BBC61C0012 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ge5h3o39ec94n5xxcwix6hay1w4gibyg X-HE-Tag: 1689670024-262889 X-HE-Meta: U2FsdGVkX18EmwUDHkUfn7uIbHcd1yrAAnPYTo+BjtJKaCb6w84d77aeYMRLf4M3MRI9bLs+ZcwH0e67//Vkpwp3kAEh+/YMOZ1exXVWc/H/yVzPMPx+UNef187t5se/uf63AXkOjI5A4acuqFIgPKaebdSO7Ya4IJl5y/lrfeK1uhiivNKrJtOIU150j2V11+vkB7MbvbyNZ+P4GHcNzeO2UfdRyHW7wzjtD5XMmPantjR5r7Zrrs2mQDLCAftRfz29s/op8Q17gT+d0mCdxpaMdzQA/AEm1ByUVh7wmGAskm82ggQc5nwFGiqLTlxfveJESP3HF6iHa9NGdwGzlG56GpduFsmhbhx2K2bAuQenfe+IKdV9uTJ/h57TD8PIVcc4A7K7sc494eNpdq1ih3Wl8X9GAHqPYpV8omvI7KTW5aEMbqXPdJ22+u71YCzjgBnUxWotMk9xaEr+MxSfYMt6YQNBS8zXivehnmU/wB1PaD/BtNk2rF/GiJ1iHMtBpbEfA+jME5J9CcudVl52BVGjwcZmxrejN8XfWYFRVmIzS770tkPPF0m37eJR1AfDa8U9x/WL5iQ6snWP1GdHJsgI48BtuYIzMtS2z0XKr/MpYLdwq+pPMVYie0eNIo3JP0D7lnzDH/1CBZB7gnLF7lTw65SXuyL6zDXF14pcJBGx+IMfdUu/s9V+oW/+Ut5oI53eqU5CYPAc2v0PiMp4+/mV/Db2u/uKenWhuyQ00mIvmEyFZUnWpqEUBeMCuzpa50oZZcbOfqKCmXKicUjMrChpM5t+kHeWf36sZ+FYGi2pWNdrTYzcNjlIWQQ+JhyGZV+Nmq8EbbdiO3aefYoYXuu1XJsAwjd9CFwKmnQKjA+GHT2ovrRRDXl3cK4cUeEpm2L3f0VVp+AKAdVx6X/ReThXPf5g8hoKdJcmEVvP4iT5N5Z7todEPOrKGeAt29mm6cuQYbWmqr9IXRiynfW tQxgKjFx lGHHAhtK6zLJMQ0GkXdl1cAYAByOZ+Ls6lUyWyRdeeYUPCej6yFZQGfSIGkVXXaUVT7VSLZMFQbX9WhQVNd0WZ4d4IQWv5eJfEX1mhUeEOSq9gKesZIjCgz3lY77adglSZQxmSTfhvsZLxkkM8BcPDKkMKoOgIc6HPSgxbl1xQgGQXWa/PlzxOHKLknJFAzKGSuqmuowboI/uWRtpoQPnxxoiRJddd1FDRSB9auREcHZSZEjITJFx4BLRjYN3Gem23778ERpl4mIvBbpjlbpOIagVHvE0g2BEVzBEU+FRwF9s7r0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Add VM_PFNMAP to vm_flags in the mmap handler to ensure that the mappings would be managed without using struct page. And, in the vm_fault handler, use vmf_insert_pfn to share the page's pfn to userspace instead of directly sharing the page (via struct page *). Cc: David Hildenbrand Cc: Mike Kravetz Cc: Hugh Dickins Cc: Peter Xu Cc: Jason Gunthorpe Cc: Gerd Hoffmann Cc: Dongwon Kim Cc: Junxiao Chang Suggested-by: David Hildenbrand Signed-off-by: Vivek Kasireddy Acked-by: David Hildenbrand --- drivers/dma-buf/udmabuf.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c index c40645999648..820c993c8659 100644 --- a/drivers/dma-buf/udmabuf.c +++ b/drivers/dma-buf/udmabuf.c @@ -35,12 +35,13 @@ static vm_fault_t udmabuf_vm_fault(struct vm_fault *vmf) struct vm_area_struct *vma = vmf->vma; struct udmabuf *ubuf = vma->vm_private_data; pgoff_t pgoff = vmf->pgoff; + unsigned long pfn; if (pgoff >= ubuf->pagecount) return VM_FAULT_SIGBUS; - vmf->page = ubuf->pages[pgoff]; - get_page(vmf->page); - return 0; + + pfn = page_to_pfn(ubuf->pages[pgoff]); + return vmf_insert_pfn(vma, vmf->address, pfn); } static const struct vm_operations_struct udmabuf_vm_ops = { @@ -56,6 +57,7 @@ static int mmap_udmabuf(struct dma_buf *buf, struct vm_area_struct *vma) vma->vm_ops = &udmabuf_vm_ops; vma->vm_private_data = ubuf; + vm_flags_set(vma, VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP); return 0; }