From patchwork Fri Jul 21 03:44:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Zhang X-Patchwork-Id: 13321296 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47835C001DE for ; Fri, 21 Jul 2023 03:45:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F72F28018F; Thu, 20 Jul 2023 23:45:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A6F528018C; Thu, 20 Jul 2023 23:45:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA57028018F; Thu, 20 Jul 2023 23:45:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B2E9928018C for ; Thu, 20 Jul 2023 23:45:18 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5F61B80126 for ; Fri, 21 Jul 2023 03:45:18 +0000 (UTC) X-FDA: 81034228716.26.B0C53EB Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf25.hostedemail.com (Postfix) with ESMTP id BDF64A0008 for ; Fri, 21 Jul 2023 03:45:14 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf25.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689911115; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wN9Jy/8pPyEHOuZ2Lb/sCQ9C45wtfFLi31VZgiAcDtY=; b=IPKycK7i1oEGmUkNrbIQU40hyIS0Vpb9DdVhmnrwwqFiItvTuORrkDPH/Iu/2PKOmPmKHY uTyXaBOjQPeKd1+Lr8RqiisqmoAcUBvN1prcwCzxWOxnTnBnA+V4RsgJDHLrFGbWBFwXUA 8fYJ/IivVUY7rJ8cYCLFHx0WqDhKRgY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf25.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689911115; a=rsa-sha256; cv=none; b=m1ZP3aljXw6nPoca7lSU9W2v+9Ru2cCblCgRVQ63MzPwGyMVBc8rZyByoywZh9i04UJPei UMasVCdIp6w2w7sWnOzgH1ub3tU20goB4FW67hJ020IDQCikIqN11hHbDnF/U1ZD7TLoxo DHasvQYGHEt5KZMkCvhaTE+4lq2a834= Received: from kwepemm600020.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4R6b2x0j9XztRMB; Fri, 21 Jul 2023 11:42:01 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by kwepemm600020.china.huawei.com (7.193.23.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 21 Jul 2023 11:45:08 +0800 From: Peng Zhang To: , , CC: , , , , , ZhangPeng Subject: [PATCH v4 02/10] mm/page_io: remove unneeded SetPageError() Date: Fri, 21 Jul 2023 11:44:43 +0800 Message-ID: <20230721034451.16412-3-zhangpeng362@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230721034451.16412-1-zhangpeng362@huawei.com> References: <20230721034451.16412-1-zhangpeng362@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600020.china.huawei.com (7.193.23.147) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: BDF64A0008 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: sn31i89k6jsagjoh5ekqfjue7pyqwejk X-HE-Tag: 1689911114-952225 X-HE-Meta: U2FsdGVkX18JCV1kBmnp1qBAYCCAK1cMwh7+AnsISQmLydapAHGVpeyrLDHwdEvp6X/FQL1Nnyk7KEKyFhqfjqZLV4CR7gCW9QfWzCwhNVEzl4G5GhQiIT7cqZQTr1vYAwzHd1MRzBzR0Mqgx95PYfsSvzVpZE0bp+qhiVnrhPFo8a29sQ2Vh/8jZCJZAQ+ctdASiotUdKBdm4QZ3CL3ZTdHCalWmokDXtfAgtPJLh5/gU2mcOEKgAILKe+0lsTo/2NR/LM08LXQO21yZdVEa3qco2gvL2+sfkBNaJidn+CMbu1egzOwKwjU+N1oviSyU2orS9aW8IE6Neae6l/aUplh9iDNen78kb/SMnhIQ+5HVGVBbEyyMyg2UF40QQuw6l/E3CS0QjOr/WRQ5n4B92RFo/glIDn2C6H2Y30vfTmXLyD/WZPl7tRxXBYO0NdESEUo6huEWI1tioraBPsG1soQ9o5V7XgLcRkKGVsSMG/3kGGNtjxA8jNPbR8u4vb/2TDbnAJSIGZiuwXF5eqX/tC4f4MYZBwMvSB0tqfFis7/fuFBPEiq+kX1dsvd/h6fdPbDMNBJpYRwI9cSg9Hw3+T5jHWRHrEVaSWTzAWHAuS737WHb/STJk/9V69XiabczwbiRHOh1M/I8ycuOsjthrbsIPvDoGV4/0NKuh05tIEGHXbrgwuHJdCaXqPgJMYsXuB3Ly0rUv8O71GmK0rr4NVbiqtlqblLxKzhBN3quwkKM7UbtKVgi9ixxrB1JQ27DdjVgDB1mYBof0n+VIZSuceoomawszu+vh54F4ZYWGRykgTv0zvJzkDKX0M/RPjcDjeFf7xDcz/kr2HiRgNY6MBdxta1dR0+La9UlVQgn8znModCFuNvr4ahKXh1W5y6loSiNmtNSKMvZ3kva+isyxnnc4tVJ1s28S2jyp4QzOSW+4ESamqdIWSoXnTJFvFOIoRszF56d9heiimoj8p 7Qkp0pzp 3UX8HJBlNeBPgoTPw2xUXkgAUWZ3hQBe1xQSvIgz1Ecaj1oAjsoH0oI/ArFv3JVMxAHTPHu/rZEpRUejKrP12es2Eby8AjScOte13uUDMSXfdbdVFfXB3twVKNb94Zu7qSmwTwpfT/njJWVSeiiUahJbq+YdKRuWtxTNf5+hJYAYOjOMoYAVhWmj/YqhLfxU4kSpVycP/vatnehsmylU6vkxYFvdB/iPX3p3ll4WTEGcogd8q0GKdsjDMcg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: ZhangPeng Nobody checks the PageError()/folio_test_error() for the page/folio in __end_swap_bio_read/write() and sio_write_complete(). Therefore, we don't need to set the error flag. Just drop it. Suggested-by: Matthew Wilcox (Oracle) Signed-off-by: ZhangPeng --- mm/page_io.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/mm/page_io.c b/mm/page_io.c index 3087a69a014b..5ddb5d9c5013 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -32,7 +32,6 @@ static void __end_swap_bio_write(struct bio *bio) struct page *page = bio_first_page_all(bio); if (bio->bi_status) { - SetPageError(page); /* * We failed to write the page out to swap-space. * Re-dirty the page in order to avoid it being reclaimed. @@ -61,7 +60,6 @@ static void __end_swap_bio_read(struct bio *bio) struct page *page = bio_first_page_all(bio); if (bio->bi_status) { - SetPageError(page); pr_alert_ratelimited("Read-error on swap-device (%u:%u:%llu)\n", MAJOR(bio_dev(bio)), MINOR(bio_dev(bio)), (unsigned long long)bio->bi_iter.bi_sector); @@ -415,7 +413,6 @@ static void sio_read_complete(struct kiocb *iocb, long ret) for (p = 0; p < sio->pages; p++) { struct page *page = sio->bvec[p].bv_page; - SetPageError(page); unlock_page(page); } pr_alert_ratelimited("Read-error on swap-device\n");