From patchwork Wed Aug 2 05:55:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Verma, Vishal L" X-Patchwork-Id: 13337663 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7040C001DE for ; Wed, 2 Aug 2023 05:56:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 001ED280129; Wed, 2 Aug 2023 01:56:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF501280112; Wed, 2 Aug 2023 01:56:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBC70280129; Wed, 2 Aug 2023 01:56:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CEDED280112 for ; Wed, 2 Aug 2023 01:56:06 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 75487C0D8E for ; Wed, 2 Aug 2023 05:56:06 +0000 (UTC) X-FDA: 81078103932.19.3647787 Received: from mgamail.intel.com (unknown [192.55.52.43]) by imf05.hostedemail.com (Postfix) with ESMTP id 222EF100014 for ; Wed, 2 Aug 2023 05:56:02 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HTsksJ6c; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf05.hostedemail.com: domain of vishal.l.verma@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=vishal.l.verma@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690955763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PsMNMxVCWqnb303u9rotLe+AE2ps4sCY/dSZ88FWhG0=; b=Izr9p14c3KHopEq1fgYmfN2QWAw9wc1HMxkHerbwgW+FbOpQQH6HRP158U/XVZ5MgzV0gd NuDYIg605mNlx9Q+tVo+UJrzGgPscic0uQhlXukJ0J/FEBv2zB0byHTp8BHc9F/3y6Szb4 yuVE/agS6gzdlDS1iLmoCmcepNi4Y9Q= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=HTsksJ6c; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf05.hostedemail.com: domain of vishal.l.verma@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=vishal.l.verma@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690955763; a=rsa-sha256; cv=none; b=f3QleItixYNnNaXY54aVfzA+bIxiA8m/8lusn9ZBw9GVjWQI38txYU4Qxd0khKYtC9h7ES KnHQ6q1pi1JOGTCgUWOyMTliIanytnhhxozGj8j0sT3IBVVx6vaSfznsLct/WzCH46u4BV p+sIOv+Tx64YmRmiU4mXbgkc/bf7pJg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690955763; x=1722491763; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=E5mEEIt6gjKxiTw4Ms0ez32FP/kFUb2pffv4TH9UhUo=; b=HTsksJ6crPTq6Q3cpbkU1drYZe+QOsf02tqXt7b8R2Slkk1Nfo5wG4+u XfyO/IcjtBvZy3fuUdyAli6tudomIp3JC4rBVBGGn0atxMBK1Y2OKD6bo mpX7Fl4ILsQ0TqRinkEsvCn29q00qqnGW1tZVIA2X/tIwf7Z/3wtyhNo2 ja+kuhRknkxiJsaWhpm5Q1Wpq37Hsu5KMuhR9FNWbl7sUdw6I0Thg581H jgs3H38a+97c6NoBhMNa/st7ke5EidEuMfE2bWa6DSVXkZhbCXBLkw29T TRI0OA1TEZmX4tsySILFBNzxm1LX/CCU7p8PG28yw9QjTu2ZLoedMnj74 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="455857448" X-IronPort-AV: E=Sophos;i="6.01,248,1684825200"; d="scan'208";a="455857448" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 22:55:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="852746659" X-IronPort-AV: E=Sophos;i="6.01,248,1684825200"; d="scan'208";a="852746659" Received: from hongrudi-mobl.amr.corp.intel.com (HELO [192.168.1.200]) ([10.209.173.200]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 22:55:45 -0700 From: Vishal Verma Date: Tue, 01 Aug 2023 23:55:37 -0600 Subject: [PATCH v3 1/2] mm/memory_hotplug: split memmap_on_memory requests across memblocks MIME-Version: 1.0 Message-Id: <20230801-vv-kmem_memmap-v3-1-406e9aaf5689@intel.com> References: <20230801-vv-kmem_memmap-v3-0-406e9aaf5689@intel.com> In-Reply-To: <20230801-vv-kmem_memmap-v3-0-406e9aaf5689@intel.com> To: Andrew Morton , David Hildenbrand , Oscar Salvador , Dan Williams , Dave Jiang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Huang Ying , Dave Hansen , "Aneesh Kumar K.V" , Michal Hocko , Jonathan Cameron , Jeff Moyer , Vishal Verma X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=7959; i=vishal.l.verma@intel.com; h=from:subject:message-id; bh=E5mEEIt6gjKxiTw4Ms0ez32FP/kFUb2pffv4TH9UhUo=; b=owGbwMvMwCXGf25diOft7jLG02pJDCkn3z/QY5R+6++V517+ueOljdOXma7Rh56v7l68/K/yv /WHP6xp6yhlYRDjYpAVU2T5u+cj4zG57fk8gQmOMHNYmUCGMHBxCsBE+LgYGS7V9LMo1x2d++mW 1OIvpYrh50pEghW2iNr1GqjfnFj/N52RYbJA1K7qfWnMCUf0l/5+NHvppBCuO1Gmn3VZj95TvlC 5hxMA X-Developer-Key: i=vishal.l.verma@intel.com; a=openpgp; fpr=F8682BE134C67A12332A2ED07AFA61BEA3B84DFF X-Rspam-User: X-Stat-Signature: w671784yad55cyp4dow5yxastzpagq47 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 222EF100014 X-HE-Tag: 1690955762-46777 X-HE-Meta: U2FsdGVkX18rLchyRRXi1Og00wotA9S6SxqXgkxw5yMX4jTNwUK4HB9eQ6hFT71hZaGK9zZoZJ1VdOo4IJJFRRhlz5oiHANSBMhzhD6BmrriEQuVP/BogrO8P+8Ps+1YeKY7XC2kZGmzT2ROlZodAN7w/dALRMC9Yegff5IVcGHamRQNEPRUWM4H/GiSlhWBo2wvfbrVmlqDYMua0Sa0R5pPF7AUTIeoL9aEb5yu5IQAEbFuRy2UzdMNJ1Gp+zoRp6PtJc/fy8yckpUh/ops8QgTSVJ3QjNwxKSWR8C2k50BSIyJeIX5SPCneWy5Lg8fPaUVgp9N1QQFtMyk/sqRixYZihYRLnuxPpV4v7GCS5OZBT2zW3U08rFDEc96Xg4SDCLySvrXwERlpBWE3btCq14gEq3b5Mkd40EbuiU24OIUu88WVUOO4dznDSRod0u9i6zw9lo+kDgAyJ4yXk5C0w43wMfQHx3ccxUzGE2BA93YjLtikNhyoXMAJ+O/ZasWrEck8Yh+3n2jzUJWlI0gFuJELoqI+MuexCSn5kCNWRUY3+Gu2Abuu3XkqlfsnV9TZuK5ht7dghO9NMz9CHPHFpMli9mF628ZdJQtjxCnhxoIPxcDZtYxcHkvTXaZdTLFGujUW9B4BYlJ/e0LqCP5qpnmxvaiWsGR+CL+kcYOtIKRz4UJNmoF39RcxeDCnaJs9IurzJ86Q3V4f8MX2ZkqIYGfDq2nsC6MhUGhWP3mBlJM4jkp9MHRW/JypN0J3SuyY7Adpx7liOkinhuD4U26JIifAxJ67mcLpMNJC2kcybg7pzH2zWcacT54luZIu6o/1kBxje7wgAl/bDdw0yIwhcgqRcCd2nI9lx9PjCzqxoK9RDZlIVtVjTKB7Ifm86M5L3i0M5OgDAlYuiacqp7h5U/GxRruZGrKCjBTmnZOGOTDhm58GvKRaHvoNbTy2V/QtEaefjXcXKNTaHL7F7L 3y94+5JI Tymu6kHMKENmf/xcuh/jP1mL4hNNy+8GSYeTpGtXU+VLD5V7qv1TUeW7vKTg47BL/dHR9LkqjClXQioxypSOUZeCGxctpVuBRcZhpHjiWIrNYBLtyXKnv8JUJ20kUxY5tc68itr0+b/YVw0ly7h+D+6EdqnOSe9UC+Lmyh+Qi7DHvI3FWY62bvOpIIaaF+vvTnn6SpeIM8qKzepkmNTNhLc0WB+Y95c7PKfjiF093sQTloAqzox5fYJjzFywi9rDtCQeFNqIoWE3EQpPmb3oAqtFoDPdBHgRDbxn9xiytPCnjtInh0QbVKXTbTOrtDR68d1iD10NCdqjxJ6FXt7C8tKcCrSILYyc/Se62g33jsxcSlnJ0gwO7JDECjs9jTKHRyHwFgofrF0H+4ocs6fAV+xJrLw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The MHP_MEMMAP_ON_MEMORY flag for hotplugged memory is restricted to 'memblock_size' chunks of memory being added. Adding a larger span of memory precludes memmap_on_memory semantics. For users of hotplug such as kmem, large amounts of memory might get added from the CXL subsystem. In some cases, this amount may exceed the available 'main memory' to store the memmap for the memory being added. In this case, it is useful to have a way to place the memmap on the memory being added, even if it means splitting the addition into memblock-sized chunks. Change add_memory_resource() to loop over memblock-sized chunks of memory if caller requested memmap_on_memory, and if other conditions for it are met. Teach try_remove_memory() to also expect that a memory range being removed might have been split up into memblock sized chunks, and to loop through those as needed. Cc: Andrew Morton Cc: David Hildenbrand Cc: Michal Hocko Cc: Oscar Salvador Cc: Dan Williams Cc: Dave Jiang Cc: Dave Hansen Cc: Huang Ying Suggested-by: David Hildenbrand Signed-off-by: Vishal Verma --- mm/memory_hotplug.c | 150 ++++++++++++++++++++++++++++++++-------------------- 1 file changed, 93 insertions(+), 57 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index d282664f558e..cae03c8d4bbf 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1383,6 +1383,44 @@ static bool mhp_supports_memmap_on_memory(unsigned long size) return arch_supports_memmap_on_memory(vmemmap_size); } +static int add_memory_create_devices(int nid, struct memory_group *group, + u64 start, u64 size, mhp_t mhp_flags) +{ + struct mhp_params params = { .pgprot = pgprot_mhp(PAGE_KERNEL) }; + struct vmem_altmap mhp_altmap = { + .base_pfn = PHYS_PFN(start), + .end_pfn = PHYS_PFN(start + size - 1), + }; + int ret; + + if ((mhp_flags & MHP_MEMMAP_ON_MEMORY)) { + mhp_altmap.free = memory_block_memmap_on_memory_pages(); + params.altmap = kmalloc(sizeof(struct vmem_altmap), GFP_KERNEL); + if (!params.altmap) + return -ENOMEM; + + memcpy(params.altmap, &mhp_altmap, sizeof(mhp_altmap)); + } + + /* call arch's memory hotadd */ + ret = arch_add_memory(nid, start, size, ¶ms); + if (ret < 0) + goto error; + + /* create memory block devices after memory was added */ + ret = create_memory_block_devices(start, size, params.altmap, group); + if (ret) { + arch_remove_memory(start, size, NULL); + goto error; + } + + return 0; + +error: + kfree(params.altmap); + return ret; +} + /* * NOTE: The caller must call lock_device_hotplug() to serialize hotplug * and online/offline operations (triggered e.g. by sysfs). @@ -1391,14 +1429,10 @@ static bool mhp_supports_memmap_on_memory(unsigned long size) */ int __ref add_memory_resource(int nid, struct resource *res, mhp_t mhp_flags) { - struct mhp_params params = { .pgprot = pgprot_mhp(PAGE_KERNEL) }; + unsigned long memblock_size = memory_block_size_bytes(); enum memblock_flags memblock_flags = MEMBLOCK_NONE; - struct vmem_altmap mhp_altmap = { - .base_pfn = PHYS_PFN(res->start), - .end_pfn = PHYS_PFN(res->end), - }; struct memory_group *group = NULL; - u64 start, size; + u64 start, size, cur_start; bool new_node = false; int ret; @@ -1439,28 +1473,21 @@ int __ref add_memory_resource(int nid, struct resource *res, mhp_t mhp_flags) /* * Self hosted memmap array */ - if (mhp_flags & MHP_MEMMAP_ON_MEMORY) { - if (mhp_supports_memmap_on_memory(size)) { - mhp_altmap.free = memory_block_memmap_on_memory_pages(); - params.altmap = kmalloc(sizeof(struct vmem_altmap), GFP_KERNEL); - if (!params.altmap) + if ((mhp_flags & MHP_MEMMAP_ON_MEMORY) && + mhp_supports_memmap_on_memory(memblock_size)) { + for (cur_start = start; cur_start < start + size; + cur_start += memblock_size) { + ret = add_memory_create_devices(nid, group, cur_start, + memblock_size, + mhp_flags); + if (ret) goto error; - - memcpy(params.altmap, &mhp_altmap, sizeof(mhp_altmap)); } - /* fallback to not using altmap */ - } - - /* call arch's memory hotadd */ - ret = arch_add_memory(nid, start, size, ¶ms); - if (ret < 0) - goto error_free; - - /* create memory block devices after memory was added */ - ret = create_memory_block_devices(start, size, params.altmap, group); - if (ret) { - arch_remove_memory(start, size, NULL); - goto error_free; + } else { + ret = add_memory_create_devices(nid, group, start, size, + mhp_flags); + if (ret) + goto error; } if (new_node) { @@ -1497,8 +1524,6 @@ int __ref add_memory_resource(int nid, struct resource *res, mhp_t mhp_flags) walk_memory_blocks(start, size, NULL, online_memory_block); return ret; -error_free: - kfree(params.altmap); error: if (IS_ENABLED(CONFIG_ARCH_KEEP_MEMBLOCK)) memblock_remove(start, size); @@ -2149,40 +2174,14 @@ void try_offline_node(int nid) } EXPORT_SYMBOL(try_offline_node); -static int __ref try_remove_memory(u64 start, u64 size) +static void __ref __try_remove_memory(int nid, u64 start, u64 size) { - int ret; - struct memory_block *mem; - int rc = 0, nid = NUMA_NO_NODE; struct vmem_altmap *altmap = NULL; + struct memory_block *mem; + int ret; - BUG_ON(check_hotplug_memory_range(start, size)); - - /* - * All memory blocks must be offlined before removing memory. Check - * whether all memory blocks in question are offline and return error - * if this is not the case. - * - * While at it, determine the nid. Note that if we'd have mixed nodes, - * we'd only try to offline the last determined one -- which is good - * enough for the cases we care about. - */ - rc = walk_memory_blocks(start, size, &nid, check_memblock_offlined_cb); - if (rc) - return rc; - - /* - * We only support removing memory added with MHP_MEMMAP_ON_MEMORY in - * the same granularity it was added - a single memory block. - */ ret = walk_memory_blocks(start, size, &mem, test_has_altmap_cb); if (ret) { - if (size != memory_block_size_bytes()) { - pr_warn("Refuse to remove %#llx - %#llx," - "wrong granularity\n", - start, start + size); - return -EINVAL; - } altmap = mem->altmap; /* * Mark altmap NULL so that we can add a debug @@ -2221,6 +2220,43 @@ static int __ref try_remove_memory(u64 start, u64 size) try_offline_node(nid); mem_hotplug_done(); +} + +static int __ref try_remove_memory(u64 start, u64 size) +{ + int ret, nid = NUMA_NO_NODE; + + BUG_ON(check_hotplug_memory_range(start, size)); + + /* + * All memory blocks must be offlined before removing memory. Check + * whether all memory blocks in question are offline and return error + * if this is not the case. + * + * While at it, determine the nid. Note that if we'd have mixed nodes, + * we'd only try to offline the last determined one -- which is good + * enough for the cases we care about. + */ + ret = walk_memory_blocks(start, size, &nid, check_memblock_offlined_cb); + if (ret) + return ret; + + /* + * For memmap_on_memory, the altmaps could have been added on + * a per-memblock basis. Loop through the entire range if so, + * and remove each memblock and its altmap. + */ + if (mhp_memmap_on_memory()) { + unsigned long memblock_size = memory_block_size_bytes(); + u64 cur_start; + + for (cur_start = start; cur_start < start + size; + cur_start += memblock_size) + __try_remove_memory(nid, cur_start, memblock_size); + } else { + __try_remove_memory(nid, start, size); + } + return 0; }