From patchwork Wed Aug 2 09:37:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 13337511 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95D7CEB64DD for ; Wed, 2 Aug 2023 01:37:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25D73280110; Tue, 1 Aug 2023 21:37:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C3BE280114; Tue, 1 Aug 2023 21:37:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA80C280112; Tue, 1 Aug 2023 21:37:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 80F13280113 for ; Tue, 1 Aug 2023 21:37:35 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4F2A04069D for ; Wed, 2 Aug 2023 01:37:35 +0000 (UTC) X-FDA: 81077452470.10.36FE192 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf04.hostedemail.com (Postfix) with ESMTP id 104C74000C for ; Wed, 2 Aug 2023 01:37:32 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=none; spf=none (imf04.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690940253; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ojMDeLWoj1XODyjeyi7n+gkeOl0JR/suB/pw9H0+pdg=; b=tNIQecKQvcoP04nR/ekfHPuHil1FmqEtlhmBrnogTbg1nVsS5YgYQ/EIFGJ1YW9WoJ4jdV DzkPtXx/KweSfuE0D0jcYK0Zw6a2BwuuzmWBpOE8SNXKi2rYd0+ISdqaAOKXgxLUHw6fxa Ryxpo7zgfCFWpwIJ84MocIKMOYqw/PY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=none; spf=none (imf04.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690940253; a=rsa-sha256; cv=none; b=AJMnjWIOKH4rfO/zTSlzKvPtb54G1hyuyfbL3jGwE9TPKqp8UQ0ZVuQ7QSBV2gY54LQUHm qbE4FMyP5x0bR1TllKGe1SNLoFfz+RHiwAzhEavqfhpprVphtp1E5J2HngoV+b0VtY/2sr 91/On+thirFpwm8jHo0hfn5emULNkyE= Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RFvjg4r0kz4f3nTt for ; Wed, 2 Aug 2023 09:37:27 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgAXzrFTs8lkvrtvPQ--.56352S8; Wed, 02 Aug 2023 09:37:28 +0800 (CST) From: Kemeng Shi To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, david@redhat.com Cc: shikemeng@huaweicloud.com Subject: [PATCH v2 6/8] mm/compaction: correct comment to complete migration failure Date: Wed, 2 Aug 2023 17:37:39 +0800 Message-Id: <20230802093741.2333325-7-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230802093741.2333325-1-shikemeng@huaweicloud.com> References: <20230802093741.2333325-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgAXzrFTs8lkvrtvPQ--.56352S8 X-Coremail-Antispam: 1UD129KBjvdXoWrZF1UKrW8Kr48JrWrWrW3Wrg_yoWfWFX_Jr 4Iyr1rWw1F9r9IyanrCayayryagr4kZr17Ww1DX3y7t34vyF4fW3WDArsrZr9YqayDW3sx C34kZr1jk3Za9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbDAFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M28IrcIa0xkI8V A2jI8067AKxVWUAVCq3wA2048vs2IY020Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJ M28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2I x0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK 6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4 xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8 JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20V AGYxC7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAF wI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc4 0Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1I6r4UMIIF0xvE2Ix0cI8IcVCY1x0267AK xVWxJVW8Jr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r 4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0pRvJPtU UUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 104C74000C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 97nsfmicoqrsreitkzc7hxpd4ezafjmc X-HE-Tag: 1690940252-834438 X-HE-Meta: U2FsdGVkX1/oq3kMeX3H8BonGbNQ2pkZ5bIkgcVBIeFh1d9AhvH+bSC45M++1T1a7WWzDL2DJBTSYKvKVN5wWaaN+Ax5fIOiAsAbgwho+L9+053s5xsJjP8tfOReIk8riCNbdaUNye4TId7W6Clnz6srqavWCycHt0g6fb5LFy7wGQCpIUkGVJXfsBNsqYZfTFUQMSE3m+AqX7y8CBs58xW/xXkD1n1kvBxC3u56Q1m0pyKf470D1H6x2ixr5cuFnKyCZN9IyMTsRmELXu0xjcj/MJ+hlCf6sh92+r32oMfPaJFsbjYczTFD/2RSYqPWbAI8X2JqOhyaLZU+AHip6pT/cMwDT8tQmzMJF6zq513X9pGhQhCcudjEkExMAJ33894Y14zCCgaWPf+RQVfHnP00CNb8/aednI5WU+PP/knTkyXD1uhaAZlDiROVc6MGMNKXmvLUI9fzh4d8FpBeOhZeAcA8sqinM2VU540f3MNiCzmBDd5JR1voPq/FYhYDyM8ZN8pc8EI5vsTTYVBmwy0Y/qRJhgddugSAS1cqhHVaP0ncOPV2Zg/uWNRj1FtRI7oWcRFB2sNGG+jtgIOjDbhpYliAe21NEuVjQTj//WYG2APcNSq29GP3pXu8A9wAImeIQWxeswMnhNZbg7Cr9+m8K33YTi5xfipIrG4hhVdLa0PGYGZy5HGrv6DaYOO4C29fkvGGCms9AszRaSSaFPf1NnclnrX1eg1KYtiNHVU7MWLVWfufKYcz5oOWRhsaB+Wm3YbxLb5i89bXSvzMozljmkiIEsAN19/WAbFzYa7YgUGHSxkVzh3N5hH2i+NNxDdKUI5wG93c/5DwCfyWluLGeYq/ks/MUfxu6z8rklR4QOco7x2Tu+FBkc49aMoLI0d64MEpA9Hyfwd95e1/BvZ0mv4tiKbxoOy36Pq/Qbm69425gN9EEMxzlePeMdBb/HVK00t0dlRAWTRlfaf eoYRH2SX 5PxSWDbal0NWr1DM6cwg0E45qgADokjFrGoDUq5PAVdI5oFV8zCBalGToMsYWXk+JGrNe7lGjdQhW6ZZ9GjSQV7Wm3x/UBVnBH7mSJ946xaXweI+K1h3N67IlYKcMl5YnIQGefqzegthEWcoPWjggnbFEEVPZ0ac39OMVWofHmQPWUazO8hPUp7vfqrq35wQfwsKgzQNyXG+r21iTvLPYw9z0c6BVORBxqVqeYpMH/r0A5OfOIs67+GysaCFM51X3mJVQkNpIIImMnIdxUgl3IhxF93+b6GOODqqD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Commit cfccd2e63e7e0 ("mm, compaction: finish pageblocks on complete migration failure") convert cc->order aligned check to page block order aligned check. Correct comment relevant with it. Signed-off-by: Kemeng Shi --- mm/compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/compaction.c b/mm/compaction.c index 7f01fbeb3084..5581e4cccac5 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -2512,7 +2512,7 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) } /* * If an ASYNC or SYNC_LIGHT fails to migrate a page - * within the current order-aligned block and + * within the pageblock_order-aligned block and * fast_find_migrateblock may be used then scan the * remainder of the pageblock. This will mark the * pageblock "skip" to avoid rescanning in the near