From patchwork Fri Aug 4 11:04:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 13341176 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E7C6C04A6A for ; Fri, 4 Aug 2023 03:04:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A910A2802AE; Thu, 3 Aug 2023 23:04:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C6682802BF; Thu, 3 Aug 2023 23:04:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 708182802BD; Thu, 3 Aug 2023 23:04:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 622282802AE for ; Thu, 3 Aug 2023 23:04:49 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3355080609 for ; Fri, 4 Aug 2023 03:04:49 +0000 (UTC) X-FDA: 81084929898.13.AF019E9 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf04.hostedemail.com (Postfix) with ESMTP id A3B8640019 for ; Fri, 4 Aug 2023 03:04:46 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=none (imf04.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691118287; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3FXHuIfV5f3mvJi1wEv8UvvdZ/TMCTjKFGN28OOXy98=; b=czUNCUblQUXczJ9OcNkFzpDJTej7AJLPpgtp6YAXCUZOApQTnaFZgr/qKT1rnGWm7LS9z4 1eTMjWXfda6E8JcR/jsNuPGeNP4lCPGR6XbrwnbrcHgggb9wubeGiAkgwTHoz8/hqBet8i djul+YvpY56JUy9SaYxgv+xfJ9cMXjQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691118287; a=rsa-sha256; cv=none; b=SoMUu0+fAj+Xr4ipzN1zWRkPs08+8YGdi9KD4ydBpaI0upN/UV3BXREXbP5vL6UGkFEdBQ qrQOnjhW6bxHttEO1LqkfgexZ9eSQeJyKltvSGnYxLRIdL3pEZ/IRMei50SoFEku/SchY9 SU5WT+a0g+wW4mv7q60cYXGH9WJUFCs= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=none (imf04.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RH9YN6YSDz4f3yyn for ; Fri, 4 Aug 2023 11:04:40 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP1 (Coremail) with SMTP id cCh0CgAXODLGasxkWSvZOg--.12542S7; Fri, 04 Aug 2023 11:04:41 +0800 (CST) From: Kemeng Shi To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, david@redhat.com Cc: shikemeng@huaweicloud.com Subject: [PATCH v3 5/8] mm/compaction: correct comment of cached migrate pfn update Date: Fri, 4 Aug 2023 19:04:51 +0800 Message-Id: <20230804110454.2935878-6-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230804110454.2935878-1-shikemeng@huaweicloud.com> References: <20230804110454.2935878-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: cCh0CgAXODLGasxkWSvZOg--.12542S7 X-Coremail-Antispam: 1UD129KBjvJXoW7tr1Duw4UKF45Ww1UJw4rAFb_yoW8Jw13pr 97Cw1jqwsYqa13Kas2yF18Za18Jr4ftFy7trsrK348AF13K3ZrtF9rtFyUZrWUX3sayrWa vF47KF47ta1fZaUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUPY14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2jI8I6cxK62vIxIIY0VWUZVW8XwA2048vs2IY02 0E87I2jVAFwI0_JF0E3s1l82xGYIkIc2x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0 rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6x IIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xv wVC2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFc xC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_ Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2 IErcIFxwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E 14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIx kGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUCVW8JwCI42IY6xIIjxv20xvEc7CjxVAF wI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r 4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0pRvJPtU UUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: A3B8640019 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: c9aqz5wky1tr64swinz5nkub15ydb83o X-HE-Tag: 1691118286-786943 X-HE-Meta: U2FsdGVkX1/qvdCGhVH0F8lnMHoSIRllaM28sU1NC1HwFO+Ol0SKC3goR0x0tq7bItq3PZcHqZsXmllnrncCmlcNy9e+RS0rMWStYNCWVoA2hUg3nQysIBGpkA9fz1v3kqUZ9+nJ/qiwyJpi1Z9RFzgN9eu1NTKPvZvyJb9lMb/bZh7maSsmd1a+KR+jL7CseSCDGqHu5dYOXLCJ4c8h5OClhXngT0GZ2Ujv+nvA215yWf6RWUHUEX+53u4Ls4GixcR/HKDla8eAiKvtnHjSTP9/9l5OZp/fLykuWGub0Q6iR2cflVm9oo1vPKpc/y+qnH89emLcRZ7xpqSSvMrVZdv/CBSZ0zNik1xPXZYSYAnaJft8oSQwRdTOih8Jq8wwgdmFPivIefx/IQ+68OYW7EB2lYgBOgFnObCg2607ezaoHuEdHTP/NPQ5LXnqsxAhYWhNKpRDAizL741Zu7yEZdvTlRug3/a/WCvKwSkuqu2Hd3YkvkoloVkQexJvDOQDuTmyTlw0yWV63YrP3snVxm5C9R2M4uXnmZm0v+C5CFOb6814AaLfQ/4rI7VmF2X2x5Sb1ecGL1SuZoPpMJjTwZQS4595hcBwyoumJMNMw7YhdVKFvm7fpfwqsRX4JtL+3YqGNjw10/HgOswH1XOd8ojFm/hyeH4soB6abmPp07GVPnBbdZ/MhdCRRCZ3bPBzZ7L2nSeWroOdMPKQQuhOOVgeqRItqYCV2j9d2ySaBwUgNbceA2kpIsQH0mRbH99JtD1UUmfcjSM7YKzOPTL1Ura3cEdUemc5VHr3l+ITmWgce/qimxBUtalqCm53MQW9j2a4C+Brsiav0JNAS8JASG0pHlQRG8pgRJdlc34uInI+VkNNnWELqabj/mcYnsw+QhvzLGmkuKNsSabyyh5EUpsnU0BUrFXsXVenL8EkOkUe1O/2tr3EyLDwNkD3lrh3cbFldVTd+jSexZKSJ0D DDO9F2kR oR0G/el4XfhP4sZPhS+atkE3HbCK3QkxOsxTNAoO9bA9WzuxSlasQnpyoSQs4MIe/IFinRXoJw3IIy0skUNWCyUOGR91lpwgYjpX2YHdpFXg4+XbPFhAZsWtQTZhLlFMAC1HTTTSMXZdwXTwzTx8VyzSLYcPNopKQUf1MmDlUaqxYMJGUW52Uh8PyKZZ29iP6JzBCMmvkw0aRxcAqrJGKaliySbrgj+78sgNvF4+/KN4weODtKiHpwf8AIQvhMQVa/0MgvD8XcIIekLsVgkpDmIgwMHBmWsW8WJdkZvP5G9l4HNBU8VdZ58h0bw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Commit e380bebe47715 ("mm, compaction: keep migration source private to a single compaction instance") moved update of async and sync compact_cached_migrate_pfn from update_pageblock_skip to update_cached_migrate but left the comment behind. Move the relevant comment to correct this. Signed-off-by: Kemeng Shi Reviewed-by: David Hildenbrand Reviewed-by: Baolin Wang --- mm/compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/compaction.c b/mm/compaction.c index 4bf2dc936add..fda61dc40f93 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -469,6 +469,7 @@ static void update_cached_migrate(struct compact_control *cc, unsigned long pfn) pfn = pageblock_end_pfn(pfn); + /* Update where async and sync compaction should restart */ if (pfn > zone->compact_cached_migrate_pfn[0]) zone->compact_cached_migrate_pfn[0] = pfn; if (cc->mode != MIGRATE_ASYNC && @@ -490,7 +491,6 @@ static void update_pageblock_skip(struct compact_control *cc, set_pageblock_skip(page); - /* Update where async and sync compaction should restart */ if (pfn < zone->compact_cached_free_pfn) zone->compact_cached_free_pfn = pfn; }