From patchwork Sat Aug 5 11:07:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 13342475 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AABC3C00528 for ; Sat, 5 Aug 2023 03:07:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7BFF18D0003; Fri, 4 Aug 2023 23:07:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D7E18D0006; Fri, 4 Aug 2023 23:07:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DB528D0007; Fri, 4 Aug 2023 23:07:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 107CF8D0003 for ; Fri, 4 Aug 2023 23:07:08 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D6A031A02C0 for ; Sat, 5 Aug 2023 03:07:07 +0000 (UTC) X-FDA: 81088564494.18.F30C0ED Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) by imf05.hostedemail.com (Postfix) with ESMTP id A478D100006 for ; Sat, 5 Aug 2023 03:07:04 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=none; spf=none (imf05.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.56) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691204825; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TnEuM+JFuyPJEF5vsFmy3+0fVDqCpjqTmz6mI4Gk1yk=; b=Z7tB2x10JnChYRfofpKYakYEq91mXV13kWkfxYCmfRnip0q4768mX1aUSiQgmGh23MXkx3 aM74N0bXmGF6oT4eKWwjBe8jdKXiX4CeJOqPE965NmoyFN5bPuyj/YQJ3wV9s9emKRGacG WlqMHjD9Hsln+KgAbb3LVu+ApG4sKYA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=none; spf=none (imf05.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.56) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691204825; a=rsa-sha256; cv=none; b=Y8x1FpNesY3oY8ipPteW4pi2dVyUPX6VOmHYQB4xnHZizJ/LFQpzJQ8cp9RuInURgjDWv5 10RWyDUjX5PJ6SdbeBQvn5LcjTWMUdISH70XIDTYlX5frzik+0izNSLU89bThFUMm3xwdi /1iWFsOtO0J7aC1gV18VRDtomVVKRG4= Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4RHnYY1v9Tz4f3lKr for ; Sat, 5 Aug 2023 11:06:57 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgAHvrHQvM1k6A5ePg--.23962S7; Sat, 05 Aug 2023 11:07:00 +0800 (CST) From: Kemeng Shi To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, david@redhat.com Cc: shikemeng@huaweicloud.com Subject: [PATCH 5/9] mm/compaction: remove repeat compact_blockskip_flush check in reset_isolation_suitable Date: Sat, 5 Aug 2023 19:07:07 +0800 Message-Id: <20230805110711.2975149-6-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230805110711.2975149-1-shikemeng@huaweicloud.com> References: <20230805110711.2975149-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgAHvrHQvM1k6A5ePg--.23962S7 X-Coremail-Antispam: 1UD129KBjvdXoWruFyxur4ruw48JFyxCr15urg_yoW3Wrb_Jr n3KrsYyrW5ArykZrZrArsIyFs0gFWkAr1UWr1qqa1Yy3sIvFsYqa1DZF17Zr15XFW7Wr93 u3WrZFyYkF1fWjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbDkFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M28IrcIa0xkI8V A2jI8067AKxVWUAVCq3wA2048vs2IY020Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJ M28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2I x0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK 6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4 xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8 JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20V AGYxC7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAF wI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc4 0Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1I6r4UMIIF0xvE2Ix0cI8IcVCY1x0267AK xVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr 1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7sRiVbyDUU UUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A478D100006 X-Stat-Signature: o7dompn5wfbd1ans67yod3zjbxrndetb X-Rspam-User: X-HE-Tag: 1691204824-978712 X-HE-Meta: U2FsdGVkX1+xYbu81PBqusueCGWAHwskuB4ySrFYAGs054eLZIk0w5h89xIrbp/colehrLq/01gWwf8gRpfXc9eq3mAL/9VjcXo0r3EjCtbUFga7c/WQwLuY4lQCgCDQB7WhEwczmCEnpaC8YmeaXNglElB34sXbpyJOWtTyzIpLGE2e5eszVmpVSvgQwxbWObdWyQUmGgibJBLmXvKUL3kyn/473MUz+POVttU8c72oxedDVRT5fjMd+DIvGal0M0io6AP7si9Qr0/r8TLfUwn0S9sWC1SxhPwKe4LzqBz36ECK4HeH9ja2TaBuNiVgo1X5kcY9CpHuc34t3RDhvK6zWaYnoHXzGTkkh4FJUktP0zxl7/nYrNJWlwvAOuK673q6F4A7oe9NPiAMFVQgEfa49gwAxvBe/cB3yJjTAm4Fin6H9MXSIp3lKgRRJuk4USxx1Gb3SnmS+uhcnDMh8pMFhjjbF1wBOKEpV0EOuH39SITm//4REJI7Xmfom5lQ2oAAl3WEQ3vXHb9ZcuIgtpJzfOj6ES9MSziAjdQlxt2CLnUNqzcZAS/kXeM15mtzGCEz9qvI55iq2C0XVoyHHGwB0aYmgFft1hZIqq2ab7wF7v3iyfviDKVXC7jtHnQCBtn8hFhFHIq7M/1hzpxEeUtBLELraOeNHhgWPSfM+/t0h+FQHxV9G4W8F0EV6BBQZa1kpjbS5PytveXUvkBnQWhE+oFMVgOttaHDemFQX9Xs6raAaVvvGIDqjkEHb8dmR/0RrUiOqBGaRqDfG+5VQyOMBllP0k96bZgvLv9rQpj7Td1FXqZnVx/6d4OThMjPBB/npA7sqJbG4Yf7ViajJqk2APhH155dLxjE9nWRXQD1jz+aIiAWl6mBqdSkSdJypp6L7FDClpBVFTL/5Wg8YS0Tza/48A881eaksqyWMz05g3Pd9RvMEw+Zd3st6xnnD1Ld8kTsG0lFXk2rL3/ RPyobqrx Uai5XkK/WdSAFS58JOkK5x68Zg+DSdP09kasQrABHObo00CuQYz9QPn/0nIWFeCVxWFVqEpslI79IHDZKEfCtlPwwUhzXdMXsepvaPGj+zeqlBxQ2Ib9kFThAHAaeBeTOTZdslV6Q+b5TJYdt8PyJwrWkAGfy2i32AbfOMq/vx9turJGm9wuGeYU8vnWrU4TjUeEDxGZotwUWitHNwPQn4r5OBO64nJAGXQO6BVCj8pe98hn/DXGwMcmw1pHss7q3vuhJqWAfmV9KvjjS6gUddfAf/monzBMA2A2Le7ynwapC8FLOVDhzqGeMtwKIOY+qb0yS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We have compact_blockskip_flush check in __reset_isolation_suitable, just remove repeat check before __reset_isolation_suitable in compact_blockskip_flush. Signed-off-by: Kemeng Shi Reviewed-by: Baolin Wang --- mm/compaction.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 8d7d38073d30..d8416d3dd445 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -434,9 +434,7 @@ void reset_isolation_suitable(pg_data_t *pgdat) if (!populated_zone(zone)) continue; - /* Only flush if a full compaction finished recently */ - if (zone->compact_blockskip_flush) - __reset_isolation_suitable(zone); + __reset_isolation_suitable(zone); } }