From patchwork Mon Aug 7 11:09:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qi Zheng X-Patchwork-Id: 13343495 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9141EC001DF for ; Mon, 7 Aug 2023 11:13:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A8686B0075; Mon, 7 Aug 2023 07:13:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 259346B0078; Mon, 7 Aug 2023 07:13:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 121208D0002; Mon, 7 Aug 2023 07:13:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 02B336B0075 for ; Mon, 7 Aug 2023 07:13:52 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D4B021609A8 for ; Mon, 7 Aug 2023 11:13:51 +0000 (UTC) X-FDA: 81097048662.02.56C614E Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf23.hostedemail.com (Postfix) with ESMTP id 0718A140003 for ; Mon, 7 Aug 2023 11:13:49 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=dRL5OTw5; spf=pass (imf23.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691406830; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GSWsN00ewH1CUxuL2on0amogNZtYjpfZMPk3tXk1MLc=; b=zHyYmN0LUHI+Yo8Sfk3ghi5UkV2lNBUkMz91sMILIpWpGNafA2VoCusU3KbNn/VBInN5eU OTl0eXQr/F7FQyoHHwcuBIJ2pqwrU/9N/Yyb6pISoShyG8lycp05hZ4EiHEK/+llRQrnrf ZL0eQAFQlL9xIkDb8FsnXmdohI+kCnI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691406830; a=rsa-sha256; cv=none; b=zQ0ny2EIanq85Us3dIP6OHD6Yc7PdoyMcarH+31aIP9X0JSApYg+gDLJt38f5jREk1X2Su 5VbmBQKTY8YYzxn4Xghc2NoG4poVcdw82Lz5PpTsOyRXntZTZsPZ0VBWcbRcuEsUTTXuGu QIW9OTz529xp72246THK02xFBlP58Ig= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=dRL5OTw5; spf=pass (imf23.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-55b78bf0423so391756a12.0 for ; Mon, 07 Aug 2023 04:13:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406829; x=1692011629; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GSWsN00ewH1CUxuL2on0amogNZtYjpfZMPk3tXk1MLc=; b=dRL5OTw58GKSKLSEPIkOk3RNFcmmAqsiLvwXwuCsQ6898crZQ//U31N7J6aETctBqp +yNfSzW4P67hr/Q5en6KlpeaCzhuSArK09Uv1s7rX7JtU6KCmHd6Mqm/4AQ65zu5m5Io c0AgOv8G8SDnrmCDqGvw9U9rsdHywgcFHequBwptONEnrpN+7djJ7c1au1NclddO4RuF fGkbwSFA8neTzyjHzVx+h2JTuM9t2Q0O3KvbIWMUOl7gxPC5QUE4BflF3xVEC1ALf5VX oJ+rwFdIWe78RvMraM76IWcwrhx+7xBzgx3bdbJKVCqu0ytQTpll1s2Np/nEdRD5cowd HYLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406829; x=1692011629; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GSWsN00ewH1CUxuL2on0amogNZtYjpfZMPk3tXk1MLc=; b=Zs1tsC/6/KIgThkg+7+ya4RWoqs3xWTLeVDY2BX00nSr99lmM8a2K4FAUyXh98cye4 zwMcmEgjzPNUymz1a5NbOSiWlLgLuJWN25JbZPALp5fOJ33bqTqmzmzmt2i6sZjxTKmf r3LfOFOTqLXYs6YO0LpcdgZxXkxgChqbkE0HZ/Rd8UZBvNEObeacZX4vjoGJU5kv0QCB RxdcDeoNyOltUgW8xdyGnJPwLT834683QpcrLvJpnkuEpqFF0xOWcKQSs4NCud2G0zmY 4QUMR0bb4Y10Cp28uriUtL/9C9+GTDXjRJeu2upW8Xq9jYS2P5SwEfoNPTCL6Nw1OuRz Pczg== X-Gm-Message-State: ABy/qLZCYqe7f5tXAa743/m0cHox3TjwwfcrNLsaknWobNlsDdQ3SXhN B2ZxFlcENS+ZU1tp4XtirzQQmA== X-Google-Smtp-Source: APBJJlEEwhe0wjgrc7nxC5j9G5K3ZI0sWgwDykpBRAx7nLtKV2LZNd6jgA89VvGSaryf9LAeIFxakg== X-Received: by 2002:a17:90a:901:b0:268:3a31:3e4d with SMTP id n1-20020a17090a090100b002683a313e4dmr23070871pjn.2.1691406828996; Mon, 07 Aug 2023 04:13:48 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.13.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:13:48 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH v4 18/48] rcu: dynamically allocate the rcu-lazy shrinker Date: Mon, 7 Aug 2023 19:09:06 +0800 Message-Id: <20230807110936.21819-19-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 0718A140003 X-Rspam-User: X-Stat-Signature: zgudimnzdh5469m68hji8j5pc5yrf86x X-Rspamd-Server: rspam03 X-HE-Tag: 1691406829-570384 X-HE-Meta: U2FsdGVkX1/LVKVqpEy56qZ7QNVh1rs0NaKd7kXBNSYDc7MyPzvtzHB2aU2UhMnsjShHTpbsO15zlddCHfN8BR7N8C8rIbJXXKKBI8WENdA3a/9usP4v7uaJTFAIlh7FIoOKqd3pRCbYcmiTWg+wFt1RjOIlya9jkFvh+Z1j1QYe8HxgKjApmWzk5AnT6Cb1dfkFF7Gk3HdXZRI83AIQen9IQp+faQvmORFawpwXYvZV3ANTBwbB4llLPKtJAoi8LRPBa3jRy0fS+kpvyi+ILMhVpEjCTtMDHO4VlNroIqMmqx+W0ZTBxA7h6NDgt/uNVSGFS/HigkI4/aPqsjB32ksILguxrQb2OwHJjPiK3+sX6Mqd37SaWqLSZZPYSsPd31qrovQCBxQTldKVf0bM6FC2UFnUsFd7YbwhKdWw/58K/3jfIeenzFrZDCOrUP1AO+Qm13RBuhciaN/fuJtpitbYctVHfgy0oJhbfXxmyTC/Mhbei9xeH6gGhVTxUh4kdZOOKarcC4Vtla/qN1Gs5XgYaEU6KxNwiAFBw5dQ2z+6O8R0MBqRuGaDgFCgJzjP4OEjYBXItFMJctxen6SnjC0UlrUvG8ASJKnlTr/hdZU5fSWNkaeC9CxqgHrUw7ad7sn2AvcaphN1M+TEEf1Dv8jWX3PPzOnGS/jwscTnDxepjoecISBSFjqSjwxN3OVbusTk1Ddw27LQ6dDO/MqFBq0k7DkzKLhvfsr1OEXnl2czQwxHe/cS53FHE/5gsK19uilMhBknhWreubBUrow0IZcBIJbaSO8A3WP15xv8zu+eY8nYRqE0DiwNar927PF1FKexZ3hCpWJww2N3moKhISlu6R4eqJgbrKCkCLCjYwXSqHoRTzNYWvRBFcZ0NuO/y5FAJq9BqevqgufCz1xBTeDSGf/oX+8UKCOt5go+ve5MByZbcdOKdwLxMwWgQPiDF/Ggk06SXO+BcgSVB0l Z2NTyPXI uKjEWtOlR/S43s22utShjS17xzzxcAdrPAPE8l1wE6sLfpahpExrt4ljhaD/4h87W+GPjli0NkKT7MwuZUywT6Up3vCIon3W5y/9+EO64prlNRCmMmHSM4dgl1O1zSqcS8wC3JChBUK8yEjI2SicIxHYLxJFrm1uGarBvLRMqmIO54ixPU2YipWRl7GysUV97KDjorfQtlxpCHzzXP0TuKsIK/YKiMKRr7UBXtVr+dgj9wufa/Ib+uv22gAsk8gIoD+AwuvWDbOiUwBNMB4clGwsuDkav8BKxLHPPAxPUM+XHo/1EG3LqWCZIw25OpsICnGy5fVxkRuZbUB/T+8IJQfoLJOurt6O52v+2W11M4sPGDsFIDJSsxsT8vPKl5F166TM1M5jGv/T613PzuMSdZay1nikh7valNEPq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Use new APIs to dynamically allocate the rcu-lazy shrinker. Signed-off-by: Qi Zheng Reviewed-by: Joel Fernandes (Google) --- kernel/rcu/tree_nocb.h | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h index 5598212d1f27..e1c59c33738a 100644 --- a/kernel/rcu/tree_nocb.h +++ b/kernel/rcu/tree_nocb.h @@ -1396,13 +1396,6 @@ lazy_rcu_shrink_scan(struct shrinker *shrink, struct shrink_control *sc) return count ? count : SHRINK_STOP; } - -static struct shrinker lazy_rcu_shrinker = { - .count_objects = lazy_rcu_shrink_count, - .scan_objects = lazy_rcu_shrink_scan, - .batch = 0, - .seeks = DEFAULT_SEEKS, -}; #endif // #ifdef CONFIG_RCU_LAZY void __init rcu_init_nohz(void) @@ -1410,6 +1403,7 @@ void __init rcu_init_nohz(void) int cpu; struct rcu_data *rdp; const struct cpumask *cpumask = NULL; + struct shrinker * __maybe_unused lazy_rcu_shrinker; #if defined(CONFIG_NO_HZ_FULL) if (tick_nohz_full_running && !cpumask_empty(tick_nohz_full_mask)) @@ -1436,8 +1430,16 @@ void __init rcu_init_nohz(void) return; #ifdef CONFIG_RCU_LAZY - if (register_shrinker(&lazy_rcu_shrinker, "rcu-lazy")) - pr_err("Failed to register lazy_rcu shrinker!\n"); + lazy_rcu_shrinker = shrinker_alloc(0, "rcu-lazy"); + if (!lazy_rcu_shrinker) { + pr_err("Failed to allocate lazy_rcu shrinker!\n"); + } else { + lazy_rcu_shrinker->count_objects = lazy_rcu_shrink_count; + lazy_rcu_shrinker->scan_objects = lazy_rcu_shrink_scan; + lazy_rcu_shrinker->seeks = DEFAULT_SEEKS; + + shrinker_register(lazy_rcu_shrinker); + } #endif // #ifdef CONFIG_RCU_LAZY if (!cpumask_subset(rcu_nocb_mask, cpu_possible_mask)) {