From patchwork Tue Aug 8 09:53:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vlastimil Babka X-Patchwork-Id: 13345911 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EDAEC001B0 for ; Tue, 8 Aug 2023 09:54:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 320606B0074; Tue, 8 Aug 2023 05:53:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A7888D0005; Tue, 8 Aug 2023 05:53:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E906C6B0074; Tue, 8 Aug 2023 05:53:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A523D6B007B for ; Tue, 8 Aug 2023 05:53:56 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 76866C0278 for ; Tue, 8 Aug 2023 09:53:56 +0000 (UTC) X-FDA: 81100476072.10.7B229B5 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf24.hostedemail.com (Postfix) with ESMTP id 99C91180009 for ; Tue, 8 Aug 2023 09:53:54 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=TM63PQDL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PMYk4+ps; dmarc=none; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691488434; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a3DtkVdLGQHDYk90N/OXEPjHa8PNLxLzj/qp7wDJMuQ=; b=RLkzkw9D5jJ81SuBffTTIi/bJ6KLs4tJephWbaBOhjl9BvAX3zQnhCD9e6EiM56mrXwB95 4REf0/MXCqyur4terHe7+1GqcRqm6Ays+q7bY0tSi+yaLkGxAgsdOGg0OgMcjKBZt+Awfa LDmkylNdJzw3sj9eGjUD8dpSG3efQI8= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=TM63PQDL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PMYk4+ps; dmarc=none; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691488434; a=rsa-sha256; cv=none; b=YxLQZjyyRKzAUd/e1c+Pr28ZqAW3hQxeaynx4XHWV1Xq7HsUcBPFy0LdS1ZMW3ErubDKLm 6N9SpzHlXs/XbiL7klzdRqwIezaRddLaClytWqxQXC0GAteUiC4kM6ZDoJJiQhXQYpma0p 26jZLPcpuv/C6+cZSwzXZM+5VzFX0Vs= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 244E520319; Tue, 8 Aug 2023 09:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1691488433; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a3DtkVdLGQHDYk90N/OXEPjHa8PNLxLzj/qp7wDJMuQ=; b=TM63PQDL1/kV/0eRyfhNJd9mTnr0x7YZSgjc8gu+OShasFlpsvfTd29e6XuZUTzyIuOzKh epAVCCvXUWmkzTZ+F27l6Dqs/VEedrJReg+43nUQbnAOrW9MhnfDcJEo+daT4fyDfyI7+2 tuJoCLZ60xeq+ygkOsdBQLf9xHRywQI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1691488433; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a3DtkVdLGQHDYk90N/OXEPjHa8PNLxLzj/qp7wDJMuQ=; b=PMYk4+pst66z0H1Ard3n4p3Ej4MlqgpLiQdaPFhRHz+PTuyTYA3lk/x+G2Bsq/DLk5blTG bJlASInXsVjsuJBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id ED5F6139E9; Tue, 8 Aug 2023 09:53:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IP9CObAQ0mSBJQAAMHmgww (envelope-from ); Tue, 08 Aug 2023 09:53:52 +0000 From: Vlastimil Babka To: "Liam R. Howlett" , Matthew Wilcox , Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Vlastimil Babka Subject: [RFC v1 3/5] maple_tree: use slub percpu array Date: Tue, 8 Aug 2023 11:53:46 +0200 Message-ID: <20230808095342.12637-10-vbabka@suse.cz> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230808095342.12637-7-vbabka@suse.cz> References: <20230808095342.12637-7-vbabka@suse.cz> MIME-Version: 1.0 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 99C91180009 X-Stat-Signature: idgqkefpn16si73zq614pp9sjh34fmkj X-Rspam-User: X-HE-Tag: 1691488434-631052 X-HE-Meta: U2FsdGVkX1+Dxqcj5NGmr066YDw0IOO56YeONupMJIpCZoHpIfFtvnFSrvuhDMSjP5AoWbBUAczwk7fdpRbNEayqRRY8Jl3AZp/WT6fnns76Kd8OSnUbfEbNNNHSrRLAi43YtZdu+UiKyxgPsrYof3qY/2M9HS6DTiNVtn7mSHbv6mcY2UGVNzCjsTl1hFeNKYKwW5LFPjGXEA3Vrhil8a3JsxBAR/NmBRymBNVCj1JkY3du0f5XW5olx9Z37Y+IfbjXllM4fUufzyBTZr0KpMXXxXKGJkCfugqb7pDgzS4kR8Jmxu4r3j0gI/XLF+dyB44fX+UlF+KXTRDZswFR0I/e14BTOKN2+Ryici4VYkkav+TG+6xKqnlORBQSmUPteIfZ85a8qQ6J/2j9/kfOuHvsGtF+egOL5nLgBNRpls1XwkxcsTAddQXhG2biNUYRKTWKeQDyWOEvoF+M0bZ3GVHv+kx+w6D+ywHYFuK8tTJ/kLLZ4uwSDdEzSyHkdcG3wUaB+Fg3Psn2i1eEv6Jl7mai5VwEoTY6Zdy28KIdGcLTCYGRiRoKU0FYt/zF8330LjXEwoMato6CHJ8LydrdIhmV34UALxZBN9p73Y+dzCI8jv+J8Krv4gNNvEUa0fRMMMYNkA4Lmn6H7Bq/yXU8lAVdNKeNZRS596XNdjtxAFTcyGgVaSG9tT6l2TV3ZksrBRc/V/3OJGQW8hApLB//cy4O0XAchPuse+YxE/B6jEpeerA8JeICdV8htguDUbwriOnVwC2ZevVx1jSMEmP4XKEbYAGNOVPjrr5Z7hbx820QqjSix6+KGgJ/SxjU5GE7MgtKEMiklXLCPyUFY73TCRhys6JiKu+rpGXIkyVzvNd7OnQtgqxop27QZSrzh8K0qFD0pTsGddMDMB72RYYj9TbN3OUmhn06RBJh5KbrHz+i5Q0gyuD8C2vh2J6CyiYSmma13OE6DI8OF3Udk30 kCKtWnzc xJEOzNVrNyUh62Hb2JQaMZXtrUKg9igNn1xTn4Jk0NvNrwEF7aEuFdhJ2ihUFaNnDl3Bk57xe9TQKIzCfDgl1IN4uJ+aBa2tfOLWvH5YB7rG/++wYr6nCAM9BlyTD9NOhzBCenITrMaLQHVMVJHzXHeeSFmPSAqUf1LrrxII7XRGhr0ZENUUhYWcEGmc8qxpkGPoEhv1H0CXmHerngKWnEpz+3BHT2fdy7mRP3Y3NVaJeLTvzjHBkiMeNi9y3aj6PtNabDkkoEzN6wVav0fv/a1eIfkFfvr1pyUBw52j7XHRbxM0MHcUN24/CWw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Just make sure the maple_node_cache has a percpu array of size 32. Will break with CONFIG_SLAB. --- lib/maple_tree.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/maple_tree.c b/lib/maple_tree.c index 4dd73cf936a6..1196d0a17f03 100644 --- a/lib/maple_tree.c +++ b/lib/maple_tree.c @@ -6180,9 +6180,16 @@ bool mas_nomem(struct ma_state *mas, gfp_t gfp) void __init maple_tree_init(void) { + int ret; + maple_node_cache = kmem_cache_create("maple_node", sizeof(struct maple_node), sizeof(struct maple_node), - SLAB_PANIC, NULL); + SLAB_PANIC | SLAB_NO_MERGE, NULL); + + ret = kmem_cache_setup_percpu_array(maple_node_cache, 32); + + if (ret) + pr_warn("error %d creating percpu_array for maple_node_cache\n", ret); } /**