From patchwork Tue Aug 8 09:53:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vlastimil Babka X-Patchwork-Id: 13345910 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8B65C04E69 for ; Tue, 8 Aug 2023 09:53:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08D7B6B0075; Tue, 8 Aug 2023 05:53:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1B3E8D0005; Tue, 8 Aug 2023 05:53:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC4366B007D; Tue, 8 Aug 2023 05:53:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7E8B16B0075 for ; Tue, 8 Aug 2023 05:53:56 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4F795120ACE for ; Tue, 8 Aug 2023 09:53:56 +0000 (UTC) X-FDA: 81100476072.07.37D44DA Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf18.hostedemail.com (Postfix) with ESMTP id 07C6F1C001A for ; Tue, 8 Aug 2023 09:53:53 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JuHIK5yA; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8lR8OBOO; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691488434; a=rsa-sha256; cv=none; b=IGJuG1Obub46w+vqya7LBtqHrEDTfy/C4Qc7W+4TJHZXQH7HOxYgSR/f9/NIdUyLytFubE vSjASDfFatCWA3/M6TreolbyhsZpFrlVnNHfQERLV6RElmOhDbnKnrTUH2SjVH+XSRbOXH Pdd/5TbYoTH9GJh0EIEAUoIWufsgyL0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JuHIK5yA; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8lR8OBOO; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691488434; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X+E0unmCYoA/5q96uLhFby2/QU/JbMexzKmCXmErmbw=; b=M4ZMqyY+wlskAgH1sDiJd2qnnUsgxMab3FbbB8E3Z+Ae838WyXMiZHos1YdwrtPRzTxmD2 wSO8eWwpP2mcKTP5VPYUnLg2Draf9xI6UNsRXN/LRRMnSfTENh5Ktjx3bJ1QnVk/08Xucn nzgrRTq8zwSz8PxzQ0v66EsircNH584= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BB09221C21; Tue, 8 Aug 2023 09:53:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1691488432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X+E0unmCYoA/5q96uLhFby2/QU/JbMexzKmCXmErmbw=; b=JuHIK5yA07vWudODvORFefuFMGecT3WRUyFcG8HubBRT64OpJEFUdDEl52fFQ6gz4H90kv ISXwJNf7MbV3Wd1UHDOlLh6ux3vyjmJtY8aOpXZlfV2j0fAloFWTumEgSdimGKJIpjMF0J glyqRd0MduDW1F5GfTB24ayFXh4xtUo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1691488432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X+E0unmCYoA/5q96uLhFby2/QU/JbMexzKmCXmErmbw=; b=8lR8OBOOUrNsZP5iXkEKBSPRcGaYP8iGo6k7WS/5Qv5TNNAqaGgIxraAPd11BDjhyHllGM Q5rHU4gmYa6PUnDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8F110139E9; Tue, 8 Aug 2023 09:53:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +FJRIrAQ0mSBJQAAMHmgww (envelope-from ); Tue, 08 Aug 2023 09:53:52 +0000 From: Vlastimil Babka To: "Liam R. Howlett" , Matthew Wilcox , Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Vlastimil Babka Subject: [RFC v1 1/5] mm, slub: fix bulk alloc and free stats Date: Tue, 8 Aug 2023 11:53:44 +0200 Message-ID: <20230808095342.12637-8-vbabka@suse.cz> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230808095342.12637-7-vbabka@suse.cz> References: <20230808095342.12637-7-vbabka@suse.cz> MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 07C6F1C001A X-Stat-Signature: d3xicf1p4ww6nd58434yu9sqpq4uuejo X-Rspam-User: X-HE-Tag: 1691488433-520290 X-HE-Meta: U2FsdGVkX18ooh1cIkUz38q6q0xqYFAynK9NzfmNdbim3Lb2Jt+isQ3Bm6RgMgzh2BJMjK8z3LVZm2cGI3iYzbMEzj1cL58/LZJNFjjnDQSmIQTuBVGhtXNcJoIsONGPsvRJK9RxyOFvWD3gh5RX9KfMi5GppWpGiiPFKe1BOZWWtJEvmO0fIojgeLF5cR6RLC51Gq+EBV+r2jd+0r+F8ObsMPrrW5stfJ4G7g7ks+1nZxenXWHV1cRgc/JkeZmN+RKcH3UNqiZmzelm303Y6kJOP38diGtn6zghVh/AY5zcG1bfoA6GRV043iGavL+kGbDohWyjRSD8yd+ZJQKajzpdgbb8+KXymlzFzo8Tz7tIawM8KRCAM3/2CJQkq+dg8yWP3tG3ln6TLhjLRuBho5eNLjPl7uuYUQVacdeUnoXchPPw47bjEnImjjThsgKYNoNnJb36uecgf7PSE8iaiqSmx7J977bLe3GoywcFMNp8NYUNnq/B5hoP231ydAtCRVbDhgptkXJhRDstxmJlmyiT7rgQcpP8HCoqTlhPHVcWNqHfnmVCRy0XFZjcW+Hv7AdkfU75eY+Ie0hf1gtvSC7BdI6qfUFvwahkEA7W8vSVrqI35ot0HAoLXjObTBdUb8WzgkuCOUpKSDShEdrmqMRj9uz5HWXiEhasZJVAbb81GQi/PfhsaFJFau63zbZLxwdxU/huUac2BNCJQ4R47+PtuSPNTMe/hqBTr8oRpHWFlVmmrtVSiyCvbqt1iS/TJ6JINcKMXF62glewEHmotK8FHMJCayKw2sgJnBt9WKWxyZobzD6BR+I1X3XEIenYQnjB+zdFTPdCqeIHeMWLmA0D/d2n/vuhcU1sMpbDy3oBjBJE7RZcH/Xh16hR5e0RYFs7tt0EJTMb+q/lbLCBn9mHGsyGfDGiTZb9WRQWB4LvSnjUXLdqMyOgNAKSWvLQMyopobrjny8cekM7PUt Pjc0p8sZ fd0q+73vw1ucZShxWZMzcOvja5yevmgwFazs/2z7Nzc/+VueTW+BvKv1xsnQ8/iAquPUObGJC5+5yrXVuO0Bpma+ZJ304zEMUPV9C6FBkAsIUeibOG/0cmoh9p8HYg+NhroEzlgPC9YK0uCXf2vJeP6WYkAXfZiPJQvZHfIvIo8dXClUIylgNzAk8lAfsJoagTpdTDooWZAgliC9FFN58sQ7CGZEKzN87bIqqDEK5naGw+ixemCyvkkH25kgdjGmJHYQ1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The SLUB sysfs stats enabled CONFIG_SLUB_STATS have two deficiencies identified wrt bulk alloc/free operations: - Bulk allocations from cpu freelist are not counted. Add the ALLOC_FASTPATH counter there. - Bulk fastpath freeing will count a list of multiple objects with a single FREE_FASTPATH inc. Add a stat_add() variant to count them all. Signed-off-by: Vlastimil Babka --- mm/slub.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/mm/slub.c b/mm/slub.c index e3b5d5c0eb3a..a9437d48840c 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -341,6 +341,14 @@ static inline void stat(const struct kmem_cache *s, enum stat_item si) #endif } +static inline void stat_add(const struct kmem_cache *s, enum stat_item si, int v) +{ +#ifdef CONFIG_SLUB_STATS + raw_cpu_add(s->cpu_slab->stat[si], v); +#endif +} + + /* * Tracks for which NUMA nodes we have kmem_cache_nodes allocated. * Corresponds to node_state[N_NORMAL_MEMORY], but can temporarily @@ -3776,7 +3784,7 @@ static __always_inline void do_slab_free(struct kmem_cache *s, local_unlock(&s->cpu_slab->lock); } - stat(s, FREE_FASTPATH); + stat_add(s, FREE_FASTPATH, cnt); } #else /* CONFIG_SLUB_TINY */ static void do_slab_free(struct kmem_cache *s, @@ -3978,6 +3986,7 @@ static inline int __kmem_cache_alloc_bulk(struct kmem_cache *s, gfp_t flags, c->freelist = get_freepointer(s, object); p[i] = object; maybe_wipe_obj_freeptr(s, p[i]); + stat(s, ALLOC_FASTPATH); } c->tid = next_tid(c->tid); local_unlock_irqrestore(&s->cpu_slab->lock, irqflags);