From patchwork Mon Aug 14 18:44:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Xu X-Patchwork-Id: 13353180 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 063CAC001DB for ; Mon, 14 Aug 2023 18:44:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAE10900005; Mon, 14 Aug 2023 14:44:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0FB3900003; Mon, 14 Aug 2023 14:44:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9616D900005; Mon, 14 Aug 2023 14:44:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 77FA6900003 for ; Mon, 14 Aug 2023 14:44:23 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 425D4A0C6B for ; Mon, 14 Aug 2023 18:44:23 +0000 (UTC) X-FDA: 81123585606.10.365E2D3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id DDE0C14000A for ; Mon, 14 Aug 2023 18:44:20 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=e7XN054Q; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692038660; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FNQlVHJQ4pIimjZoX+ixCZ4sXgWXT3PPMnETr4dtlP8=; b=2dWpXeuYaFAgkRWWsUdGrezfAuNh0P1mSpdNjMv2urPAE1j2e+mbMhmQZ4vpfFta/3WM1m 9Q7IREJZSv0R9Rsb0i7xgjJgMiQuWq4FSymRY3IZmdl4Y/c9IA4n+sMOGXHFu4DqJYQ0Uo JEwpzyX2zSMWdsjz7+BOmyBQbLNwzDA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=e7XN054Q; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692038660; a=rsa-sha256; cv=none; b=asrWvEUl7fRUaKHVpxpksJaowTwB2iEtQ56bls6bR2Pk86Et2l48xU+FxpJ0KyZjQxY4Vn QCoH4F9SLI2eR6N5THpnMW7O6te02LDnW1NSTzpbyAsAz5iSmkQRqj4jjymRUIxR4m7loP v4fkpRwA0C+iBC/GOaFs3ktdD3N3KZ0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692038660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FNQlVHJQ4pIimjZoX+ixCZ4sXgWXT3PPMnETr4dtlP8=; b=e7XN054QmRLQr/cKA+MUKQLb/QKlF/HQdNlvqgaWf/0LaKP4XrPRyWZTARCl2ujXdliwJQ lDLEGI9yQxSqblIe3ev+POVggLfTBnip1ZZ+KUTyEd4kzbOigprd33uRbBLQmumn/9GsDz akcNCVAsMrkD7i2RkjuuYe0lLtWHuUY= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-654--aboGh27NwuGXFGSi5dvNg-1; Mon, 14 Aug 2023 14:44:17 -0400 X-MC-Unique: -aboGh27NwuGXFGSi5dvNg-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-63c9463c116so13418416d6.0 for ; Mon, 14 Aug 2023 11:44:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692038656; x=1692643456; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FNQlVHJQ4pIimjZoX+ixCZ4sXgWXT3PPMnETr4dtlP8=; b=T2d2nwg4lefjJD4YNxuTElZ4xOjEYpROqB3ECld77uXeaG5TTp8w8DxbHq/N9e5UjC 7e3WCEU8/f5u0n4/6FXpDJylA8VA4Vl3beq3jsuKz9QrCc965tW32PvEthF/D7IPPSNV /6eYUYQ2mvXmUpRhSsNrKIzBmoJ7KOkUqxITr92OlRGBe2v4fOm68GX98lkG6zswTYkC 7yWrwE0hY9ybjQ56sjxfD/IR7MGF7sDw8joo26onL7txYTBuirKH9aij2F4v6mTc5aCX 0ocEnP4+pIDIZ7W50FegdwDsiMa0lLj3M3/WYCMG3aCZaw+/RdX2WvsMN+s6K0XrkkNn ktng== X-Gm-Message-State: AOJu0YyuSlP2z/vJV+K6jvS9FbOOopyUc/CR57sRChp+GXazlZoUYdV+ CWXqgt2Q5rOBLxetlLVxgqlKV6z4o+mpM0iR3PthoN2RmAfm5sXdVkQXKzXpXYpvwLeNaeFICgw OWqowYLDygAhDVCCTYz2ngO8WRZsXn6Somnp65w0wNJ0B2YDPflBuofGEWUCKJViajBRP X-Received: by 2002:a05:6214:1d09:b0:635:d9d0:cccf with SMTP id e9-20020a0562141d0900b00635d9d0cccfmr14721975qvd.4.1692038656457; Mon, 14 Aug 2023 11:44:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHg5lNOTyDZrEVxNjNHMJ72ccEGFwymh3Zpf7FNl3V4lRHNSY8M7kb1dQ3rnyfSzoGymgcKPg== X-Received: by 2002:a05:6214:1d09:b0:635:d9d0:cccf with SMTP id e9-20020a0562141d0900b00635d9d0cccfmr14721945qvd.4.1692038656034; Mon, 14 Aug 2023 11:44:16 -0700 (PDT) Received: from x1n.redhat.com (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id a7-20020a0cb347000000b00630c0ed6339sm3566561qvf.64.2023.08.14.11.44.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Aug 2023 11:44:15 -0700 (PDT) From: Peter Xu To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Mike Kravetz , David Hildenbrand , Matthew Wilcox , Andrew Morton , peterx@redhat.com, Yu Zhao , Ryan Roberts , Yang Shi , Hugh Dickins , "Kirill A . Shutemov" Subject: [PATCH RFC v2 2/3] mm: Reorg and declare free spaces in struct folio tails Date: Mon, 14 Aug 2023 14:44:10 -0400 Message-ID: <20230814184411.330496-3-peterx@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230814184411.330496-1-peterx@redhat.com> References: <20230814184411.330496-1-peterx@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Rspam-User: X-Stat-Signature: xmt4jdmazh7un19334t8ttichsn37hfq X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DDE0C14000A X-HE-Tag: 1692038660-866198 X-HE-Meta: U2FsdGVkX1/v9c4WIcq1/c/1IlkIupumNpcZw1YeQ1+fkeZCUJzuWg+kxpudaK2V9QZMskFfS3dFhwONKCYVrOyRer63J81zWNX7P//OOlbhhJH3f/4mQED+FPYf6VQeHfNkk01Jh+g9mdraxlqhtv83GFNN8Q5CPXKo+mn1TmY7GyKRAK591087UeGxWvsqz1rPB4iJtzlAhqqklvhAwndKPz7IcQbyryrkGFIJMvoblJ/xx2I/fEye6f2A4rQvlEZe4jNnqDdlONG/KfKc+HpqdXbAlN42EDI9Ij/g2laMo3HKPMun1DTZq5tmBvfyMHYU31IlhXIBTXOdXOQjHQN2vFNkQqmlvZSUZP4lDZhoiMtzNRXCoSE4Q1OTgjF2cvdfdd3ZKNgWT1385vBOaoLwdB4mNHbJ5rgXYC2FcNatIHub30Zi4qQjstOuIbKFhy3c8AAhcDJhWLhg6iw08Cm6wuhFOO6Opd0tGPOC6Kd3apkMtgOAeQW6zm929M77fsP6BIsLheT/9EK6R77CR/+Ai4UuktIM6yc9u93NsLdS66N6nhNyw4+aoWF4CAG8ig9c+eOBiovIVX7R2kZ9tVfEIW9kXdJScC04Chpq9SSRI0DX+C5P+m7sl2wXUFoMeCL/DAUDONW/wJAfA0urKf9cVR37hdJEf1x01QGmv9YiS0KW1AKfLvFhyA9e6G60be2aHP4dU9TUC/B9S6O+tbew4AMQhPHG4X+JAhlRluYdXDTxhzl8e61qirRKFzfdevXe/mLI9hLTBdlGDSjvcXSTprN7NpMgcZQnyYqeIfUlOmW3oa6WYTv35qHbgJeP4vjMvWUtqHxo0Vi44tTOzPAyak48WccX6RO6QrkknB257lYSkKeJnNqssb5cgukSiqddnYk7IOOZi64lumnlro3ihe2zYL8BWSQLUUZyflwUHkVuLd+IbncQz1r0vIA04/pUuHK7x0dPGPhnHLF BvEy028p MDCTAXrokFXkqNHwUL8e/eVN88zYeDlFb3Vz8nAXZgsiN2bSSQAB5aUJ0Iec2Q28bBIys5BtLJpHGGgIZxR1CWmvUBTy2jbx++nH9zKrMOxqy4X/DGRwaUUKCL7JactvvVhZ/NEI/gWMBVOqGf8RZzovJD/8ZFd7I3HZIPPyvjJlKAfwL3T6dfUyUqcXuUTWIVSA2hl2ZXOw6/7W/9IH0whDLjxEltHjDoaMtmcT/WsaoJffTKDAmBmTLOdtIFJ6W0qZWRbbepOGC9q0TkvUuHM5lz6rjkNCmrZxx3EuT7t94CgUoHXt3xSRgqmQNRJA2wbyqYs27Zu7aswEXtZbZKTlsqa+zbyKU9ufZRDvOAvgUWt7P8Mbam5+cj5O4M8Qtrgfgy+MeoXUjL7s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It's not 100% clear on what are the free spaces in the folio tail pages. Currently we defined fields for only tail pages 1-2 but they're not really fully occupied. Add the fields to show what is free, and also reorg them a bit to make 32/64 bits alignment easy. Here _free_1_0 should be a constant hole (of 2 bytes) on any system, make them explicit so people know they can be reused at any time. _free_1_1 is special and need some attention: this will shift tail page 1's fields starting from _entire_mapcount to be 4 bytes later. I don't expect this change much on real performance - if it will it might be good to have _entire_mapcount and _nr_pages_mapped to be put on the same 8B alignment, assuming that _pincount should be rarer to be used in real life. But in all cases the movement shouldn't change much on x86 or anything that has 64B cachelines. This is the major reason why I had this change separate from the upcoming documentation update patch - it may need some attention, and when unwanted things happen (I don't expect) we quickly know what's wrong. _free_1_2 / _free_2_1 just calls out extra free spaces elsewhere and shouldn't affect a thing just like _free_1_0. Signed-off-by: Peter Xu --- include/linux/mm_types.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index 3f2b0d46f5d6..829f5adfded1 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -329,11 +329,21 @@ struct folio { /* public: */ unsigned char _folio_dtor; unsigned char _folio_order; + /* private: 2 bytes can be reused later */ + unsigned char _free_1_0[2]; +#ifdef CONFIG_64BIT + /* 4 bytes can be reused later (64 bits only) */ + unsigned char _free_1_1[4]; +#endif + /* public: */ atomic_t _entire_mapcount; atomic_t _nr_pages_mapped; atomic_t _pincount; #ifdef CONFIG_64BIT unsigned int _folio_nr_pages; + /* private: 4 bytes can be reused later (64 bits only) */ + unsigned char _free_1_2[4]; + /* public: */ #endif /* private: the union with struct page is transitional */ }; @@ -355,6 +365,8 @@ struct folio { unsigned long _head_2a; /* public: */ struct list_head _deferred_list; + /* private: 8 more free bytes for either 32/64 bits */ + unsigned char _free_2_1[8]; /* private: the union with struct page is transitional */ }; struct page __page_2;