From patchwork Tue Aug 22 01:54:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 13360079 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0554CEE4996 for ; Tue, 22 Aug 2023 01:55:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78C3B940024; Mon, 21 Aug 2023 21:55:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F2C594001D; Mon, 21 Aug 2023 21:55:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47CF0940024; Mon, 21 Aug 2023 21:55:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 303D494001D for ; Mon, 21 Aug 2023 21:55:30 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1481616013E for ; Tue, 22 Aug 2023 01:55:30 +0000 (UTC) X-FDA: 81150073620.25.12E7836 Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by imf24.hostedemail.com (Postfix) with ESMTP id 48C0818001A for ; Tue, 22 Aug 2023 01:55:27 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=BVxKaBwC; dmarc=none; spf=pass (imf24.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.166.42 as permitted sender) smtp.mailfrom=joel@joelfernandes.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692669327; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FD9aGvqokkyzhhNkz6Ym1Row+eZXw3mkXyW6dIKtxjg=; b=bvIhhVq0fWjs7VlqkyGrLQG7vhj/nZHtvXGhzKielo80iakUtTcRvwIihwiadCh6Cgqhm2 dsEOdrhJX4fyJW04NnadwoeTrF7THkHk7smjJPcrHlJYbAC25X8gjglnCV8qWQG/1rsXjT X6+8Xqh0Wt6ePOT0UddSsiyTphnCfQc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=BVxKaBwC; dmarc=none; spf=pass (imf24.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.166.42 as permitted sender) smtp.mailfrom=joel@joelfernandes.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692669327; a=rsa-sha256; cv=none; b=RsMTOXCQP1igbsb29GeamzS8iAhIfiaJLft+NbZNY4YCDPC/q034N89u6YDQvBqXqRsSWS WlZDoUn2H0MA719NGsk7ENqNRO12s4knb+7JufBZRS4tag3Ki8d2ugAfG1rZgAB5xseGWn cEEb5i95lc9pKlDjCTy00hwSReBIDZY= Received: by mail-io1-f42.google.com with SMTP id ca18e2360f4ac-79244dd2e49so15853839f.1 for ; Mon, 21 Aug 2023 18:55:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1692669326; x=1693274126; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FD9aGvqokkyzhhNkz6Ym1Row+eZXw3mkXyW6dIKtxjg=; b=BVxKaBwCWqmv9ynuQE7s7YtVK38FkX779KlBkPDkQBjoFlq8GAIqxdpbPgdXIHuYEP sTZl8JURdoNTsMC+vviGXqt9EnyyK4mtdmmYuLB06JdlbsUAxre1uPUPQ9095aYWBBzQ UX41cyoBUmNRAXgSpAygarUMAnDMlAVDQL8Lk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692669326; x=1693274126; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FD9aGvqokkyzhhNkz6Ym1Row+eZXw3mkXyW6dIKtxjg=; b=VcwfjAcpugz2QgQG6gNTgjg1vS/HOhQmoYwaVO2yLsXq0YMgNqUMhRESXj1YL7byNF 581VH0odAfbtwYzq3RxZl3rj2hjfTG5n8OeT/iIDwnyWXyyWReIRiUH8Qe0gs7VwdaOA YwJyoM59U3f4idj4gLkilzahTKXWalE778llXVV+0AvDbnvim9qdKgOUzpwszcSwX2OW 9kdbukJ0eBU8TJjEU1IGrSxcGxmCbpf2xxfnK84i9qbAIk+E/8ZgPgVWb6puHn06AJ+g IDiszptXCTaERyQRc8RUu14OPRB+hKFcK7x3zxVPRY6llRL1TRZ8HMav+p7xSuB1ZqVx o2mQ== X-Gm-Message-State: AOJu0YxXEntCf/AKaLeyFNgNyodnYCDL8yWXVUBjMKlWAzJ7pXTJ70k5 vw8/mV9bwfYUXKU7m9WvBDRphQ== X-Google-Smtp-Source: AGHT+IHvcEbCoDqCw1Fy8RgEWPuit/xENlfoh2EHuYOQYRSjxZ82L50BdV84tK7DyIjYWJTuRfLE/Q== X-Received: by 2002:a05:6e02:190d:b0:346:1185:31d0 with SMTP id w13-20020a056e02190d00b00346118531d0mr11455463ilu.9.1692669326463; Mon, 21 Aug 2023 18:55:26 -0700 (PDT) Received: from joelboxx5.c.googlers.com.com (156.190.123.34.bc.googleusercontent.com. [34.123.190.156]) by smtp.gmail.com with ESMTPSA id q11-20020a92d40b000000b0034886587bdcsm2907390ilm.18.2023.08.21.18.55.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Aug 2023 18:55:25 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Shuah Khan , Vlastimil Babka , Michal Hocko , Linus Torvalds , Lorenzo Stoakes , Kirill A Shutemov , "Liam R. Howlett" , "Paul E. McKenney" , Suren Baghdasaryan , Kalesh Singh , Lokesh Gidra Subject: [PATCH v5 6/7] selftests: mm: Add a test for remapping within a range Date: Tue, 22 Aug 2023 01:54:59 +0000 Message-ID: <20230822015501.791637-7-joel@joelfernandes.org> X-Mailer: git-send-email 2.42.0.rc1.204.g551eb34607-goog In-Reply-To: <20230822015501.791637-1-joel@joelfernandes.org> References: <20230822015501.791637-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 48C0818001A X-Stat-Signature: r5m7ziys1wdc6kdoofbgnmdkabnbtur3 X-Rspam-User: X-HE-Tag: 1692669327-531759 X-HE-Meta: U2FsdGVkX19zP/y/+jcON7RVhvZJkf1wcaKlxAhItf87jAZ7FQ2vee1GWRxaZqxwFAaD5tfxUYpr8knnVwhiFGQGGz6WfA9cq2+Ux7hAxllgG8Hy9wMC1cTpc+e2g7Jgr7/yXr6zI3arNYOFedOP+pNJ4hRQXWOhwRXPcBeK/Tj/yqIPE31xZsSvNvqEo0XxV08Tz1qWpAx9fsX34SnukSkwzo0P2ibWJIzrr4QO13woQQgyejo/yVBCREZ4NZy+WO0AwaypR8YCQpHwnDZawHT7pS3BDbdhq/9eGFAsvE4KvWsaqKiP3wcNMgAMBa9TNEoZXL5r9BrWL5jS8/n6moPJ9cAmjkC7LqUaDPwt0/Ii7Gi9D5QvxcBp89hgM/CeKomu4b0Y7VKHBqQO0OlM5sPL9GwJFJiL2dXu4kuBBEf/tHLDv/7iazf36zAVXZfom9vha85CplizcGSNc8wRlLPYFHDM9tBfGHlcna+8nJ1/z2xPUOhmj+hOrwrcnG4WyPWTKIyT7RLnzfJlPymyABm/zwBd6nYcNGVPPv15OgfQiKFSBgXMU/YeuK1r4MvIQPrC5Ll+qzzdVVTVqC98Ev0MThul4SkA2DiFPvLw/4EmNVKU357oEj8LYdKEyt3y85tmVRu2xDtzSFnxzx006a1RT4sNijGEy2tDRxF8sp6rngrzH3VmozbIAh6IeUpTbDwzQXL/ogjBqeN31D3VjsM075fk9y6YEKXmCOVE9xPkBBnvJPrOPx6/M5mM7g3/tuoNdhPXUOSMSKdHAW7RmoZXVdNhkWRtI/C5Ul+yMoya8lkywDOSz9cb97Iake49IrCN6EGqOjoxyMMBo8ECq/HUcIC/0CBeZ1on1vT7yi+t/MOAquAYHe6u1a7jdhP9eXYV8wwVgc1XSy3qFIPC9QLjs97ORmLojR1j3Oz26+C/7JK36hlvvQ8KPlYP2JAPP1WtzCTpzo74SiCImLZ r6NpnomA nGjW0ky8nk0hU86Ioy44yrO4/1dd+CGAo81a68OGT6sBZqxfi9x55dqLqh/LPeN0qEhmJFbH5lvfTeiJNmGvyp8ISe8XZ9ec+YBqAft0rMz+gmZ5TSeRruvw0lGEIlFJi9LUwwu+8DQR6CygSQwj4+r90KbAEU7+JKfqkakUW2+GbhQdg+qZH/f8UXUn54EJJA6+uV0rXbKfUfq/Aw6MSkEf0V5XsRSFLwvZ52fI5Gy9NG1da9RFzKUO48SZb0VNAbuq+kgYboQ4Dg1OHkWRdqpNSiDDRIijks+EkQEzdk8NkXUL1EJD3OAhoggqLTJJYhSxYzEvrQxLvI30cICXJdo9W5zu6KDjf1BAuAJbWxIg9PWzGHf0yNxdtsS0Yoa1PK0EPzaqVIPL6L6hCEJVB5uaiuGxPs2tAwP83mUzWZlh3XLMOrozthz431UBM5JSfhAj5nZcRCapqrw/kvJ5QQWTgfw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Move a block of memory within a memory range. Any alignment optimization on the source address may cause corruption. Verify using kselftest that it works. I have also verified with tracing that such optimization does not happen due to this check in can_align_down(): if (!for_stack && vma->vm_start <= addr_masked) return false; Signed-off-by: Joel Fernandes (Google) Reviewed-by: Lorenzo Stoakes --- tools/testing/selftests/mm/mremap_test.c | 79 +++++++++++++++++++++++- 1 file changed, 78 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/mremap_test.c b/tools/testing/selftests/mm/mremap_test.c index d7366074e2a8..f45d1abedc9c 100644 --- a/tools/testing/selftests/mm/mremap_test.c +++ b/tools/testing/selftests/mm/mremap_test.c @@ -23,6 +23,7 @@ #define VALIDATION_NO_THRESHOLD 0 /* Verify the entire region */ #define MIN(X, Y) ((X) < (Y) ? (X) : (Y)) +#define SIZE_MB(m) ((size_t)m * (1024 * 1024)) struct config { unsigned long long src_alignment; @@ -226,6 +227,79 @@ static void mremap_expand_merge_offset(FILE *maps_fp, unsigned long page_size) ksft_test_result_fail("%s\n", test_name); } +/* + * Verify that an mremap within a range does not cause corruption + * of unrelated part of range. + * + * Consider the following range which is 2MB aligned and is + * a part of a larger 10MB range which is not shown. Each + * character is 256KB below making the source and destination + * 2MB each. The lower case letters are moved (s to d) and the + * upper case letters are not moved. The below test verifies + * that the upper case S letters are not corrupted by the + * adjacent mremap. + * + * |DDDDddddSSSSssss| + */ +static void mremap_move_within_range(char pattern_seed) +{ + char *test_name = "mremap mremap move within range"; + void *src, *dest; + int i, success = 1; + + size_t size = SIZE_MB(20); + void *ptr = mmap(NULL, size, PROT_READ | PROT_WRITE, + MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); + if (ptr == MAP_FAILED) { + perror("mmap"); + success = 0; + goto out; + } + memset(ptr, 0, size); + + src = ptr + SIZE_MB(6); + src = (void *)((unsigned long)src & ~(SIZE_MB(2) - 1)); + + /* Set byte pattern for source block. */ + srand(pattern_seed); + for (i = 0; i < SIZE_MB(2); i++) { + ((char *)src)[i] = (char) rand(); + } + + dest = src - SIZE_MB(2); + + void *new_ptr = mremap(src + SIZE_MB(1), SIZE_MB(1), SIZE_MB(1), + MREMAP_MAYMOVE | MREMAP_FIXED, dest + SIZE_MB(1)); + if (new_ptr == MAP_FAILED) { + perror("mremap"); + success = 0; + goto out; + } + + /* Verify byte pattern after remapping */ + srand(pattern_seed); + for (i = 0; i < SIZE_MB(1); i++) { + char c = (char) rand(); + + if (((char *)src)[i] != c) { + ksft_print_msg("Data at src at %d got corrupted due to unrelated mremap\n", + i); + ksft_print_msg("Expected: %#x\t Got: %#x\n", c & 0xff, + ((char *) src)[i] & 0xff); + success = 0; + } + } + +out: + if (munmap(ptr, size) == -1) + perror("munmap"); + + if (success) + ksft_test_result_pass("%s\n", test_name); + else + ksft_test_result_fail("%s\n", test_name); +} + /* * Returns the start address of the mapping on success, else returns * NULL on failure. @@ -491,6 +565,7 @@ int main(int argc, char **argv) unsigned int threshold_mb = VALIDATION_DEFAULT_THRESHOLD; unsigned int pattern_seed; int num_expand_tests = 2; + int num_misc_tests = 1; struct test test_cases[MAX_TEST] = {}; struct test perf_test_cases[MAX_PERF_TEST]; int page_size; @@ -572,7 +647,7 @@ int main(int argc, char **argv) (threshold_mb * _1MB >= _1GB); ksft_set_plan(ARRAY_SIZE(test_cases) + (run_perf_tests ? - ARRAY_SIZE(perf_test_cases) : 0) + num_expand_tests); + ARRAY_SIZE(perf_test_cases) : 0) + num_expand_tests + num_misc_tests); for (i = 0; i < ARRAY_SIZE(test_cases); i++) run_mremap_test_case(test_cases[i], &failures, threshold_mb, @@ -590,6 +665,8 @@ int main(int argc, char **argv) fclose(maps_fp); + mremap_move_within_range(pattern_seed); + if (run_perf_tests) { ksft_print_msg("\n%s\n", "mremap HAVE_MOVE_PMD/PUD optimization time comparison for 1GB region:");