Message ID | 20230824034304.37411-5-zhengqi.arch@bytedance.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A8BAC3DA6F for <linux-mm@archiver.kernel.org>; Thu, 24 Aug 2023 03:44:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE876280071; Wed, 23 Aug 2023 23:44:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D98CB8E0011; Wed, 23 Aug 2023 23:44:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C39C7280071; Wed, 23 Aug 2023 23:44:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B2CDE8E0011 for <linux-mm@kvack.org>; Wed, 23 Aug 2023 23:44:23 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 92C07C0145 for <linux-mm@kvack.org>; Thu, 24 Aug 2023 03:44:23 +0000 (UTC) X-FDA: 81157605606.28.31DC0C3 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf24.hostedemail.com (Postfix) with ESMTP id C462B180012 for <linux-mm@kvack.org>; Thu, 24 Aug 2023 03:44:21 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=F7mx7Z2S; spf=pass (imf24.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692848661; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hCA0ApwXV5FyQtvOpmWRZ9XMHHHCgvXZoPv/VlrFSS0=; b=iKFCQuC6rvhDz+4J4ZRz+5k//Ugm3cNSHikZ8eTe9hSRcgRmnZkmrHK5E2zw3jMmmrnPYr J4DZAuPVPl6unbKx1QTnAnzS2D0X69vjyc9ytV8tmA/RO386n3n74Zs6yWtTxGQU6UCoUk Pg7MZTdNxQlu/wR9vw1dMlAWiRBECzs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692848661; a=rsa-sha256; cv=none; b=2v0hRDr8SdGNywpH8KV8aTUPkWmN2l7z2605JQUSuqaEhsqqwIZOAakoOdzKr5v3EIRNQ+ DatLab7xu1dR4GmcSe3TxI5Z32PfHvTqpB+2LKUg+GDJ1Tfy4kUicMSZbK7Jpscj3El/VH T5yhTjpgEUlGOvnglBte34rIpK6tPqg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=F7mx7Z2S; spf=pass (imf24.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-68a56ed12c0so755701b3a.0 for <linux-mm@kvack.org>; Wed, 23 Aug 2023 20:44:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1692848661; x=1693453461; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hCA0ApwXV5FyQtvOpmWRZ9XMHHHCgvXZoPv/VlrFSS0=; b=F7mx7Z2SATT/Tw8oqVu7LGCwIgOY9q6nNnmh5/ganhwLW8GaQrL8dhMzkQme16OyB1 4ZcrhSW1iVS/oXJkAxqcqvYnRC8V6z5f0tnKQYSO6HG2Ws1pP37Xuc1otxDqi5KUNw9T WVRuI/U+MbwSKZhcaJBbRNgA7W3KFvvzyeKOBXeWATvONSpA9TS02B13yxyrYGxzzveW u5fhQzEptjlMGS36OjAsEf17/AFamZ+U3xOMpKlF84KqegOgtZie0MuXeEOyLRhKQDjM 0P+76n+lplLjw7rWWL6ybRhAGOOQQQlRJmwWoHvL9CcCs2DRS/s36iNm5swp9kdFbKCI NE2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692848661; x=1693453461; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hCA0ApwXV5FyQtvOpmWRZ9XMHHHCgvXZoPv/VlrFSS0=; b=FEN6BWzPLnRkLGNe/ochbTzxx09D4F+TRjb1Lxihr5Cf+MsuPfa2t9oplTLNTEOYRe 6XcYjZqNnHI9rJHKWkMH5og2fLzp3mTmf35YV+A+tpdrjPvfAOaqt2Ss5sC4XC9Dh0BQ nxOUh59rv4E2M6JAlT1XyS+tIe5AipLjfc3TpOKGJQWhzjJ/akrNUo1bq1LoQIPEeJNC zls/+6xu8ZL/WnNR6h7uP3vY4afo50kuwBfd0UbCk2cUK9ZCZUa8Zj4Ivh7hiYj5O4Kp cuygFoo+SUueLAkd8tzNr1qrs4+/G7wR312n+7O7L08TfaMHMsA6zDs3lxonAZDJRw12 3XgA== X-Gm-Message-State: AOJu0Ywa15wv3rpbBDdk4uLbMsTTBeBcOprKXU3Rvrs/gkz+co1FK9Ie p7xY384VtTprtDBN+hVbOlx3ZA== X-Google-Smtp-Source: AGHT+IGMOB5tWYNyEDyo5eiTNUNcN0ymONSI8d47WEA6VQz24qAk45RADJx4EG80WGrowCiJNhDryQ== X-Received: by 2002:a05:6a20:3941:b0:137:4fd0:e2e6 with SMTP id r1-20020a056a20394100b001374fd0e2e6mr17386821pzg.6.1692848660762; Wed, 23 Aug 2023 20:44:20 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id t6-20020a63b246000000b005579f12a238sm10533157pgo.86.2023.08.23.20.44.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Aug 2023 20:44:20 -0700 (PDT) From: Qi Zheng <zhengqi.arch@bytedance.com> To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Qi Zheng <zhengqi.arch@bytedance.com>, Muchun Song <songmuchun@bytedance.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, Christian Koenig <christian.koenig@amd.com>, Huang Rui <ray.huang@amd.com>, David Airlie <airlied@gmail.com>, dri-devel@lists.freedesktop.org Subject: [PATCH v5 04/45] drm/ttm: dynamically allocate the drm-ttm_pool shrinker Date: Thu, 24 Aug 2023 11:42:23 +0800 Message-Id: <20230824034304.37411-5-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230824034304.37411-1-zhengqi.arch@bytedance.com> References: <20230824034304.37411-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: fy89jtojqp63udk1wgtj1eqrejx3u5ia X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C462B180012 X-Rspam-User: X-HE-Tag: 1692848661-584331 X-HE-Meta: U2FsdGVkX1+VqxB83xvIH6+jTzcuxdvSo66a7rvczcaYVVrtr+y25/JVT3WkfG95XCwgPEC6uBVFhcUauYPMnh2h08JkPxqJ5Ow2QbAoeXQ91nhkANO23p+kgMRD57bHvQHpvW9gdfQJURF+KJuVyGeHt+F95nt4NgoL5vfGvQG/HcTre+dPq5cmG7sPAguMrCDyL6WKTTZWA26B0AZCuv2ENVNqk6/+zfAJYTEjhS8jh7A4AmMV+XkC7cg4WrlLgUkN39AIzSENWK8VoINKgwfpKnRbKVcPWBLYEuDeDfAVFkvlHzrkLsY+1klPr0wfCGbiMn0eJKyTz/lC90kIKSS8EK6Lsa8lgS3QYRcWsK3qzsg9cD8RIQAovUDdKfCqUaFeMc+KuAG/S7DeyXNI+Hppk4iR9mQPMUm6XrA5GxPZ8A3C/WkTfQCKX4YQfli7OuAADamZxvSxAahpXU8P492+PoKLUIkNceoTKkg42mXs5iTEaah9ebTYBJa6Ba6bRRt+pUQ2O7WxuNXrCnqaAyc2GLKhvNcctNNZbrbkbxLsR6TP6si1ehnU+q9BSfEvt5BH/d3p7iRF+qRv+0nY4MmDJha5IBkfeLFDiaYnzDkqeUKhE2DPzA5Udf9kHCHFLxDG02fpRqLUu1FPiZz2buy0/jM1iE2PFH9CTO20YpOk1GUzZYYpx2kdberR4eop/NG2nWlixZhGLMK+ZcgdWSx8aSCNYiy8iIQbd4SmfJpCQYHx69M1C9gjF5xusQCutrkqtYX7r2rAj4m/w70955dOZ/0gpO5IrQnAkPdz4mcDBzsomktJClF5e+ZetSSliHlVJuCXR0MjPujCdnt6NmFNNximdx9F8Plvp7aU40eXxbCGcEuRhE9S2qSHt0Ikh+1ZR3mPcLMq2ine+3H/XXOCFkDTSn8kUB0FXhiHMGzP7qjIuA3lrQTvuXgZ5iyspkm9+U9CkSfJYsF29Kf CWYOuUA7 sVQLO/+R6EqmrJOMOs/EFzDBkSYDcOGWumnYXS5HbS7jB5691lRdNbCWtf6gK1szEokR/Vm3YfEZpVjfZIKrZWiOycLjm8E0R37L7G00bAC4Pm8PC+pZC2kxfhmn0z/0xYlDMc1WRdIT+JX3IhuGtaVYYGYM3caOIfGNXUDTZ4nLZLeGNVfslCrUeRvsTMC4UNUscV5ogZAD+v0ReKF7csbmkhauU1Vt/mKmyTpJfhiI7lfe34hFlari/gljs+uZYauwIeFFu/EOcyiuTUOVas//jkP5qDiz/DOfpJGqwwWQ+jREP1em1AXr/jI7ysbRv8chERzXXV6DWB9QSax+7EalahPiBDZqvmPrBUXjpJI4mqIwDGNYJeY33TQCgXFnlPPINzmBwLWyfwdAyRqknsEg25gy2ELi6zetqMSyDTbnuchM1XRZ4jbeI/GNhCt90ongqrpxuucu7KSnkzaSfVxvaXvdGELJLjFAUkP0eBJzDuyJoPA5gAMbtlR8dx/FRdEY1i+7mqD7dIAZJy7VlmediedE1B8nfYggw/S9+DmChxGwJVK2vy+k2rrpOpmjoGHP/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> |
Series |
use refcount+RCU method to implement lockless slab shrink
|
expand
|
diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.c index 648ca70403a7..fe610a3cace0 100644 --- a/drivers/gpu/drm/ttm/ttm_pool.c +++ b/drivers/gpu/drm/ttm/ttm_pool.c @@ -73,7 +73,7 @@ static struct ttm_pool_type global_dma32_uncached[MAX_ORDER + 1]; static spinlock_t shrinker_lock; static struct list_head shrinker_list; -static struct shrinker mm_shrinker; +static struct shrinker *mm_shrinker; static DECLARE_RWSEM(pool_shrink_rwsem); /* Allocate pages of size 1 << order with the given gfp_flags */ @@ -749,8 +749,8 @@ static int ttm_pool_debugfs_shrink_show(struct seq_file *m, void *data) struct shrink_control sc = { .gfp_mask = GFP_NOFS }; fs_reclaim_acquire(GFP_KERNEL); - seq_printf(m, "%lu/%lu\n", ttm_pool_shrinker_count(&mm_shrinker, &sc), - ttm_pool_shrinker_scan(&mm_shrinker, &sc)); + seq_printf(m, "%lu/%lu\n", ttm_pool_shrinker_count(mm_shrinker, &sc), + ttm_pool_shrinker_scan(mm_shrinker, &sc)); fs_reclaim_release(GFP_KERNEL); return 0; @@ -794,10 +794,17 @@ int ttm_pool_mgr_init(unsigned long num_pages) &ttm_pool_debugfs_shrink_fops); #endif - mm_shrinker.count_objects = ttm_pool_shrinker_count; - mm_shrinker.scan_objects = ttm_pool_shrinker_scan; - mm_shrinker.seeks = 1; - return register_shrinker(&mm_shrinker, "drm-ttm_pool"); + mm_shrinker = shrinker_alloc(0, "drm-ttm_pool"); + if (!mm_shrinker) + return -ENOMEM; + + mm_shrinker->count_objects = ttm_pool_shrinker_count; + mm_shrinker->scan_objects = ttm_pool_shrinker_scan; + mm_shrinker->seeks = 1; + + shrinker_register(mm_shrinker); + + return 0; } /** @@ -817,6 +824,6 @@ void ttm_pool_mgr_fini(void) ttm_pool_type_fini(&global_dma32_uncached[i]); } - unregister_shrinker(&mm_shrinker); + shrinker_free(mm_shrinker); WARN_ON(!list_empty(&shrinker_list)); }