From patchwork Mon Sep 4 18:08:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 13374257 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF881CA0FF3 for ; Mon, 4 Sep 2023 18:08:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E64188D000C; Mon, 4 Sep 2023 14:08:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E14688D0001; Mon, 4 Sep 2023 14:08:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDCC98D000C; Mon, 4 Sep 2023 14:08:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BD0348D0001 for ; Mon, 4 Sep 2023 14:08:13 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E0903407DA for ; Mon, 4 Sep 2023 18:08:12 +0000 (UTC) X-FDA: 81199699224.04.A995386 Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) by imf08.hostedemail.com (Postfix) with ESMTP id 05DB9160033 for ; Mon, 4 Sep 2023 18:08:10 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b="SSDabr//"; dmarc=none; spf=pass (imf08.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.166.171 as permitted sender) smtp.mailfrom=joel@joelfernandes.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693850891; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=Zr3sV+XQtYagsN7Oqrbp+58+EQW5Ic/xyDIjYG4JLi4=; b=muNA7MPkRiEOInoFEVy4H0Y+T4NukceTw+Qm+xt+kl15//I+jMk5cOEt4yMSbRGKf5yu2R Rkt1C7cV7TWlskr2xAB32Dd+yGtjJinSNuJc4+OCo4TI9xN7Guhqlc1Ysd6nNYFPzpRDDb 6uyBSSIq6oDpjMcTJR1Y9NDwYHMrC6w= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b="SSDabr//"; dmarc=none; spf=pass (imf08.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.166.171 as permitted sender) smtp.mailfrom=joel@joelfernandes.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693850891; a=rsa-sha256; cv=none; b=VQtTm4slzZPgLZBJwbgWHG4ccDQLs4FjZYoNDwgBofrnL6+fMjEAzGDUXoXyO9t1z8x0JZ uiCa3CkHykQBumo7JZ1TokHTPPCWmbrKQuYQXX6JxS3aPMRN6jZwoXTVNm7IAu2pwlz1Sm 9g60p0fCoeMnDXnalfbg6U6gcbLc+ac= Received: by mail-il1-f171.google.com with SMTP id e9e14a558f8ab-34df4799a62so5280215ab.1 for ; Mon, 04 Sep 2023 11:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1693850890; x=1694455690; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Zr3sV+XQtYagsN7Oqrbp+58+EQW5Ic/xyDIjYG4JLi4=; b=SSDabr//njqJchAldU3Dfdp58Ydcl8SKhivErqP6f/xwWJw5geKNED52tbfWT/pFj6 Nlah/8YpO80ZyR9ECRFe8B1fjcI+mUmEfP3Y5f6sZGnLx/P+N/zsXLEJAbEixOQ4h/GP GBALJ+xp3p08+AGSe27rRZHDJ6fnrtRAQ+V5s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693850890; x=1694455690; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Zr3sV+XQtYagsN7Oqrbp+58+EQW5Ic/xyDIjYG4JLi4=; b=Q0pAQV1ePa3bmyGyerFegnAWI1cuOuhmNvEcZNDgT40CU1iDHfZZs5oGf1ILvYO2n1 8CRTNWy5EiyfFGvIXwbblyj/wEE5fcPjh9oV2cv3ny8bRxT1gHR5EVHUwLPAISYw+jss YCc4Ux3xZed9FQXq4775swgeFOr2X8KQOCofXONeGOrTmY/aJxY7PN+dElbEFPYxG0ax SFvccJ6CfEe91qsZSSksRsiTIw/gUbzoEas0yxJziXIcY/LVz71v1U7bAdQf/l5+VXHP FWw8Ocm1U2Mt41MYhjixAiwZP+YVgoQg7qn+Wn2mn2/VW/bLN2d+w10TjOm2vPw7rGpY 279A== X-Gm-Message-State: AOJu0Yw356S2NN+kq4vbyDGzPLjEaw8nQ67IUTAmDnYp0WodYsyKndFe +HsDcQ/gGI77iWok05vtmm9oaw== X-Google-Smtp-Source: AGHT+IFbD+DaAQ3YbgG2+T0I0C6EZ5+DKMrgMuUdKzBowVD9B/0AeNCAjrN71tih8W71+pJaIVm+PA== X-Received: by 2002:a92:d90b:0:b0:34c:e5c2:918b with SMTP id s11-20020a92d90b000000b0034ce5c2918bmr11118950iln.13.1693850890063; Mon, 04 Sep 2023 11:08:10 -0700 (PDT) Received: from joelboxx5.corp.google.com (156.190.123.34.bc.googleusercontent.com. [34.123.190.156]) by smtp.gmail.com with ESMTPSA id g15-20020a02b70f000000b0042bb13cb80fsm3520216jam.120.2023.09.04.11.08.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Sep 2023 11:08:09 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org, Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , "Paul E. McKenney" , Vlastimil Babka Cc: "Joel Fernandes (Google)" , Zhen Lei , rcu@vger.kernel.org, Zqiang , stable@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v3 1/2] mm/vmalloc: Add a safer version of find_vm_area() for debug Date: Mon, 4 Sep 2023 18:08:04 +0000 Message-ID: <20230904180806.1002832-1-joel@joelfernandes.org> X-Mailer: git-send-email 2.42.0.283.g2d96d420d3-goog MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 05DB9160033 X-Stat-Signature: gg54711giwj14djyj3j81rtz9stdjttg X-HE-Tag: 1693850890-802255 X-HE-Meta: U2FsdGVkX18Jl0BTxxmnaErI1S/0BBVbqBJQiISKPpDXFUgL5XEbnLbAQZF4w1BQ6aymhB4XhRkRotBpLOoxb8ZHvjsFYLjOUkpBgBX4k9xnXjDzq1ogQ+wb67NLNs+I3R/y0AkebWaeMOQMAaIV3RX+z1a/Hv6zzPJesZkVAr0aL1ts04YFghiq5CspOB8D5khdqSGYTe9L1fNewuouRSWW9fLLFsH/dVp98Maq5fx5SvyHuOBPI3+jxPQL81DbjunKKKrR3yG+bjCMH1IW/V/eAaZJ9f2UedAjsr9xyoIk701kuuZ9zBn9zEdt90AGgqupNrjHeXAV5Ol81HRf4KlurLUUu1jGErPwf3xeHgBLvJcC2FVPyjo+JOGmI2K4Wc751AfKKKpxmSdLMG+hJG1EbAiCrXpnNMoE6uF5TXSgr+lAgGskaCbt33k8d8Z2VXewn8FEnytebmOdTu47/6zVx2km0B2dF3WQoGzV9b8Fj9NPsh+6Mc0zSkTzWxNjuGG/VKdre7o0lW7y+CGfipNxf/zfwXG/jH5VnhoGA/xrUDVTp/ZNvwEE+T9FfdiV9uok62UGcnzuQneqp/APQJ+XzApMYOkOQlPiu+1kkTr8Cruh+misLOSHbSBITgS5gJ5cd2oK6nUmGR5N6A175ANsoSOu4oGLSlgx9eeR9JDCencAxeJvXQFxHZmLg7AuKdaYvsfVwkZFvamv+yaUNql/81Sknc8UcyPSZRqCEFLv1Wjh3coDyKCvuP4XXKNga35/ivJKgakmHPgr+FCACDJCnnIZkLp/uZhWwyZc1BJmmYi331w839mg0YfiksHeTOHAJztqiYn6EcbRL9AqyN8L/+QyvNfJpV58hORgSET8CsXy2+TONrSrNMEFErens611cYAyAkK243McMqNchgptB3h5mlgY5EGDtuD+H2gEalqTTH1eoJGfWYPlvw7b8LHvH8ODyrPUAbdNhGT JmO0I9Ft EceB5JI7jlezA7K7A60v/edAufHQE6i3ovYPs5HU8ojt3LmsthrPhBQJc/hY9m7JZvlD5HOZvYaHPHaPrlavEj8byxYMs7zUt9DOKIRX5H/Ow2gYH3QooPlwjnGRi9vMxpv6pBp6qHEzNqrVDleJQkvyPKzdjFuKvPZXpFm474hyVqFVaN9qSpzspNduvf21qsigKO500SzlVlp8ckHY5Rw/osAQoOT6/4o5RljMXmhLvLiome7Dei0Q99LhR6qn3N6zR5hi7AcusnOX2w2azIsPyQzhDUcNJxfNo0RrfNhFq/jYtnL0TK+N6hyZe1aIyAr3VYfwz/STD0mD6TB5YZ8m/4s9XOe3IpqOf6gRG7paZdElHm5tErsEgVkbYv26uOzDVsdlRPp47Rkqyd/IW/sBDVuAPTfw4zZd+KrwpvjuIH5hprsJcohLz2HCNIkX60YBjL6igbJn9k7n6Tazf+SsjTxt5QT4uBMQU1/8SKp58C1gYIWnulTatqFkfJJFdqrNjEfUut4URJcssOsiyc8siGYYQ4PJm9kpPx3nhrzFOIlbJ6CGqZJQuUA2xrqsdUnrPV16pYElqRupp4nfUfbQFW69RIGtXn1ocGckj8TFukM+blZsmPBGPVn/B7UUFxjmmeq7iZtYpMT5Xgl0gMizE3QXfmXl+jGMD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It is unsafe to dump vmalloc area information when trying to do so from some contexts. Add a safer trylock version of the same function to do a best-effort VMA finding and use it from vmalloc_dump_obj(). [applied test robot feedback on unused function fix.] [applied Uladzislau feedback on locking.] Reported-by: Zhen Lei Cc: Paul E. McKenney Cc: rcu@vger.kernel.org Cc: Zqiang Reviewed-by: Uladzislau Rezki (Sony) Fixes: 98f180837a89 ("mm: Make mem_dump_obj() handle vmalloc() memory") Cc: stable@vger.kernel.org Signed-off-by: Joel Fernandes (Google) Reported-by: Zhen Lei Reviewed-by: Uladzislau Rezki (Sony) Signed-off-by: Joel Fernandes (Google) --- mm/vmalloc.c | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 93cf99aba335..2c6a0e2ff404 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -4274,14 +4274,32 @@ void pcpu_free_vm_areas(struct vm_struct **vms, int nr_vms) #ifdef CONFIG_PRINTK bool vmalloc_dump_obj(void *object) { - struct vm_struct *vm; void *objp = (void *)PAGE_ALIGN((unsigned long)object); + const void *caller; + struct vm_struct *vm; + struct vmap_area *va; + unsigned long addr; + unsigned int nr_pages; - vm = find_vm_area(objp); - if (!vm) + if (!spin_trylock(&vmap_area_lock)) + return false; + va = __find_vmap_area((unsigned long)objp, &vmap_area_root); + if (!va) { + spin_unlock(&vmap_area_lock); return false; + } + + vm = va->vm; + if (!vm) { + spin_unlock(&vmap_area_lock); + return false; + } + addr = (unsigned long)vm->addr; + caller = vm->caller; + nr_pages = vm->nr_pages; + spin_unlock(&vmap_area_lock); pr_cont(" %u-page vmalloc region starting at %#lx allocated at %pS\n", - vm->nr_pages, (unsigned long)vm->addr, vm->caller); + nr_pages, addr, caller); return true; } #endif