[v6,15/45] rcu: dynamically allocate the rcu-lazy shrinker

Message ID	20230911094444.68966-16-zhengqi.arch@bytedance.com (mailing list archive)
State	New
Headers	show Return-Path: <owner-linux-mm@kvack.org> From: Qi Zheng <zhengqi.arch@bytedance.com> To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Qi Zheng <zhengqi.arch@bytedance.com>, Joel Fernandes <joel@joelfernandes.org>, rcu@vger.kernel.org Subject: [PATCH v6 15/45] rcu: dynamically allocate the rcu-lazy shrinker Date: Mon, 11 Sep 2023 17:44:14 +0800 Message-Id: <20230911094444.68966-16-zhengqi.arch@bytedance.com> In-Reply-To: <20230911094444.68966-1-zhengqi.arch@bytedance.com> References: <20230911094444.68966-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org Precedence: bulk
Series	use refcount+RCU method to implement lockless slab shrink \| expand [v6,00/45] use refcount+RCU method to implement lockless slab shrink [v6,01/45] mm: shrinker: add infrastructure for dynamically allocating shrinker [v6,02/45] kvm: mmu: dynamically allocate the x86-mmu shrinker [v6,03/45] binder: dynamically allocate the android-binder shrinker [v6,04/45] drm/ttm: dynamically allocate the drm-ttm_pool shrinker [v6,05/45] xenbus/backend: dynamically allocate the xen-backend shrinker [v6,06/45] erofs: dynamically allocate the erofs-shrinker [v6,07/45] f2fs: dynamically allocate the f2fs-shrinker [v6,08/45] gfs2: dynamically allocate the gfs2-glock shrinker [v6,09/45] gfs2: dynamically allocate the gfs2-qd shrinker [v6,10/45] NFSv4.2: dynamically allocate the nfs-xattr shrinkers [v6,11/45] nfs: dynamically allocate the nfs-acl shrinker [v6,12/45] nfsd: dynamically allocate the nfsd-filecache shrinker [v6,13/45] quota: dynamically allocate the dquota-cache shrinker [v6,14/45] ubifs: dynamically allocate the ubifs-slab shrinker [v6,15/45] rcu: dynamically allocate the rcu-lazy shrinker [v6,16/45] rcu: dynamically allocate the rcu-kfree shrinker [v6,17/45] mm: thp: dynamically allocate the thp-related shrinkers [v6,18/45] sunrpc: dynamically allocate the sunrpc_cred shrinker [v6,19/45] mm: workingset: dynamically allocate the mm-shadow shrinker [v6,20/45] drm/i915: dynamically allocate the i915_gem_mm shrinker [v6,21/45] drm/msm: dynamically allocate the drm-msm_gem shrinker [v6,22/45] drm/panfrost: dynamically allocate the drm-panfrost shrinker [v6,23/45] dm: dynamically allocate the dm-bufio shrinker [v6,24/45] dm zoned: dynamically allocate the dm-zoned-meta shrinker [v6,25/45] md/raid5: dynamically allocate the md-raid5 shrinker [v6,26/45] bcache: dynamically allocate the md-bcache shrinker [v6,27/45] vmw_balloon: dynamically allocate the vmw-balloon shrinker [v6,28/45] virtio_balloon: dynamically allocate the virtio-balloon shrinker [v6,29/45] mbcache: dynamically allocate the mbcache shrinker [v6,30/45] ext4: dynamically allocate the ext4-es shrinker [v6,31/45] jbd2,ext4: dynamically allocate the jbd2-journal shrinker [v6,32/45] nfsd: dynamically allocate the nfsd-client shrinker [v6,33/45] nfsd: dynamically allocate the nfsd-reply shrinker [v6,34/45] xfs: dynamically allocate the xfs-buf shrinker [v6,35/45] xfs: dynamically allocate the xfs-inodegc shrinker [v6,36/45] xfs: dynamically allocate the xfs-qm shrinker [v6,37/45] zsmalloc: dynamically allocate the mm-zspool shrinker [v6,38/45] fs: super: dynamically allocate the s_shrink [v6,39/45] mm: shrinker: remove old APIs [v6,40/45] mm: shrinker: add a secondary array for shrinker_info::{map, nr_deferred} [v6,41/45] mm: shrinker: rename {prealloc\|unregister}_memcg_shrinker() to shrinker_memcg_{alloc\|rem… [v6,42/45] mm: shrinker: make global slab shrink lockless [v6,43/45] mm: shrinker: make memcg slab shrink lockless [v6,44/45] mm: shrinker: hold write lock to reparent shrinker nr_deferred [v6,45/45] mm: shrinker: convert shrinker_rwsem to mutex

Message ID

20230911094444.68966-16-zhengqi.arch@bytedance.com (mailing list archive)

State

New

Headers

From: Qi Zheng <zhengqi.arch@bytedance.com>
To: akpm@linux-foundation.org,
	david@fromorbit.com,
	tkhai@ya.ru,
	vbabka@suse.cz,
	roman.gushchin@linux.dev,
	djwong@kernel.org,
	brauner@kernel.org,
	paulmck@kernel.org,
	tytso@mit.edu,
	steven.price@arm.com,
	cel@kernel.org,
	senozhatsky@chromium.org,
	yujie.liu@intel.com,
	gregkh@linuxfoundation.org,
	muchun.song@linux.dev
Cc: linux-kernel@vger.kernel.org,
	linux-mm@kvack.org,
	linux-fsdevel@vger.kernel.org,
	Qi Zheng <zhengqi.arch@bytedance.com>,
	Joel Fernandes <joel@joelfernandes.org>,
	rcu@vger.kernel.org
Subject: [PATCH v6 15/45] rcu: dynamically allocate the rcu-lazy shrinker
Date: Mon, 11 Sep 2023 17:44:14 +0800
Message-Id: <20230911094444.68966-16-zhengqi.arch@bytedance.com>
In-Reply-To: <20230911094444.68966-1-zhengqi.arch@bytedance.com>
References: <20230911094444.68966-1-zhengqi.arch@bytedance.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: owner-linux-mm@kvack.org
Precedence: bulk

Series

use refcount+RCU method to implement lockless slab shrink | expand

Commit Message

Qi Zheng Sept. 11, 2023, 9:44 a.m. UTC

Use new APIs to dynamically allocate the rcu-lazy shrinker.

Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
CC: rcu@vger.kernel.org
---
 kernel/rcu/tree_nocb.h | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

Comments

Muchun Song Sept. 18, 2023, 7:27 a.m. UTC | #1

> On Sep 11, 2023, at 17:44, Qi Zheng <zhengqi.arch@bytedance.com> wrote:
> 
> Use new APIs to dynamically allocate the rcu-lazy shrinker.
> 
> Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>

Acked-by: Muchun Song <songmuchun@bytedance.com>

Thanks.

diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h
index 5598212d1f27..4efbf7333d4e 100644
--- a/kernel/rcu/tree_nocb.h
+++ b/kernel/rcu/tree_nocb.h
@@ -1396,13 +1396,6 @@  lazy_rcu_shrink_scan(struct shrinker *shrink, struct shrink_control *sc)
 
 	return count ? count : SHRINK_STOP;
 }
-
-static struct shrinker lazy_rcu_shrinker = {
-	.count_objects = lazy_rcu_shrink_count,
-	.scan_objects = lazy_rcu_shrink_scan,
-	.batch = 0,
-	.seeks = DEFAULT_SEEKS,
-};
 #endif // #ifdef CONFIG_RCU_LAZY
 
 void __init rcu_init_nohz(void)
@@ -1410,6 +1403,7 @@  void __init rcu_init_nohz(void)
 	int cpu;
 	struct rcu_data *rdp;
 	const struct cpumask *cpumask = NULL;
+	struct shrinker * __maybe_unused lazy_rcu_shrinker;
 
 #if defined(CONFIG_NO_HZ_FULL)
 	if (tick_nohz_full_running && !cpumask_empty(tick_nohz_full_mask))
@@ -1436,8 +1430,15 @@  void __init rcu_init_nohz(void)
 		return;
 
 #ifdef CONFIG_RCU_LAZY
-	if (register_shrinker(&lazy_rcu_shrinker, "rcu-lazy"))
-		pr_err("Failed to register lazy_rcu shrinker!\n");
+	lazy_rcu_shrinker = shrinker_alloc(0, "rcu-lazy");
+	if (!lazy_rcu_shrinker) {
+		pr_err("Failed to allocate lazy_rcu shrinker!\n");
+	} else {
+		lazy_rcu_shrinker->count_objects = lazy_rcu_shrink_count;
+		lazy_rcu_shrinker->scan_objects = lazy_rcu_shrink_scan;
+
+		shrinker_register(lazy_rcu_shrinker);
+	}
 #endif // #ifdef CONFIG_RCU_LAZY
 
 	if (!cpumask_subset(rcu_nocb_mask, cpu_possible_mask)) {

[v6,15/45] rcu: dynamically allocate the rcu-lazy shrinker

Commit Message

Comments

Patch