From patchwork Mon Sep 11 09:44:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qi Zheng X-Patchwork-Id: 13379078 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 144DEEEB57E for ; Mon, 11 Sep 2023 09:48:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4ACE6B0208; Mon, 11 Sep 2023 05:48:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A07DA6B0209; Mon, 11 Sep 2023 05:48:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C4546B020A; Mon, 11 Sep 2023 05:48:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7E33F6B0208 for ; Mon, 11 Sep 2023 05:48:50 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 658AE1CA24C for ; Mon, 11 Sep 2023 09:48:50 +0000 (UTC) X-FDA: 81223842420.15.ECECEB8 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf07.hostedemail.com (Postfix) with ESMTP id 90B704000C for ; Mon, 11 Sep 2023 09:48:48 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=UdqWth2l; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf07.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694425728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ruGIazUIgd5W3iD+fpVWztgrL7hXLBFpKRJYJNwmlEs=; b=H9JUXeOY/mvjYVMF8Y0UO4yH0vle+wgMSLqg3I+N1eovTiL7OOFA9+0Ww4sTpqutFfg4yy 2ESYeDhBh5M7yWVta5YFNMbfktGC/kCi1DA6tSXm7UAeRb48+DBDEi/fCn6WjkR51Y7VQe sMo9y8wMypxABErijmdlXBtSXyCN0Uc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=UdqWth2l; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf07.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694425728; a=rsa-sha256; cv=none; b=DDkxlmR4p3GoeivUU2c+KdMQMOPd17+/zYgv79ZtqwwrRyyYRgvRif8ZYyeawt/0a2Q/Ek 2BD7fBeZfdurSBPQYPisbXb1swe8EZlwmb+pGe5OlUC5QIBzrpd0anv5puRfxVKIOEiOa6 IX6vKDBZGT3ULFbPf3WR16Dt9b4Etx4= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1befe39630bso9367055ad.0 for ; Mon, 11 Sep 2023 02:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1694425727; x=1695030527; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ruGIazUIgd5W3iD+fpVWztgrL7hXLBFpKRJYJNwmlEs=; b=UdqWth2l5E2KGCdwt0wOgOwGPQp8Uks/0pPRe5ARsQBTpXvtVTKqk6gGp87LLqKQrE mwG7r/mEmzvVEvEYEf7KW4nka+3z4NNNfd2lLUtGfCQAtqJQG693GxktE7q01xLqSKud +pOtzfMyfg7s5OMDDaoKwWuCNNs0bRSQXvyCiU9u7pwdeBjvMZ6Iyc6gV9xY03TYBDIK MO+bHF1/gR8sFVuFoI0ZiM5ezTU6JW8/8azCpV75P2qTSBea/orLPtTrB6Q09NjJeMyE MKrKqPhXW2p7aIip/dP9oP998zBW0psCL/w5xH/RZ2qHWQkHLVpfVVdhy/tCNkYHEymv QLJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694425727; x=1695030527; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ruGIazUIgd5W3iD+fpVWztgrL7hXLBFpKRJYJNwmlEs=; b=WmLSOEcXc2YwtAf93KUXyUjUFgdjDZS3MNx5z4k1cAQI4k26aU59nIO2weCGOsJKCq PzB0O8snH/VkbKu0cDXMw5J6DYFMvxPS5mQJsDn6QtxJtY/jOJ4WHpKsF4+qPcpFojpw VdCXLUcL317FYOscCHA5UD9Scv7eTG9W0modQ1lz9DjgG3Jo64eQPhB/SELN1icIqsfF vtZbZRWQMukyibsD2+ZnIHj2k/bWctURx831hE9eadIaEoCeXZBzpvH6q6gVAv2SIOIo Dfse5zHjBeu2B1/yGqw/uDDcEi2LL/sE4zMVBl55a1TMmf1oTQRbKqQEX+rixUK3HrAP sVgg== X-Gm-Message-State: AOJu0YzsLxMmfNwxfV3k2OpKFrHkkwRnyJ1+L7/X6N59Wyb12H0eUMLT 6Evqd5KS5PXhMAVeof90W+sBQA== X-Google-Smtp-Source: AGHT+IGGBhJFk/SRU3E2zGlQ2j/g+CUjwQeV+kN/9j9QP3+HgtWpTi+Be+pjzGQyb1HeKYNZhEoDDA== X-Received: by 2002:a17:902:e849:b0:1b8:aded:524c with SMTP id t9-20020a170902e84900b001b8aded524cmr10985885plg.1.1694425727595; Mon, 11 Sep 2023 02:48:47 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id az7-20020a170902a58700b001bdc2fdcf7esm5988188plb.129.2023.09.11.02.48.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 02:48:47 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Qi Zheng , Muchun Song , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com Subject: [PATCH v6 24/45] dm zoned: dynamically allocate the dm-zoned-meta shrinker Date: Mon, 11 Sep 2023 17:44:23 +0800 Message-Id: <20230911094444.68966-25-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230911094444.68966-1-zhengqi.arch@bytedance.com> References: <20230911094444.68966-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 90B704000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: qgrmutgbwqdfr94ry63fqbxcdj37nfze X-HE-Tag: 1694425728-128698 X-HE-Meta: U2FsdGVkX197FW2YPw2vuTGEBPBzl9LZlf9ojnaqdmZI3Aafa5PECtPJcyl2Yjizq4nn9l06k8IG0b8X89Uh4LPm7qJRhTp0UzYbs6wWCYeXMYk1bmNdoG1gfVb3MPX+ctYGyByym+tssl034qWqCRj9lm9IvaXnKtnLXvWEkd0pbBjApW7WnCG6L5j+zldftItBJU69I8srT7c4XsXqgVSG9agknH+vLbndyl0P0U3E+1GwvyHbz5WJCE4Wd7QsTcZtZzjdN6I5X9VE39dmYq4KMPum2YdTuckX5lj7Z/6oA2sh72woSj9oKhd4wqwS0C7l3joFeX7zn83yvqzKoR5kJkm1azg2RCByqYuP50/gIbiTcSlqBbepYiKR10IT63Lyg9mJM5uSgC8Itakht+cnJRCHuiE3h97su78GYdQbT3WPi6nTg2caMliTUQBVr+Hoh/CHfEF8L9W8ntISIPhjM0aKThFgwxm++/mrTVosnNWh4H+d4OgJTq/oQHYHVRhmiZ8lb6V45WlVKBMDR07aCHrBdTxUHPW0RLzwGlduJSSDjb10kQizdTHKTN2hsn1Nw65uVb7++bUkhbsNWdDP7ROofyTbyNciKfnScEwt1We/pPkhDo2X33q7wVrQLA+ZJQAJNLCemFrj6GlZZSQ46JMkKuWZkU1gQlXP1pygVOKkROfYkqOED0UiOfxrn7fvgvU5M63bfKEZwg2VKgWZZu3ien3f6UBxwORvUA+n/L+UN0v9dx/7m/6kzBW0dAEscPAZlGgKcJaTaS7BgOm05TJQpNoTbWKge0RUrgR83DDNRDHOZVdkG4UdMFFW/mslj7J1lN23Z9FWJil/7HWELGAjvtczxXDPvzD382Z97324ar1m7DlbLeaZEKZMgp7cF55LvmH6Yv2mjhtmqcbM8DT+W3f9Xs0H/tZ187I6MDzal+MbJBPexgK3hr1jdyflQkUvwCj9B00rdHc eSbFUlXv 7Fw/N0vvx+RQkNFwnIaI4ZY7ZCABLxjZpPIwQVhZXTMl3bcZRv3z2FdsXle50bbK0VfNga70sq7hb9dL/adL8/l2ZgJ6JUlpZZCgXjfTkMDzgcDWBkLmcqfE2pTjiAAi/GZio+EB7jTogZRQvMK5SBpj51JQMl7nmNxBESYoUOZIvAqlPyfWBjqCNcnlQLuXjpiQiBAJqE5QDid3HLWP3FcUx9wvyDvgKno4+0ZjzSWmJ2UvzJ2ha3OINfggckOZvfxE7zmJVBXxxXX1MQiljGeCCjxxu8KEEoRmnu6WNy/aAuf+3OMKS6sDcwirDfcPnFo51j9osZlyrrpeJ4tLW2I5kGwn3zwGpl1jzze6q8GfYUkZsT8Kk/pOK6RNPCY7q2bsjAeTLUaXWHrQ/X97I1SBYtJq3/DVNNX13+B6TwEDHUdr1KsotlHszqgi+A+AJ9ruHPAjC2/HItLPawkn9QNwOIAyMYEIkbrozgnuXLm3RUb1vbOnPA68qog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the dm-zoned-meta shrinker, so that it can be freed asynchronously via RCU. Then it doesn't need to wait for RCU read-side critical section when releasing the struct dmz_metadata. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song CC: Alasdair Kergon CC: Mike Snitzer CC: dm-devel@redhat.com --- drivers/md/dm-zoned-metadata.c | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c index 9d3cca8e3dc9..60a4dc01ea18 100644 --- a/drivers/md/dm-zoned-metadata.c +++ b/drivers/md/dm-zoned-metadata.c @@ -187,7 +187,7 @@ struct dmz_metadata { struct rb_root mblk_rbtree; struct list_head mblk_lru_list; struct list_head mblk_dirty_list; - struct shrinker mblk_shrinker; + struct shrinker *mblk_shrinker; /* Zone allocation management */ struct mutex map_lock; @@ -615,7 +615,7 @@ static unsigned long dmz_shrink_mblock_cache(struct dmz_metadata *zmd, static unsigned long dmz_mblock_shrinker_count(struct shrinker *shrink, struct shrink_control *sc) { - struct dmz_metadata *zmd = container_of(shrink, struct dmz_metadata, mblk_shrinker); + struct dmz_metadata *zmd = shrink->private_data; return atomic_read(&zmd->nr_mblks); } @@ -626,7 +626,7 @@ static unsigned long dmz_mblock_shrinker_count(struct shrinker *shrink, static unsigned long dmz_mblock_shrinker_scan(struct shrinker *shrink, struct shrink_control *sc) { - struct dmz_metadata *zmd = container_of(shrink, struct dmz_metadata, mblk_shrinker); + struct dmz_metadata *zmd = shrink->private_data; unsigned long count; spin_lock(&zmd->mblk_lock); @@ -2936,19 +2936,23 @@ int dmz_ctr_metadata(struct dmz_dev *dev, int num_dev, */ zmd->min_nr_mblks = 2 + zmd->nr_map_blocks + zmd->zone_nr_bitmap_blocks * 16; zmd->max_nr_mblks = zmd->min_nr_mblks + 512; - zmd->mblk_shrinker.count_objects = dmz_mblock_shrinker_count; - zmd->mblk_shrinker.scan_objects = dmz_mblock_shrinker_scan; - zmd->mblk_shrinker.seeks = DEFAULT_SEEKS; /* Metadata cache shrinker */ - ret = register_shrinker(&zmd->mblk_shrinker, "dm-zoned-meta:(%u:%u)", - MAJOR(dev->bdev->bd_dev), - MINOR(dev->bdev->bd_dev)); - if (ret) { - dmz_zmd_err(zmd, "Register metadata cache shrinker failed"); + zmd->mblk_shrinker = shrinker_alloc(0, "dm-zoned-meta:(%u:%u)", + MAJOR(dev->bdev->bd_dev), + MINOR(dev->bdev->bd_dev)); + if (!zmd->mblk_shrinker) { + ret = -ENOMEM; + dmz_zmd_err(zmd, "Allocate metadata cache shrinker failed"); goto err; } + zmd->mblk_shrinker->count_objects = dmz_mblock_shrinker_count; + zmd->mblk_shrinker->scan_objects = dmz_mblock_shrinker_scan; + zmd->mblk_shrinker->private_data = zmd; + + shrinker_register(zmd->mblk_shrinker); + dmz_zmd_info(zmd, "DM-Zoned metadata version %d", zmd->sb_version); for (i = 0; i < zmd->nr_devs; i++) dmz_print_dev(zmd, i); @@ -2995,7 +2999,7 @@ int dmz_ctr_metadata(struct dmz_dev *dev, int num_dev, */ void dmz_dtr_metadata(struct dmz_metadata *zmd) { - unregister_shrinker(&zmd->mblk_shrinker); + shrinker_free(zmd->mblk_shrinker); dmz_cleanup_metadata(zmd); kfree(zmd); }