From patchwork Fri Sep 15 02:52:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13386318 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 024F1EE0205 for ; Fri, 15 Sep 2023 02:53:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6AC396B0312; Thu, 14 Sep 2023 22:53:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 65BDE6B0314; Thu, 14 Sep 2023 22:53:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FCB56B0315; Thu, 14 Sep 2023 22:53:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 387446B0312 for ; Thu, 14 Sep 2023 22:53:15 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0235FC0746 for ; Fri, 15 Sep 2023 02:53:15 +0000 (UTC) X-FDA: 81237310350.19.41BA1F3 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf11.hostedemail.com (Postfix) with ESMTP id CCAAF40004 for ; Fri, 15 Sep 2023 02:53:12 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UNlsCXn2; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694746393; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kq5huNrcaXucw0j7mRG+Q0tHkEUy8BekbmYeCC7zaEU=; b=kLOePgfjifGMN5ldU82AWzdW8ZBEKvF/1kYOVT7b+n4tRc8uhG7dr+nybz33rkiHsHw9KM IEN1n9jCE+wy8WEBrvNukUOnTkKJCVBHsUK9GaEf9zXo0HdwPThgLc1ry2ZhQfz8/zJfT8 T06/GgU7fj1ONV7SmYy4QNpg+ypxVa4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UNlsCXn2; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694746393; a=rsa-sha256; cv=none; b=YDUllWVyJhrrU60ILTHWvLtBMUdAe/xj6dLwZngui4OxvG9Qs3+3oA86LgoPDBV7Y4/PqC nNvciOuqdAmCzFlqCz9cP3OKCILyGeO1fuyccLRWd6wp5VSouRHTd/x/OL2+MDPBEEHUWb jXp6y8exYUptT5d6yHSZKKWXNgr+x3k= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id DC5B9CE297B; Fri, 15 Sep 2023 02:53:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAF88C433C7; Fri, 15 Sep 2023 02:53:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694746388; bh=wBwPsUGsJdUgsPRGuDP3t7LM9PStyxdXiFRE+6KpN8o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UNlsCXn2IBMaifeZPCzuHLGLs2hxZKyJo15KTVgqw2yb4GmWro5TL/tfPUSK6bwAq QSOAsTa0LGtwiKWKcmD1j92KgS8dR/UlLaruT1InEnnlxtuvkE5wIM8GnH2+tyScCR HMt5/hYyduUJntyRBoJPQoWIIz97O2i1IEi621u4wpsk80vovp6HWkUWxkTJjc6RjB MZymM9MTewhbrj7bf1/KSdeYXkLuE/8doyfioVpzF8G9iUZWTtpW9qXiCvu+xpL69h an2xvGCqhontwiXgJKZVeoJGDGf/60hYDKC+MCOd7c9xjhhgMRJAHQNtxTeZMy/dlP HM07jOkZBw0Cw== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/8] mm/damon/core: introduce nr_accesses_bp Date: Fri, 15 Sep 2023 02:52:48 +0000 Message-Id: <20230915025251.72816-6-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230915025251.72816-1-sj@kernel.org> References: <20230915025251.72816-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: pohxoe3ioxysppwjotxft7k83t1gy78m X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CCAAF40004 X-HE-Tag: 1694746392-518567 X-HE-Meta: U2FsdGVkX1/VWGVCeF/RTsKk49sHAiweuJDYzDuL9VbDcv3HL2tGzBSyPoZ0WD0LObxCMOmD6jKhKWTVQlN6xUhPscnG69+457KI2vxK8CsZhdDnJwsircGBvSdiJrr1FnhVqOs+6Md3xXHFKeyGbR9Z5JEgynCSmZau5Mnig70ohkrdINArePjWCoQeEopW3iBQqVEwjuKOrYPRIjVavn1d64XLDulhbiK9AyfLaQ8gOVEtgPGSU4knOsVVUv47HafbPUsdNjrKPrCXVtBQnF17Rt5FUyO65SC2f5TQmfIZ5JmRHWOjPP1d22sDHLZtsybKV1LBSNXJLwLKDLyYZdJtY8NJWiDLvan+xbpGPwD3yUAm6W0zbqtvpbleeGDS/VJ0C7GfoaC6yEBoy4QeiYlmBKptdDy2w9mPowRyH+S8xtPW0k2MORjKhhFoQAqakKjm4MNTZfhKbke6zojzAzfpvGNaXMBfTiZoJbxRZT59ycJeylCQDP5ARyjE4kRWhAlAVlkJWVqdkolkipHruy1L5Rn0Y/ZA5iX031L6LTXkxDmbv3G00IrkBpX/7cnjqJfRXyUOGVPxRRqX8ybIL56GL2rYa6PKRLN4vvBgZHbWcPlY8HCUujIpOb4uuznOJuuX5UKImPZ2v3YFWOp52dU1S6njqIpleICpZDyfz1+C+xZ0ELLvAB6ABLfhMlx3qqSanqxV7GhRHTdM1K1lUxxUnLT5bPNQ1Kakk2euqsTKRRfWwR6s0FCwMDbeVLD9N0g3Knj9zJanYqt978fF29ODfPnkTNn2VGnegyWuS9XWrB3RaiEWvKj1uX7gopaciOomOjx+hlQs2lpHEXMvWjtZsBv/UCDvqTeo73h4ESGqb3E77poSDjmaMO2t0FXjVfAYgBYnQ2KWl2MKLuNHqBycTc76ZYV2vMBuvmFbycu6R34fkyj0Ttdee+Vres1Hx7+onedNIwkX16tiELH 7ZkhSYdW 4+I/qDQTAy3z0MvJ4Yk6YpTq3m84FPpi/1F70U/kife3o+8D/Oeqq2QhfQBf/gV6VPtvP14ZbFYqj+8KHfUfCBz+Mvd1SJVxt8QF2+W8BxUKLKSdgagFRjsnVy6NooCj2ztxht9KguFQeVpVsjQFB1RpuvTonOrCc8xCm6eiP97/+wgUNnyr5GS5/oIZyB/9jPvyTCHs8KibpoIgwc9Dxg/Ual/GtMIAwIjcH98UOxxrzHeKWVToSxjBvdI9t1/MXSZki3r9+McGyWkTxOi2sxuCDja7xpVWNxNPu9Us05YhFU78PHclNzf3F1SGzena9Ot7tWmT9rBKZupXJVyE6aySrzr8GOqHD0Oz0q7oWSpVJjnky8oZXb0GNr0Ka+E8agdeZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Add yet another representation of the access rate of each region, namely nr_accesses_bp. It is just same to the nr_accesses but represents the value in basis point (1 in 10,000), and updated at once in every aggregation interval. That is, moving_accesses_bp is just nr_accesses * 10000. This may seems useless at the moment. However, it will be useful for representing less than one nr_accesses value that will be needed to make moving sum-based nr_accesses. Signed-off-by: SeongJae Park --- include/linux/damon.h | 5 +++++ mm/damon/core-test.h | 5 +++++ mm/damon/core.c | 6 ++++++ 3 files changed, 16 insertions(+) diff --git a/include/linux/damon.h b/include/linux/damon.h index 487a545a11b4..15f24b23c9a0 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -40,6 +40,7 @@ struct damon_addr_range { * @ar: The address range of the region. * @sampling_addr: Address of the sample for the next access check. * @nr_accesses: Access frequency of this region. + * @nr_accesses_bp: @nr_accesses in basis point (0.01%). * @list: List head for siblings. * @age: Age of this region. * @@ -49,6 +50,9 @@ struct damon_addr_range { * not be done with direct access but with the helper function, * damon_update_region_access_rate(). * + * @nr_accesses_bp is another representation of @nr_accesses in basis point + * (1 in 10,000) that updated every aggregation interval. + * * @age is initially zero, increased for each aggregation interval, and reset * to zero again if the access frequency is significantly changed. If two * regions are merged into a new region, both @nr_accesses and @age of the new @@ -58,6 +62,7 @@ struct damon_region { struct damon_addr_range ar; unsigned long sampling_addr; unsigned int nr_accesses; + unsigned int nr_accesses_bp; struct list_head list; unsigned int age; diff --git a/mm/damon/core-test.h b/mm/damon/core-test.h index c539f0e8377e..79f1f12e0dd5 100644 --- a/mm/damon/core-test.h +++ b/mm/damon/core-test.h @@ -94,6 +94,7 @@ static void damon_test_aggregate(struct kunit *test) for (ir = 0; ir < 3; ir++) { r = damon_new_region(saddr[it][ir], eaddr[it][ir]); r->nr_accesses = accesses[it][ir]; + r->nr_accesses_bp = accesses[it][ir] * 10000; damon_add_region(r, t); } it++; @@ -147,9 +148,11 @@ static void damon_test_merge_two(struct kunit *test) t = damon_new_target(); r = damon_new_region(0, 100); r->nr_accesses = 10; + r->nr_accesses_bp = 100000; damon_add_region(r, t); r2 = damon_new_region(100, 300); r2->nr_accesses = 20; + r2->nr_accesses_bp = 200000; damon_add_region(r2, t); damon_merge_two_regions(t, r, r2); @@ -196,6 +199,7 @@ static void damon_test_merge_regions_of(struct kunit *test) for (i = 0; i < ARRAY_SIZE(sa); i++) { r = damon_new_region(sa[i], ea[i]); r->nr_accesses = nrs[i]; + r->nr_accesses_bp = nrs[i] * 10000; damon_add_region(r, t); } @@ -297,6 +301,7 @@ static void damon_test_update_monitoring_result(struct kunit *test) struct damon_region *r = damon_new_region(3, 7); r->nr_accesses = 15; + r->nr_accesses_bp = 150000; r->age = 20; new_attrs = (struct damon_attrs){ diff --git a/mm/damon/core.c b/mm/damon/core.c index b005dc15009f..ce85c00b0a4c 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -128,6 +128,7 @@ struct damon_region *damon_new_region(unsigned long start, unsigned long end) region->ar.start = start; region->ar.end = end; region->nr_accesses = 0; + region->nr_accesses_bp = 0; INIT_LIST_HEAD(®ion->list); region->age = 0; @@ -508,6 +509,7 @@ static void damon_update_monitoring_result(struct damon_region *r, { r->nr_accesses = damon_nr_accesses_for_new_attrs(r->nr_accesses, old_attrs, new_attrs); + r->nr_accesses_bp = r->nr_accesses * 10000; r->age = damon_age_for_new_attrs(r->age, old_attrs, new_attrs); } @@ -1115,6 +1117,7 @@ static void damon_merge_two_regions(struct damon_target *t, l->nr_accesses = (l->nr_accesses * sz_l + r->nr_accesses * sz_r) / (sz_l + sz_r); + l->nr_accesses_bp = l->nr_accesses * 10000; l->age = (l->age * sz_l + r->age * sz_r) / (sz_l + sz_r); l->ar.end = r->ar.end; damon_destroy_region(r, t); @@ -1138,6 +1141,8 @@ static void damon_merge_regions_of(struct damon_target *t, unsigned int thres, else r->age++; + r->nr_accesses_bp = r->nr_accesses * 10000; + if (prev && prev->ar.end == r->ar.start && abs(prev->nr_accesses - r->nr_accesses) <= thres && damon_sz_region(prev) + damon_sz_region(r) <= sz_limit) @@ -1186,6 +1191,7 @@ static void damon_split_region_at(struct damon_target *t, new->age = r->age; new->last_nr_accesses = r->last_nr_accesses; + new->nr_accesses_bp = r->nr_accesses_bp; damon_insert_region(new, r, damon_next_region(r), t); }