From patchwork Mon Sep 18 07:47:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 13389076 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FD44CD37B0 for ; Mon, 18 Sep 2023 07:48:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17FB06B02A9; Mon, 18 Sep 2023 03:48:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1066F6B02AB; Mon, 18 Sep 2023 03:48:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F11D96B02AA; Mon, 18 Sep 2023 03:48:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DC1B96B02A6 for ; Mon, 18 Sep 2023 03:48:54 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B23CF1A034A for ; Mon, 18 Sep 2023 07:48:54 +0000 (UTC) X-FDA: 81248941788.03.94FF27D Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf17.hostedemail.com (Postfix) with ESMTP id 614D840020 for ; Mon, 18 Sep 2023 07:48:50 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of ruanjinjie@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=ruanjinjie@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695023333; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pR16u9YSxxcuK6qoS689DOIWQQZebVrEutP1giBVzpg=; b=XmybCExYp2JMCaBGSCQw9lDmOl4OxmcS69Be/i9jR+6NrViZs1y4z0I8i4uDPmX2XlqdQH Hz2yrKErrRdZpmeZKAZw3Xz1C/X0i6JGEpETS1s3IrPrEGeYM8owF1A4zMwLaoW17xJigT /oRftVUTb7ey44UvPXKKTZFkOj3RW0E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695023333; a=rsa-sha256; cv=none; b=IyXIVVNwYiT1BRE+5/Es3X3hb2TAcvjx9zGYJlAN0HCp+F33WTt3QqLISBAb49JJ2jEUbk u74SWsW13oN3BrfvzrSKjgcuRzcH1iudGsXz0qj08teWcI0K/Ll/FYU6eU94baFz975BTy 7+Wg0S/9lnc//cRiX764u+uMR+2JvwM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of ruanjinjie@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=ruanjinjie@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Rpxh04pc7zrShj; Mon, 18 Sep 2023 15:46:40 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 18 Sep 2023 15:48:43 +0800 From: Jinjie Ruan To: , , , , , , , , CC: Subject: [PATCH v2 2/2] mm/damon/core-test: Fix memory leak in damon_new_ctx() Date: Mon, 18 Sep 2023 15:47:59 +0800 Message-ID: <20230918074759.3895339-3-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230918074759.3895339-1-ruanjinjie@huawei.com> References: <20230918074759.3895339-1-ruanjinjie@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 614D840020 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ki3gjq8czzgy1oqizpckzof9hmghn5u7 X-HE-Tag: 1695023330-54247 X-HE-Meta: U2FsdGVkX19sw6KExYn70T7ooPXy4NzVFsnQi4a5WzvUaEBMdddlZCqgetffa7rW/92HDQPQxO4EpCKAdRaJVoqa/mcaDbSB8T6g5VGIcpKdfQloPn/xa9xMQqvlM/9wxLT53xRntCwaF5AcZboLxa7wcZzRLKCPLCoRjMpfx/glXGNmflE0+uCtQm3NE2C3rKiNG0ob3LhPwCD0q/Fu+d7PB/wq3iXz9RaHrlbnB9sGYXMnjJZMwMKeMm6A52dxK1LKhFSMNz3z6mVFWe0q/tyqVKgGodZg9q8haPOGqxwWGHkijaCtr7ANKZ3Wab9yHgc4VBE0ykRwohvtwz+cXMMevERVezp2XfogO37orF7bJUeZt8x5VwTcNAAdoRubOIL5Wwuh9UNID5r/NDZHhImyg5Mb9vHl09xi/n1z8FSfZzMVRvbXPoY7VQB00M6HF1un5O6J7GM3vRRBR/r6a36HYcQiXPb+5/MVHC2cT0Xac82Si03dmGk5fJvKazFly6piM7fh/At/XV677XFcVkaC2Ty4MPWWHJk8g2a+bDaP6WnbWxSevDwizRCnyPJxSyzLusloQPl9jWUHbH5lXqhDNNjgq5A7DksvkwwVGPUnTPmM9Woniplhx/DmLgCBpByVz2xm3thCtYy830ai/wiVSM81pip90CVuhb0HLtB1Ub3wgasNokryJcTicFSokYqXzAyQrRw1f+Yc87CfxcjQV2il0Bl+LVkHj+33xb2bqj3jWotl+Jo7RB9kQVehGYF4UGKuABZFUHQxEmzcsVHSkTBhQMJZxlRKr8/NiPp2cXegq2dR2sjskhzfALG0sw0wrpzzOE4TXEQqNfcThgeCXovM+ZdzTfXIAw5v8eLDE7Etl9SK41lkXNAGFn36nXMJHS0rOLMKzzlYC482LrklRya4it8VUPBeEwYRI8/zXDXYyrKEy6CttTq9mIDX/epsuQe/PrNivr33u4U YtTnLH7Y AAkK19Zzl6i1xqhfjhL8/3mdvKy6ZYAmnj6kjOkCPyisyzMMTYj2A+tFzabKGE96bnUvZ4gfC7zJLdfpxzxBUZB2/rk8LZAK4ImaE9DL1PAnaNKBdZaLhrEa3FCkaWSdUDcG8H9rxzPrpKcG29EE6vGXo7lYjY2XXLX2Ppa2JXqJEktzgNdF61l5FoWTyTyKXzaimKf3CVDoVMP5njk/3Wa3zXw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When CONFIG_DAMON_KUNIT_TEST=y and making CONFIG_DEBUG_KMEMLEAK=y and CONFIG_DEBUG_KMEMLEAK_AUTO_SCAN=y, the below memory leak is detected. The damon_ctx which is allocated by kzalloc() in damon_new_ctx() in damon_test_ops_registration() and damon_test_set_attrs() are not freed. So use damon_destroy_ctx() to free it. After applying this patch, the following memory leak is never detected unreferenced object 0xffff2b49c6968800 (size 512): comm "kunit_try_catch", pid 350, jiffies 4294895294 (age 557.028s) hex dump (first 32 bytes): 88 13 00 00 00 00 00 00 a0 86 01 00 00 00 00 00 ................ 00 87 93 03 00 00 00 00 0a 00 00 00 00 00 00 00 ................ backtrace: [<0000000088e71769>] slab_post_alloc_hook+0xb8/0x368 [<0000000073acab3b>] __kmem_cache_alloc_node+0x174/0x290 [<00000000b5f89cef>] kmalloc_trace+0x40/0x164 [<00000000eb19e83f>] damon_new_ctx+0x28/0xb4 [<00000000daf6227b>] damon_test_ops_registration+0x34/0x328 [<00000000559c4801>] kunit_try_run_case+0x50/0xac [<000000003932ed49>] kunit_generic_run_threadfn_adapter+0x20/0x2c [<000000003c3e9211>] kthread+0x124/0x130 [<0000000028f85bdd>] ret_from_fork+0x10/0x20 unreferenced object 0xffff2b49c1a9cc00 (size 512): comm "kunit_try_catch", pid 356, jiffies 4294895306 (age 557.000s) hex dump (first 32 bytes): 88 13 00 00 00 00 00 00 a0 86 01 00 00 00 00 00 ................ 00 00 00 00 00 00 00 00 0a 00 00 00 00 00 00 00 ................ backtrace: [<0000000088e71769>] slab_post_alloc_hook+0xb8/0x368 [<0000000073acab3b>] __kmem_cache_alloc_node+0x174/0x290 [<00000000b5f89cef>] kmalloc_trace+0x40/0x164 [<00000000eb19e83f>] damon_new_ctx+0x28/0xb4 [<00000000058495c4>] damon_test_set_attrs+0x30/0x1a8 [<00000000559c4801>] kunit_try_run_case+0x50/0xac [<000000003932ed49>] kunit_generic_run_threadfn_adapter+0x20/0x2c [<000000003c3e9211>] kthread+0x124/0x130 [<0000000028f85bdd>] ret_from_fork+0x10/0x20 Fixes: d1836a3b2a9a ("mm/damon/core-test: initialise context before test in damon_test_set_attrs()") Fixes: 4f540f5ab4f2 ("mm/damon/core-test: add a kunit test case for ops registration") Signed-off-by: Jinjie Ruan Reviewed-by: Feng Tang Reviewed-by: SeongJae Park --- v2: - Add Reviewed-by. - Rebased on mm-unstable. - Update the commit message. --- mm/damon/core-test.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mm/damon/core-test.h b/mm/damon/core-test.h index 3959be35b901..649adf91ebc5 100644 --- a/mm/damon/core-test.h +++ b/mm/damon/core-test.h @@ -269,6 +269,8 @@ static void damon_test_ops_registration(struct kunit *test) /* Check double-registration failure again */ KUNIT_EXPECT_EQ(test, damon_register_ops(&ops), -EINVAL); + + damon_destroy_ctx(c); } static void damon_test_set_regions(struct kunit *test) @@ -346,6 +348,8 @@ static void damon_test_set_attrs(struct kunit *test) invalid_attrs = valid_attrs; invalid_attrs.aggr_interval = 4999; KUNIT_EXPECT_EQ(test, damon_set_attrs(c, &invalid_attrs), -EINVAL); + + damon_destroy_ctx(c); } static void damon_test_moving_sum(struct kunit *test)