From patchwork Wed Sep 20 06:18:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Huang, Ying" X-Patchwork-Id: 13392115 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EC16CE79AC for ; Wed, 20 Sep 2023 06:20:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E626B6B0119; Wed, 20 Sep 2023 02:20:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E13E46B011A; Wed, 20 Sep 2023 02:20:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB4546B011B; Wed, 20 Sep 2023 02:20:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B59206B0119 for ; Wed, 20 Sep 2023 02:20:07 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8429781060 for ; Wed, 20 Sep 2023 06:20:07 +0000 (UTC) X-FDA: 81255975654.21.3659726 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by imf29.hostedemail.com (Postfix) with ESMTP id 74AB212001A for ; Wed, 20 Sep 2023 06:20:05 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=EJur15Bd; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf29.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695190805; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UIyhaTtMVzkd1JNxNHUm6Tdf0oFtWg8xOLzRvYoLm7Q=; b=qtfqcobOs0RkmfdOukiHS4Q/ooUT6PQLBf7X07BwSDYRbDzJp8oq66ZQEHZVt324qrgksP tAyTZhpqucANuVy/6MFS6L0Q/wxLEylcelCRyy/NpYpsO07CEyZDGiObgKE/vkvhXPhax1 McB1NBsvgDLXd9TeDnIaECdBLN0Nx38= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=EJur15Bd; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf29.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695190805; a=rsa-sha256; cv=none; b=jYt6fiubjm1YoXzj4ufXJKoLV1eElOkfHUYt/B3H5+2TgsE4VYI1on5lIoXfF9N/ErlVMi lPEVXYmHntLFZt3h1JHW+NN19Advseoh20MpolmOJn/RN1Ufw0hYvoUqSQXOdgu505q74o FR6PaMn01KGeyAci6Q1uO1NSw0O/EAc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695190805; x=1726726805; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6W6lJyCPE2vK1mxwG+RBHDFX6xtr7yfsoTDfDpxDR10=; b=EJur15BdL1AofMJxC1dgVPzOu6jkqI1uiiSu9QDQNm5rjdI5ghObtCnU B7sqjN0uTlMAwW35J2+xf9TapE76cyd799uZ/I6PdNc2PEJoj6TAVyfnO Ev2Y/Rs7a4OZhQOfH/qL44GVwcHdPY+ZXJ1v3VKSw7kbP++jX+B67BQTR 3uKUdKzTzerKd44k2sBrekpfIlEqJsKSM7QNcl+lCMkUIBTOuRJj/pk0S V/VbAVmsiWm2BvCp4kjK6iNRslW0sdw+bq7jpfOECMJkW8GxBbWi9gunP hMhDqMRb9HQ2TDSV2gdwpk2KfweKTC+H+cdR87sSmEtW2VKULP2Y3EEZM g==; X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="365187766" X-IronPort-AV: E=Sophos;i="6.02,161,1688454000"; d="scan'208";a="365187766" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2023 23:20:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="740060665" X-IronPort-AV: E=Sophos;i="6.02,161,1688454000"; d="scan'208";a="740060665" Received: from yhuang6-mobl2.sh.intel.com ([10.238.6.133]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2023 23:20:01 -0700 From: Huang Ying To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Arjan Van De Ven , Huang Ying , Andrew Morton , Mel Gorman , Vlastimil Babka , David Hildenbrand , Johannes Weiner , Dave Hansen , Michal Hocko , Pavel Tatashin , Matthew Wilcox , Christoph Lameter Subject: [PATCH 08/10] mm, pcp: decrease PCP high if free pages < high watermark Date: Wed, 20 Sep 2023 14:18:54 +0800 Message-Id: <20230920061856.257597-9-ying.huang@intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230920061856.257597-1-ying.huang@intel.com> References: <20230920061856.257597-1-ying.huang@intel.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 74AB212001A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ze6ornsz6j46w563gq9mruwee1f4wxm8 X-HE-Tag: 1695190805-892348 X-HE-Meta: U2FsdGVkX1+SfIcJ4dbiOsgcpv4+X18zu8HyJw/X30QJWnUZTjAQTEiIi5d3np9e+TX+rQPTwMTBO/VlctW0KxKMfy3aPwLi/LXLU4/k5us0n8MAfLwBz/iNoIrlPh+IUX4TnUNSi4y+9g9O75wNlUoiFINWS7++Ai1rLyj2CKSeAMwmY2OPt5dMHljn7VHwCBgnY+JUvBSkJ9lfSklywLJLpe2dYrUOi3qkH3s5FeptDKfpesft5qLWUcFMAXxRqe2rbilz597u7mO3Ouf9G+0syTHGWTil+7GavYtrPFEp2Z9hdqvgCMCUkvOC4yeqakHHSbxwf2zji56/Hcty7JWxE3QODI7ZVt0a43nwgluhxbj0E7QkRvuDD6BH9MJe7lVYLprk6r1eyBM1lXHxPDk3g/kgMhjdPDqfJaSsmHjOBiWMlrUQG7vxetYPZYgIBcpqsqt0Dz6d7KTm8xQ1fL51X4YFe/mJOuMMjkD86auOgIS8aMIlhBmeloi/V4H5f2Ch3LmQ5PCUwJbOVxVDDRDwGLzRYcB+4AutVAneFdgHvOEWOqv12248D8wyjOMozdBeUJCt51vvxEJzOO6GN9zmRwn7NqWWBqCUXRdd4nJpco6oTK8F2CRSd3wkOAhvDbkf2TgR8nxOfeKZieiYtSOpbKWEEThrcxsU7z86rj6jQpUEtr1mNoZlmjXoD32R91dPSrKft2ZQliGU+sTDHYqC9nyfhZeHKfDNewab5TZNxuwUQes02FJxQpdwQaoAeNDQTAVKc1y1pfOckVRutmBy5orktIIRW/GCJgeISXMFYzpaBWJ0e1tJO7/hA6JtXAYYTh1TmboDx6J4cc+aOt6fVr6/QvxRQOPQHVEsn45v7SQ1uUxIcK87PAmZMrVKVHusjpyNO7TnWJesOo+obljBqGiNvchXFqXS990ZIBgcibCr1jnDsn+9+z0calVEX4hgAyLg497HQcy083Z dP+qB/UH HoFAplInxtToM2VsBvopLaCaHrxxYyCifQBcHJmSkZ75YM2TsVnt1niICtTNKQyLeJv+xvUitdJEG4LfzA17KmBxD3K8CPdN9JFL6u4DtSH1QgwR33l8cPF2aZOjbLGE8QyO+9UNFwroce15QoBMdlRVsbogZBlv0Q0e30qWTWJuKC5BSfp6olKS9/3f6bZE5f4sNphJg3oSlA0YF2Eg+Z8D7HOdA0aAuuih/NllusPxiCXVhWuBwnGAyHLTYFWSVm20d3QDhBd+84x0jdCsPuWP9DYOXmgm+OxtcTDOBEyXSGhwD4tZowcNu8fkTyoNisRSdtAGm1xxqNaUFHbMhbI59K9IKyJPqYfYQ6SKLIjzoIyVJJ/H1eT0hvhOX/c2hf/7ZUqnJUK6LVg+0voUPWP9ofnYR67ugX0veJ8FNAeGvKtzlaw8le55gy+rakziMHzhneAG4dwh+PgziYIVI09x3joaUvenQ5Ly0EE6KJ68/5FxERcoxW2BccAOgSsc1X7F1cNBnp8XcXQefk10FtS+5s3XHvIPL0FFb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: One target of PCP is to minimize pages in PCP if the system free pages is too few. To reach that target, when page reclaiming is active for the zone (ZONE_RECLAIM_ACTIVE), we will stop increasing PCP high in allocating path, decrease PCP high and free some pages in freeing path. But this may be too late because the background page reclaiming may introduce latency for some workloads. So, in this patch, during page allocation we will detect whether the number of free pages of the zone is below high watermark. If so, we will stop increasing PCP high in allocating path, decrease PCP high and free some pages in freeing path. With this, we can reduce the possibility of the premature background page reclaiming caused by too large PCP. The high watermark checking is done in allocating path to reduce the overhead in hotter freeing path. Signed-off-by: "Huang, Ying" Cc: Andrew Morton Cc: Mel Gorman Cc: Vlastimil Babka Cc: David Hildenbrand Cc: Johannes Weiner Cc: Dave Hansen Cc: Michal Hocko Cc: Pavel Tatashin Cc: Matthew Wilcox Cc: Christoph Lameter --- include/linux/mmzone.h | 1 + mm/page_alloc.c | 22 ++++++++++++++++++++-- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index d6cfb5023f3e..8a19e2af89df 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h @@ -1006,6 +1006,7 @@ enum zone_flags { * Cleared when kswapd is woken. */ ZONE_RECLAIM_ACTIVE, /* kswapd may be scanning the zone. */ + ZONE_BELOW_HIGH, /* zone is below high watermark. */ }; static inline unsigned long zone_managed_pages(struct zone *zone) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 225abe56752c..3f8c7dfeed23 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -2409,7 +2409,13 @@ static int nr_pcp_high(struct per_cpu_pages *pcp, struct zone *zone, return min(batch << 2, pcp->high); } - if (pcp->count >= high && high_min != high_max) { + if (high_min == high_max) + return high; + + if (test_bit(ZONE_BELOW_HIGH, &zone->flags)) { + pcp->high = max(high - (batch << pcp->free_factor), high_min); + high = max(pcp->count, high_min); + } else if (pcp->count >= high) { int need_high = (batch << pcp->free_factor) + batch; /* pcp->high should be large enough to hold batch freed pages */ @@ -2459,6 +2465,10 @@ static void free_unref_page_commit(struct zone *zone, struct per_cpu_pages *pcp, if (pcp->count >= high) { free_pcppages_bulk(zone, nr_pcp_free(pcp, batch, high, free_high), pcp, pindex); + if (test_bit(ZONE_BELOW_HIGH, &zone->flags) && + zone_watermark_ok(zone, 0, high_wmark_pages(zone), + ZONE_MOVABLE, 0)) + clear_bit(ZONE_BELOW_HIGH, &zone->flags); } } @@ -2765,7 +2775,7 @@ static int nr_pcp_alloc(struct per_cpu_pages *pcp, struct zone *zone, int order) * If we had larger pcp->high, we could avoid to allocate from * zone. */ - if (high_min != high_max && !test_bit(ZONE_RECLAIM_ACTIVE, &zone->flags)) + if (high_min != high_max && !test_bit(ZONE_BELOW_HIGH, &zone->flags)) high = pcp->high = min(high + batch, high_max); if (!order) { @@ -3226,6 +3236,14 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags, } } + mark = high_wmark_pages(zone); + if (zone_watermark_fast(zone, order, mark, + ac->highest_zoneidx, alloc_flags, + gfp_mask)) + goto try_this_zone; + else if (!test_bit(ZONE_BELOW_HIGH, &zone->flags)) + set_bit(ZONE_BELOW_HIGH, &zone->flags); + mark = wmark_pages(zone, alloc_flags & ALLOC_WMARK_MASK); if (!zone_watermark_fast(zone, order, mark, ac->highest_zoneidx, alloc_flags,