From patchwork Thu Sep 21 11:04:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 13393858 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD608E70719 for ; Thu, 21 Sep 2023 11:04:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78A6A6B0200; Thu, 21 Sep 2023 07:04:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 739CA6B0203; Thu, 21 Sep 2023 07:04:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 628FA6B020E; Thu, 21 Sep 2023 07:04:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 52D186B0200 for ; Thu, 21 Sep 2023 07:04:49 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 30C82808B6 for ; Thu, 21 Sep 2023 11:04:49 +0000 (UTC) X-FDA: 81260321898.15.5F6BAD7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 39F5240013 for ; Thu, 21 Sep 2023 11:04:47 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AMxZCFTq; spf=pass (imf01.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695294287; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8AP4WAkfm0g8fnMPEPLH78szMDWqxElEcpAiYehWd/g=; b=RZ2Iul435LDQYwcJXiMQJGk6ILrFh2HcJbyaOIpIoQU+NAF19Dy97co4rMnPvwgSTM1Ars QFi+X1TYAQ6ba3QvbXhpKo1TCUvTKfZOIJO0vr+v+DIn0bS/BRt6KgXlddCDTdmhiMfGy/ R4d9WXhTiJIvtvOzlPe1D3xqXZeeNMk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695294287; a=rsa-sha256; cv=none; b=jlRuu4FwIcYnWKoP+RfZl5yzmRncAoKN6hUOi/D7L2bsyWsN/rtm7lPZ/VfajEzUSp/TRK PAOe4mVCoeKaPfAZ6eksrI7UsOKjSijIN5X+I/0TC7oQvv34TjMv6Hs7RdE4o64VAtSKQU GuNOrc6nlvlwjShabKABPoE1D/F6pYU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AMxZCFTq; spf=pass (imf01.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695294286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8AP4WAkfm0g8fnMPEPLH78szMDWqxElEcpAiYehWd/g=; b=AMxZCFTqrs0BHN48xSc4N61K2WV+bdtGaHTFo9qMYfvBL2X7hpYNOzA3R9SwtUNG/CNlBg hQ/g2nIAeCWsUil8Hwba1Ed5KbmgM1rU9Kcj06gyb4HYRbWVADl32VN9tlAMnnIYh3TB1S YCAC9aJAiMuYQNHPWkPWbes70+Rtyno= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-584-Ku-6zn3_OjOqTQ_ymnSqzQ-1; Thu, 21 Sep 2023 07:04:42 -0400 X-MC-Unique: Ku-6zn3_OjOqTQ_ymnSqzQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6C410185A79B; Thu, 21 Sep 2023 11:04:41 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (unknown [10.72.112.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id C03FF2156711; Thu, 21 Sep 2023 11:04:34 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, arnd@arndb.de, jiaxun.yang@flygoat.com, mpe@ellerman.id.au, geert@linux-m68k.org, mcgrof@kernel.org, hch@infradead.org, tsbogend@alpha.franken.de, f.fainelli@gmail.com, deller@gmx.de, Baoquan He , Thomas Zimmermann , Christophe Leroy , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH v5 1/4] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64 Date: Thu, 21 Sep 2023 19:04:21 +0800 Message-ID: <20230921110424.215592-2-bhe@redhat.com> In-Reply-To: <20230921110424.215592-1-bhe@redhat.com> References: <20230921110424.215592-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspamd-Queue-Id: 39F5240013 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: unoraso9m67qjmkdkc9947y76k3ccusr X-HE-Tag: 1695294287-966022 X-HE-Meta: U2FsdGVkX1+rrkRpQzkAw0E7BwEEB5PT96F0XDuBlUNo5MeG6UjGRiZ8dXPlUNvwuQ1OxYytcFVl0/AAGofB4FexqZECFzn40HlMeonTUS/iF4pIStivcJJ91WlKsPB1fpQNRA44etzPWpxwk3GRIvsJoyZO/16fkheYYd1jvUOKOScqL9FZ5BKewVuJy2u0ean/2NaAOhWvdZmNoutlN8Nrp8/pexrQwWpw2GTZmYUThbIAXxSKSqDwXe8hcxeAvmjSz3wvSumi8K2Y6V3nZkXHPxnT51B1+3Ep8N0q1X/csPIRmfEx0eskV0y+nnjiT+cGqpF51RKD1PqnJg42TpTB+5jqIScsz7lntWBvLRSOshRwzdMt6/q9xw2MH7D/1QNTxChvlOYVDtmRjI2htT4AfAognxFwCRCWtTdwsFWCFjABoLDqn8P/3QIHX3802qk75/bJPRZycCqnV8M3lKpp1RByPMFg5Q80Rtq0Cd+SjL3fQLl3cuHCaQrSgXUmJ20vd0borRx+ptTSd1u2mYZoY9OM0fcf/uZmXTjy8QINEENKPIoSnRZC4BbfqlXci/ElIlBBGgwbQtUE2Zqxr3D4ZLkRgpj9Dpt8hleUn1JuAYfsPSpA8ZxkyZIXuGOBEFL09loAqwB9uYEORQXoC5pT8udFqrJy3kf9C3t4b42Kg/OmtvvF1bTyLNP8U0/VosNTCPxsMW1eDWif8/edET/sdkonT/3Ulap0kHrgXhriHVGFeR7xRokbcsKG4S3eUad0KT7M53sTlqaLXLbaqMZ6UbO8/SXXgXkf9Zclw1mtAJWCu2f1JcZ73lh+FayhJDaSDdf/Txxmm92kYfubzvCce8BEjJvJ3HOwJJseuWzW+0lpZ5hiftpYsRyMUmx7WB4E1MFtkMSnS6Xu3//ZPxYQCkT/3OX0+fJ4vNoIYvC+59r7Z9a6/pMT85LUkx5338gF2EK8aGzTsKKw6u8 yl5K64qR W+Aynv8J8W02MFZ8iT93wGwXCKzzAL6iPizQ8+uLugfgy1pRDJNpJKCEr+9t78yqSnTbcGcHh3bJSjrj7X4fDQEmw0EjQUrYH9oBJYutTTcFMDc1fmzrqWy/HJGfXlycG6AAtGzDF6GI92bF3qHCrBnNA2+YpJeAJuiK7DPx6+TM/uINQ8KK7UamE44+lpexST8W4pJi5jUNPAi6sc194INjMTjyHYLqzD0Ykr8ilz5ANl9vJEI5mxltrLrZOHTtWVRnjcViJF6E7pPavHO3MAV5xFpCj0vxM0UzdctqgksEhiCWpJUetkTFTutxIJV8zBOL894ClPSzKsX9HnHxXPIdHl9u8+hI8hALdrNipt/s6NYgbL2SnhC38wUkofZqHlVwj7cOud7mH0kt/WXGLWs+DFl9iRSjBASH0X2VrECJMKk83mflfoP3kshsI6olX5LUFk+pSWGjSqobi2gp2CuHMcA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Arnd Bergmann ioremap_uc() is only meaningful on old x86-32 systems with the PAT extension, and on ia64 with its slightly unconventional ioremap() behavior, everywhere else this is the same as ioremap() anyway. Change the only driver that still references ioremap_uc() to only do so on x86-32/ia64 in order to allow removing that interface at some point in the future for the other architectures. On some architectures, ioremap_uc() just returns NULL, changing the driver to call ioremap() means that they now have a chance of working correctly. Signed-off-by: Arnd Bergmann Signed-off-by: Baoquan He Reviewed-by: Luis Chamberlain Cc: Helge Deller Cc: Thomas Zimmermann Cc: Christophe Leroy Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org --- drivers/video/fbdev/aty/atyfb_base.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c index 5c87817a4f4c..3dcf83f5e7b4 100644 --- a/drivers/video/fbdev/aty/atyfb_base.c +++ b/drivers/video/fbdev/aty/atyfb_base.c @@ -3440,11 +3440,15 @@ static int atyfb_setup_generic(struct pci_dev *pdev, struct fb_info *info, } info->fix.mmio_start = raddr; +#if defined(__i386__) || defined(__ia64__) /* * By using strong UC we force the MTRR to never have an * effect on the MMIO region on both non-PAT and PAT systems. */ par->ati_regbase = ioremap_uc(info->fix.mmio_start, 0x1000); +#else + par->ati_regbase = ioremap(info->fix.mmio_start, 0x1000); +#endif if (par->ati_regbase == NULL) return -ENOMEM;