From patchwork Tue Oct 17 05:44:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Verma, Vishal L" X-Patchwork-Id: 13424459 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0FC2CDB484 for ; Tue, 17 Oct 2023 05:45:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F21E8002E; Tue, 17 Oct 2023 01:45:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09F5D8002D; Tue, 17 Oct 2023 01:45:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0F3B8002E; Tue, 17 Oct 2023 01:45:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CCF5C8002D for ; Tue, 17 Oct 2023 01:45:13 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id ADD39B61E5 for ; Tue, 17 Oct 2023 05:45:13 +0000 (UTC) X-FDA: 81353865306.30.AF924D7 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by imf23.hostedemail.com (Postfix) with ESMTP id 65617140003 for ; Tue, 17 Oct 2023 05:45:11 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=i2rv9lzc; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf23.hostedemail.com: domain of vishal.l.verma@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=vishal.l.verma@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697521511; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=veuv5HqD7AFEWi54guoE5dRp2blStvCKXb9PZntf1Gk=; b=UL8pz3b1pOQUnYsMXDP95IhLfrLCFIFhaurMCQLiky3oOZJAZ3IrIaT9zrcWZ8yojK/xvq h+ZLpH/rqCYW524ZA70fJreuyZFhHl16EhJxp3vnVHQUUoa6FxGUxOgENL1M/3mLvcEZv7 djaIUsOPB0DQPoc/VhmuyiXvFht42Uo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=i2rv9lzc; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf23.hostedemail.com: domain of vishal.l.verma@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=vishal.l.verma@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697521511; a=rsa-sha256; cv=none; b=gdDXvdeKT7eQ81ZIkPGiR5mJUZ7wOjQANQXhbtBSf2wbiflDdRtRhZKzHiKlHa09O1ohhb 1E2zRy+OKk5tM4Lp+szTWgfce/jERdaetny/jJQlkPGr2yWSADiBcj6acm2UyHYSrMng9W +5bEiwrhDfBL6j/X9sSUkgHnVUB3Il4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697521511; x=1729057511; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=mEPqGi0w6uK1G2oMRp9GXgOlOlinp7OhMTBnsnQmtwo=; b=i2rv9lzcNffarA45XHe3wM8F1QBkNF+tRayBQoa0HNp5l+UpcqbClHf1 FlLDk0U44EAgfzsE+zdPY560ACSJVKkP7An9m0XqMjwbTaGtLmbIIvAab wGcIQOfbY3XGKQ8lemjo5wsisep27CZexHN8/aDGfGSY+XNPkAqGnPM9w iSHCi83LSdi7Z2cZA5QwdIFMbjST/kximI2Zhvy3GvjgxzEp7HC53JX98 nusO15gSpOQIuv95N+tts5J5hPzvdc5nTjMCJVWkPNYqHLqmnXTEbnEZr ywBYHWgLHv2uFmw9W4q1xEIQ+PAUl1yXihI2tV0vHNRDfMDQXfSF+vmRA A==; X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="384580773" X-IronPort-AV: E=Sophos;i="6.03,231,1694761200"; d="scan'208";a="384580773" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2023 22:45:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="879694030" X-IronPort-AV: E=Sophos;i="6.03,231,1694761200"; d="scan'208";a="879694030" Received: from mjwirth-mobl.amr.corp.intel.com (HELO [192.168.1.200]) ([10.209.151.162]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2023 22:45:04 -0700 From: Vishal Verma Date: Mon, 16 Oct 2023 23:44:57 -0600 Subject: [PATCH v6 3/3] dax/kmem: allow kmem to add memory with memmap_on_memory MIME-Version: 1.0 Message-Id: <20231016-vv-kmem_memmap-v6-3-078f0d3c0371@intel.com> References: <20231016-vv-kmem_memmap-v6-0-078f0d3c0371@intel.com> In-Reply-To: <20231016-vv-kmem_memmap-v6-0-078f0d3c0371@intel.com> To: Andrew Morton , David Hildenbrand , Oscar Salvador , Dan Williams , Dave Jiang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Huang Ying , Dave Hansen , "Aneesh Kumar K.V" , Michal Hocko , Jonathan Cameron , Jeff Moyer , Vishal Verma , Jonathan Cameron X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4972; i=vishal.l.verma@intel.com; h=from:subject:message-id; bh=mEPqGi0w6uK1G2oMRp9GXgOlOlinp7OhMTBnsnQmtwo=; b=owGbwMvMwCXGf25diOft7jLG02pJDKl68jEzt8d3qO3/2R3M0dv+gfv651PmOwQzOZilr5kzn l/89seZjlIWBjEuBlkxRZa/ez4yHpPbns8TmOAIM4eVCWQIAxenAEwkbgkjw7E7Lm+Z2b88qLgv Enox7OdGbbO9nLmXTvo+nsDxxX1WbCDD/7RVxdElk1n/SNmXxwW82D9HtfDNb3vGQlunA9vfr31 +mQcA X-Developer-Key: i=vishal.l.verma@intel.com; a=openpgp; fpr=F8682BE134C67A12332A2ED07AFA61BEA3B84DFF X-Rspamd-Queue-Id: 65617140003 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 9nbbtxxxnngk8owxhqoezmr3w98sjtsm X-HE-Tag: 1697521511-410577 X-HE-Meta: U2FsdGVkX1+EttaZBvlArNqN9bU3BypmNpbUYJ5sBtql514yO5M4PGKIeEPZBgUZgltLHi7J1Qf4758Du5nnThU7i171UyBxVrqUQ9Vr5P4dwJWTGYLHifLTSxC37DAFzrQjFphNrwlmqZCa39eDd0IHqW7SVp/KZsENOwnLvGExRzn+qDL97HaVjEpv7BfStoHz4nhTj6gkIxf+jEsQqkcue4BajD0NsH9NgpMkQf1eniHZEoQmBWUrccShuv+9Ld4xGy9FfE2y9MHPXfHFk4TWCtC7nQUJrckcB3/QyrOavFjKQ9dG6GxIRg6WlUkEo6nRpS73mkcJS90iJsqh5i0PriR4hZv1wDVSgLut+0nPZMrl2axg6mAA3OMw/8wNKocJzegBM4EyaUcnDuoarv9vhC5RXnINTotnUIsDehvV0CBM/IZGCyjGxCBBq0iGMvR0yAg4MNLYo1PIf9GhmtQMA4NJiw8pLRG5pVVR1fAmvjO0RaU9poaRvIeLu+68ff1m/Pi2FIYrJM34PnepiICiM6SpsNHOzhYHyTmNg5B2UeEqBUih83aigA8QWES9mXR/wUUrURqxSQh5VUgYAbUqNQ5XiNqH2KyVday0KlPJVA7kfyG/9tR9MPnks8tchuHsboXlZh4Y30FG2xiR69WvKUFhJX21m1z8SJ5VrLr/yWVUufb3eV94XzKt5to3hpcV5E30jOGdUmqqZQTj2Ez+OVlVbOvTXBdw592+4Hj2w9H+qiA61GsTyJy1Nyk89R0sEdDwsB5t2sXPIWXTtcU1eZJGPU1DpYxezdcJ1jXD0mt/6n1eDw7iFdDBdDJfZO/zxV4Rg2DbSx2M8rTr8UXV89QEq5d9mUYEnkeeNOqvV18qxjtHNEU4+hRJey0xuwJm3gdLk0cdx6EFLqTUMSnxH5XBq62OwFZ1nCWbHQfRprtExWiL7xlEDFj26ynY/txIMT8EqwHnOuv1R5C NCvl3ANP rMYqWNBKEn36MOxPbfN4ddQVfT+mNFw7GheTf+/Y/RX8qP3pG86DRoJAuv0sBfpkOUwtnEP3iAZBDY+5B+ma0A9ECTtW/7XrxcUaw4Jy8Px+K632hRk05m0li8jX2GSfDMaNe2f/mEVo0+lQWvvKSZicTUCPHX3uHLPzt/CvIC9jCWLpWCfIU2HH6BJsjYgLkh/mA9ZkYMugWAzMnMp/e4HTPVMG3j9FkSA5CEpFiMgkzYfCtrhbgfkRp4OoHLNPyPycbXoVqkDGskZAjgqUjvupew2e6SW8WUvhh0C50zsuMroCRv9R4lVzV8sJysYZHjUl5Q1QD19+LGZOKosN7MIYeQVdSXN60SiMLrSLapD6vkyy3tB5s2AG5ktdoCKhVEfaQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Large amounts of memory managed by the kmem driver may come in via CXL, and it is often desirable to have the memmap for this memory on the new memory itself. Enroll kmem-managed memory for memmap_on_memory semantics if the dax region originates via CXL. For non-CXL dax regions, retain the existing default behavior of hot adding without memmap_on_memory semantics. Cc: Andrew Morton Cc: David Hildenbrand Cc: Michal Hocko Cc: Oscar Salvador Cc: Dan Williams Cc: Dave Jiang Cc: Dave Hansen Cc: Huang Ying Reviewed-by: Jonathan Cameron Reviewed-by: David Hildenbrand Signed-off-by: Vishal Verma --- drivers/dax/bus.h | 1 + drivers/dax/dax-private.h | 1 + drivers/dax/bus.c | 3 +++ drivers/dax/cxl.c | 1 + drivers/dax/hmem/hmem.c | 1 + drivers/dax/kmem.c | 8 +++++++- drivers/dax/pmem.c | 1 + 7 files changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/dax/bus.h b/drivers/dax/bus.h index 1ccd23360124..cbbf64443098 100644 --- a/drivers/dax/bus.h +++ b/drivers/dax/bus.h @@ -23,6 +23,7 @@ struct dev_dax_data { struct dev_pagemap *pgmap; resource_size_t size; int id; + bool memmap_on_memory; }; struct dev_dax *devm_create_dev_dax(struct dev_dax_data *data); diff --git a/drivers/dax/dax-private.h b/drivers/dax/dax-private.h index 27cf2daaaa79..446617b73aea 100644 --- a/drivers/dax/dax-private.h +++ b/drivers/dax/dax-private.h @@ -70,6 +70,7 @@ struct dev_dax { struct ida ida; struct device dev; struct dev_pagemap *pgmap; + bool memmap_on_memory; int nr_range; struct dev_dax_range { unsigned long pgoff; diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c index 0ee96e6fc426..ad9f821b8c78 100644 --- a/drivers/dax/bus.c +++ b/drivers/dax/bus.c @@ -367,6 +367,7 @@ static ssize_t create_store(struct device *dev, struct device_attribute *attr, .dax_region = dax_region, .size = 0, .id = -1, + .memmap_on_memory = false, }; struct dev_dax *dev_dax = devm_create_dev_dax(&data); @@ -1400,6 +1401,8 @@ struct dev_dax *devm_create_dev_dax(struct dev_dax_data *data) dev_dax->align = dax_region->align; ida_init(&dev_dax->ida); + dev_dax->memmap_on_memory = data->memmap_on_memory; + inode = dax_inode(dax_dev); dev->devt = inode->i_rdev; dev->bus = &dax_bus_type; diff --git a/drivers/dax/cxl.c b/drivers/dax/cxl.c index 8bc9d04034d6..c696837ab23c 100644 --- a/drivers/dax/cxl.c +++ b/drivers/dax/cxl.c @@ -26,6 +26,7 @@ static int cxl_dax_region_probe(struct device *dev) .dax_region = dax_region, .id = -1, .size = range_len(&cxlr_dax->hpa_range), + .memmap_on_memory = true, }; return PTR_ERR_OR_ZERO(devm_create_dev_dax(&data)); diff --git a/drivers/dax/hmem/hmem.c b/drivers/dax/hmem/hmem.c index 5d2ddef0f8f5..b9da69f92697 100644 --- a/drivers/dax/hmem/hmem.c +++ b/drivers/dax/hmem/hmem.c @@ -36,6 +36,7 @@ static int dax_hmem_probe(struct platform_device *pdev) .dax_region = dax_region, .id = -1, .size = region_idle ? 0 : range_len(&mri->range), + .memmap_on_memory = false, }; return PTR_ERR_OR_ZERO(devm_create_dev_dax(&data)); diff --git a/drivers/dax/kmem.c b/drivers/dax/kmem.c index c57acb73e3db..0aa6c45a4e5a 100644 --- a/drivers/dax/kmem.c +++ b/drivers/dax/kmem.c @@ -12,6 +12,7 @@ #include #include #include +#include #include "dax-private.h" #include "bus.h" @@ -56,6 +57,7 @@ static int dev_dax_kmem_probe(struct dev_dax *dev_dax) unsigned long total_len = 0; struct dax_kmem_data *data; int i, rc, mapped = 0; + mhp_t mhp_flags; int numa_node; /* @@ -136,12 +138,16 @@ static int dev_dax_kmem_probe(struct dev_dax *dev_dax) */ res->flags = IORESOURCE_SYSTEM_RAM; + mhp_flags = MHP_NID_IS_MGID; + if (dev_dax->memmap_on_memory) + mhp_flags |= MHP_MEMMAP_ON_MEMORY; + /* * Ensure that future kexec'd kernels will not treat * this as RAM automatically. */ rc = add_memory_driver_managed(data->mgid, range.start, - range_len(&range), kmem_name, MHP_NID_IS_MGID); + range_len(&range), kmem_name, mhp_flags); if (rc) { dev_warn(dev, "mapping%d: %#llx-%#llx memory add failed\n", diff --git a/drivers/dax/pmem.c b/drivers/dax/pmem.c index ae0cb113a5d3..f3c6c67b8412 100644 --- a/drivers/dax/pmem.c +++ b/drivers/dax/pmem.c @@ -63,6 +63,7 @@ static struct dev_dax *__dax_pmem_probe(struct device *dev) .id = id, .pgmap = &pgmap, .size = range_len(&range), + .memmap_on_memory = false, }; return devm_create_dev_dax(&data);