From patchwork Tue Oct 24 06:44:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13433971 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 022F4C25B71 for ; Tue, 24 Oct 2023 06:44:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B9C36B017F; Tue, 24 Oct 2023 02:44:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 76A756B0180; Tue, 24 Oct 2023 02:44:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 658966B0181; Tue, 24 Oct 2023 02:44:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 56B0B6B017F for ; Tue, 24 Oct 2023 02:44:30 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 28FD4160E05 for ; Tue, 24 Oct 2023 06:44:30 +0000 (UTC) X-FDA: 81379416300.11.C5A3991 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf17.hostedemail.com (Postfix) with ESMTP id 83BD040006 for ; Tue, 24 Oct 2023 06:44:28 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=LbsFIHIa; dmarc=none; spf=none (imf17.hostedemail.com: domain of BATV+e19589c3639214e6c3cb+7366+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e19589c3639214e6c3cb+7366+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698129868; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xv0Y7MMN6a+oO5YWZ9vpRkvqCfuPiGUZ4v0gSgQ4Fio=; b=AUUue2Oh6LGy2MrcY0JSNP34NVxhRXwqtRP1XnAEbVcVV9VCRduHlM46lURmVLCNVaWR21 7u81R5ryAgLVGXYhax3tQ5rdMC/GevwftAFgaPIrFkNJG2nUld2E7G+VdDvHwP+LsblYRb 1SC++hNrpf9RBZ1myqoR2OSQZirn4D8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=LbsFIHIa; dmarc=none; spf=none (imf17.hostedemail.com: domain of BATV+e19589c3639214e6c3cb+7366+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e19589c3639214e6c3cb+7366+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698129868; a=rsa-sha256; cv=none; b=56ZgniK/oLIy8Tir61ErfkF5vylmWa5XmiyDpIJnkMd1jZMI5oYDZGR699UNpL7TN4m+HZ VV9gNiz1nNQ+jjGBglmSBuams5jRgxN38ZjsZDU7MTEhrZTrTJTIQCeaLeGNCz6CeUl3eS QjzStEk6R0dWIS3FFOd/cBoYW3+Eoqk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=Xv0Y7MMN6a+oO5YWZ9vpRkvqCfuPiGUZ4v0gSgQ4Fio=; b=LbsFIHIaMCxJK5tHyXHay27Tpj 0aMIGXw6DujKIybLgCJyppua7cZTABksNxgjpULkWeufdVhy2DR4tImheev61lt+bUJVdzkbAyRJf TiLWyG+7G5LSn3Z3tq3hbiI0bEU3JiOMlA2+aPMAOnQ1TkJ6rKJegATMhaWnO0hkLOKuikj+ETiYi 4GI+mG3g+TmTne4T+QQA5YEP9rgNldFXZWy3SCjN0kFegAOqXb5l9CSJYDShQLtNCAq1enB5zZaXR CXRHTj6muUCEt5sPaPDSl+ZW2FFxKkWLwcZKhPXGp/FCX/Dns/BDyxnH6AxR22KqReTfq0saPB8k1 8MjFBsXw==; Received: from 2a02-8389-2341-5b80-39d3-4735-9a3c-88d8.cable.dynamic.v6.surfer.at ([2a02:8389:2341:5b80:39d3:4735:9a3c:88d8] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qvB9N-0090S8-1j; Tue, 24 Oct 2023 06:44:25 +0000 From: Christoph Hellwig To: Jens Axboe , Matthew Wilcox Cc: Ilya Dryomov , Andrew Morton , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 2/3] block: update the stable_writes flag in bdev_add Date: Tue, 24 Oct 2023 08:44:15 +0200 Message-Id: <20231024064416.897956-3-hch@lst.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231024064416.897956-1-hch@lst.de> References: <20231024064416.897956-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 83BD040006 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: zx8cxojdnqck4rdcjbmfwc4nfxfn3yaz X-HE-Tag: 1698129868-887395 X-HE-Meta: U2FsdGVkX1+XQavJtNqNuqCnREYgifpTezXTg4xw1MRTcN+gh8Ai4+4aSu5PJMDmkXwQIZ/wB/bCA0Rolsaum5eWaQTmSala9z+00QbCbaPwri8+L2YZbHUIqEY8sSdBZybDKjCmolT6CSIdrrKaJSzpUw/hC24N/XzBGSRZ7n3fF2rFM5LJxUhmWGChzY6TM6NsmpodfV9lpKspTS40XlY0vpWZ0P6NBAQ8Whp17HSyyUeCDLJ5b2d5WFoNTWRRpnLT735afdYlGrkjuOHcyASGPgLsUGxg1QXd7ZLo5w9shlxMlhgf/qMNNxmFMTd3vjNMO0HNQlUhmo6ud47FajVL6Gc5Y8EZ6vV3BxF6zPZlBzX5s2nbN19ZPICxEWlDUI474VvxlQX1jqZBZu7l1q8Nao2MBcJ4eB/4CHY3BXQmESxvdrMorswPqQXTnZmqaNDoNQGeb6ano9szlP+dMlXkFZ3UXmJz9oCPXR2uDKsXFIqBuPyuUakCSJ+7HTgYs7Q199aEcF43I1wICGoxHDjF9uXIGyK8Yo5euD4bfkZV3VHJ1BlXQLzSQI3LeaBX1XEsT+rpQXCg197H1mtnuIjj3HCS0YYvvBZj0oY5dkvQXi2Jk4kZ+lByoUoG9z9JEjPIZAZcyYIHSMURnt1wVfeOghU/IWVb11bQPjyqSgLvooMlVonnMK1l4n1UD74VXfRMjemS0Ek0dNnLjDcGsir+UGv5WxaiWy0c79IYCKVZZw9+uvG1CYwKhYrzZ5+VB/qEwH+TZx+wBI6QbVbGGIgVOif1jpZTOAzK6YlI96027o/Bjk9z6Zd2tZOosDcMfIq7P/kMJboPjnqCq+U71Mp4QR2rcYfshlvMch0NLeZJJ8OBfhklDtprpHNH+BlOvW2xWjW9fxHf/sjVUXsUueWxGzyfxUsHHmpyYUxiahRqpcol7xTHTwdtn9jTWkEID6FwB0A+IUPOLAJRUKm dZXqrrER pPasiRcD7mpuv14QaycmUd/58+PEcb2/cSP+zWavL9A3eRDg4orUHc/TQy2RBoy5ff15rSWgAX36HdRyt8baqNCaUcl8anIz5M2Gj9F1cDSTlntuzSkzmCerShsFNcBOcFJTIeYwoP33+4qW6RZ90qdepHvt3j5Rejps8rxe25TQmpzW/Ij7H8KVT8JyBEUeHOeTaKUrFG/+WKshusGfqYpFkYmyf4ADYGUBWWrewF9rFXLoC2TMRpqeiBqTwZlCjyhsr7ZBwOw/tJsn7LMCLY1LETkTJGi8K8ARCIM7L7vj5Au2zFlDKDEy1kRk+qMzD8WpcWoPDAKG6nOvM9pgyBbSqYWPAw4+J2pqtSo1ycMfOW/GFi/0DLFJUCdDMgqGnW+Dxcy6YQXYjs+PLxaqa9dZBXzCiLiB9o/tuSx4rbGEZ7iKP1j2D7PwM1enAKR1RcNetahiiT1IWANeUCUpyZEFy4BuR/OyrjdzFs4M46Uy+rrM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Propagate the per-queue stable_write flags into each bdev inode in bdev_add. This makes sure devices that require stable writes have it set for I/O on the block device node as well. Note that this doesn't cover the case of a flag changing on a live device yet. We should handle that as well, but I plan to cover it as part of a more general rework of how changing runtime paramters on block devices works. Fixes: 1cb039f3dc16 ("bdi: replace BDI_CAP_STABLE_WRITES with a queue and a sb flag") Reported-by: Ilya Dryomov Signed-off-by: Christoph Hellwig Tested-by: Ilya Dryomov Reviewed-by: Darrick J. Wong --- block/bdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/bdev.c b/block/bdev.c index f3b13aa1b7d428..04dba25b0019eb 100644 --- a/block/bdev.c +++ b/block/bdev.c @@ -425,6 +425,8 @@ void bdev_set_nr_sectors(struct block_device *bdev, sector_t sectors) void bdev_add(struct block_device *bdev, dev_t dev) { + if (bdev_stable_writes(bdev)) + mapping_set_stable_writes(bdev->bd_inode->i_mapping); bdev->bd_dev = dev; bdev->bd_inode->i_rdev = dev; bdev->bd_inode->i_ino = dev;