From patchwork Tue Oct 24 13:46:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 13434607 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94098C00A8F for ; Tue, 24 Oct 2023 13:48:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 468A16B0299; Tue, 24 Oct 2023 09:48:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EF8E6B029B; Tue, 24 Oct 2023 09:48:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 221286B029C; Tue, 24 Oct 2023 09:48:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 07FFF6B0299 for ; Tue, 24 Oct 2023 09:48:09 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D270EC061C for ; Tue, 24 Oct 2023 13:48:08 +0000 (UTC) X-FDA: 81380483856.07.6CFF9D4 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf15.hostedemail.com (Postfix) with ESMTP id 23D86A000B for ; Tue, 24 Oct 2023 13:48:06 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VgPNi01n; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of 3Fss3ZQYKCLstvsfochpphmf.dpnmjovy-nnlwbdl.psh@flex--surenb.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3Fss3ZQYKCLstvsfochpphmf.dpnmjovy-nnlwbdl.psh@flex--surenb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698155287; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nwLU1aU2LNAtecsch6dr14rd1yTTpsfUN6nYD0uWJEE=; b=1T64juikDiKKkvAeFiVBnh9TdNXslvy6HVZJNxDb963CHpp6BdvAQ/UmhaNkQdoBYfYRbq Q6GplDvtYbKnH4RYzPLPB1JoAGW5g6ZNFGp/8+qFZy4hxY3o/l8wQ6Aoozg0irdRUrZwBc jfaUvwrmACCxNpAO4qzf2jlnbpF953o= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VgPNi01n; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of 3Fss3ZQYKCLstvsfochpphmf.dpnmjovy-nnlwbdl.psh@flex--surenb.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3Fss3ZQYKCLstvsfochpphmf.dpnmjovy-nnlwbdl.psh@flex--surenb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698155287; a=rsa-sha256; cv=none; b=No+ww6wTKsdLzqc1D2ovBWq5KDBzWOjqCB80Qe6dVY6eilvQlY3DKLQTh/xUusblF6RqIa uet9Pyly1ydqmRBXOtyKh7xZF0cIjXSB/P2ycHD74oLpKdNV7Rsp90lrHTBsXHKARyu8al XRmRvB1ZzB3+Q9aXXzfPnTRRCOPbcO4= Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-d9a39444700so5323376276.0 for ; Tue, 24 Oct 2023 06:48:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698155286; x=1698760086; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=nwLU1aU2LNAtecsch6dr14rd1yTTpsfUN6nYD0uWJEE=; b=VgPNi01nOwtEDrXmf+bx8tzFIC3eyRIbovmy3wmGQ8rzimDJGBPOs5H65tb8SlAX2+ o4hfi9rrFzPx6F4rrjUzaM7FSRRCix/IsIw8X3j5ag/xnBgAszarQ7zpoh0tcJHb8+nw w3Yq6v/u2EJcl3KXsT6eZyYBewDmZ1hqffPY9XmAO/s2db9ByURuyL8lpDXWmRellqiD WwTCkQFuVZjNXvOgbZF9QvqvMP2qkDss8NQLfNLNEo5hM3qkNyGF6xNvJtTyohnjsg5m OyrH1nykngH1bVb97F/V35OgoeNm951PWg9lguqv/OVX3oQh8OdkSxIFW2UBQI8AeTtm FnTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698155286; x=1698760086; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nwLU1aU2LNAtecsch6dr14rd1yTTpsfUN6nYD0uWJEE=; b=ZKZeuIhtbv3wR5qlyAZRxzAnKTrgtf6ilOq3QzcDRQ9tbHszxS2NK/uZYMOraPSxkO MhTu6Ho0T+WRHGKBTCEZzWhZ2XHg7IAhmPbqlOEDKGy+VAiuLUFvQahTHVa6fLdvj2LQ 3HuKL9D8HeFdNS9JwV2z6+JQg0x2jc8HO0yiiIbg0VXf7dL/oHqHhNV1Av5ac/DahDsV l7+vWhJe7kQ+F4iwT+Bg1Jg1S7dU3P+Y6NYMhwirAvI8HwvKpRcPC0YcbsSVt49T8jZ+ y4xBh5lHp5wQeEI1AgjvrY5Ki/7T4rvm8Fq1Qv4ZagNKZcrcIhjDkjL85ldeGnDYPg9b JJCA== X-Gm-Message-State: AOJu0YzB0z1OaMZ9cg4WyDwhzZ/vdAm602yDpiwKHCjAbU5iwX7NHMy6 yqZ6Fhg5vM00yY18Opu4ylQJfEipoL8= X-Google-Smtp-Source: AGHT+IEQFxSAdc50qujfzmzJKJcWY3qyZfXbT1k7XuYaFuTlpAInpKqkovdUmqHR4hu8HiZ2L8Ah2MqCV0A= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:201:45ba:3318:d7a5:336a]) (user=surenb job=sendgmr) by 2002:a25:d244:0:b0:d9a:4cc1:b59a with SMTP id j65-20020a25d244000000b00d9a4cc1b59amr317326ybg.1.1698155286109; Tue, 24 Oct 2023 06:48:06 -0700 (PDT) Date: Tue, 24 Oct 2023 06:46:35 -0700 In-Reply-To: <20231024134637.3120277-1-surenb@google.com> Mime-Version: 1.0 References: <20231024134637.3120277-1-surenb@google.com> X-Mailer: git-send-email 2.42.0.758.gaed0368e0e-goog Message-ID: <20231024134637.3120277-39-surenb@google.com> Subject: [PATCH v2 38/39] codetag: debug: introduce OBJEXTS_ALLOC_FAIL to mark failed slab_ext allocations From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, surenb@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 23D86A000B X-Stat-Signature: ekjokbu5ufdbzd414hqi4di8h5cfi7dw X-Rspam-User: X-HE-Tag: 1698155286-603563 X-HE-Meta: U2FsdGVkX19PxMuuQOGj5Slnp2sws1SOXuutVQki399fhBrJvZUBSCb0pCUua0iOtk4gFGifNEhOT0ZSXoOC/wShlRCEUXYALY7ZJU5Be2oZx1X9QOyeozDrS3PFzvd8bMkq10fP28LhIWdImxUn227MOyqPzjgrLlRvX5WLasXrcgZ0xBoJFlaKboEigN4/N4DvstAFURs11kjLxcJCnbC3JRFEaI9Ms/UpjDLaKb51urHnyGM0KwhU7f4HHYbUKVUlf58Bm83DnrHq0+PAWhfxwBz/zB379JtjhWBjyVvJMjJupQpp9db+mw6erjjrG5yeDEaBUxxRzSd/PIcCDsEShl1hn4QvBtb0fE0jzxTI+vNwiP2XEAdstXQuypXDfpb/qNv+dyAQAAO36bRZUW5iqDq1zUC/NSiHX01iR1lPbXlH9ZV45bjVRJH/Pk6SEzlCTTr+goGza9UCmRREvC91KkuURQWMnVZNjCR0vsTxGK9FnLADNYz7FVVedCMeQAFHbweG6Dsc/voHL25InduSk+IutbbZaq/c8SzFoDdGRq931IT2UrGu/k3MEdBA2LV3/dS2cvbXamr0KDPjMKO6Q2pslvE+piYfcyZxwF+5dmDa1Ee57OtRJwRdv2ZlF1GHGOqwYnUqiqAwx9nk1YAC3mcjCr5EDeNAfRLO9S+vk2iAEAzs+UtWhaiWAGp4q4lCPXq4rI3iuFRZ/oaVOwd47gEQ/QghhY1ASZBjgTPo0SHzf1c0W8k3A9gzYWQn9ihrl9cubzJTDKQuXomrU+rkoh66m/F3bplS7mzD8lcaEuo209jsBxisLo4R5i30tqTuxEPuR2W2RRCydQbr6S3ExS7rh4Cqr+tmworQkJKgPBJUc/M6wK7ecsWxAJWOl5hJpLhir7J+B0ZigKMqEg3R8Uzlzy1+mtfQRCTU5rk21n2M5URpCNfEu1LGgoO5fZJqk12WPqLWTCBs8wP yyqRENTy F+EqGVKRGdZbY/w0c0aiBt2fgjIJ+vqfUEBHpZmxd0ii1KWvr0+SQeVZ5HetctpRKTIAJwfcpT0dNUsOCxmpbuBQzMLkZKcAv8gTTJR0Msjp5FiTjWCgJPZaOcNX+5RL0D32NkBua1A5khTEwToGh9vtpiLiZULHBkH9GXIF/DG64I1ucWHPecXIoK9ubmd6T3BE9VJvKHLZgrQdH28cDhdYM58c8DY8diZ3gMZYZfVDiDDhap37nV7NJ4ZxNuPKJisFNFYV3wE9WEhWMYL+nbD96JmIE/vzcnXJfs+d4iviwwyXVGfgp421pDU/c6pgTTGRHBD1LvDC2Y+GnIxtIyzgLVFPmMVJTMAqH4jaLmdvEEV7rP08yWmJdHWElnIuEe8ui7+G3KW+sfXLcyvoMmM3x6a5Imo4UugHGOEzy+ZIKo6x8GFPVtkRyAUOUrRlAZCT2FGgj7ab5Ct4/EGTVKBNaeTU/xG90oSk3sOerYCUpxwmTeYgNZsfL4dZziKCL0M5FQpo7SyP5YHyLihbmPW8FQc/Uq9vO2HNO4RqgHWmHd/9B9rqt65vXzS3l7WJaCNnmNSBe4wOk3vxRqcKCCzCFfJiDJ8fPxDJseq9VmD0Ly5mBVrawGkl2O+oW4uScZhhEy7AY6YhoRMXctVhcBOIHdU5ToRuge7gs2SxxLQrI5V8lYHMPrU0o/JK+magSqN7fO1T6Lvaatt7wJ6VpRhwgsw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If slabobj_ext vector allocation for a slab object fails and later on it succeeds for another object in the same slab, the slabobj_ext for the original object will be NULL and will be flagged in case when CONFIG_MEM_ALLOC_PROFILING_DEBUG is enabled. Mark failed slabobj_ext vector allocations using a new objext_flags flag stored in the lower bits of slab->obj_exts. When new allocation succeeds it marks all tag references in the same slabobj_ext vector as empty to avoid warnings implemented by CONFIG_MEM_ALLOC_PROFILING_DEBUG checks. Signed-off-by: Suren Baghdasaryan --- include/linux/memcontrol.h | 4 +++- mm/slab.h | 25 +++++++++++++++++++++++++ mm/slab_common.c | 22 +++++++++++++++------- 3 files changed, 43 insertions(+), 8 deletions(-) diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 853a24b5f713..6b680ca424e3 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -363,8 +363,10 @@ enum page_memcg_data_flags { #endif /* CONFIG_MEMCG */ enum objext_flags { + /* slabobj_ext vector failed to allocate */ + OBJEXTS_ALLOC_FAIL = __FIRST_OBJEXT_FLAG, /* the next bit after the last actual flag */ - __NR_OBJEXTS_FLAGS = __FIRST_OBJEXT_FLAG, + __NR_OBJEXTS_FLAGS = (__FIRST_OBJEXT_FLAG << 1), }; #define OBJEXTS_FLAGS_MASK (__NR_OBJEXTS_FLAGS - 1) diff --git a/mm/slab.h b/mm/slab.h index 45216bad34b8..1736268892e6 100644 --- a/mm/slab.h +++ b/mm/slab.h @@ -474,9 +474,34 @@ static inline void mark_objexts_empty(struct slabobj_ext *obj_exts) } } +static inline void mark_failed_objexts_alloc(struct slab *slab) +{ + slab->obj_exts = OBJEXTS_ALLOC_FAIL; +} + +static inline void handle_failed_objexts_alloc(unsigned long obj_exts, + struct slabobj_ext *vec, unsigned int objects) +{ + /* + * If vector previously failed to allocate then we have live + * objects with no tag reference. Mark all references in this + * vector as empty to avoid warnings later on. + */ + if (obj_exts & OBJEXTS_ALLOC_FAIL) { + unsigned int i; + + for (i = 0; i < objects; i++) + set_codetag_empty(&vec[i].ref); + } +} + + #else /* CONFIG_MEM_ALLOC_PROFILING_DEBUG */ static inline void mark_objexts_empty(struct slabobj_ext *obj_exts) {} +static inline void mark_failed_objexts_alloc(struct slab *slab) {} +static inline void handle_failed_objexts_alloc(unsigned long obj_exts, + struct slabobj_ext *vec, unsigned int objects) {} #endif /* CONFIG_MEM_ALLOC_PROFILING_DEBUG */ diff --git a/mm/slab_common.c b/mm/slab_common.c index db2cd7afc353..cea73314f919 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -218,29 +218,37 @@ int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, gfp_t gfp, bool new_slab) { unsigned int objects = objs_per_slab(s, slab); - unsigned long obj_exts; - void *vec; + unsigned long new_exts; + unsigned long old_exts; + struct slabobj_ext *vec; gfp &= ~OBJCGS_CLEAR_MASK; /* Prevent recursive extension vector allocation */ gfp |= __GFP_NO_OBJ_EXT; vec = kcalloc_node(objects, sizeof(struct slabobj_ext), gfp, slab_nid(slab)); - if (!vec) + if (!vec) { + /* Mark vectors which failed to allocate */ + if (new_slab) + mark_failed_objexts_alloc(slab); + return -ENOMEM; + } - obj_exts = (unsigned long)vec; + new_exts = (unsigned long)vec; #ifdef CONFIG_MEMCG - obj_exts |= MEMCG_DATA_OBJEXTS; + new_exts |= MEMCG_DATA_OBJEXTS; #endif + old_exts = slab->obj_exts; + handle_failed_objexts_alloc(old_exts, vec, objects); if (new_slab) { /* * If the slab is brand new and nobody can yet access its * obj_exts, no synchronization is required and obj_exts can * be simply assigned. */ - slab->obj_exts = obj_exts; - } else if (cmpxchg(&slab->obj_exts, 0, obj_exts)) { + slab->obj_exts = new_exts; + } else if (cmpxchg(&slab->obj_exts, old_exts, new_exts) != old_exts) { /* * If the slab is already in use, somebody can allocate and * assign slabobj_exts in parallel. In this case the existing