| Message ID | 20231111105455.37917-1-ppbuk5246@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mpale_tree: remove redundant check on mas_wr_append. | expand |
* Levi Yun <ppbuk5246@gmail.com> [231111 05:55]: > Checking data appending on node is done by > mas->offsest == end > which is identical with: > mas->offset == wr_mas->node_end > > Remove redundant check and there shouldn't be functional change. This was already sent out by Peng. See http://lists.infradead.org/pipermail/maple-tree/2023-November/003051.html Thanks, Liam > > Signed-off-by: Levi Yun <ppbuk5246@gmail.com> > --- > lib/maple_tree.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > index bb24d84a4922..d16b8e211174 100644 > --- a/lib/maple_tree.c > +++ b/lib/maple_tree.c > @@ -4141,9 +4141,6 @@ static inline bool mas_wr_append(struct ma_wr_state *wr_mas, > if (mt_in_rcu(mas->tree)) > return false; > > - if (mas->offset != wr_mas->node_end) > - return false; > - > end = wr_mas->node_end; > if (mas->offset != end) > return false; > -- > 2.41.0 >
diff --git a/lib/maple_tree.c b/lib/maple_tree.c index bb24d84a4922..d16b8e211174 100644 --- a/lib/maple_tree.c +++ b/lib/maple_tree.c @@ -4141,9 +4141,6 @@ static inline bool mas_wr_append(struct ma_wr_state *wr_mas, if (mt_in_rcu(mas->tree)) return false; - if (mas->offset != wr_mas->node_end) - return false; - end = wr_mas->node_end; if (mas->offset != end) return false;
Checking data appending on node is done by mas->offsest == end which is identical with: mas->offset == wr_mas->node_end Remove redundant check and there shouldn't be functional change. Signed-off-by: Levi Yun <ppbuk5246@gmail.com> --- lib/maple_tree.c | 3 --- 1 file changed, 3 deletions(-)