From patchwork Wed Nov 15 15:49:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 13457010 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47FDAC072A2 for ; Wed, 15 Nov 2023 15:50:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6FAA8D0006; Wed, 15 Nov 2023 10:50:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F97480018; Wed, 15 Nov 2023 10:50:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 872F08D001A; Wed, 15 Nov 2023 10:50:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6AEC28D0006 for ; Wed, 15 Nov 2023 10:50:03 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 498B2803A7 for ; Wed, 15 Nov 2023 15:50:03 +0000 (UTC) X-FDA: 81460624686.15.5D68645 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 0D7CB180027 for ; Wed, 15 Nov 2023 15:49:59 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MbF9drla; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700063400; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=71Btu3XYwWZK+FmqHCgDmjFCfU/69a0+IvtQoWaiN/g=; b=cLLvfQ51lSo+4WMNcgzbGXZDWiR6UxkFGe24CGZyQUFlT1D59lXVJFrShluQXxFaXHbnfi ziJRhG3kWLoz7bIc+3UxBnx++Dkta+YDmW88qk1arL2P0n1GQ+lbqPTOy5L2uWXVbb/gPB ypHr0b/rhA81Vr1huCQ3ntS5x2byhlA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MbF9drla; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700063400; a=rsa-sha256; cv=none; b=RVHfyUHg3PJbnSm2kKmGc+UjZP/hOGUw/y2Vhe8nbFR32j4sPk3gEX8rhV3c4vWLaaMAAm ZOji8Kd3S87/Hx1MjGLtvearAwtwXnltStwOEyZaL5j02Vk0IbEqqKTKO+imqY5V0wNcgT 2ewTZP6yvPW9IWgsDYlGjN0+63r7dA8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700063399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=71Btu3XYwWZK+FmqHCgDmjFCfU/69a0+IvtQoWaiN/g=; b=MbF9drlacVkfyy2S3Ju7iLyPVi1MfD9QrGfrOxHrBV+aDDbqbvUAeEu8HVa9O3k5qfQeac 6GlKc6aIdoDObBlCCsGn+ZrHB7LIBv9Rhx5V3JNZDz7ZIZ0ZQrWZk1Jo4iLhjTVJUNtw7V 6lw9Gdypg3CiEfuI24FCQ2OtrOR2ZL0= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-230-IlTGLqZBOdmHvz4PCUDiHg-1; Wed, 15 Nov 2023 10:49:58 -0500 X-MC-Unique: IlTGLqZBOdmHvz4PCUDiHg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D97E13C000B4; Wed, 15 Nov 2023 15:49:56 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4FED7492BE0; Wed, 15 Nov 2023 15:49:54 +0000 (UTC) From: David Howells To: Christian Brauner Cc: David Howells , Jens Axboe , Al Viro , Linus Torvalds , Christoph Hellwig , David Laight , Matthew Wilcox , Brendan Higgins , David Gow , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, Johannes Thumshirn , Christian Brauner , David Hildenbrand , John Hubbard Subject: [PATCH v3 01/10] iov_iter: Fix some checkpatch complaints in kunit tests Date: Wed, 15 Nov 2023 15:49:37 +0000 Message-ID: <20231115154946.3933808-2-dhowells@redhat.com> In-Reply-To: <20231115154946.3933808-1-dhowells@redhat.com> References: <20231115154946.3933808-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Rspamd-Queue-Id: 0D7CB180027 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: dxibfbhs4jsnaa1k4r3wpp3qkatz98ma X-HE-Tag: 1700063399-770072 X-HE-Meta: U2FsdGVkX18TEEhOFM2+fm8N3+5nHP+mUTCxQex+EgeLV3/p1GOTMHmXItsK8zbzYq+x5V3MZqzuN20M2+DtJbG5WwiMwweHbytQQzToQU8EhGi3s18AG9Inlyr4hEIXIWOP7D9+cTVLd6x5pP4LCDIz5bWIcwtNoieIzyp6xebpcH5kYxiof+mcPlmj158tfXq39a+XCzlLGU+EeLl6rjSRIPqPcuV0s8rYixW+ZSYkhLCW6PTS/5Y+S/GlhXcbMblzPR5YG24jJLbQ/+mLPk3MSycFGe0+znn57Us+4CvxzOJundtQ9zu0XPc+OouuEPWJH1g4UJrk3FDVk6WbyiUrOzgU9EQYi33ALjHXy+LaR16aRPSRbJkXmIB/y7MFeQOODyw7uDaiiqKsJ8nN1bVQ6OOpuN+iEBxwT3vQ95I4w8pJZT4lcGswLZzcItLJkupMRGA8D9Bt/+yJsh/NqrBLLy+U+fjR02PxhYGS/9lcSw8cEXPByVTqhrO7hMJrZz3rzzogSrH4ZmsNDzul4C/6UvBttbYw+2LlYXorYCYX0k52TA0Rw78tTL0HParV1VpzXHLBpI3ogT2SoFch6eorC/HcYPWgBch+IoCtNIpwqss5DMFug94MlNf+6j1P8zq6y369bRMUrytbHlxbriXGC1rgjn2hQolkiEJhIx21Fm62kiLN7rDMZ/ACTxrS7Zals2PYzcZylSw7eRf4QZI30SWbssL8aUI7hXzEXuob2MN63F2k6atNBgekED5GIcVx2ba9nol4n2ng50PBCjW1C1hMmI5OzHZBCMjmHRGQcbYQCbwIMufurYm6zoMSUCp847emN9Wgap7rRzPl17L0NVJUf114uyilm4P+91yZKdCbUIj9VHktJh4V5S0q2pn56f8mN9ZWWQX4aoZtC6WrRJnZjpzywZFdamT9RD5ViVu+rcuGwrWnkwoPdjdTSktl2ShAuWRwgifJtH0 LTNRdkze PC8Ibu4NwBcES1ZMMz25k5WzrOxwoQYdc7OrfEtG35zPOT9AWdLCkKfbdWfHYYB5VaPI1n3q6RPtipQFB/APmrSyEgBnQ3mh/JDoKfCpt2Zs4YweNAzY2lRyAXK/TynQ8ZQgYvFjCuk3wLD9/zNQ6zw8KLlJmz5VSi1kzLXZprYj/jjIXNVItsezwS7F+JFFvdt/Op6F98Dv+QBueW5hdtczT/D1FbYqnk1jfa/Y2t+EsXzmPyLkvmRyYZRJ7Ct+5Zyczg6eO2eqrYiNBfCGAhncOzWth4Fj4TJ2du+zW03xbSxOPrt0uBdbUY0xXthVJQqQlmfbAR4I87rTa9T+iVOfm7qw1eVYJOTMuZnfaghFurf6+uepAov9LWM0ZOwZk0jthRdhxIqz1YB3dFy9epKtJySb7hxLZiS+XGW4GZ4QeM3RCSSW/OFy3aE806CMRPAp6WRXFm6AFDoNJb1PxiqiId1TtJcEmsBjN0JQAbAWZyBovoYMlHQCoSkXxJxppmLKufljb44q3T4XV9A8HvyoKIQVTTgz/9XsOvr5rhT30wYPViaR33plIuQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Fix some checkpatch complaints in the new iov_iter kunit tests: (1) Some lines had eight spaces instead of a tab at the start. (2) Checkpatch doesn't like (void*)(unsigned long)0xnnnnnULL, so switch to using POISON_POINTER_DELTA plus an offset instead. Reported-by: Johannes Thumshirn Signed-off-by: David Howells cc: Christoph Hellwig cc: Christian Brauner cc: Jens Axboe cc: Al Viro cc: David Hildenbrand cc: John Hubbard cc: Brendan Higgins cc: David Gow cc: linux-kselftest@vger.kernel.org cc: kunit-dev@googlegroups.com cc: linux-mm@kvack.org cc: linux-fsdevel@vger.kernel.org --- lib/kunit_iov_iter.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/kunit_iov_iter.c b/lib/kunit_iov_iter.c index 859b67c4d697..4a6c0efd33f5 100644 --- a/lib/kunit_iov_iter.c +++ b/lib/kunit_iov_iter.c @@ -53,7 +53,7 @@ static void *__init iov_kunit_create_buffer(struct kunit *test, void *buffer; pages = kunit_kcalloc(test, npages, sizeof(struct page *), GFP_KERNEL); - KUNIT_ASSERT_NOT_ERR_OR_NULL(test, pages); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, pages); *ppages = pages; got = alloc_pages_bulk_array(GFP_KERNEL, npages, pages); @@ -63,7 +63,7 @@ static void *__init iov_kunit_create_buffer(struct kunit *test, } buffer = vmap(pages, npages, VM_MAP | VM_MAP_PUT_PAGES, PAGE_KERNEL); - KUNIT_ASSERT_NOT_ERR_OR_NULL(test, buffer); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, buffer); kunit_add_action_or_reset(test, iov_kunit_unmap, buffer); return buffer; @@ -548,7 +548,7 @@ static void __init iov_kunit_extract_pages_kvec(struct kunit *test) size_t offset0 = LONG_MAX; for (i = 0; i < ARRAY_SIZE(pagelist); i++) - pagelist[i] = (void *)(unsigned long)0xaa55aa55aa55aa55ULL; + pagelist[i] = (void *)POISON_POINTER_DELTA + 0x5a; len = iov_iter_extract_pages(&iter, &pages, 100 * 1024, ARRAY_SIZE(pagelist), 0, &offset0); @@ -626,7 +626,7 @@ static void __init iov_kunit_extract_pages_bvec(struct kunit *test) size_t offset0 = LONG_MAX; for (i = 0; i < ARRAY_SIZE(pagelist); i++) - pagelist[i] = (void *)(unsigned long)0xaa55aa55aa55aa55ULL; + pagelist[i] = (void *)POISON_POINTER_DELTA + 0x5a; len = iov_iter_extract_pages(&iter, &pages, 100 * 1024, ARRAY_SIZE(pagelist), 0, &offset0); @@ -709,7 +709,7 @@ static void __init iov_kunit_extract_pages_xarray(struct kunit *test) size_t offset0 = LONG_MAX; for (i = 0; i < ARRAY_SIZE(pagelist); i++) - pagelist[i] = (void *)(unsigned long)0xaa55aa55aa55aa55ULL; + pagelist[i] = (void *)POISON_POINTER_DELTA + 0x5a; len = iov_iter_extract_pages(&iter, &pages, 100 * 1024, ARRAY_SIZE(pagelist), 0, &offset0);