From patchwork Fri Nov 17 21:15:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 13459583 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40624C54FB9 for ; Fri, 17 Nov 2023 21:17:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 456DE8D0051; Fri, 17 Nov 2023 16:17:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3395D8D001C; Fri, 17 Nov 2023 16:17:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18ACE8D0051; Fri, 17 Nov 2023 16:17:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 055858D001C for ; Fri, 17 Nov 2023 16:17:45 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D4EDC16066F for ; Fri, 17 Nov 2023 21:17:44 +0000 (UTC) X-FDA: 81468708048.19.E492C61 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 25B9912001C for ; Fri, 17 Nov 2023 21:17:42 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dsV58zQv; spf=pass (imf29.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700255863; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GawAUyJ9iP0gj2PbHUjDCEhyVAdgsUqdjSUQK91ytDA=; b=osaf8/pB8Qsh/e1dcbwOmckU1uUn+cBO3SX9EYi+C3x1Sr10kfOoJEN1wlxj2lc8+/Jg5f oQlwKMlKcPzbRkoR3tl9CanRE4bTynkWt3D/2s9gNfT/3bf9eM/5gBOcAB9eICRo7xH/5S g47zRBlc4aPNEUKnnPZp98oqraykBYo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700255863; a=rsa-sha256; cv=none; b=VD8izCn6/mb9XJjM9w9mMN/s3qBTISOgx+2LgeWgMNoJgur19qjSas0alWvSuZ7MmhdJAh hyu3uPiZ9ptfU5A5jLoWrmd8RbWS9ST+QNvnJVPMcmixXaTpug5YSrHHUFbtBGprS3lkW4 3UtFAZVvhe1IAV7PjZqYH0yPXv7JkaY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dsV58zQv; spf=pass (imf29.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700255862; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GawAUyJ9iP0gj2PbHUjDCEhyVAdgsUqdjSUQK91ytDA=; b=dsV58zQvmDs7Qkn2Ku9sMS5bHslxW0Pf/Aos3TGTjQl8prXkLzzI9L3KpYczrzHQ8msCOm KTv0/FHb9+RHcdZbZYCpNVvBQlwgSmdtwq5rxAAOf3cG0J4ekRs6lYRhOH4r4M6KN07DEP Kmu0l1EnAGbz6gYFBbhAtf3YFMeVY/g= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-QpEPVGaUPRqKx6AAAOAUBQ-1; Fri, 17 Nov 2023 16:17:41 -0500 X-MC-Unique: QpEPVGaUPRqKx6AAAOAUBQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F17E828040C0; Fri, 17 Nov 2023 21:17:39 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id 59660492BE0; Fri, 17 Nov 2023 21:17:37 +0000 (UTC) From: David Howells To: Jeff Layton , Steve French Cc: David Howells , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Dominique Martinet , Ilya Dryomov , Christian Brauner , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 27/51] netfs: Implement buffered write API Date: Fri, 17 Nov 2023 21:15:19 +0000 Message-ID: <20231117211544.1740466-28-dhowells@redhat.com> In-Reply-To: <20231117211544.1740466-1-dhowells@redhat.com> References: <20231117211544.1740466-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Stat-Signature: ctao7ycuhr7zyq3u6p3fxjzrijb97ehr X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 25B9912001C X-Rspam-User: X-HE-Tag: 1700255862-757548 X-HE-Meta: U2FsdGVkX1/l+3xr/AjHMcbKmJfgOpuo7SsAGwghOUs6dywpCvwNSKo+CzLC67KWso7gBTAArRQbwplkFtYYiPYqEUohDSENHRMNApk5Ngbd6b4BqRRN/GvwMd04v18T/Ngm1NB0ClA0T0qNo1EyWjr/GDfxgfpY84gcgjulBV092R80faXCtFoZR2ZM1AO2H+JvT2ul25m9B8y/RP6Wd/TR9xH9vDmi7HDCQChugx08jX6Rgiu+xnNOd1AflHy++JF0QUHM+p79gepNKQ7sOOialWcGWE4iG1GAtMJ3GhkWN3JzMThLexI2UmEjp85sqL72JJTM+T0UnuAcQupEdqalRBkqnwRlJkNRgAexQVQn00WnGyAHJcSPLTxK98za7ytu4AD2MjZpbofyjm7BPxUvBS1exJRXtuLW2nXgtAAryfFztpAoQ38aPArceGm7E6CvlkNl9xP1ydViXgYrbaAWVtdIxEMr3Hn3umJMDSIwnm2ReHehbzQX+7icGQaUZRWRmXTdrS4ROyu0xokOZwMbGxdJTO3NYDD1qdWHp1a5CAUuhctJWg0VQT6+87BP6tE6J5vS4JMwyi8U4Q6t+N0/2eY65OFo3N8X1xPM7I0M1/FV3PEreCn+5h0qmY/AoMhG1OyAqsMuMQr3DibBKSNqjfeRKterU/Vk1/lVhk3Owgowf5QGVUaXFXZtb/8KVDSPwKbdYFv7WCR6SzDsPIL871G3ERrwzXALW4z2ZaUjJQ/t/0SgOddWmL5f918NX4MoOJo3mv8bwfScXBpijv6zPzq/bpEzWxr2it8IzicMzYdU55Fe/8iSHWKJbHUon8MT/Fc1qQXXRSi5oRaDo/1v9Nnyjw/CS93Gj3/gWBFxTwUlV3D1f2zTtHEZDEqO7QOmEvcOVNGf/pbtSULE47lzZz9XMgpUsOAorlxTodpcZZmXt0C/eGxARm5GpG+Jv1hf2SJvxSsWR0a2pSj Mqr0f5q/ yi2ErKIdB9VEXETIwpaJgrEfbbL0qm/LFKDaxfY3EHdV3EEQM8T3TnAGe0nbNf6xa8amHWT9JnvNCOkjTMlskvW8CWztYkEQ+J1/o1n/I4RFNF/RFHc+sFJHpsqrJ8SfCWlYsgnQ2QGMFQBNwMy7mPwymfqKQ95kbPHrmeBtbM+SwOcSNSm9wZ3pKktyjHmPspicjkDoNIo1S7L8FfriMKP/gtBA0+Pe/FUJ0YrXaYWRGWkJEqfvL4tLfhtiVYYtaAuvuF4QzX/F/GinW800sTT2NrJ0Y1aQYoyyZlKT8LFM0KmE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Institute a netfs write helper, netfs_file_write_iter(), to be pointed at by the network filesystem ->write_iter() call. Make it handled buffered writes by calling the previously defined netfs_perform_write() to copy the source data into the pagecache. Signed-off-by: David Howells cc: Jeff Layton cc: linux-cachefs@redhat.com cc: linux-fsdevel@vger.kernel.org cc: linux-mm@kvack.org --- fs/netfs/buffered_write.c | 83 +++++++++++++++++++++++++++++++++++++++ include/linux/netfs.h | 3 ++ 2 files changed, 86 insertions(+) diff --git a/fs/netfs/buffered_write.c b/fs/netfs/buffered_write.c index 4de6a12149e4..60e7da53cbd2 100644 --- a/fs/netfs/buffered_write.c +++ b/fs/netfs/buffered_write.c @@ -330,3 +330,86 @@ ssize_t netfs_perform_write(struct kiocb *iocb, struct iov_iter *iter, goto out; } EXPORT_SYMBOL(netfs_perform_write); + +/** + * netfs_buffered_write_iter_locked - write data to a file + * @iocb: IO state structure (file, offset, etc.) + * @from: iov_iter with data to write + * @netfs_group: Grouping for dirty pages (eg. ceph snaps). + * + * This function does all the work needed for actually writing data to a + * file. It does all basic checks, removes SUID from the file, updates + * modification times and calls proper subroutines depending on whether we + * do direct IO or a standard buffered write. + * + * The caller must hold appropriate locks around this function and have called + * generic_write_checks() already. The caller is also responsible for doing + * any necessary syncing afterwards. + * + * This function does *not* take care of syncing data in case of O_SYNC write. + * A caller has to handle it. This is mainly due to the fact that we want to + * avoid syncing under i_rwsem. + * + * Return: + * * number of bytes written, even for truncated writes + * * negative error code if no data has been written at all + */ +ssize_t netfs_buffered_write_iter_locked(struct kiocb *iocb, struct iov_iter *from, + struct netfs_group *netfs_group) +{ + struct file *file = iocb->ki_filp; + ssize_t ret; + + trace_netfs_write_iter(iocb, from); + + ret = file_remove_privs(file); + if (ret) + return ret; + + ret = file_update_time(file); + if (ret) + return ret; + + return netfs_perform_write(iocb, from, netfs_group); +} +EXPORT_SYMBOL(netfs_buffered_write_iter_locked); + +/** + * netfs_file_write_iter - write data to a file + * @iocb: IO state structure + * @from: iov_iter with data to write + * + * Perform a write to a file, writing into the pagecache if possible and doing + * an unbuffered write instead if not. + * + * Return: + * * Negative error code if no data has been written at all of + * vfs_fsync_range() failed for a synchronous write + * * Number of bytes written, even for truncated writes + */ +ssize_t netfs_file_write_iter(struct kiocb *iocb, struct iov_iter *from) +{ + struct file *file = iocb->ki_filp; + struct inode *inode = file->f_mapping->host; + struct netfs_inode *ictx = netfs_inode(inode); + ssize_t ret; + + _enter("%llx,%zx,%llx", iocb->ki_pos, iov_iter_count(from), i_size_read(inode)); + + if ((iocb->ki_flags & IOCB_DIRECT) || + test_bit(NETFS_ICTX_UNBUFFERED, &ictx->flags)) + return netfs_unbuffered_write_iter(iocb, from); + + ret = netfs_start_io_write(inode); + if (ret < 0) + return ret; + + ret = generic_write_checks(iocb, from); + if (ret > 0) + ret = netfs_buffered_write_iter_locked(iocb, from, NULL); + netfs_end_io_write(inode); + if (ret > 0) + ret = generic_write_sync(iocb, ret); + return ret; +} +EXPORT_SYMBOL(netfs_file_write_iter); diff --git a/include/linux/netfs.h b/include/linux/netfs.h index 4f9a46a21c28..4cdadd1ce328 100644 --- a/include/linux/netfs.h +++ b/include/linux/netfs.h @@ -389,7 +389,10 @@ ssize_t netfs_unbuffered_read_iter(struct kiocb *iocb, struct iov_iter *iter); /* High-level write API */ ssize_t netfs_perform_write(struct kiocb *iocb, struct iov_iter *iter, struct netfs_group *netfs_group); +ssize_t netfs_buffered_write_iter_locked(struct kiocb *iocb, struct iov_iter *from, + struct netfs_group *netfs_group); ssize_t netfs_unbuffered_write_iter(struct kiocb *iocb, struct iov_iter *from); +ssize_t netfs_file_write_iter(struct kiocb *iocb, struct iov_iter *from); /* Address operations API */ struct readahead_control;