From patchwork Sat Nov 18 06:32:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vivek Kasireddy X-Patchwork-Id: 13459886 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C50CFC54FB9 for ; Sat, 18 Nov 2023 06:56:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32CEF6B03DB; Sat, 18 Nov 2023 01:56:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 24F966B0538; Sat, 18 Nov 2023 01:56:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECB3B6B0535; Sat, 18 Nov 2023 01:56:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DE7876B03DB for ; Sat, 18 Nov 2023 01:56:11 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BFB1F160E3C for ; Sat, 18 Nov 2023 06:56:11 +0000 (UTC) X-FDA: 81470165742.19.0A65B9B Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by imf14.hostedemail.com (Postfix) with ESMTP id C4C2E100008 for ; Sat, 18 Nov 2023 06:56:09 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=QuIabWgD; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf14.hostedemail.com: domain of vivek.kasireddy@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700290570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OFWxI1i+p4efvmikRdB46knSq10ZwkVaViiQ0SsvQMA=; b=Jdqu7aieKJzdxYxsG8Dhq+sOo66viPNnd2FtCpbUOVTOMSuTtCOHZMjiQM1dx3txfZDZTR uPMLI2pijlTMxzhEFjjVP0Os8elHbTe2g7zzpGcT2DU3IKoTIndCuyIRTggPS+jtLbTAyq 9czW54b2eWt2RQsqQwrTaWT4JKbIRiY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=QuIabWgD; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf14.hostedemail.com: domain of vivek.kasireddy@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700290570; a=rsa-sha256; cv=none; b=UN7l8d0mhCKA4qGzOcMBFkItcXhmwtbYoRDuHINYrOoLj1sxcyFmDYDZsobhKqb7GQnBm6 jKsK33HiIaFkSzEO8BTSPXPbSmhk/H/CCpOgk4cfVPRq9IucOQX+G5PjNuLs6pMBAgJhG2 CEI22uo1QHrSJRhqMlFu9XerLxMMfK8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700290569; x=1731826569; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=U5Op4CjhDDAHfKtiDzpe6+9a1b7R8CllBxVTE/TesJE=; b=QuIabWgDBjr48MKUEe6AGH/StxP3oN17obpZTHKRBaCFHI/JPlEif0PO ojIgSFuAsd6xjYnhGmzOfg6/BLPfHY/b7nx5SOMd0E4npUB5b+yncZyK8 iVDdl3m0VC9kaM7mP03rin9zg08Szy1cm6PAAtW3zSgkZgXh3FitSD4oP 1+VEniQuxQU028A6iihQp6XAe1/LAMpi7faLFIqeuJ7gCP3aEnb5ObGA4 k709FlbCamr0VzooRNm3bIHQFaoONk4FgM9+qmDwYSHe5qbyFWWrLhH05 2vuhEuFFPkAqaDKopF9nzXkDSl0w3+a28EmlVFGfoe+wvYqsSLs4iIgmG w==; X-IronPort-AV: E=McAfee;i="6600,9927,10897"; a="457912353" X-IronPort-AV: E=Sophos;i="6.04,207,1695711600"; d="scan'208";a="457912353" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 22:56:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10897"; a="800686575" X-IronPort-AV: E=Sophos;i="6.04,207,1695711600"; d="scan'208";a="800686575" Received: from vkasired-desk2.fm.intel.com ([10.105.128.132]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 22:56:06 -0800 From: Vivek Kasireddy To: dri-devel@lists.freedesktop.org, linux-mm@kvack.org Cc: Vivek Kasireddy , David Hildenbrand , Daniel Vetter , Mike Kravetz , Hugh Dickins , Peter Xu , Jason Gunthorpe , Gerd Hoffmann , Dongwon Kim , Junxiao Chang Subject: [PATCH v4 1/5] udmabuf: Use vmf_insert_pfn and VM_PFNMAP for handling mmap Date: Fri, 17 Nov 2023 22:32:29 -0800 Message-Id: <20231118063233.733523-2-vivek.kasireddy@intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231118063233.733523-1-vivek.kasireddy@intel.com> References: <20231118063233.733523-1-vivek.kasireddy@intel.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C4C2E100008 X-Stat-Signature: jaxw9o8ducr6b4axwno173nf99y8bikt X-HE-Tag: 1700290569-732944 X-HE-Meta: U2FsdGVkX18hwD5AtupikzLGQkoziTDqD4wglZhUmnmlXZihshQGUr/6IeVAkkhCVvP6Ac9vcyaB4KBoxpAmKT/H1dWGWh8EdpCklmso7X1F8Xq6rKF2GL3UwNzDXm41OIlJfsHrhkSVkCdVbN/j0Q35aWaoNN33Mai/29QSrpzlvLGHRehZ05Hv0iHbwy2p/foY4BxbihYf0D6Bv0H5B5WdVxjXAEJUom4bw8ZqjoeA4gCinL6b7QnsJ8I9YCSyqeVAwp/t9DJAZw7PZXMj70gtEqwAJUEFjeNBGfbw0qyiu5Vb9Yemp01UZojt032eMJ/mWlhEMAmygVARypaQjX6bsxkzMWnBQn9H3wgbGWsQrgv19Qk3V//N1ft1JNjwEngY8b7E7GfX/BfHYYaIpUvjtgbLqi2OtWkZXgf7ZC4rzgkJVfluzYUAEYmQ21bnPpFi1lqpX8DwvdmFnZ2kd52sLl1xsjiLbptJqGBog7sAO+MgkPoZhW4QApFZ2Mk4OXiUownX+fnQ7/nEO89Z0DhEGR5QH/B+sDUXICmHuMS3zWSvVKLeg7sNIUgjLEkFOB4xRYvYkfiM8AY8RMVrVNAN+XbS8mgVL2ivsM25TLAiiSe/wT/fGZLmIo7khNj3Is4Havyg/kpWAiERB//dG6NMBP4riJYrq7P4cZ74Pe3HgEwqiKXBNxKGzAUlrk3lIMu73Tv7C3cZ+WEFUbnNWBnpSX8cLMFoImDr2zWQCzoqEbB9lVA1b7KmfDy6qQTg06qgl1PxxYX8cByGDG2vnKPQs8P3pernk52VkXcfQg3PfQ+omED0ced1iaP1dtcP5AMWpFQX3dWvlec7/r101AYwKcrIR3nFqLQknHfmdjMNDeuthdqQx5Ma4BjtPTubcd/jPUsKZcEjqleOX7DxVJrrAUfdOKKBnV+On2ZhOhfvVfK+DxwkQGOKxiNN2nfnYj35OdkHTygs6POkNem qrF7SCMm e1iTNP82/5ATzjifd6Ob546uLlNZonBHIlZM9xY1jQSKdUQOQH0AeBam4SwpWvG+4GdCvfshsLnVC8qIQxWpKgccXevSgZPQv2roD492qTkAn+2TTyPJkB05YOWYMxXnPvnU44ajhyKlgtWN2i0szvpOvspewIUquXHRNTvMlZQh3maW/LNFVnEr+1GR2BX5dn9nH1EqogVyREuOALMl0OTOMSmB9ivWmXm4NZT8ItzNN3AbZB2KHpNhUwQTAk6pm4H/V6bYfUSniBZ4EqWR+zgHhPcqJi/wCs0ZPkMwdhBMAh84= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add VM_PFNMAP to vm_flags in the mmap handler to ensure that the mappings would be managed without using struct page. And, in the vm_fault handler, use vmf_insert_pfn to share the page's pfn to userspace instead of directly sharing the page (via struct page *). Cc: David Hildenbrand Cc: Daniel Vetter Cc: Mike Kravetz Cc: Hugh Dickins Cc: Peter Xu Cc: Jason Gunthorpe Cc: Gerd Hoffmann Cc: Dongwon Kim Cc: Junxiao Chang Suggested-by: David Hildenbrand Acked-by: David Hildenbrand Signed-off-by: Vivek Kasireddy --- drivers/dma-buf/udmabuf.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c index c40645999648..820c993c8659 100644 --- a/drivers/dma-buf/udmabuf.c +++ b/drivers/dma-buf/udmabuf.c @@ -35,12 +35,13 @@ static vm_fault_t udmabuf_vm_fault(struct vm_fault *vmf) struct vm_area_struct *vma = vmf->vma; struct udmabuf *ubuf = vma->vm_private_data; pgoff_t pgoff = vmf->pgoff; + unsigned long pfn; if (pgoff >= ubuf->pagecount) return VM_FAULT_SIGBUS; - vmf->page = ubuf->pages[pgoff]; - get_page(vmf->page); - return 0; + + pfn = page_to_pfn(ubuf->pages[pgoff]); + return vmf_insert_pfn(vma, vmf->address, pfn); } static const struct vm_operations_struct udmabuf_vm_ops = { @@ -56,6 +57,7 @@ static int mmap_udmabuf(struct dma_buf *buf, struct vm_area_struct *vma) vma->vm_ops = &udmabuf_vm_ops; vma->vm_private_data = ubuf; + vm_flags_set(vma, VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP); return 0; }