From patchwork Mon Nov 27 07:04:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?S3Vhbi1ZaW5nIExlZSAo5p2O5Yag56mOKQ==?= X-Patchwork-Id: 13469238 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33663C07D5A for ; Mon, 27 Nov 2023 07:26:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 988BF6B02E0; Mon, 27 Nov 2023 02:26:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 938376B02E2; Mon, 27 Nov 2023 02:26:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 826FF6B02E3; Mon, 27 Nov 2023 02:26:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 73EC76B02E0 for ; Mon, 27 Nov 2023 02:26:03 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 46B9E12013B for ; Mon, 27 Nov 2023 07:26:03 +0000 (UTC) X-FDA: 81502900206.21.566BF0A Received: from mailgw01.mediatek.com (mailgw01.mediatek.com [216.200.240.184]) by imf03.hostedemail.com (Postfix) with ESMTP id ED45120014 for ; Mon, 27 Nov 2023 07:25:59 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=mediatek.com header.s=dk header.b=Ir7dyl8P; dmarc=pass (policy=quarantine) header.from=mediatek.com; spf=pass (imf03.hostedemail.com: domain of kuan-ying.lee@mediatek.com designates 216.200.240.184 as permitted sender) smtp.mailfrom=kuan-ying.lee@mediatek.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701069960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9bckHyNJG5IsDCmEKDwalIObMqsZcNV3+pMVYGOWkZA=; b=ZSCbQq8XjTHMO0qZP4c4N25KCx9SOg7iRFhVD+EGqcI7q5Acpqn4Eu/EX01b29fhH279KA bV5S1zazh9ESERPSR/47OQBg/o8QGKq5MHw7hZKalZlk+DCO9cSO3wEIspKJoYnGZOD7J+ 8YGUlq/39ufvP05wGKk6/0+BsB17RVo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=mediatek.com header.s=dk header.b=Ir7dyl8P; dmarc=pass (policy=quarantine) header.from=mediatek.com; spf=pass (imf03.hostedemail.com: domain of kuan-ying.lee@mediatek.com designates 216.200.240.184 as permitted sender) smtp.mailfrom=kuan-ying.lee@mediatek.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701069960; a=rsa-sha256; cv=none; b=pA91ZtLN0h+54A3yVcOcNsZFj2PebzyvPT103n+GCT1+wE4PL8KV6s1Vz63qIdKTnMiK+W FqeCiHHLX16PoBnCawltadIAwmL4cVVtB7ahAaQdrPESjrz1JIgLRjHQoPKnjpzTV7G34j fyGPqoWQpJctCdE7Cn8RuSma1FSakuo= X-UUID: 31f8b57a8cf611ee9b7791016c24628a-20231127 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=9bckHyNJG5IsDCmEKDwalIObMqsZcNV3+pMVYGOWkZA=; b=Ir7dyl8PjdmMjC+E7j7WJKdu7+hMtFfdIN58H9s//k+s7NSqJSzGhW86Vxfc6zWzeQVyThe33zlJ/oSxxEjzKQ2OFFg2OSgpkYT7+DXd9XHueqj4wspARvc+3LBdMRyIG6JfYuYsPX8AUS7ktTJTrce9aa9tdw9wQCbf/D1+z48=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.34,REQID:a6da6c24-a2f3-4301-b28e-f6fee4f9b537,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:abefa75,CLOUDID:60011c73-1bd3-4f48-b671-ada88705968c,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:11|1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR: NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULN X-UUID: 31f8b57a8cf611ee9b7791016c24628a-20231127 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 2026218972; Mon, 27 Nov 2023 00:25:52 -0700 Received: from mtkmbs13n1.mediatek.inc (172.21.101.193) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Mon, 27 Nov 2023 15:05:16 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs13n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Mon, 27 Nov 2023 15:05:16 +0800 From: Kuan-Ying Lee To: Jan Kiszka , Kieran Bingham , Matthias Brugger , AngeloGioacchino Del Regno , Andrew Morton , Oleg Nesterov CC: , , , , Kuan-Ying Lee , , , , Subject: [PATCH 1/3] scripts/gdb/tasks: Fix lx-ps command error Date: Mon, 27 Nov 2023 15:04:01 +0800 Message-ID: <20231127070404.4192-2-Kuan-Ying.Lee@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20231127070404.4192-1-Kuan-Ying.Lee@mediatek.com> References: <20231127070404.4192-1-Kuan-Ying.Lee@mediatek.com> MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-AS-Result: No-10--4.762900-8.000000 X-TMASE-MatchedRID: TCPSmmY0AVNXKLar1IWcqhIRh9wkXSlFBdebOqawiLujC1E/zCEIr8Rk oeJ3OFRc3k+CPiKHMcLBSaBGgOy3GNEdmUPXI8FxWd1vvclMcXUUqWKocoJo6WrVm7PW4m4IaUX s6FguVy2veSUy9VcQXIAy6p60ZV62fJ5/bZ6npdjKayT/BQTiGmKd6TrD/tOxJTyu087Bl/3dU/ 0piiw/KVY8fik7GhBq/WJMB7lBUBeC/0zoitWvtG59So5u9ctjsIj++Y58d/rqkfDrTAOo86CjN WMcfCKKdATQdtPksR+3/JiWOe6GXXSWgQ2GpXdZbxffl9hhCBw= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--4.762900-8.000000 X-TMASE-Version: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-SNTS-SMTP: 29868F287BE6268FBBD8E35727CAA5215BC88AFF032D54227874052E0B4452B82000:8 X-MTK: N X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: ED45120014 X-Stat-Signature: pcccy6k9jufcw5tt8dzhaod6tbh1g7zc X-HE-Tag: 1701069959-717650 X-HE-Meta: U2FsdGVkX1/zEJ7Iu41sNKUCZKEzRWZ9QjEsltK86PCUjHCUS5M9xbsXLAjMI0noVRH3j5rAOsSOifePvfeOUuCRiv08Lz++8Q19qmnMke5rCKGIs/ooWMXPlU4Vk2qMAKruL+8VLQWGRxFzzNkfVtKRA8hilDkbOYlaza1bI9cUV0550K7HkZZZ2Px0XI2nKciLsmNiXEFNjS7lIkm3jGjrSTrh3UKDeRV69pRbCc2jgOrIRMa13mPmbgjnNvEpkcasb+GxSQf9k96z1kaAyikQz3KvCzOtBIpM1JomAfpDquo/eix9Ra3bbVb4M1kmKdgTcU5V3M6Ykj5wuIPSrn05fpjQJzNPqLzE/8N/yjAvKv0/DSCeStOJjfsWc3qrSCZIWPjAsJBBUrTUuGQbZaW5BmyI+2doFbP9FF1JAdwLUlNRm1HeDNXbBy+PYA+zprjW4aghNcrY/r+I7K9N9tnTnYGnkV9U2b2NsLI5IDwjEIerqJ1mxmLcvpGFZVtvHACFg8Nr/kljFaiWW6sKwxqcUpO2xOgGr/u86okjfw9SOX9F6fIMCxY134ViEq3aLrdZfHHF9MNcglPC1rwEXPmarWmMgmqYFc9Ylnk0jN7WX50YBvfDkLfYDKDBzpykXIWS4b0aqVuIQhAE/M3faMnMdZGgVEnLBGkFED5iSAI6Cje+jDESWQCvPUT+TToWwesc37+O8GL7HhJEe7pf9g/ECljoIaWzT/8XAYuGQH7MM7vhieCPbWQrWzxvfcHBIkAaBCwPnEu85H0MxwOrkIxZ8M5lMYvU+qA6+zkDfEcXtNFFHe3rVuyJ0suJuObS5jAC2rpX8sc5HTwRB+7Y6ksQEJIcwEg21MSsLgkx548IB2qJhHBzP6hy88HD/niI6tjXMnBI1RBmFBPb17BiCp+FVvzX3Hh5g+O69uzpBeAnZen3HWNhtfS2oPDiq9jUb9FWOMn0ThxMT+WTvWE KdyObvad Z8E52JGvB1CWwbEgDw6Gb/xyenot8KKhZjuK/mNnQlE6hVOqVa9arOzNf1cB4yoIRU3PqDRIKD4hDnK2sP2tMcWDNv7dwCHnZFmZU/Qmai+IWp8JaAfqLlJeuENtetG1ANb2cxb0E2IPy0NDEbBmSZRzgTlx7YjMIrP4rV/yNrGUVO8DyqpKI+CIR1r2YgF5R1oo0dTPPZd8eL0zq5jJwr3prkoWxeBTal5Tvs6W0z/CWI1/R+4Hcm6XvTtVazv0TJ+gQjRoX0w2jMDTZ/+lxlqMFhfahUypOZ8k+ytP5VE6AdMRopAJrpTRYNg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Since commit 8e1f385104ac ("kill task_struct->thread_group") remove the thread_group, we will encounter below issue. (gdb) lx-ps TASK PID COMM 0xffff800086503340 0 swapper/0 Python Exception : There is no member named thread_group. Error occurred in Python: There is no member named thread_group. We use signal->thread_head to iterate all threads instead. Fixes: 8e1f385104ac ("kill task_struct->thread_group") Cc: stable@vger.kernel.org Signed-off-by: Kuan-Ying Lee --- scripts/gdb/linux/tasks.py | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/scripts/gdb/linux/tasks.py b/scripts/gdb/linux/tasks.py index 17ec19e9b5bf..7c32f4c8284b 100644 --- a/scripts/gdb/linux/tasks.py +++ b/scripts/gdb/linux/tasks.py @@ -13,7 +13,7 @@ import gdb -from linux import utils +from linux import utils, lists task_type = utils.CachedType("struct task_struct") @@ -25,13 +25,9 @@ def task_lists(): t = g = init_task while True: - while True: - yield t - - t = utils.container_of(t['thread_group']['next'], - task_ptr_type, "thread_group") - if t == g: - break + thread_head = t['signal']['thread_head'] + for thread in lists.list_for_each_entry(thread_head, task_ptr_type, 'thread_node'): + yield thread t = g = utils.container_of(g['tasks']['next'], task_ptr_type, "tasks")