From patchwork Thu Dec 21 18:00:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: andrey.konovalov@linux.dev X-Patchwork-Id: 13502485 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01A9BC46CCD for ; Thu, 21 Dec 2023 18:00:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A6366B0081; Thu, 21 Dec 2023 13:00:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4557B6B0082; Thu, 21 Dec 2023 13:00:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3454D6B0083; Thu, 21 Dec 2023 13:00:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 222756B0081 for ; Thu, 21 Dec 2023 13:00:54 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E5F7CA2424 for ; Thu, 21 Dec 2023 18:00:53 +0000 (UTC) X-FDA: 81591591186.02.40EED42 Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) by imf01.hostedemail.com (Postfix) with ESMTP id A81484004E for ; Thu, 21 Dec 2023 18:00:51 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ea6gr3dH; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of andrey.konovalov@linux.dev designates 95.215.58.179 as permitted sender) smtp.mailfrom=andrey.konovalov@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703181652; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=ztPTKR8sr9h6D18SGkQNBYXp/fqVZdKTe5VGqgvKvQk=; b=GifZCv+BNhlcTHWOCbxfOt5IjBj8P557zrp2+6MT3r8PH5rnDTDVH79xQV3RWM0sgvnEPR j1jlykoD57V14JfatAV6ELGrfyom6wdm6pTVDGLiU6jgsBqKKGoNFW1kguJxE1Wxu3VawG wTj/Evt82CWz9czSv1rdDjGoQP9SOZw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ea6gr3dH; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of andrey.konovalov@linux.dev designates 95.215.58.179 as permitted sender) smtp.mailfrom=andrey.konovalov@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703181652; a=rsa-sha256; cv=none; b=gfyI5FEbxFi8BBxl2XLE+1gTdFySyB2jjKKNMxg9aTf9QmJL9Z8mJlPssTNPRdlByA2o49 rThSSsbUPPpfRMUrVr1BWzI637W6b9T5ppEKSRV70js3QIDaQfJmRIx15t8tDNhbFDaHZn 7sTcEbqzIKLxNgYwp/1PzX63cVHYICQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1703181649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ztPTKR8sr9h6D18SGkQNBYXp/fqVZdKTe5VGqgvKvQk=; b=ea6gr3dHoZVnBVxsz7Lv0gahIQ7R6TjWF+UWkxyDh6aRnEKLyT6WCUetH/UFbxrfUHM2nX ZiHFFaywum9XP//SPR5kuQLc5lxkrbC/ghAWwN1WS77TNJMUlFfKUnMlhUuaLnC/sPcJ4Y ZLmtpE2KnHgmrE0amIm/az1Ms2e+PQo= From: andrey.konovalov@linux.dev To: Andrew Morton Cc: Andrey Konovalov , Marco Elver , Alexander Potapenko , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Nathan Chancellor , Tetsuo Handa , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: [PATCH mm] kasan: Mark unpoison_slab_object() as static Date: Thu, 21 Dec 2023 19:00:42 +0100 Message-Id: <20231221180042.104694-1-andrey.konovalov@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: A81484004E X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: qo8i9axfnz9md6c996y6iq36r8ge7do4 X-HE-Tag: 1703181651-324838 X-HE-Meta: U2FsdGVkX1+L/6Sz6BFdDViJ0I7IQ2QeHzZfZJsPXI1fZCQWJ3qzWKNDOdeO1q2qm4zrjrjBIMVvfgqjpp91Mcit8c1VqhCs4m+iU2lCJ2YwyN7qTcThFl8iu332GWcyPtbC0YAXK/u+qSlUnHyBIKtvSaIDSTIbn/TC3f/TYJnd5VFipK3GIUsl36mWaizSVJQurNa64+/XX85cuhMkHWn4V06sFi2P5JR8rk3K6gno47h4w/iDxonjSeAuQTQ8J3pmMu0OS84e5x796HciKU6EcjACy0KtmQ40LItCVGFjiCmzBlBjTH5963vCgXl9exucOjYz1yXPKU51HJp/IzDsuIDn1P5mEGlPYE8JfKJOa3eG99+V1Wqp+PcUDF0Kpoox3lgxnlw2CpivQhOGcpBKi14BNuMxDEht0XzyoWZ4QhyphllxHjahrNyVrTW6lr37noX58e0oZJsKb49RvjGEqz5Alma4MmCGpI/QYKrVahfoTWwxL7qARqQFkc+BqNylFaMpCVuFXqjkRKk9j+RiQFmlfPL7EDrxh3hku6XJ6KYkeCeYui0EQUi5JYsOOPIaDOgGHxS2CbYKnRnL4oVl4Ry7gYEW1sPd15CjUYe/izIHmKQfuVu1PB+KDIkPJhu7jFWDZ0a0/VmHPpSfTOq7Sk8H4WOuirlaVjrMwqN/KKoM8k5L8hH8eanNyHh9okTjZHjfvMu4/T6edJ9I6HOSphuVwOPJi8IpBmffw+NLZq/pI5OvfP/wd3H220lmULSAxLss5VYfIrby7drS36+BViXFUPTTW8Zv2jix/bjh1aLRD8JIOBfmDzGECPizruzw+z3jOYx6q/7BuHXTB1UUqNVr/Sep/PWwSuad94YF9t59+x1znzOpMX/Wzz2Xpzwu2usNtTzZi4n7+IxL3v8XVwvh7dl6ZbpM0GcjMJ8jeJdlz5jjtefIpqBFfBPfkO5tVOVMkyHD4NR5wMt LA8gLRCk 9ckCE9bKGqL0+jXaoo+QLQkUrNdNTKb5ulJTgWGRF/I2k4EAfz0z2ghMgpkNsLhUiFAbULK8qB5zYb7ocIe1Yp0zB/QHSamJ+88aYzuOz2jTCM0xKIpOW+a7jJlgLy6W8ioAnyUENEHX258Q1k2hHH64grg03rVstMR7iInNDfEZXoSStYSVwpVHLKgZ54rEcMDpcPqdwB0BlMkc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Nathan Chancellor With -Wmissing-prototypes enabled, there is a warning that unpoison_slab_object() has no prototype, breaking the build with CONFIG_WERROR=y: mm/kasan/common.c:271:6: error: no previous prototype for 'unpoison_slab_object' [-Werror=missing-prototypes] 271 | void unpoison_slab_object(struct kmem_cache *cache, void *object, gfp_t flags, | ^~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors Mark the function as static, as it is not used outside of this translation unit, clearing up the warning. Fixes: 3f38c3c5bc40 ("kasan: save alloc stack traces for mempool") Signed-off-by: Nathan Chancellor Signed-off-by: Andrey Konovalov Reviewed-by: Marco Elver --- Changes v1->v2: - Mark as "static inline" instead of just "static". --- mm/kasan/common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/kasan/common.c b/mm/kasan/common.c index ebb1b23d6480..f4255e807b74 100644 --- a/mm/kasan/common.c +++ b/mm/kasan/common.c @@ -277,8 +277,8 @@ void __kasan_kfree_large(void *ptr, unsigned long ip) /* The object will be poisoned by kasan_poison_pages(). */ } -void unpoison_slab_object(struct kmem_cache *cache, void *object, gfp_t flags, - bool init) +static inline void unpoison_slab_object(struct kmem_cache *cache, void *object, + gfp_t flags, bool init) { /* * Unpoison the whole object. For kmalloc() allocations,