From patchwork Wed Dec 27 07:38:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vivek Kasireddy X-Patchwork-Id: 13505186 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCBFDC46CD2 for ; Wed, 27 Dec 2023 08:02:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF1468D000A; Wed, 27 Dec 2023 03:02:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A77D88D0001; Wed, 27 Dec 2023 03:02:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87B648D000A; Wed, 27 Dec 2023 03:02:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7278B8D0001 for ; Wed, 27 Dec 2023 03:02:47 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 47590806A5 for ; Wed, 27 Dec 2023 08:02:47 +0000 (UTC) X-FDA: 81611856774.25.8538749 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by imf21.hostedemail.com (Postfix) with ESMTP id 284BB1C0003 for ; Wed, 27 Dec 2023 08:02:44 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="eujCaL3/"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of vivek.kasireddy@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703664165; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h3emmYlObQz4YBWvxea89j9SxvY/uMNOIgA3BV8wvNU=; b=DiosQ1pNOpxJGspGck4n7VUWEALeBATV0PX4Kzfoli4NToDW9OjqPOgEsLUvHnHAeko86w Bou541ZIzb5kpwsCe8pKxedfm2eGPdAqfgfFgpwsnwDXuF/c5CgjEvN22AmB3oPMXlFelN Oyumy6MQqnuLSMc2YZWGTXOsCSsrox4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="eujCaL3/"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of vivek.kasireddy@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703664165; a=rsa-sha256; cv=none; b=0MnEdpfIZLkgr800B2rJ7MF6tEs/tklHe7g8te2ye1S8qG4ewm55Qwu0QbGOUvOYWn2p/d PLjK1J4laecSCPrL7t3/9HJImCq8cEiP+JIa6S7vLCRTmEdR/kv/pXYHBtw6RDmtjyNC4d idqOqhpybCRNTLdMBRkg6EQ7LFfdxAE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703664165; x=1735200165; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=r39C9fURv/tYjjTgfRvVfOiacLkGBXJF65fG2x4l+b0=; b=eujCaL3/3LpisJpHnr6ynVIL3YfRZcRWTW51NdmeK9vISBWd1eBGwx0Y mlRqJ0gBeNnERr7AQJhOChAoA0jvCfvcqhAaa4D1T9DiZgIuN0h8saEwP fOnJI7eH+UN2Qv/0ZveQOzhI00ABP60d03u13flCEq6dKj8DulRduPWz+ RHkE1xv7TwbhVpfVpqjKZQcB7vSFOHv5i0AankbjF/4fjuXnM4on8dUWh m40NQonKQ0cC/7SJwpaGq6QUhlBfGK5HbxkDMnLkXyzSM8shmQkOh55rB IXF0lDgCP/8kM2cxQwjKATDL29zYW09CSFYfOpYFA+LXqM+2EQ/jSvPfi A==; X-IronPort-AV: E=McAfee;i="6600,9927,10935"; a="482604327" X-IronPort-AV: E=Sophos;i="6.04,308,1695711600"; d="scan'208";a="482604327" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Dec 2023 00:02:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10935"; a="781668197" X-IronPort-AV: E=Sophos;i="6.04,308,1695711600"; d="scan'208";a="781668197" Received: from vkasired-desk2.fm.intel.com ([10.105.128.132]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Dec 2023 00:02:36 -0800 From: Vivek Kasireddy To: dri-devel@lists.freedesktop.org, linux-mm@kvack.org Cc: Vivek Kasireddy , Shuah Khan , David Hildenbrand , Daniel Vetter , Mike Kravetz , Hugh Dickins , Peter Xu , Jason Gunthorpe , Gerd Hoffmann , Dongwon Kim , Junxiao Chang Subject: [PATCH v9 6/6] selftests/dma-buf/udmabuf: Add tests to verify data after page migration Date: Tue, 26 Dec 2023 23:38:22 -0800 Message-Id: <20231227073822.390518-7-vivek.kasireddy@intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231227073822.390518-1-vivek.kasireddy@intel.com> References: <20231227073822.390518-1-vivek.kasireddy@intel.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 284BB1C0003 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: axio4t57p6wsdwokaby5ettaxuij5gmr X-HE-Tag: 1703664164-734125 X-HE-Meta: U2FsdGVkX19/TjoJ+xE3PuAbB8kMFeQM0nHjiHeMtoZONybpGqaEpznIv+71wShfV0fpR+ozo6vk9el9ImzSg7DCcrdSVQWH+XLlx1wSrT+xPns6RYh51S90M7hJP3rwGHfp0sfm7vHF0a0kqYHnjH9E9sCaktELzWSTSmpNSJPwA90Q+fjnkdwfchZ6joEa0PF/SmKXBTawQH1GDQq2p+/t4ujIz8KR3Ipi83gs5l9OKA6+LVH5pK62wFxYuU1PfQ8TJG1snhcVkws4jDlu2+S776FPZuVkKum0L0C6Gy/TgdcTXRRCwqW4PgTYuYe/Z50my3sELjBPMZpZLAZzbfKc0A6QrhwaA5Y/b8OIazfWnJIMGLtWsdXfmTikHWONLJGTwcQoaGxPrRHCGZVu0pT19UwPfel9L4OnyiccBF3kGbjd02800e8cv31ze9Pg7xU8vAgaVlP+3uGlywYPfmkT2iW0thOVUNaleON+mQbb8UHAwKb3xOlhpmFykkAiHuDQpmR4QAPqWsulaMhHuvmENIYtXUmXHEnTv5y2vyCoeH7pGoEbn+iOvq3v6Ah++6+724CjfYAgUThJZQ/1wiq9upkPMwVI3M40B0ROYxV+tKwrY3hz/BNfFSpHiNKddofd1SIwTmNQoF2M9kzDIwUMVohVp1HpXHo4HpjFxJDPGcKchbaLnJfaVR0nXlDgV8tkU6q3b8F3JpHMfiz8LfGRCrAhfyaWj2pVC4ulPPzLuiowHnz3Fi4ntPrE5VknKKUa4AdNXcNjbR+Ox7jUMfi4fZ6tRyJQ7uDB0kTwJSbPgRAqIwIZUFtSfPF/ef+VeX/hLU+Q4Aw+MVPI/cvHm7k5ycLnVvcX3LGhsyJz4nYjeLGGZZOZ4Ow2aPITx5RF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Since the memfd pages associated with a udmabuf may be migrated as part of udmabuf create, we need to verify the data coherency after successful migration. The new tests added in this patch try to do just that using 4k sized pages and also 2 MB sized huge pages for the memfd. Successful completion of the tests would mean that there is no disconnect between the memfd pages and the ones associated with a udmabuf. And, these tests can also be augmented in the future to test newer udmabuf features (such as handling memfd hole punch). Cc: Shuah Khan Cc: David Hildenbrand Cc: Daniel Vetter Cc: Mike Kravetz Cc: Hugh Dickins Cc: Peter Xu Cc: Jason Gunthorpe Cc: Gerd Hoffmann Cc: Dongwon Kim Cc: Junxiao Chang Based-on-patch-by: Mike Kravetz Signed-off-by: Vivek Kasireddy --- .../selftests/drivers/dma-buf/udmabuf.c | 151 +++++++++++++++++- 1 file changed, 147 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/drivers/dma-buf/udmabuf.c b/tools/testing/selftests/drivers/dma-buf/udmabuf.c index c812080e304e..d76c813fe652 100644 --- a/tools/testing/selftests/drivers/dma-buf/udmabuf.c +++ b/tools/testing/selftests/drivers/dma-buf/udmabuf.c @@ -9,26 +9,132 @@ #include #include #include +#include #include #include +#include #include #include #define TEST_PREFIX "drivers/dma-buf/udmabuf" #define NUM_PAGES 4 +#define NUM_ENTRIES 4 +#define MEMFD_SIZE 1024 /* in pages */ -static int memfd_create(const char *name, unsigned int flags) +static unsigned int page_size; + +static int create_memfd_with_seals(off64_t size, bool hpage) +{ + int memfd, ret; + unsigned int flags = MFD_ALLOW_SEALING; + + if (hpage) + flags |= MFD_HUGETLB; + + memfd = memfd_create("udmabuf-test", flags); + if (memfd < 0) { + printf("%s: [skip,no-memfd]\n", TEST_PREFIX); + exit(77); + } + + ret = fcntl(memfd, F_ADD_SEALS, F_SEAL_SHRINK); + if (ret < 0) { + printf("%s: [skip,fcntl-add-seals]\n", TEST_PREFIX); + exit(77); + } + + ret = ftruncate(memfd, size); + if (ret == -1) { + printf("%s: [FAIL,memfd-truncate]\n", TEST_PREFIX); + exit(1); + } + + return memfd; +} + +static int create_udmabuf_list(int devfd, int memfd, off64_t memfd_size) +{ + struct udmabuf_create_list *list; + int ubuf_fd, i; + + list = malloc(sizeof(struct udmabuf_create_list) + + sizeof(struct udmabuf_create_item) * NUM_ENTRIES); + if (!list) { + printf("%s: [FAIL, udmabuf-malloc]\n", TEST_PREFIX); + exit(1); + } + + for (i = 0; i < NUM_ENTRIES; i++) { + list->list[i].memfd = memfd; + list->list[i].offset = i * (memfd_size / NUM_ENTRIES); + list->list[i].size = getpagesize() * NUM_PAGES; + } + + list->count = NUM_ENTRIES; + list->flags = UDMABUF_FLAGS_CLOEXEC; + ubuf_fd = ioctl(devfd, UDMABUF_CREATE_LIST, list); + free(list); + if (ubuf_fd < 0) { + printf("%s: [FAIL, udmabuf-create]\n", TEST_PREFIX); + exit(1); + } + + return ubuf_fd; +} + +static void write_to_memfd(void *addr, off64_t size, char chr) +{ + int i; + + for (i = 0; i < size / page_size; i++) { + *((char *)addr + (i * page_size)) = chr; + } +} + +static void *mmap_fd(int fd, off64_t size) { - return syscall(__NR_memfd_create, name, flags); + void *addr; + + addr = mmap(NULL, size, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0); + if (addr == MAP_FAILED) { + printf("%s: ubuf_fd mmap fail\n", TEST_PREFIX); + exit(1); + } + + return addr; +} + +static int compare_chunks(void *addr1, void *addr2, off64_t memfd_size) +{ + off64_t off; + int i = 0, j, k = 0, ret = 0; + char char1, char2; + + while (i < NUM_ENTRIES) { + off = i * (memfd_size / NUM_ENTRIES); + for (j = 0; j < NUM_PAGES; j++, k++) { + char1 = *((char *)addr1 + off + (j * getpagesize())); + char2 = *((char *)addr2 + (k * getpagesize())); + if (char1 != char2) { + ret = -1; + goto err; + } + } + i++; + } +err: + munmap(addr1, memfd_size); + munmap(addr2, NUM_ENTRIES * NUM_PAGES * getpagesize()); + return ret; } int main(int argc, char *argv[]) { struct udmabuf_create create; int devfd, memfd, buf, ret; - off_t size; - void *mem; + off64_t size; + void *addr1, *addr2; devfd = open("/dev/udmabuf", O_RDWR); if (devfd < 0) { @@ -90,6 +196,9 @@ int main(int argc, char *argv[]) } /* should work */ + page_size = getpagesize(); + addr1 = mmap_fd(memfd, size); + write_to_memfd(addr1, size, 'a'); create.memfd = memfd; create.offset = 0; create.size = size; @@ -98,6 +207,40 @@ int main(int argc, char *argv[]) printf("%s: [FAIL,test-4]\n", TEST_PREFIX); exit(1); } + munmap(addr1, size); + close(buf); + close(memfd); + + /* should work (migration of 4k size pages)*/ + size = MEMFD_SIZE * page_size; + memfd = create_memfd_with_seals(size, false); + addr1 = mmap_fd(memfd, size); + write_to_memfd(addr1, size, 'a'); + buf = create_udmabuf_list(devfd, memfd, size); + addr2 = mmap_fd(buf, NUM_PAGES * NUM_ENTRIES * getpagesize()); + write_to_memfd(addr1, size, 'b'); + ret = compare_chunks(addr1, addr2, size); + if (ret < 0) { + printf("%s: [FAIL,test-5]\n", TEST_PREFIX); + exit(1); + } + close(buf); + close(memfd); + + /* should work (migration of 2MB size huge pages)*/ + page_size = getpagesize() * 512; /* 2 MB */ + size = MEMFD_SIZE * page_size; + memfd = create_memfd_with_seals(size, true); + addr1 = mmap_fd(memfd, size); + write_to_memfd(addr1, size, 'a'); + buf = create_udmabuf_list(devfd, memfd, size); + addr2 = mmap_fd(buf, NUM_PAGES * NUM_ENTRIES * getpagesize()); + write_to_memfd(addr1, size, 'b'); + ret = compare_chunks(addr1, addr2, size); + if (ret < 0) { + printf("%s: [FAIL,test-6]\n", TEST_PREFIX); + exit(1); + } fprintf(stderr, "%s: ok\n", TEST_PREFIX); close(buf);