From patchwork Tue Jan 9 11:20:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 13514773 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A686C46CD2 for ; Tue, 9 Jan 2024 11:20:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D65506B0075; Tue, 9 Jan 2024 06:20:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CEB496B007B; Tue, 9 Jan 2024 06:20:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B972A6B007D; Tue, 9 Jan 2024 06:20:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A47F76B0075 for ; Tue, 9 Jan 2024 06:20:51 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7C3D01A0358 for ; Tue, 9 Jan 2024 11:20:51 +0000 (UTC) X-FDA: 81659530302.15.2048C80 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id C1031A000A for ; Tue, 9 Jan 2024 11:20:48 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CSZTfwHx; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704799248; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rr5EJ/KUtWAGcPxbo/TizcNZKdZiXnS9Nbdtw3WvDek=; b=yFjd+CTbV/kL3BtPDF0bdjNiObNAjguONASzuGDKwGkOh/vbL/NGH5LISmO7zymk9bgGoD EPKzQZEFk9SSz5dfs5znmzrcVD4gpC3TRFx07I3xSsQYfQFSedsjAEcyo0SgOC6d/ynwuw JhFaD0mA0ovDT7x6fab/lvwaUGqQNw0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CSZTfwHx; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704799248; a=rsa-sha256; cv=none; b=tjgMMQRdo96V4BZ6CNMd5hZHXMDSnRcOj7fAIFGEGAjWTQe7HIlOdzSIzU2VNVmdIa1mod 5PMA6+8hbPuT1oDNStTG2+QYkK5fkQzxo05pyd62WiGzL2E/VSaZ8x4Z8mA4mJJlB55Lir l7/k8DE8xMlkT6hN9KffOV3IdZCR4NA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704799248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rr5EJ/KUtWAGcPxbo/TizcNZKdZiXnS9Nbdtw3WvDek=; b=CSZTfwHx1aUV+dSdXSXOq+K/hOBw8sJH3CgH4q+n5Uz8BTCr40ZKhh4Ot89JUhFF/W21h3 oauX3LmgtTlWgDoZro6soOVGq3xX6yQfwA+a396twgHGwxFl4A5IEGerlNc55SOqM+9oED sRf74Yu6Zh2Aa01OCXHBZEINzRC3YT4= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-100-EIoi-qiVMCWdOvvkHaBtvw-1; Tue, 09 Jan 2024 06:20:43 -0500 X-MC-Unique: EIoi-qiVMCWdOvvkHaBtvw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 59A0D29AA3A5; Tue, 9 Jan 2024 11:20:42 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7E2DBC15A0C; Tue, 9 Jan 2024 11:20:39 +0000 (UTC) From: David Howells To: Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet Cc: David Howells , Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/6] netfs: Mark netfs_unbuffered_write_iter_locked() static Date: Tue, 9 Jan 2024 11:20:18 +0000 Message-ID: <20240109112029.1572463-2-dhowells@redhat.com> In-Reply-To: <20240109112029.1572463-1-dhowells@redhat.com> References: <20240109112029.1572463-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Rspamd-Queue-Id: C1031A000A X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: i69nhoxzg1k3wjinkqptzwggxwyqtis3 X-HE-Tag: 1704799248-193124 X-HE-Meta: U2FsdGVkX1+HbxFelC5q7CWLXbBN0xTysChejfDPNn0K1f+E+FdnmV4g/LhhjJBOpwioCrTgqKt+rI75mekqjlAe2DgeMFhNz/qj80aptHKpKUJLfKCY8ChOW/AOccPWJdZoirXIVGNDweC8/uyhrCUzJGSnp3wRrR9jsp35Oj+/+oM+T7Sq9t7kzbs/nnw7oY5WdZEfb/0NqJxAqSGwQzNVQTdbugFExamOAZFfJnyMCqWCb3gTgrhgkNB/GPLYH7VIQMkvJtE87m4zgRpXRsDtumYFnaAqxoM21P+E1P+Ig+kFgsC0DwyyuseUpgma2c1/6mIoq31EU7FTpoqtk1TStSleqYHQNWIhfSIkK7NCmFp0kGd7JM9MoZsVe6+MOsdRAIw3KWjI7jVQdGi5RTw3CfoKU7aj5weYNsnI2e8VbpjTwSsbVUws12W501laZiws46gdAog1m2COdswV18CQ62qTVkC3Uh6606vajyjR4uEv+lQ5iy9NHm2A8se2ji7n/F/uYgdAvCTxNn0MLjoLSmWK7voWePz45D8EnwDQH501P8cQnstqFpiNuxsbb12GOgJQF5+cYSehuxRsXzmgM7ebLY9j3jcop3EHEA5NOLwNG9Ih+Zh+mHjbFzQyClEeIq6fQgNZp9/MlkrrdN3f/Eiyyhf1MREasJuitMn5BqUP+koKBre+THW4V1Ja83+ofxq4d+ufPAq2jMMKkXNXki24rFKJrplD170aetgfaJ4my8vj0+6QAY0nldngFD/ioTHE4eJGZyGKcupnajvTZAok8lk8wH3Bvicf6D2MhBtUYQFZ4EUL/gHfdh+6W/PXi4dkPjo+DWpj/Wa37oRBN99Mq6MwygscdKzxa7dET18xmCYAHnWN3fRSi38BbtZlAK6664qobqZ/h1wjV7PI8Ph0CAMls2lxqKThelSdBjKoBV5X1gAxfvhxyef3wsnkjNKYuwDSPEUGwx3 6GfmiXx+ Eeo4zaZtUmCYKaqz0NUSx93hO15AFuC0a4EvrBch3m4kuwWuES4u1ARLscmXqL8qvWIKfPgHtFff3D5y7Ca+rxryh3a93OKRZ/U/ZTRoJYI/txCvgxLqgYt5wBhmt5t9R27a1A6Sa/oa3WfQHiHX8odaiOytfzDoFG+sDFOTUXu5fdxai56BgjXEr6gMKirJX0IAQMGIACgIujPvqNuJUnx+SKhC1Y1nC03Tw6cWfuVVTT/xkUq7YhgLpz4iyn9NDLYWZW4uwM0surb3Z//xds0qGUlYNTXQ8cyFboKA4gzRPHXAjmMu7pDiqAb0xHeMXbuVNQYhKeKBReXT7wT4k9Xogxw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Mark netfs_unbuffered_write_iter_locked() static as it's only called from the file in which it is defined. Signed-off-by: David Howells cc: Jeff Layton cc: linux-cachefs@redhat.com cc: linux-fsdevel@vger.kernel.org cc: linux-mm@kvack.org --- fs/netfs/direct_write.c | 4 ++-- fs/netfs/internal.h | 6 ------ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/fs/netfs/direct_write.c b/fs/netfs/direct_write.c index aad05f2349a4..b9cbfd6a8a01 100644 --- a/fs/netfs/direct_write.c +++ b/fs/netfs/direct_write.c @@ -27,8 +27,8 @@ static void netfs_cleanup_dio_write(struct netfs_io_request *wreq) * Perform an unbuffered write where we may have to do an RMW operation on an * encrypted file. This can also be used for direct I/O writes. */ -ssize_t netfs_unbuffered_write_iter_locked(struct kiocb *iocb, struct iov_iter *iter, - struct netfs_group *netfs_group) +static ssize_t netfs_unbuffered_write_iter_locked(struct kiocb *iocb, struct iov_iter *iter, + struct netfs_group *netfs_group) { struct netfs_io_request *wreq; unsigned long long start = iocb->ki_pos; diff --git a/fs/netfs/internal.h b/fs/netfs/internal.h index d2d63120ac60..a6dfc8888377 100644 --- a/fs/netfs/internal.h +++ b/fs/netfs/internal.h @@ -26,12 +26,6 @@ void netfs_rreq_unlock_folios(struct netfs_io_request *rreq); int netfs_prefetch_for_write(struct file *file, struct folio *folio, size_t offset, size_t len); -/* - * direct_write.c - */ -ssize_t netfs_unbuffered_write_iter_locked(struct kiocb *iocb, struct iov_iter *iter, - struct netfs_group *netfs_group); - /* * io.c */