From patchwork Sat Jan 13 06:52:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vivek Kasireddy X-Patchwork-Id: 13518882 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D22CC47DA6 for ; Sat, 13 Jan 2024 07:16:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABA418D0003; Sat, 13 Jan 2024 02:16:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9ACAD940007; Sat, 13 Jan 2024 02:16:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 617768D0003; Sat, 13 Jan 2024 02:16:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4531D8D0006 for ; Sat, 13 Jan 2024 02:16:45 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 21D6B1C0F5E for ; Sat, 13 Jan 2024 07:16:45 +0000 (UTC) X-FDA: 81673430370.15.AC985A7 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf03.hostedemail.com (Postfix) with ESMTP id 1885C20010 for ; Sat, 13 Jan 2024 07:16:42 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gyapHY70; spf=pass (imf03.hostedemail.com: domain of vivek.kasireddy@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705130203; a=rsa-sha256; cv=none; b=HxxGfFjaRfp1j1ls7t6qTqszgJranOHM0m/T1NV06xn1+XsVg1rBHSUJ/Z2TsJThYWSdxJ rMAW/cRGc3b49NrPDrGK1VTGuW9WZjnA5oADc2l3tWJh+EqMW2zEhQ4ODO2vbunq4wUajx Rvowy+Q4SdMry58hnAWAOgkDDkAP+o4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gyapHY70; spf=pass (imf03.hostedemail.com: domain of vivek.kasireddy@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705130203; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OFWxI1i+p4efvmikRdB46knSq10ZwkVaViiQ0SsvQMA=; b=XwKH4I0+wD50cQuhGDITPB16mV+t4vnJ4egj0FLbo9jGX+Tkfyk59krcOW6zkMYsEwk0Of nPiY9APce2F0a5o+UZf1XS9apdkcSRhrB5H/1MtmvpE/2l2X+t+7QmM6Jy2WCghn/JLIJL 42x5r6ktHkCE7EyRpQltVbxXHpLjH+8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705130203; x=1736666203; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=U5Op4CjhDDAHfKtiDzpe6+9a1b7R8CllBxVTE/TesJE=; b=gyapHY706Mx4aHHjYQrzosDRoUfEwI9pBAWYOf1w1f5kXMikD5ARxrg/ MQyL2YhzKJoQY72tCJxoRFdT3tHswRs4o0W6ZYdWM+7J4KtycrIPIg6lX 3vbfBTgi690iJkLXfSRadCZWS74vfhhKP80s7DVJo+DGN46zm390Zakz7 Qsj3ljQL2s8c7jtGYkJeGh6HuehGiOgPrYOZZLnSJZ+Gz4hPgeCaRLsGv QJZCb8tF7HI9H9sHcX2DW16YDxqWxx0+/qgGOK1p8X79ngrpDMcAXJjvW RKsSLdJOp0xC7z++kqCo6Eg9GqRIyPw2ML+fQfcdMaSrTrkKCojtdBJri w==; X-IronPort-AV: E=McAfee;i="6600,9927,10951"; a="6078134" X-IronPort-AV: E=Sophos;i="6.04,191,1695711600"; d="scan'208";a="6078134" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2024 23:16:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10951"; a="783269499" X-IronPort-AV: E=Sophos;i="6.04,191,1695711600"; d="scan'208";a="783269499" Received: from vkasired-desk2.fm.intel.com ([10.105.128.132]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2024 23:16:38 -0800 From: Vivek Kasireddy To: dri-devel@lists.freedesktop.org, linux-mm@kvack.org Cc: Vivek Kasireddy , David Hildenbrand , Daniel Vetter , Mike Kravetz , Hugh Dickins , Peter Xu , Jason Gunthorpe , Gerd Hoffmann , Dongwon Kim , Junxiao Chang Subject: [PATCH v11 4/8] udmabuf: Use vmf_insert_pfn and VM_PFNMAP for handling mmap Date: Fri, 12 Jan 2024 22:52:19 -0800 Message-Id: <20240113065223.1532987-5-vivek.kasireddy@intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240113065223.1532987-1-vivek.kasireddy@intel.com> References: <20240113065223.1532987-1-vivek.kasireddy@intel.com> MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 1885C20010 X-Stat-Signature: oddd463ew7yfgd31nt9qrj89g35j1831 X-Rspam-User: X-HE-Tag: 1705130202-761054 X-HE-Meta: U2FsdGVkX1+yoVOXZnW4MG/N2q03dvUiIXJvqvxYRmqW+LpkRpkkyzO54XJ+VMCv8pYu4DBihxbWMmh/9S5kA7y24wlHPIsF6WWTkYhMqQ23huFrhhNhlhlv0GvJ0kfuDRmol7tb9WDeSCe1MFSGyVzXYEkZLS03DqCo5PHWrtHe/n8dA4Qhkh3f83aHukimSW3PvrMDmitHhmoZLBZas8KuUBIgEl8FJEUDe8ynN7M9RfNXFXMJIi87cbQBMv3L0q5D+b7aStQ0qlLRoqfD9TZzvSa5x7Q1fSNNa8k/CIpUcpsyghbAPSBegmhT4mpITRqf7QStqHaYTZJgut5tGgUEAL/VpRYljFmu+Id8dUqqTD+Czke7vw8gCSK8JaEZeYNEYhLA+QKBcNVaGPxO4scFW3qrGqCFywrpFCEol5KGi/LGIsASq+J5T+9GfxHnbR0fWyHEC0fuoEoHoHbF2431HkUUlCrShrr7vU0VWH632X4v9lDgOHBJrOPS+tLw4EfZF4YLEkrvweWCsDOkBzzckCDcVL84d+X1mFuMyOmFlEvGhGWa9OY0UjGNVxn/lkDj5fm6cXkWulvRqkNhHLE6ydpDhcqbtlhGXrizrHjOOsx00pXUQ/mQ/JPHrxJEm2HI+l6ArilAxAZjWQQHLIL+Jb6yh2QpvNyOXBDj2VQVvl82CwnV79C4RUo2Ra7ks204rXhXaxin7ERLTM/+NfHMwg7gdsNyDWwcVKDFpu4SPRdbJeFdWChjpOf1LoCbzkJ4JOp1RF4nb/2LN9H8IAXnqbpibEEOPiyG5L97b5TWbNiNVclCWDlH+1FjVrgU5k2ANwvT52v49G9D5lUH03LraKVjMJf2pj9A47XxFy6sT1evqZTmBxgl14etHU2Mk19mPojffzeAF5C6+H60pE7IupLDALxnP72ApJMCSuns+oK7ysJ/wK65UBfB1pWbKUhPWXG8viLExWgCmUC JsTr/tem z5ALJfBFEJfXrx15A4apivNQkzcLI3zZiepxccHIdrez4UdLG4wsjjjBHMLJxHu2AoS1EwVd+rMqgDh3noThKN2+10+3csPT/DPohyG0H42gDagqA3gKz6X+V6eV8ezO9zqBwlL4wJuhTyfCGQCbma7Eqq921dvs44rXUI2IZTsjMypNvMGQ0JLegWGzVWXyX/m/YPKBs6zEy0wE94jSPMKg2i/DNDdOJ95KDKl1TDPH3gN7evgAo4ei/l9k0i2QeXjqcEk0/c6EQD93Yq1A8jUurB1IccuIV08KhzgX5PWyjhnk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add VM_PFNMAP to vm_flags in the mmap handler to ensure that the mappings would be managed without using struct page. And, in the vm_fault handler, use vmf_insert_pfn to share the page's pfn to userspace instead of directly sharing the page (via struct page *). Cc: David Hildenbrand Cc: Daniel Vetter Cc: Mike Kravetz Cc: Hugh Dickins Cc: Peter Xu Cc: Jason Gunthorpe Cc: Gerd Hoffmann Cc: Dongwon Kim Cc: Junxiao Chang Suggested-by: David Hildenbrand Acked-by: David Hildenbrand Signed-off-by: Vivek Kasireddy --- drivers/dma-buf/udmabuf.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c index c40645999648..820c993c8659 100644 --- a/drivers/dma-buf/udmabuf.c +++ b/drivers/dma-buf/udmabuf.c @@ -35,12 +35,13 @@ static vm_fault_t udmabuf_vm_fault(struct vm_fault *vmf) struct vm_area_struct *vma = vmf->vma; struct udmabuf *ubuf = vma->vm_private_data; pgoff_t pgoff = vmf->pgoff; + unsigned long pfn; if (pgoff >= ubuf->pagecount) return VM_FAULT_SIGBUS; - vmf->page = ubuf->pages[pgoff]; - get_page(vmf->page); - return 0; + + pfn = page_to_pfn(ubuf->pages[pgoff]); + return vmf_insert_pfn(vma, vmf->address, pfn); } static const struct vm_operations_struct udmabuf_vm_ops = { @@ -56,6 +57,7 @@ static int mmap_udmabuf(struct dma_buf *buf, struct vm_area_struct *vma) vma->vm_ops = &udmabuf_vm_ops; vma->vm_private_data = ubuf; + vm_flags_set(vma, VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP); return 0; }