From patchwork Mon Jan 15 09:27:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marco Elver X-Patchwork-Id: 13519412 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF0A9C3DA79 for ; Mon, 15 Jan 2024 09:27:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4ACFB6B0092; Mon, 15 Jan 2024 04:27:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 45E086B0095; Mon, 15 Jan 2024 04:27:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FCFB6B0096; Mon, 15 Jan 2024 04:27:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 193446B0092 for ; Mon, 15 Jan 2024 04:27:36 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E1849160824 for ; Mon, 15 Jan 2024 09:27:35 +0000 (UTC) X-FDA: 81681017670.24.0135534 Received: from mail-ej1-f74.google.com (mail-ej1-f74.google.com [209.85.218.74]) by imf05.hostedemail.com (Postfix) with ESMTP id 3C76510000B for ; Mon, 15 Jan 2024 09:27:34 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=FwnmCua8; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of 3hPqkZQUKCEEhoyhujrrjoh.frpolqx0-ppnydfn.ruj@flex--elver.bounces.google.com designates 209.85.218.74 as permitted sender) smtp.mailfrom=3hPqkZQUKCEEhoyhujrrjoh.frpolqx0-ppnydfn.ruj@flex--elver.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705310854; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=bmhCfln9ac1sszz1cn9mo233ZA1ZqqWQM/ks4o+Avbk=; b=S93wxqsVrX/tS2zY7LX6wwQkiRc5K18n/fHBHG+vAWT+WcdG0a6In7yo06+MouVLk1XLu3 8m7x/62WQA72p9o6pyKeKzxh7GVE0Xy7nmWjITfhi3hqJRk4YAHrk0bs9shrf688xI+SLO 8E3IKpp6xdNipij/rAEAWdQk/egG32E= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=FwnmCua8; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of 3hPqkZQUKCEEhoyhujrrjoh.frpolqx0-ppnydfn.ruj@flex--elver.bounces.google.com designates 209.85.218.74 as permitted sender) smtp.mailfrom=3hPqkZQUKCEEhoyhujrrjoh.frpolqx0-ppnydfn.ruj@flex--elver.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705310854; a=rsa-sha256; cv=none; b=pX0HiZvoefNxuKdSX2ruLaQagN/VKI1VFeGjaVXxDMrsPoSo8/v+Jd6Bn2e57j5BzyKq6w TBt8Ikj5hZ0cZ/DTTLzyutpJ9RlUhLXyMb6+bt7JYkuk/MK3D1dVRtSn5E+dM//rYGR0Pk hfoZGWRA4DfyjsV+hMQnxR9s99o24Tw= Received: by mail-ej1-f74.google.com with SMTP id a640c23a62f3a-a2c3da4b4a2so231397766b.3 for ; Mon, 15 Jan 2024 01:27:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1705310853; x=1705915653; darn=kvack.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=bmhCfln9ac1sszz1cn9mo233ZA1ZqqWQM/ks4o+Avbk=; b=FwnmCua8wB8BBrEiOVWfI9fg2+2iIQWT45ALaLUWx4iN3F/5jvWrNWYEvuoiYNx5HH /SozZXnsq2nkgpxrtTj/RP9ALJZb8kV8Corgugq/9rQbN9Fgntx5q3yVbMiI2OXmNmFk rB7tCseU1Gl9tJuec8VruqzGTywqCMyoF3pXJb3lZtdoUxBqnLvhjotN6+xWk2INSZuz VZXvE8xx7vZjZDHK+PGP6mgN0i8zOxJnayVcXLbH9+TuDU8zGTnfjnah76xamLtfQcOv fV3f4MYTVW4HhEYWvYhu/+WQ42aSYZCOH1anRycsQUO00vF0alMdV9wPyCU2LJQqUlHT posA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705310853; x=1705915653; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=bmhCfln9ac1sszz1cn9mo233ZA1ZqqWQM/ks4o+Avbk=; b=p6g5ysfl8ZWbjrXzghj/LQQf3UP7b/5k/0nr99oYQM3n4ezsi5kJEatyA3J1Ukx7g8 D1qoZobgJ1ZzUzc2fmjUUvArsvoOwXNnUJMEHc3f6X+KC/WMcsL9YWwamreVjzaiu1Xq q+xRdzaXqRkvQlmFVMqSzD0GwBtfdMqGDhoe4gK5rIGZSZhKK1p7G4u6ZVxXXlXWfVDM HDoOj0nAnqhpq0zTSiPIhnxx93UKu6wD4gpiKm8T3mm9/zjU2hK2zu6tWUmN8R08EvYs 14zyHp09BFylYXc/SQ2gkVslgnsscS3AdF2kCidaYVZ5A57uzJVzxGF1/VrNDkKEj3Kt 5WmA== X-Gm-Message-State: AOJu0YxEAHD5Za9VqyEKVXIB1KQ7Ret2lvL7RK3UmYzl0dsWGurLyOs+ BkjyckFgXSKE8f/1ynM9URtOiAyu6PhgH5BP X-Google-Smtp-Source: AGHT+IFO5G17Z/aSbnFl1izEtytTzjyDHPAC2GSkCyKOxlkJnXKbs6uNSZNVR1ANbd4JIGqvNlRpR+vZ4Q== X-Received: from elver.muc.corp.google.com ([2a00:79e0:9c:201:38c7:85d7:36f7:e198]) (user=elver job=sendgmr) by 2002:a17:906:54a:b0:a2c:7164:ff8d with SMTP id k10-20020a170906054a00b00a2c7164ff8dmr38908eja.3.1705310852357; Mon, 15 Jan 2024 01:27:32 -0800 (PST) Date: Mon, 15 Jan 2024 10:27:18 +0100 Mime-Version: 1.0 X-Mailer: git-send-email 2.43.0.275.g3460e3d667-goog Message-ID: <20240115092727.888096-1-elver@google.com> Subject: [PATCH RFC 1/2] stackdepot: add stats counters exported via debugfs From: Marco Elver To: elver@google.com, Andrew Morton Cc: Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kasan-dev@googlegroups.com X-Rspamd-Queue-Id: 3C76510000B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: yryb77poomzh8qi41ggecrkppb9nwgst X-HE-Tag: 1705310854-23279 X-HE-Meta: U2FsdGVkX1833loIqkUnUh+B+HonjFxXlPG9SnvcB+Z4HtKv7B0n2LcEOZGvYfKKuiQ5uJwhkvZ6tfVA3xlxjHEZ8zso+UBGtOQWw0BsgWAu3Rj8i05+lrdyczWQn92pmWZE0gMedXJckhjb5Yx195n0f8Z+CvAPV1KdwNe+uuDUloo208YMmc1Qq8oXLKCxfenLNFn+R35rbYJGSYVXDqhC5kzc79Q+njEz0jwk/EgX1GgZdS5f3BHGMQQHrTQ9GaFdMclVOlSMvvV8EsG+erGCXKrtPODtTJeoe8fHGXXXFjWxs2oUJdMs70jgpALSWy64fzydzy3IEDLIZranDTvQM2ReVpaA1S41pNL39SNxaC1aEzQxE1Il0fyQwvj657TesUhpQSsS1tR8YspxPKDySOFhJdOqkY1klunSbRs4E7Gu1rr6KyH2svBvsda55xTMklcUFb4cX//hlGHr5cnot+awSQP/f2jvI5l9gpBUDCXpHy6FKyJwsrrqt3kWTgGq7K3Eb9vypNS0d0tGHadVkNvyYDh/fHFrFlIcZADb4Xr0ySOq415hZdbuIXItJkDB5xtqE5cUNNpuSJIPMfId+Z6laec4qA25o2IXlC8TQP9skUosndwpk2C3lLEGvwrYMSFetuzRzMY8k8g1qQbV9C84102BekmdtvoF+R6eFh+p0tvpmocA4/NGJM6jrbfI8LIXOPAAmYjlfeKXj2c/KtefK/u5MEIFQ6ALt44OseSKLLuIJOId4FBQ8VLxZBC782FNsjmq/RwpEcbOu1hcjkv4PXyf5qRnZd9jaQMHiqldh45WO8dSeec9/TfOgJB9cE+Tq/TSl8s9qt0Iy8ksIXbhTbCExLnHyb+oTkhPUaPQBRgyUmdlrAPixQ/vZlt2vEDa08/QAxG/MDrqSdORSqyleWla9R6fVgVk4fkC54t+J94mOK5fKi7WWGD/TyQVgs5fQwR0VcQha6W 5Fe9LVG6 XEv8aRx3RieYLN/uQKd0e3An2YMcMf32fT2GLZVMewmpHfyV62WAjgcmdhQn/T8r9u7JMqilMqmctK3ROLloioDsR8N50/5xzFVHoRjt5VJEpSyqQRM/zt8fAUzm9l5N8YbJtJLr4oktwQJQyfU4peNBid3AaB+57YTppVMfDWZpNZmBAQuCk1LBXQHe87bXyB1Ot4LLS87PBOQn79JcL3A0H0JSEUm7FMuyKm9m4wlVmDfWXhyPtPdEw0CgoxeUS+VslQBetoNUC0TKM6PtqbiGl75B3KX7+8tHkTN8aW/REFkMEv6W7fWdREEnBorwNehI7B5oyTB/csroyidtGPwSy2QHZUoT80iWGoCxuG/Qs8AgK3tBjDybBHOd36W4wQ2oKWCux6TcT9PmHgA97F3FfBs153q/ZO/bTGVEqLqKdd/feeGjx0EDMd78sxpVNFNVYfyeGnIIxW2Aj33WXgYfM0Jb/O1VrjCaqJNDFNbmmNMMYz4nidqVD5/rJRj6cpIZW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add a few basic stats counters for stack depot that can be used to derive if stack depot is working as intended. This is a snapshot of the new stats after booting a system with a KASAN-enabled kernel: $ cat /sys/kernel/debug/stackdepot/stats pools: 838 allocations: 29861 frees: 6561 in_use: 23300 freelist_size: 1840 Generally, "pools" should be well below the max; once the system is booted, "in_use" should remain relatively steady. Signed-off-by: Marco Elver Reviewed-by: Andrey Konovalov --- lib/stackdepot.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/lib/stackdepot.c b/lib/stackdepot.c index a0be5d05c7f0..80a8ca24ccc8 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -14,6 +14,7 @@ #define pr_fmt(fmt) "stackdepot: " fmt +#include #include #include #include @@ -115,6 +116,23 @@ static bool new_pool_required = true; /* Lock that protects the variables above. */ static DEFINE_RWLOCK(pool_rwlock); +/* Statistics counters for debugfs. */ +enum depot_counter_id { + DEPOT_COUNTER_ALLOCS, + DEPOT_COUNTER_FREES, + DEPOT_COUNTER_INUSE, + DEPOT_COUNTER_FREELIST_SIZE, + DEPOT_COUNTER_COUNT, +}; +static long counters[DEPOT_COUNTER_COUNT]; +static const char *const counter_names[] = { + [DEPOT_COUNTER_ALLOCS] = "allocations", + [DEPOT_COUNTER_FREES] = "frees", + [DEPOT_COUNTER_INUSE] = "in_use", + [DEPOT_COUNTER_FREELIST_SIZE] = "freelist_size", +}; +static_assert(ARRAY_SIZE(counter_names) == DEPOT_COUNTER_COUNT); + static int __init disable_stack_depot(char *str) { return kstrtobool(str, &stack_depot_disabled); @@ -277,6 +295,7 @@ static void depot_init_pool(void *pool) stack->handle.extra = 0; list_add(&stack->list, &free_stacks); + counters[DEPOT_COUNTER_FREELIST_SIZE]++; } /* Save reference to the pool to be used by depot_fetch_stack(). */ @@ -376,6 +395,7 @@ depot_alloc_stack(unsigned long *entries, int size, u32 hash, void **prealloc) /* Get and unlink the first entry from the freelist. */ stack = list_first_entry(&free_stacks, struct stack_record, list); list_del(&stack->list); + counters[DEPOT_COUNTER_FREELIST_SIZE]--; /* Limit number of saved frames to CONFIG_STACKDEPOT_MAX_FRAMES. */ if (size > CONFIG_STACKDEPOT_MAX_FRAMES) @@ -394,6 +414,8 @@ depot_alloc_stack(unsigned long *entries, int size, u32 hash, void **prealloc) */ kmsan_unpoison_memory(stack, DEPOT_STACK_RECORD_SIZE); + counters[DEPOT_COUNTER_ALLOCS]++; + counters[DEPOT_COUNTER_INUSE]++; return stack; } @@ -426,6 +448,10 @@ static void depot_free_stack(struct stack_record *stack) lockdep_assert_held_write(&pool_rwlock); list_add(&stack->list, &free_stacks); + + counters[DEPOT_COUNTER_FREELIST_SIZE]++; + counters[DEPOT_COUNTER_FREES]++; + counters[DEPOT_COUNTER_INUSE]--; } /* Calculates the hash for a stack. */ @@ -690,3 +716,30 @@ unsigned int stack_depot_get_extra_bits(depot_stack_handle_t handle) return parts.extra; } EXPORT_SYMBOL(stack_depot_get_extra_bits); + +static int stats_show(struct seq_file *seq, void *v) +{ + /* + * data race ok: These are just statistics counters, and approximate + * statistics are ok for debugging. + */ + seq_printf(seq, "pools: %d\n", data_race(pools_num)); + for (int i = 0; i < DEPOT_COUNTER_COUNT; i++) + seq_printf(seq, "%s: %ld\n", counter_names[i], data_race(counters[i])); + + return 0; +} +DEFINE_SHOW_ATTRIBUTE(stats); + +static int depot_debugfs_init(void) +{ + struct dentry *dir; + + if (stack_depot_disabled) + return 0; + + dir = debugfs_create_dir("stackdepot", NULL); + debugfs_create_file("stats", 0444, dir, NULL, &stats_fops); + return 0; +} +late_initcall(depot_debugfs_init);