From patchwork Tue Jan 23 09:33:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengming Zhou X-Patchwork-Id: 13527037 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2234FC47DDB for ; Tue, 23 Jan 2024 09:34:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA79C6B0083; Tue, 23 Jan 2024 04:33:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A57D26B0087; Tue, 23 Jan 2024 04:33:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 920E36B0089; Tue, 23 Jan 2024 04:33:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 82D296B0083 for ; Tue, 23 Jan 2024 04:33:59 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5CDA4A1E6A for ; Tue, 23 Jan 2024 09:33:59 +0000 (UTC) X-FDA: 81710064198.03.9F71E65 Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) by imf04.hostedemail.com (Postfix) with ESMTP id 8300F4000F for ; Tue, 23 Jan 2024 09:33:57 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=bytedance.com (policy=quarantine); spf=pass (imf04.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.170 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706002437; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MVB7ftxAIVcq2QIA10U3ciYcZCcQ0jJHuOcqORi4sOA=; b=lrnwPba10nFniSCul7+YmsRUlKVpSCvix3z7B8X+rysK/BOkDbWyUsNKL4y8HoLsPg8kAz 3zF/8bXqfR66hOOMzGiYUH4Jc50RiPIsgBD1l1C8f3+L9DPMnc5SGR00FqBR8CKI32UxVg VeYLm0snbVaAZjTwbpFTG6NP3OyR7Sw= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=bytedance.com (policy=quarantine); spf=pass (imf04.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.170 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706002437; a=rsa-sha256; cv=none; b=Hu6tA/ptrXVWoVfOCei1VeUE2l8DeNlwTnJ5ODmPGLxZkJrAFSdwZ0m3wIY0nmCff9zPBj PdLxpcI8UNvH8QGPdWzOqkIp5R7y5ueVKuj5gOD8yqTko8MNShSn4jgit+aAYYJuCwz6s8 A2dMsT7lYPi5EPwCH8n8mews46XXOa0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou Date: Tue, 23 Jan 2024 09:33:30 +0000 Subject: [PATCH v2 2/3] mm/slub: remove full list manipulation for non-debug slab MIME-Version: 1.0 Message-Id: <20240117-slab-misc-v2-2-81766907896e@bytedance.com> References: <20240117-slab-misc-v2-0-81766907896e@bytedance.com> In-Reply-To: <20240117-slab-misc-v2-0-81766907896e@bytedance.com> To: Joonsoo Kim , Vlastimil Babka , David Rientjes , Roman Gushchin , Pekka Enberg , Christoph Lameter , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Vlastimil Babka , linux-kernel@vger.kernel.org, Chengming Zhou , linux-mm@kvack.org, "Christoph Lameter (Ampere)" X-Developer-Signature: v=1; a=ed25519-sha256; t=1706002427; l=1153; i=zhouchengming@bytedance.com; s=20231204; h=from:subject:message-id; bh=cuwSKTPtiNqZTZ2D9xT7/HRhzSDVJccC9FWGQ4Ep0yw=; b=mJdc+YnrEwU86ZPAWNO2hIOji1KtwvraB80SdFXY8/3S14XjUgouN7U9QY4VsPfbv0iWMF2qa jNF2VdpUcx9CAUqOdk6g8VKSrJo7sg3GFd7D/n6FIaKYhdVOjnloqeD X-Developer-Key: i=zhouchengming@bytedance.com; a=ed25519; pk=xFTmRtMG3vELGJBUiml7OYNdM393WOMv0iWWeQEVVdA= X-Migadu-Flow: FLOW_OUT X-Rspamd-Pre-Result: action=add header; module=dmarc; Action set by DMARC X-Rspam-User: X-Rspamd-Queue-Id: 8300F4000F X-Rspamd-Server: rspam05 X-Stat-Signature: npbt889wkcuw8c1rggid38xxwx737puw X-Rspam: Yes X-HE-Tag: 1706002437-939872 X-HE-Meta: U2FsdGVkX1/5ccsDRdlM57GDmfuFcciG8jaQu1UDTku2jCOaqh283cZxMAHV5knKPh2af66wydFMB1Tyit8ZHy4KJ8k+HEQhHjDs0pfypzTGr1mKWgrZPOXVXAIQnvcixrBQpn6/5KPqe5VzBxifJlZFmKfAofay34iHp7RFOM5Kk1nyIdHQzhPU7/sGDHOW5QvAJOCXDdUObsdFge169kQm0sPNO43NB2LaSsy3Aq2P1p7BsM5mqC4hvuN7JV5gNMxFySxC3l8/mnMd7h2K8Nfw831XF6TWFTiRz5ntuYZ4nq+XEmnqUiNbFtbyb/wWjKP2kgakPUIQMucrSazwBhPqU4yHamYvxcD+p5Ojy40HZrS8Vnt9tiH14HU8SJWpWytzbJX6Lg2Nup3skpOdvFRzwVZaYcs1bhkV/7Ykj7DyfPUxh7KhTaOAlAKngecNGg6CJonUCd+X6DGqs2N28LcLn8ezkSYNF85eQ5OIYufxwVPXXi39VD0n5Mvhzv+Pa/F3C0a50vnMmyVDtfd/VfsoiXyYn/91iDahpb3RzIyQfuBsvH2FItCylp8k0dBIJ1HahBC6pQK6VjGOw3EOcuu8ug8FgBZhwU4NYqUiEyQ1xXMYfes9C3PaQjajJlGhtzlopt1YCJAzZkqIliRfrTl+SrC8M9nuzElP6XJwpswpgXuZm4vjLsAweLNBo3JEYy4FIVW0jZP99B/H0Y+ch6kynlTZdCU0jV5W/M8P6C0E3fBLLaHB5HJ97VoIsbdhZP50XAK9ekX7ESZjNhNo8dLTMnJiMqPcLd42L04I7+xEpzG7TL9YR9Pl3R16rFJvcaAFPqWAYvIRCMrmDvj7Athm/6CTH1TE0N3fs4DAUIwKdGdLa0xCiisxeuPcnLoTK19FqYXZINkF2zeLR8YKL8e19lrBAmwJ3Jx4HjDuBtwLS+PItb3efKIPJrrypgPnb+HPGtHF7nOhOB7mMle dIaikqXw S7K9TiU6xpBK84IRQlC5aHHgm8Zmhwd7ugG4rMZLxBfTpob7/S/WMCawHfvmAO89nXWsDjWRyGTDIo9SVIJupqGpgMwj5sNsoqlk8K3p4VeFdKejM+cF/3GqXZ4/jXXe0OaWpwYgoCVLIS4QPO3lsm5O/vHMeUmtDCJtgn1UdPq5x9zfjJTNNCLxoeDmuxh63gII1qXBJ3hu7yUwZ73YsQc3AJm0So9PpcY4cSr7eRdFJCGWF/xmM42+MvkMucu34qipW3b5TDYIB1MdHZ/5gwuGFWqxutMrAPIYOKK8nLUEnF/UgQPUq7TIrxzWK4r+gE37/pStBeQpV0QHlAAAyD7RZrxLl5dshqeaeGW9gI6fvNnhhpzLysiaAyDC3B1OIUB1DPxBWiJCKWiwtdHXjzLAQP6Os6idmZxN05SYClvaGcQZ6rspbSvJXRxpLFlz8SOd6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Since debug slab is processed by free_to_partial_list(), and only debug slab which has SLAB_STORE_USER flag would care about the full list, we can remove these unrelated full list manipulations from __slab_free(). Acked-by: Christoph Lameter (Ampere) Reviewed-by: Vlastimil Babka Signed-off-by: Chengming Zhou --- mm/slub.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index fda402b2d649..5c6fbeef05a8 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -4188,7 +4188,6 @@ static void __slab_free(struct kmem_cache *s, struct slab *slab, * then add it. */ if (!kmem_cache_has_cpu_partial(s) && unlikely(!prior)) { - remove_full(s, n, slab); add_partial(n, slab, DEACTIVATE_TO_TAIL); stat(s, FREE_ADD_PARTIAL); } @@ -4202,9 +4201,6 @@ static void __slab_free(struct kmem_cache *s, struct slab *slab, */ remove_partial(n, slab); stat(s, FREE_REMOVE_PARTIAL); - } else { - /* Slab must be on the full list */ - remove_full(s, n, slab); } spin_unlock_irqrestore(&n->list_lock, flags);