From patchwork Tue Jan 23 09:33:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengming Zhou X-Patchwork-Id: 13527038 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8374BC47258 for ; Tue, 23 Jan 2024 09:34:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15A8B6B0087; Tue, 23 Jan 2024 04:34:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E35E6B0089; Tue, 23 Jan 2024 04:34:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDE206B008A; Tue, 23 Jan 2024 04:34:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CF52B6B0087 for ; Tue, 23 Jan 2024 04:34:01 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A0C531401EC for ; Tue, 23 Jan 2024 09:34:01 +0000 (UTC) X-FDA: 81710064282.17.F2F4A70 Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) by imf27.hostedemail.com (Postfix) with ESMTP id B9CDE4000C for ; Tue, 23 Jan 2024 09:33:59 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=bytedance.com (policy=quarantine); spf=pass (imf27.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.170 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706002439; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3IpsupgbB8KI/0CM5THMh8A5I+UI4shfPxgInFnmHr0=; b=t7HuXmMGEUSOWXfpqzViWgT2Yjwby/67yBTTJy28yRh29rXwzummJMO0DUodXziXpdfgXu aCUAvTO6X3NhCh6x+jdMht3FiHCLCktsLIzWr03yWuoEZIjlL3Z0FWnGf/dwfqUzSeMty4 /TDaoLPLafQZ3Hruhr/eaLbsWmWGr+I= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=bytedance.com (policy=quarantine); spf=pass (imf27.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.170 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706002439; a=rsa-sha256; cv=none; b=VvErqOrbgEVZFPg2v9qA349d2IcJgSfdO9mO4sqvQuJcQ8kaIu9xAsoODRbzNzVPKkSa2z Jxy69bBTMp92z//w2WhDCWzEiAybMVf/m9IIGRddXSDxcOPjUGK2FhsQeVPhigCzlELf5U kIet7W1nmRgHhV2IJXq8hKLzXMxhMQU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou Date: Tue, 23 Jan 2024 09:33:31 +0000 Subject: [PATCH v2 3/3] mm/slub: remove unused parameter in next_freelist_entry() MIME-Version: 1.0 Message-Id: <20240117-slab-misc-v2-3-81766907896e@bytedance.com> References: <20240117-slab-misc-v2-0-81766907896e@bytedance.com> In-Reply-To: <20240117-slab-misc-v2-0-81766907896e@bytedance.com> To: Joonsoo Kim , Vlastimil Babka , David Rientjes , Roman Gushchin , Pekka Enberg , Christoph Lameter , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Vlastimil Babka , linux-kernel@vger.kernel.org, Chengming Zhou , linux-mm@kvack.org, "Christoph Lameter (Ampere)" X-Developer-Signature: v=1; a=ed25519-sha256; t=1706002427; l=1540; i=zhouchengming@bytedance.com; s=20231204; h=from:subject:message-id; bh=ZXzd5ZM1kPfc29nku387qFGBNfMPhmyqnVdI70QYk5o=; b=eO3C/qpMGEax+MfzVtLNHcbDe+c64BixN/5g6zrbrjsUMaxGOraPVsgUT0dI0grRB+ucrDO2l j/WoJtVo5iuD79mh2KmwA9Hx/yNMXxarI/hcbm5mwl8odmEhDnXWi2x X-Developer-Key: i=zhouchengming@bytedance.com; a=ed25519; pk=xFTmRtMG3vELGJBUiml7OYNdM393WOMv0iWWeQEVVdA= X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: B9CDE4000C X-Rspamd-Server: rspam02 X-Rspam-User: X-Stat-Signature: x9m4m4b6ow6oadtridk6iow7tch65imo X-Rspamd-Pre-Result: action=add header; module=dmarc; Action set by DMARC X-Rspam: Yes X-HE-Tag: 1706002439-765185 X-HE-Meta: U2FsdGVkX1+XR7DhmTh84z5GfRpOlvn/kRfT65Hmk36EZltjdK5z+CWU7DvRl8JuBin9fsHXfzlk7T1lLKE/+lCxcUBj5cCffEwcu1KxzFoAhcZMK3bCqbNXP2U4NveD2v7Sjrkwphn4spZpSeC2ILSiO2fVRmEHr6XMoleKOfBRZUZ7Rgtu7KOZT/S5jbypVNp8/abb6y2gi6DR2yRWddMpe8hu1qrGHNw3vtPBR9J/r9uZpCI3O9DCyeN5CrWgyoTN89/zX9LwmzZGlQTulfe9SV7CEM6XTf4zOgqhCCDXRSX6ojHhl3oc0AXw1AqYEIIhLKPZbDnKY+Akw8t/dXppqH+zZjoubtIq0ToB28aGAe4ymdduDBO4hTZ8RyT/aHr7Xo2ZTAWUHuMKCLXPlRB+W4rd8ZSBd8Kf8FgQ0DKrV6Yt2edai1G/oWRniWCIJiRJDYq7L1TcdzrxzZKI8bntpiQfq/JiOvkG6E75YaqWMikTmqSwU9k0b80yMHszPg7Lf1/wRriUXFUFdcBkThR90uJvaTw9gNsile7a1716E6G6AaFHE/6F2wZ//UpmZQF+f7X4IVKOnhr32NuJI69rnAvy7/lSS9GfQUmV3QTgV+Qobux/A+43OOzr9KMi6dUbtwb2qzMPalU1Z4UDMvycKWQ1eggC3fkoqN9GBspGTRjtWHYszsI5MI8Vft7ZfliDI748kZ6dhdYI+12nKeyEZXCKfQe9gMyItI8M0vim0q1H2r8E4TeqqznwSof3BBY9XsJEMYoStqW5ZrTxhDe9GcAl91v/BXTFMbiNeD3lYsLA+X878TMC2BUyLqGulNSdoCpk+DF1cYwSPJiakPRysN8lqzqSe+Dlqbq7tNztKHjbh9eamGLvNUX3cAiNe8MEg++FTKO2Za/ijz4x9UtoMKEUas1RQS8jfRM1Wk+0DyXlF3mlGNrDQOrVIyyV9JgIW8BSYR/aDpWM9zD HJ5Kpjkr as7jettg3x0BRXh5nkFU52coi4Grcf+dqhk+DmXm8JnS3JMyxGn2aB7pM6dvmfz1FkmDge4cya4r2JMMmhkpx3EufWo6OQKpkQxD2qm/WWOGrqddHhPO+VPWgP4YTod4DPWFQ+Z1Z3iGfEVgz4zjkv1F1I0Th8eyTcQTQT3W9kEGVRqqQ3BsJbNoG/bvqEFCxLZ/fmovCX7rv2q5UlZdU3c0XbpuRovF9WtiTPOk/Q9t4oUEzQyqmSGHwSGAj7doGt+rgH83R8mJf7uQsqHo51Mm2X0tYEYtzY7TK2nVSRfz9vD7yJFx3FZo02KubJCKbimKs8sNEada23KqtKS+BLzfjy+26b6tdBA7E3ob1Y3ZMOSx97zllCR4OcuhTNLymm5Qrkk2n+iLHv8X3B0ypuvtesUxaRW/K9aXHZQ3IA3yq9ICliQYVIqDrdveVsYb+cDP/x0qQSks2TsfcslVnoca4AeQO1rOhcjN3gvbVPqLJ3VBVpTpbCiBizPmNPbkM8lQ6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The parameter "struct slab *slab" is unused in next_freelist_entry(), so just remove it. Acked-by: Christoph Lameter (Ampere) Reviewed-by: Vlastimil Babka Signed-off-by: Chengming Zhou --- mm/slub.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 5c6fbeef05a8..7f235fa6592d 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2243,7 +2243,7 @@ static void __init init_freelist_randomization(void) } /* Get the next entry on the pre-computed freelist randomized */ -static void *next_freelist_entry(struct kmem_cache *s, struct slab *slab, +static void *next_freelist_entry(struct kmem_cache *s, unsigned long *pos, void *start, unsigned long page_limit, unsigned long freelist_count) @@ -2282,13 +2282,12 @@ static bool shuffle_freelist(struct kmem_cache *s, struct slab *slab) start = fixup_red_left(s, slab_address(slab)); /* First entry is used as the base of the freelist */ - cur = next_freelist_entry(s, slab, &pos, start, page_limit, - freelist_count); + cur = next_freelist_entry(s, &pos, start, page_limit, freelist_count); cur = setup_object(s, cur); slab->freelist = cur; for (idx = 1; idx < slab->objects; idx++) { - next = next_freelist_entry(s, slab, &pos, start, page_limit, + next = next_freelist_entry(s, &pos, start, page_limit, freelist_count); next = setup_object(s, next); set_freepointer(s, cur, next);