From patchwork Mon Jan 22 12:38:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 13525419 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 801ECC47DD9 for ; Mon, 22 Jan 2024 12:39:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38CC28D0008; Mon, 22 Jan 2024 07:39:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 315F98D0001; Mon, 22 Jan 2024 07:39:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A1718D0008; Mon, 22 Jan 2024 07:39:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E07AE8D0001 for ; Mon, 22 Jan 2024 07:39:24 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 87020A09C2 for ; Mon, 22 Jan 2024 12:39:24 +0000 (UTC) X-FDA: 81706902648.13.149D87F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id DDE54180012 for ; Mon, 22 Jan 2024 12:39:22 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MDyTlcBL; spf=pass (imf24.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705927162; a=rsa-sha256; cv=none; b=oa8t4VKIPUYJOPTDeWb1GBumGk6u6kure1Z9bOvD25gakFh5pz4gm/uAvrTs4QojlCe5uG +CAN0hlst5CqkOodjSJBCqmJhOR0eIalpZjYNrnpHVasoO4D+2j1eaTMObDhoud9mzgm1t U5f2wTvlEpXacQ5QAK0Qbi0RAkVtnrc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MDyTlcBL; spf=pass (imf24.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705927162; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4H/QyaTEJT6yM0W34T+DHhl8mPiadWYAfCey1J2x+wk=; b=yp0OApetbmNLh9gkaSV9BBuuMDEGUsgub8T/EpOhTpqOzEjK6JEoo3e+2AxgV8wrftPCbM ORJqLHiGMdPzZ3P9r71CEuRO7QQ61QENExTRfVqMwQoVjXGICg2JEne+ltcCObObxPSCz6 i+i6zEFTeV5++63h0rO7HGewCWEX9fU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705927162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4H/QyaTEJT6yM0W34T+DHhl8mPiadWYAfCey1J2x+wk=; b=MDyTlcBLUFvLxJRMaRRUJ5yHQz9ZrXZzz5n6ya0KBa3H2ripCdbArJhztVtj8/dM1oDgyf 0FJ/fSq4NIuHTDFyJpQqCWKbt2QkSFAHLMwXpc+7+uiQatXnc41i7Vmum4qTuh9S9PwBVk 05jT4kAPHFWp8zjaUhaeBqqXuKuLimQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-491-8WwqpJQRMMC-Y1cHcAnhdA-1; Mon, 22 Jan 2024 07:39:17 -0500 X-MC-Unique: 8WwqpJQRMMC-Y1cHcAnhdA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2CE6688D286; Mon, 22 Jan 2024 12:39:16 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id E7049C0FDCC; Mon, 22 Jan 2024 12:39:13 +0000 (UTC) From: David Howells To: Christian Brauner Cc: David Howells , Jeff Layton , Matthew Wilcox , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alexander Viro , Marc Dionne Subject: [PATCH 09/10] afs: Remove afs_dynroot_d_revalidate() as it is redundant Date: Mon, 22 Jan 2024 12:38:42 +0000 Message-ID: <20240122123845.3822570-10-dhowells@redhat.com> In-Reply-To: <20240122123845.3822570-1-dhowells@redhat.com> References: <20240122123845.3822570-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: DDE54180012 X-Stat-Signature: 6eedca36yebg8zcjcz38q5zxh3meefk8 X-Rspam-User: X-HE-Tag: 1705927162-718681 X-HE-Meta: U2FsdGVkX1/3oldB7kS2KINOa+v+zCFxZFGw5NtpuaSCiBftybCNee025zUmSyQyxGPRiGmradWhMaJL0djzgEYbqDVSinOSqqomDzyr6y6pmW5G3ez0p2CDvg9/o5qFlZX2QfNEGXETCOwZM2CdduNXFKkbNYtDMtepcswlwQXX4hlsPVoraxCksCslk376RmXWvzGmqwTg8Sq5spdD0vmvNqXRlSEjtfNYGCIFrdxYwjx5NGkqe7EjhrT8J4GsafpBxHBdjn9yahLYxGK6UcHEjrXzOTef+NL30EMN2rJ9CrBohlQRJVEgLgCvVWlqIra3HjSKQ2LPrfixb8lkQbIj4lVYd/ELcWtj9o/gJtGjRwFaKYDPGEr47q9z1pkq7V4Le+0o3Vqld1pLhzzP1fE6rzZgV+9kyEP6eY8WEp0feRhSqqq6XEeNrDv3lcrtjuc9JbBznimgjxR6XbdbsFMPHpIjgrdpIjSwpNgVYcyn/QtnWPGwY3fzsKaqidXZwFz31SEokqc/1k7OcDvuSpFd1EuLLxVWlfhWVTeu2aS0d70jLNX4FSlUF4ppUT5OqReT81S7bruULt49HA+34LCZbp9EWmaGmnRj5W7yNDi0H8n9HDdcfIVzHTSczYa5SzJF2Lu9ESmC4xHo1F47XM+k0g6kuajsaIDfP17xW6ZNkSw7yHrkUk36FGwbb7j6fEoEcVDNy7c9MCe2mgAVsBXeaRa+pTFHxw14m6ghxkpsNvTQ+O75l2wJ7P/+UaC4rIatjqV9JwMjF5tPcKEn7o8Tu8nGQ66me0NmiJy3CaqhQWAjFOd26vGsqrgfpiVY+xI9z6nJFT8rozEpZlDBnD3JvPP8dG//zNjjsfxyEv8e4A89OT9dRMY16Psu+eVQB7yo97PEHiYwQIexPEJh73Iimkb3HVF6Fzbddg0hL0cnm9PrKnOwOP/FP0twNysa1Uru1NxfIsIxKI7SjOc x8CO2N70 8tK1mkd4VuvBd+8yKqkR3h7kBPxi7wnl3IbPHJLz7RQU+UY24eTXjRkoOtXvEtJTfqyftpRB8/egcQLI0xf0cyuswtioXcjgWesYI1uB0Nht3c7WjUD9YnJhavCdu8OoYeea2G887XodfUuj+wrZvH62bI+of772MUMaOb+jKpMwuwMNNRQwkI6csvhLehC256xwxhTueGM+fimxSAEehqTSRsfsh6jtGuIyhGxJZ+HyZ+bHQvaBpE0utn49rqgnn1+URKTV8JlbJT/mOfQU3k0ZCi5bx38LFVGnsUoKOfVpV6loBszh5ABhLxg61eHXhva/fLKshA2GD0aA22HEuQzydxB9S6AWTGRY+WaJ5BTxtVj2twcNZics7uvfcC9/rnZPCcbZSHxSnOLbMzwqGmSnIM0TsdzEU2mNz9Y6RmafYQL7MrfJCIv6pa5D1hTJrUH/dSak5NCZOB+8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Remove afs_dynroot_d_revalidate() as it is redundant as all it does is return 1 and the caller assumes that if the op is not given. Suggested-by: Alexander Viro Signed-off-by: David Howells cc: Marc Dionne cc: linux-afs@lists.infradead.org cc: linux-fsdevel@vger.kernel.org --- fs/afs/dynroot.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/fs/afs/dynroot.c b/fs/afs/dynroot.c index d3bc4a2d7085..c4d2711e20ad 100644 --- a/fs/afs/dynroot.c +++ b/fs/afs/dynroot.c @@ -258,16 +258,7 @@ const struct inode_operations afs_dynroot_inode_operations = { .lookup = afs_dynroot_lookup, }; -/* - * Dirs in the dynamic root don't need revalidation. - */ -static int afs_dynroot_d_revalidate(struct dentry *dentry, unsigned int flags) -{ - return 1; -} - const struct dentry_operations afs_dynroot_dentry_operations = { - .d_revalidate = afs_dynroot_d_revalidate, .d_delete = always_delete_dentry, .d_release = afs_d_release, .d_automount = afs_d_automount,