From patchwork Mon Jan 22 12:38:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 13525420 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFF01C47DD9 for ; Mon, 22 Jan 2024 12:39:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 804778D0009; Mon, 22 Jan 2024 07:39:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 759338D0001; Mon, 22 Jan 2024 07:39:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D2928D0009; Mon, 22 Jan 2024 07:39:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 465E58D0001 for ; Mon, 22 Jan 2024 07:39:27 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 264C312093C for ; Mon, 22 Jan 2024 12:39:27 +0000 (UTC) X-FDA: 81706902774.23.2D00C09 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 96829100012 for ; Mon, 22 Jan 2024 12:39:25 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I7A7wpnF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705927165; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2EbxtrFCFvcK5IiuVsAPW/KUPjjRaC8uqKzNdD5mRDM=; b=L91FCdt3+NduAyRphm60SdxpSqCf1U7PKnNoIf0w30k3Jq5F3ZJXB/LKgiwkUTe1i8u77G DAwjyb2FmMwyG1TOWn/VKLXIWJVwsPESR6KfKPGLME7tZHHgicjiYZ021/Q6bKtKzFUihm uQKvUskAFXYQIp1aGThTa7O3oRNVV10= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I7A7wpnF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705927165; a=rsa-sha256; cv=none; b=54SF0CslYjnldcStneJob1pncoIUPphbZ4f7M5m/FHVApWMABUdsyop3bSVZ9XTA6nX8lA aPjdNcTY+uCWfuIaYB0/9KcXtM/5UqVr8+qjIGey618mkv7BLD6fZJDkp3iHzwt+Lafjfi hA6+A7iZSnVZPSw3RgGV/fzzyCHixZQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705927164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2EbxtrFCFvcK5IiuVsAPW/KUPjjRaC8uqKzNdD5mRDM=; b=I7A7wpnF9PS6V0kWAppp1OcOMFrANO2dUfeKcZPrQZ+U/ZKau5YCqUDy7dzzROs/Agu9pe mLenogfO9tYutVcTrb3copza0yzavWwd9A0xB2nc85tzzch1ENsgAJNC4d8aQypUK15Xco B03A4im6EOjxGw9ExlgOU8IWE5XC2Qw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-cT5bUUrvOPuNd97vS-GVBg-1; Mon, 22 Jan 2024 07:39:19 -0500 X-MC-Unique: cT5bUUrvOPuNd97vS-GVBg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C9CAD88D283; Mon, 22 Jan 2024 12:39:18 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id E643B492BE2; Mon, 22 Jan 2024 12:39:16 +0000 (UTC) From: David Howells To: Christian Brauner Cc: David Howells , Jeff Layton , Matthew Wilcox , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel test robot Subject: [PATCH 10/10] afs: Fix missing/incorrect unlocking of RCU read lock Date: Mon, 22 Jan 2024 12:38:43 +0000 Message-ID: <20240122123845.3822570-11-dhowells@redhat.com> In-Reply-To: <20240122123845.3822570-1-dhowells@redhat.com> References: <20240122123845.3822570-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 96829100012 X-Stat-Signature: e9hw33s6tptgbe3m7oassnjwhxy19paw X-Rspam-User: X-HE-Tag: 1705927165-62586 X-HE-Meta: U2FsdGVkX1/ljcBPP9zhrvgfYUjGGK5Ltdnpi38ZsotwpQ3xPCO4Kldgx4RSe8xa3YqDQacsGfZL6HtlUHGQAhIPEK8xEeWEdK3v5zHsut1MuR3916gu3xv1w8TMYeqhA7VgfgLiBPGKaXICSK3zhRJlSsPGEVPc0aP11Yax2Q0MopSfgPfiP13ku54fWkQSVRSFNRdguKlD1HEVyt7pTe9wafBsKKPGUPAqTMWBBqmj2UNhAN/CSi1O9pDNAz4JuPzRCNrbvtVWqEiFFUP+iXGnD4zYVbKKx8sNVfVNr6IVakH5aooA/TS6nvylBoPNAbNi7w41n7XlGnH6YywtNpVYumACQO42bd8QGL9xog7o9uOxfr0SdT7SLHlhzyd2DYhCeLa1CSX+6x4OthePnMR0JdYp2dPKJUQEVRsPSEViRticxwlvvVqus0Lt5vWYxFQJWiLNYDP0V9EZ0zyI/JIOTq6vwq9VgC9WFG6a9fiQKcUdsxCtlHXNruTPsSZV9iowEQWm/v68XAM6nXM5hoe6svV8ZSljYUgNJaNntvZP4HgQ9ca4svXoUvvrPzXxLuVsrbZuaA2d+MhkgtFl7zCTJymcKWRKnseqV5ZlYF4UYWmTb0GpZqW2T8QWarVK6FrZ+RdN25HnCYdvhd3eDIOOIoBav7neEDkiCaVruIk23Wcsf4rC6tGjoQopyhKjlv1FzBWu/5JEzQ0MXbYd1HWvpXDWv3JwK4nTJnzPeUoqPqA2LsMiw66nBnb2pC6HUx+kX8LVCSGZO4Vfd+g2gLqgHhNfVG3MYS6aG5SLfN8Ve7PNmy5ubDT+LUAtGMcCYLiIYYXKCVawtV7yXWb/7VWjZZe4quoP9/Dc4CI5LJCNPEVMtuUEjVbpCPT6DFYR8OAfiw/PcGdGbbrEaWGJ8Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In afs_proc_addr_prefs_show(), we need to unlock the RCU read lock in both places before returning (and not lock it again). Fixes: f94f70d39cc2 ("afs: Provide a way to configure address priorities") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-lkp/202401172243.cd53d5f6-oliver.sang@intel.com Signed-off-by: David Howells cc: linux-afs@lists.infradead.org cc: linux-fsdevel@vger.kernel.org --- fs/afs/proc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/afs/proc.c b/fs/afs/proc.c index 3bd02571f30d..15eab053af6d 100644 --- a/fs/afs/proc.c +++ b/fs/afs/proc.c @@ -166,7 +166,7 @@ static int afs_proc_addr_prefs_show(struct seq_file *m, void *v) if (!preflist) { seq_puts(m, "NO PREFS\n"); - return 0; + goto out; } seq_printf(m, "PROT SUBNET PRIOR (v=%u n=%u/%u/%u)\n", @@ -191,7 +191,8 @@ static int afs_proc_addr_prefs_show(struct seq_file *m, void *v) } } - rcu_read_lock(); +out: + rcu_read_unlock(); return 0; }