From patchwork Sat Jan 27 01:58:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhang Yi X-Patchwork-Id: 13533917 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5250CC47422 for ; Sat, 27 Jan 2024 02:03:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A6E56B00A7; Fri, 26 Jan 2024 21:03:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 330B86B00A8; Fri, 26 Jan 2024 21:03:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 134426B00A9; Fri, 26 Jan 2024 21:03:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EB3746B00A7 for ; Fri, 26 Jan 2024 21:03:02 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BFD28A0938 for ; Sat, 27 Jan 2024 02:03:02 +0000 (UTC) X-FDA: 81723443004.30.ED3058E Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf20.hostedemail.com (Postfix) with ESMTP id 47B4A1C0005 for ; Sat, 27 Jan 2024 02:02:59 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf20.hostedemail.com: domain of yi.zhang@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=yi.zhang@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706320981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o+POuTt7I/XsNA/8ETXw49t7kNThw0TpGBA2GYXDn/o=; b=TaVTEKL4JCbj3nmhX6qCJqgu1WRlQGJoR9hvieB2wdRD3lcnBUI5SzdFtYnv8Bko6nG1Ox 9SL5qfvtmgJ8uD+NbNR6J9lJIbw8ng3JI93L7uGTJeqi9WK0AzTXtHtnLhMBGJPXAwqfXR 5QTQUHkrb5Ql7qGjTpEpLPI+nnuXr1E= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf20.hostedemail.com: domain of yi.zhang@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=yi.zhang@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706320981; a=rsa-sha256; cv=none; b=lzTY1HcGTThf3ZdxxElFIMuz3EymwDsNiOU+Z1L2E6Nngev7unThm2b9qed6TxhoLIO9QG kIknsIisWzz078CqPgjdGu36z23pyHswWs1wSpAmgO/flXGlc7AfxcZmAj61ejTMxsVnIL CrA3/xbTxB648BJ7M/8mnA0ljXXl2hg= Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4TMHrt0zQQz4f3k6J for ; Sat, 27 Jan 2024 10:02:54 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id 8B5ED1A01E9 for ; Sat, 27 Jan 2024 10:02:56 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.104.67]) by APP1 (Coremail) with SMTP id cCh0CgAX5g40ZLRlGJtmCA--.7377S30; Sat, 27 Jan 2024 10:02:56 +0800 (CST) From: Zhang Yi To: linux-ext4@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz, ritesh.list@gmail.com, hch@infradead.org, djwong@kernel.org, willy@infradead.org, zokeefe@google.com, yi.zhang@huawei.com, yi.zhang@huaweicloud.com, chengzhihao1@huawei.com, yukuai3@huawei.com, wangkefeng.wang@huawei.com Subject: [RFC PATCH v3 26/26] ext4: enable large folio for regular file with iomap buffered IO path Date: Sat, 27 Jan 2024 09:58:25 +0800 Message-Id: <20240127015825.1608160-27-yi.zhang@huaweicloud.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240127015825.1608160-1-yi.zhang@huaweicloud.com> References: <20240127015825.1608160-1-yi.zhang@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: cCh0CgAX5g40ZLRlGJtmCA--.7377S30 X-Coremail-Antispam: 1UD129KBjvJXoW7uw4DXFWfXF47Jw4xAr48Xrb_yoW8Zw4xpr nIk3WrGrW8X34q9anagry7Zr1jq3W8K3yUurWS9wn8uFZrJa4IgF4qkF1xAa18trWrA3yS qF4Ikr13Zw13K3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUP214x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_JF0E3s1l82xGYI kIc2x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2 z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr1j6r xdM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0D M2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjx v20xvE14v26r1Y6r17McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1l F7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E8cxan2 IY04v7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAF wI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVW8ZVWrXwCIc4 0Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26ryj6F1UMIIF0xvE2Ix0cI8IcVCY1x0267AK xVW8Jr0_Cr1UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JV WxJwCI42IY6I8E87Iv6xkF7I0E14v26r4UJVWxJrUvcSsGvfC2KfnxnUUI43ZEXa7VUbCe HDUUUUU== X-CM-SenderInfo: d1lo6xhdqjqx5xdzvxpfor3voofrz/ X-Rspamd-Queue-Id: 47B4A1C0005 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: s3jp4p6ib7g9hxxb3zibmmx4enhk9oyu X-HE-Tag: 1706320979-85242 X-HE-Meta: U2FsdGVkX18JR9VOGgQQqLH/NNC7pNTWyr1X5II09JZ5nUtpeNKf3y72ZdRLzp/FNwXKNEt3E+H6axCzlqU563dhY7eNWOK10MogHsRfMOTtl5dU1yw4f0lez/grYP+pVtnu9Af314Jye3uMbnQzpTqbfhjv6zJwUomu3g+IzoSuTbHd3UkfAeCLNUGVgWO8brnLaYbWgoz4jVcF/Ndcxnhyjmt8s+RhPkZOGPkoTbxOXwsEJzD7YAKUSSQ7ciJ7p8CgUJAFLF+XFGtGYveXL/ixtfL6wGv6n+0QItC+N/PCCkpNcKW4eVV0Gxf3ASya+6HKmeu1qSSAXaI669COQ6+soC+5V5tpUcvotnTSYGQfHZRpSf0pKV3IlkBtTX5aP8fLKGHAqANHypI+mgSnt2yGU+aRn9BN/PU1ydnG8vqy0rx/ZWAy46s8HUk9+q01eqhTVnbkzZkLYNNI0+UnxPmWWsCiIwibPh9ICB7fq2t0Q8ZWo4iJQyouzWqvLrkQuZnPrQ585TrQDEpBbsts4vp4Nl6WbkrEix5Dj0ACdD2t3CN7+xqNOgPVw1LQUGc4+7ir6MEjAebbFRq9Ozls5NaVByb3FFakLtPgwJClPc58DPFPnBn/Fctrx68n5vFhlBngL+RsKyCn7UA7JSjHbo0yYpiPWo/kgcSqbOsCvCvPTuByLYBmbyISM6PnMzVf44gCbL7o/KdrhDsOuiTQ2uBA8BuCXA1rZ2gndZl1m+aJMt26AZydCng0IPRtybdAO/Imy1C3BKjJC+anGDOlehi0mT6Giyuw9u+S/XKt2pH1gpN2j/AK0fOI0Rkd5yaIu71a3larZZMrtFM9fpyPAFc8KolWdICjWGG9fURsfZXGPG5oeweH3VqK1U8hTKKqqrVxpbruRmSlj1qGf6dBU+Uvkc7cPYk+fyRbt+nvOkzq98+oFumRR62db29Og3joe/zjHtZ67pV7w5B8FHM vuZxL6hr O4UOFxwPnsArM3JsDP06fiO9w3gH4nkQ5vsMlvdlPryjAWuOHYFEnXCBOXYiJg9y7MPnHcvQ0CNHrA8fjnYh/RoZ4eeAxnQ0QNlqUhsl6Zb5ieFiRXEOYp4Mkh9Vyns7Gx0xB79yr+HnQP02esJxPvYwnki/wI4GYQUjgx+fhITgG7/FXFsX2Apy1GpUFhE60ng/O71Rk6olMqwKfflgcSrmcWM9hd0FhflgPng83ULwq0yd83a73hp6rRUSDC06iFPQF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Zhang Yi After we convert buffered IO path to iomap for regular files, we can enable large foilo for them together, that should be able to bring a lot of performance gains for large IO. Signed-off-by: Zhang Yi --- fs/ext4/ialloc.c | 4 +++- fs/ext4/inode.c | 4 +++- fs/ext4/move_extent.c | 1 + 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index 956b9d69c559..5a22fe5aa46b 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c @@ -1336,8 +1336,10 @@ struct inode *__ext4_new_inode(struct mnt_idmap *idmap, } } - if (ext4_should_use_buffered_iomap(inode)) + if (ext4_should_use_buffered_iomap(inode)) { ext4_set_inode_state(inode, EXT4_STATE_BUFFERED_IOMAP); + mapping_set_large_folios(inode->i_mapping); + } if (ext4_handle_valid(handle)) { ei->i_sync_tid = handle->h_transaction->t_tid; diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 30067775e828..a1dbfc2b904c 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -5384,8 +5384,10 @@ struct inode *__ext4_iget(struct super_block *sb, unsigned long ino, if (ret) goto bad_inode; - if (ext4_should_use_buffered_iomap(inode)) + if (ext4_should_use_buffered_iomap(inode)) { ext4_set_inode_state(inode, EXT4_STATE_BUFFERED_IOMAP); + mapping_set_large_folios(inode->i_mapping); + } if (S_ISREG(inode->i_mode)) { inode->i_op = &ext4_file_inode_operations; diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c index 7a9ca71d4cac..aecd6112d8a2 100644 --- a/fs/ext4/move_extent.c +++ b/fs/ext4/move_extent.c @@ -560,6 +560,7 @@ static int ext4_disable_buffered_iomap_aops(struct inode *inode) truncate_inode_pages(inode->i_mapping, 0); ext4_clear_inode_state(inode, EXT4_STATE_BUFFERED_IOMAP); + mapping_clear_large_folios(inode->i_mapping); ext4_set_aops(inode); filemap_invalidate_unlock(inode->i_mapping);