From patchwork Tue Jan 30 01:35:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13536658 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57B28C47DA9 for ; Tue, 30 Jan 2024 01:36:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 821DB6B0096; Mon, 29 Jan 2024 20:36:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A9E26B0099; Mon, 29 Jan 2024 20:36:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 671526B009B; Mon, 29 Jan 2024 20:36:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 28ADC6B0099 for ; Mon, 29 Jan 2024 20:36:02 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F1152160B12 for ; Tue, 30 Jan 2024 01:36:01 +0000 (UTC) X-FDA: 81734261322.25.BDF743D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 66989A000C for ; Tue, 30 Jan 2024 01:36:00 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HAAuZhTk; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706578560; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GYqOLNJHvqChvImZaDzafeF6/fUwF8ZZwtM6fSgwe3g=; b=K37iC25fRvlvpw4n1WB0/8Ott83NtnfvWMGN6kJ/LG827PsyRMMuBCPV0xo5meGZQTNFWs H0TsnfXME0+ulg6UhlyfT1mgxJTdQm2ZC/edbiE9jl5WOk4pSSyUE2VGgp8esQr+ZrlXHO MP7TyK7+QAyQsOki4LNv+GNTMh33fhs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HAAuZhTk; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706578560; a=rsa-sha256; cv=none; b=2e2QQi+7dC2qyg0rbaErnLOw1yAb3qVUZOebghEUBCQ6O0mvN7ysP/4aNAmxIXWPIkNXYj xPkrgf1CxJk1PtWMyhNrmEFKcRY35uFufnN/ZXYzfbIZGD5X+WB649j10lzXjtG/Vbc9qw gSdJZARnl/DgaJsF4Zg0dpeDKNbnSPQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 90D56625E4; Tue, 30 Jan 2024 01:35:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0964FC43330; Tue, 30 Jan 2024 01:35:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706578559; bh=OvMM8iJkFhvWNhsVLNub4HhcW21nuv8NW9IL6jHpWeY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HAAuZhTk9Ynq9mnYQP2Pkmcbpcd5Lg6BDiyjM+rZXnkWTHikCQS1p9FHvI24SkFhD ZdhKkrHuUzxpbRD/VtTqVpzP0p+HECcFBDoPaDHb5356mZzQC2joaa14LWsPrDuGfB lJoV1XYenWuoKc3znKqn8HLKPeKxHvYJtmWfopvS/Z5aAViVj17+6NmxfJVPcyDj8G Ue/aEGz9BUlxrfWlCSAOQD4ejnXtZXptj80MiSBKwxqs2FpaIehQdmnbmPE8ooRgT0 EvBuZRpWCsb/FbF4hz5ysYQZXWg85FXnwU0SECSbVZp7NPKKPdr50dZkyM2fr9o0lL gA1Iyha6cBm4A== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/9] mm/damon/dbgfs: make debugfs interface deprecation message a macro Date: Mon, 29 Jan 2024 17:35:43 -0800 Message-Id: <20240130013549.89538-5-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240130013549.89538-1-sj@kernel.org> References: <20240130013549.89538-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: iqmq1ewcib7jmr6stqo93cfiet4gpwoj X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 66989A000C X-HE-Tag: 1706578560-346871 X-HE-Meta: U2FsdGVkX18MRHoue/A816WIdC/vLHBulqo6fLFUjjr2nAd1N1HK4wpN1JMrgZK+gtB03we7q6XgdIelWdseQZOhNe+gmnp5tVaMtRAtwU1X2/2mEzEPP7sZ9615vBIr9XbMQrgVvnXYQBnCPR7kBBaQYJosghesoaHu0oCSHTxpep5bOFCH+tbCwAUqP+Wyu6WCJzQaVA/q9oarKex2ERvXBTD9GLPtszbOdlqYjfM40eFmgPb48HisGY+Wf1M0VCFYrvo1oz9e+2419+p0LECGM7enfdU0RA6k7FKKcFnEZjKfXFe6sNk9NudQpY3mPrCHBxeVTjYFsIX8o+X8f4++84pKf/DxkonxHGcc4BUjk/y5fn7brRRiFRJzVzmc9Bt0UYBk02fKreUPfZgHwoHKYwHy9pEVUc0NUQVsM+DcOIaCpCCLoTGZ6f5ioiQOQJyck0Whub2i1NNxDLsTQgi0LZnO1ybtC+j9eFW61G0Zp3HAdaBwIIwEbXouTnznBNpwwIv72tee+xgka3JED3/dWTQs6EvSQCvdv4YXOx7PT9r6mV0Y48lzZrtopev0XXo4a6qPm9g4WubU1k56WoWPbYH9Unb3er5pSb5G7ZL5F2nlFhI2t6sef7wVnrf1f53PchC0Nq1cPkPsekymj34vNCqsLN0tjGXqPRvX9g2CVbf1niwHWapk7qB4tilSSsmCsQLPO+/XVNp0z8v1VcvuiF9+kLcJrpdGpXcd/h9s6kOSrHs2FZbmNE+VK3BWDfvVvLjsVGtuiHdERFrUlYwupU484x7sqBes2FiEuiyjmrR9uYYOkH7D1rr4KEebUHpbQC9WaCwGq6+ZMD5m4zBZmcy0oz5AspuW/c7Roe8LBeA8yQ+d1XtFGZcrYxTb51POlC3IhMjUyJdANY6mT7JdwXUnN+94YKOdfgQD6RTj0AFsyAZNwl7FxhUu943lj0KQahKtiGO/TCs8QjP MqfFTvud 3tGukDGsq1KjYRtv0TFGd5l99cmxUW82wfBC7Svx0a8+tGjakh9+90poW2p6atGncAhmK7AGI7qV8l+CSfP1s8hcBQK/yIImi/FE9sv+VcOM0DG7LExnf9/dRoc/WFXI8A7w8j+unypZBA8nqpgukdDps0Z5BSZTKHfT2ngebDW7se/NEeeYOQBPKMUMrT2UYo7e5DKyjg1MMsMF3brFPlB54ApM+bn0gdYG8DEhm5UjxDWTzqdUr7zM3QkvBBwejalFYdx0g4XwuMDT3GYabA+F/bsZZNx7si+qSTkLwyR09tdM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: DAMON debugfs interface deprecation message is written twice, once for the warning, and again for DEPRECATED file's read output. De-duplicate those by defining the message as a macro and reuse. Signed-off-by: SeongJae Park --- mm/damon/dbgfs.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c index fc6ece5a9f37..fbc0cd63f34c 100644 --- a/mm/damon/dbgfs.c +++ b/mm/damon/dbgfs.c @@ -15,6 +15,11 @@ #include #include +#define DAMON_DBGFS_DEPRECATION_NOTICE \ + "DAMON debugfs interface is deprecated, so users should move " \ + "to DAMON_SYSFS. If you cannot, please report your usecase to " \ + "damon@lists.linux.dev and linux-mm@kvack.org.\n" + static struct damon_ctx **dbgfs_ctxs; static int dbgfs_nr_ctxs; static struct dentry **dbgfs_dirs; @@ -22,10 +27,7 @@ static DEFINE_MUTEX(damon_dbgfs_lock); static void damon_dbgfs_warn_deprecation(void) { - pr_warn_once("DAMON debugfs interface is deprecated, " - "so users should move to DAMON_SYSFS. If you cannot, " - "please report your usecase to damon@lists.linux.dev and " - "linux-mm@kvack.org.\n"); + pr_warn_once(DAMON_DBGFS_DEPRECATION_NOTICE); } /* @@ -808,10 +810,7 @@ static void dbgfs_destroy_ctx(struct damon_ctx *ctx) static ssize_t damon_dbgfs_deprecated_read(struct file *file, char __user *buf, size_t count, loff_t *ppos) { - char kbuf[512] = "DAMON debugfs interface is deprecated, " - "so users should move to DAMON_SYSFS. If you cannot, " - "please report your usecase to damon@lists.linux.dev and " - "linux-mm@kvack.org.\n"; + char kbuf[512] = DAMON_DBGFS_DEPRECATION_NOTICE; int len = strnlen(kbuf, 1024); return simple_read_from_buffer(buf, count, ppos, kbuf, len);