From patchwork Thu Feb 1 09:04:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marco Elver X-Patchwork-Id: 13540819 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE3EAC47DDB for ; Thu, 1 Feb 2024 09:04:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 514CA6B007B; Thu, 1 Feb 2024 04:04:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 49E066B007D; Thu, 1 Feb 2024 04:04:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3663B6B007E; Thu, 1 Feb 2024 04:04:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 235136B007B for ; Thu, 1 Feb 2024 04:04:45 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8E0B1140DCB for ; Thu, 1 Feb 2024 09:04:44 +0000 (UTC) X-FDA: 81742649688.21.FE935DB Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf30.hostedemail.com (Postfix) with ESMTP id E5EBB80009 for ; Thu, 1 Feb 2024 09:04:42 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=BqEHyJu5; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of 3ql67ZQUKCIkry8r4t11tyr.p1zyv07A-zzx8npx.14t@flex--elver.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3ql67ZQUKCIkry8r4t11tyr.p1zyv07A-zzx8npx.14t@flex--elver.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706778282; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=qvWvk4QvsQxB0P/BHzB26BqaiUYgtrBgA7rGlBoMg2M=; b=EdyA8a9d9haqWLbNsTrav64rIKAJAkktI87uvzHWCDuXEkUad771E2PXuZ6fOqoEAujFiB J3melZcapJ9LrC6XmmFfJ0n1gNQnpmobylBihJGvv93HEHPE1I4KRA+x13bD1jqShAQLdE Jgmh89M683VAvJNtEB46/xPq0V8lUTM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=BqEHyJu5; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of 3ql67ZQUKCIkry8r4t11tyr.p1zyv07A-zzx8npx.14t@flex--elver.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3ql67ZQUKCIkry8r4t11tyr.p1zyv07A-zzx8npx.14t@flex--elver.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706778283; a=rsa-sha256; cv=none; b=DLQPrB4vlNQq/7HLDavxZNa724DHbWWjnz4qNOgFcB5DGsFESjZ5eXW78ofXUVp0skn8T9 lYk5Z5JK/EiVq1vz0eA1MWTyLljUGlOm2PbfdMK24nXFpkjtC+GdRcYhMNXaXDVVWGHr6N l5nL8k9TkpwWcfNnadEk8bZN7TO3Ocg= Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-60420dcb127so922427b3.1 for ; Thu, 01 Feb 2024 01:04:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706778282; x=1707383082; darn=kvack.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=qvWvk4QvsQxB0P/BHzB26BqaiUYgtrBgA7rGlBoMg2M=; b=BqEHyJu5Jc1FTzJ0KMFboxoZmcL6SMQsUTvb4zCHi5Uhuz8Tv0uovM1LsA2yrjWTfM NsopDeAgPbzexP0MQ0rptfPzPURBa7X346UA2bjuZhNIauhskTzHVnbBVz9BkL4iW53R 4KtrHve11xA/5Hd9zENIMArvkbvLUfSGQ7CZEqXp2hafqu6IN+z011+b+ffUTXVnJkOX uFnR7gwMzCWk2OCPuguFRuN2K47nKP1dNoqWiiLqm+dkAYi6hNmGCaHmDjXtmMdgH2bZ O1U7eLn2GNS7wJYLvSTpY2c/oQiDQevjkI6H/HvSg7nPSTnhNIbA5a1Zc8+TVxJ5HJdW +10g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706778282; x=1707383082; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qvWvk4QvsQxB0P/BHzB26BqaiUYgtrBgA7rGlBoMg2M=; b=g9nbxE1oWeFbgqxW/lLZAX96rEEdBuDcgwmeNdpA7B/K3Gd8axPk36JncvyLNBiTFX VM3VS2u+HdE1/PIhFhovp7eir68AjQPADPkjtLA7br2GYB+tQSDUiPqny4FMJloYO47t 1KAO/sDmFG5J6bEX/wKlANtdsv+a0dc0W4ml+bQKullo8WybxoK+2m8j/1nRnzxvoHYM JEiHfOuYudtrwo33O23IhaKgKhKM5yFTxRMWruDnnSihaipbRz7O2YQ02m95EOiafyc2 tNcIj3spLKnnCNeK7C7V38FQV2uuRNyYI6W/xoU+VuiiFlRFxKT31z5PhE0M5meA7cHb bi2A== X-Gm-Message-State: AOJu0YxwdlbVTJ6wcgrQp6+XkjflVLAJtiPA4uzfmZi1FWgWsQmVzWLB P7LrtUfyptawtkPKmwFOL6+5hCOfRZmYi1hAefHrZOvTn5FkiiqJS4U1rBpFs7syEGmWesMP9Q= = X-Google-Smtp-Source: AGHT+IGMuY8j6HgmaOYL/yVI7EA1U7Y++bJ3lMlFLigy9FB5qwdbehhOpMkJ9usslQabmxdsVv6Y8adU6A== X-Received: from elver.muc.corp.google.com ([2a00:79e0:9c:201:c945:1806:ff53:36fa]) (user=elver job=sendgmr) by 2002:a81:99d8:0:b0:5ff:6e82:ea31 with SMTP id q207-20020a8199d8000000b005ff6e82ea31mr849671ywg.3.1706778282041; Thu, 01 Feb 2024 01:04:42 -0800 (PST) Date: Thu, 1 Feb 2024 10:04:30 +0100 Mime-Version: 1.0 X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog Message-ID: <20240201090434.1762340-1-elver@google.com> Subject: [PATCH -mm v2] stackdepot: fix -Wstringop-overflow warning From: Marco Elver To: elver@google.com, Andrew Morton Cc: Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kasan-dev@googlegroups.com, Stephen Rothwell X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E5EBB80009 X-Stat-Signature: xwocbers44kb3kdncf9u8sytxfqy9jik X-Rspam-User: X-HE-Tag: 1706778282-491498 X-HE-Meta: U2FsdGVkX19bG+ddaKJQUQoMD+Ulq1nWJbQU0aXNG0idrc7DQnP8BKo1bHSKD5wqIzOdhBgJmvE1j3nKRUAg76D5phs2+AgNcmS9ZZ/NGYEIoOjre7kaw/LbSdTKXBFtc0yU6u6I8LkU4PQao53D4VhhCI/JEl8Y87jkRogQbItbwk+pTOZB0EbILPXu1WLqoJzhctyjHOGpY9xBTvK6p0qK0vZDO1XuO5vqFF/humEOHB4fSLH8vcCgup6H3l8+zThHIUU8TJqeBPaqVa5HhN6U4rwX7XB5w76hxGeXmybKPmgFWQ/KaMN/Dxf6vR/y6VCf4UAzZaVPBMzrHX016E6o6eVdTidGc+LME39qKQ6eJOsSvP+1HDDAzwUeKFV2gWfQLPZsfcIQ1qPFn8Fuor6v/O19ovIHXWQMOQTfInXN4/Pc2Ev1fOyGDa0YVYcxypTs1stOCqcCfkULzMQAHBp3ym8ZIZAhA3KeKn86Sr6TfY0FxCdrWPImofKJWupq9Oc9HjLXyq2vU0nJX8i2QoZpwfAI3K1LqAJoIG/48N+hpmlxR+rK/ucc12jtYObpJxzt+yxCEROj/jqWdmDKt8sivWYL+WaaTGhv1XvlxngXNmUufldbiusmnAEo/2aJQ27AkrXsG2GyAl3CFOuPgoU9TGWVvMPElfRQjPA9+URTXp/zEUhuaSmjWlV8mE+9i5Oqbugm/CjnPbRN24Qqnywfrh/Jg9EdUfU6ExaeZwgkJ/CouY/mhXwl43HhvESQBliGczZGxQis/rMD7PQrGz7rHS4Th8Y3IrhLUy2jjJNyj9Jt+FAh0UsViWbbY20sqqWmKC2ZsT9TNTRzJU38eAX/R/s3tstpINTHTXYaPdxd38COCFGh9uor2ma2zYpzQBIUAIn3pc2Cu58wARD18NBypll0v7I/7FmYdF67lGj0wjJvAXRVnMBKajyU3zODzMG8wn79m5QZx3hJJ+J D2EWscYJ lKrWxpSr3BnaSOomDikzcapspXT9fRxHwskkB6/IonleYzjctMQuLvlyAFf0NMv0EJRiww/OEHtJjz314VFourn5HdR0A8HNG3/0peW360kwlN0N6VvugLa/GI4Nls3LLifKbe/6D1eE8W4o79azkAPwfvQ+9Zo8emuYCz+BEYwroZKlGL3F6TMIgJekbckla5bYPj/GMAAJDxe90/Gg2wygWPzIC99s5arPUYFrWSYKcvk/NYhyWV/xl+Zhie21NMCutvHlTd3bfvN4zypN7lqkKzTe8FVlPIbKSsnx73MZfSbXtsfeBE8j8YdfgJQ3vzkiA5jviG4F0wHHngJjYBPvw4eQKi0fawomMdeNzovHFISXQ4iBzcryLvWdAlhQfHY1BA2nNgEJaaTW/craZaBsUaoauR2JqRfwhgMFVUwl9uufhRGPXodGF/++Ao2ILGZTZnYjDcEG0YAVqxFC3S2bpu8IuHkJiTW+Q9eioozNTMeMlhjZq6y2a60xuZFgLXsaonaSl3ggyGzmsOJkQnbw8jRF22+Rv5Gn0ulWwLi/ECDLVM/KthTKzsdEzbSwNhC9eCeq5fCYamOCeHGIfntov6Cr8Xa/GuHGPmu8l5xH2eGGdHwxMTlbDY5TZCIKvtaaNb0VDqbf9al2DP6Q90jmksMNusL9LZvX+H4SfjiNSTB49JLXUuGPq9rtrpGvzo2VO0IoQ6SbOoGpxmAVen2eOEA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Since 113a61863ecb ("Makefile: Enable -Wstringop-overflow globally") string overflow checking is enabled by default. Within stackdepot, the compiler (GCC 13.2.0) assumes that a multiplication overflow may be possible and flex_array_size() can return SIZE_MAX (4294967295 on 32-bit), resulting in this warning: In function 'depot_alloc_stack', inlined from 'stack_depot_save_flags' at lib/stackdepot.c:688:4: arch/x86/include/asm/string_32.h:150:25: error: '__builtin_memcpy' specified bound 4294967295 exceeds maximum object size 2147483647 [-Werror=stringop-overflow=] 150 | #define memcpy(t, f, n) __builtin_memcpy(t, f, n) | ^~~~~~~~~~~~~~~~~~~~~~~~~ lib/stackdepot.c:459:9: note: in expansion of macro 'memcpy' 459 | memcpy(stack->entries, entries, flex_array_size(stack, entries, nr_entries)); | ^~~~~~ cc1: all warnings being treated as errors This is due to depot_alloc_stack() accepting an 'int nr_entries' which could be negative without deeper analysis of callers. The call to depot_alloc_stack() from stack_depot_save_flags(), however, only passes in its nr_entries which is unsigned int. Fix the warning by switching depot_alloc_stack()'s nr_entries to also be unsigned. Link: https://lore.kernel.org/all/20240201135747.18eca98e@canb.auug.org.au/ Fixes: d869d3fb362c ("stackdepot: use variable size records for non-evictable entries") Reported-by: Stephen Rothwell Signed-off-by: Marco Elver Reviewed-by: Andrey Konovalov --- v2: * Just switch 'nr_entries' to unsigned int which is already the case elsewhere. --- lib/stackdepot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/stackdepot.c b/lib/stackdepot.c index 8f3b2c84ec2d..4a7055a63d9f 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -420,7 +420,7 @@ static inline size_t depot_stack_record_size(struct stack_record *s, unsigned in /* Allocates a new stack in a stack depot pool. */ static struct stack_record * -depot_alloc_stack(unsigned long *entries, int nr_entries, u32 hash, depot_flags_t flags, void **prealloc) +depot_alloc_stack(unsigned long *entries, unsigned int nr_entries, u32 hash, depot_flags_t flags, void **prealloc) { struct stack_record *stack = NULL; size_t record_size;