From patchwork Fri Feb 2 08:07:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Roberts X-Patchwork-Id: 13542349 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA04DC47258 for ; Fri, 2 Feb 2024 08:09:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EAC26B009E; Fri, 2 Feb 2024 03:09:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 599F06B009F; Fri, 2 Feb 2024 03:09:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 414C16B00A0; Fri, 2 Feb 2024 03:09:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 311626B009E for ; Fri, 2 Feb 2024 03:09:12 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0D6EC160F30 for ; Fri, 2 Feb 2024 08:09:12 +0000 (UTC) X-FDA: 81746138544.29.8BAF414 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf11.hostedemail.com (Postfix) with ESMTP id 656B74000C for ; Fri, 2 Feb 2024 08:09:10 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706861350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/BCYDUOM6grDx0BQxG+5TvCOyfppgVqDK+cfK1dp4FA=; b=f5FhTV6PvcezCvo5GD6MndQ8rjrQbNZMlVHOYNOk0Wow52ZcjNBLl8WZLVI0nRLki/wN9U gqtMKsVEuU9uwtiQXUdTwdbdAZWUB/K7o9+qWMCtSxQHkDlPMxeNwqeoOUc7DCNagORC03 xllieERNVTSZeAM+oCLx21LTK5DyBk4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706861350; a=rsa-sha256; cv=none; b=hwa+ODNY9nqyx6DihKxr+TePudFnLWU65BdDNQ5OCDqIqqBsf9BChucVj5do6X5g3V82UU nav3aIxxJgTnykbto64bZM39ba8HgIzZgeW9mIl5vDZKnxhW2f6ajlOGuCwR/px346Bf6S CflDnDV6/gVMKV8QVdo6SdvJ2yqiuuA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 159451A00; Fri, 2 Feb 2024 00:09:52 -0800 (PST) Received: from e125769.cambridge.arm.com (e125769.cambridge.arm.com [10.1.196.26]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 29E883F5A1; Fri, 2 Feb 2024 00:09:06 -0800 (PST) From: Ryan Roberts To: Catalin Marinas , Will Deacon , Ard Biesheuvel , Marc Zyngier , James Morse , Andrey Ryabinin , Andrew Morton , Matthew Wilcox , Mark Rutland , David Hildenbrand , Kefeng Wang , John Hubbard , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , Yang Shi , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Cc: Ryan Roberts , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 14/25] arm64/mm: ptep_clear_flush_young(): New layer to manage contig bit Date: Fri, 2 Feb 2024 08:07:45 +0000 Message-Id: <20240202080756.1453939-15-ryan.roberts@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240202080756.1453939-1-ryan.roberts@arm.com> References: <20240202080756.1453939-1-ryan.roberts@arm.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 656B74000C X-Rspam-User: X-Stat-Signature: bjx63zgj5qghtcgnsuqr4wwjc47zexxb X-Rspamd-Server: rspam03 X-HE-Tag: 1706861350-200017 X-HE-Meta: U2FsdGVkX19ok4KAtyJPdELKawzUuWefpsMcmVOuaP8o4ntVpjbLLuSS5hAZo9TIXC8g+LgPdsGjmNJNDHI92AnkgIosZqUbo9bqqDI6QtAB7mcDjONVHw9YxY1vsiCD4d+NfmjkkGjpO/ojJiN47Z9Lfht0falBlQnizYvk1YYqbfPQKyTtjDU+3910BsBwNcwaH6SCt5Z08zyC3vHir6Zc44QQuiADrHeZzhj41n88c35N9UB0FPcuEI2Im2YewTno65vzf17Hv33iT1gJDEOoXN2V/Pl+VBZExH1Ur0ge+CXUJKO8fyLbVIbWSHRAc5z87ZlO/ezWc/LDxAmalmXmh5B7jhPQtspNJ3tPe66lLpJtbbvkjferldHU8UcFvvHZE/4Kw+tYNi6Z4YX4/7xxsq8E3pUkD4Z1tIYFaZB8GuKmFN601n/HTcXMLUas/BMM45KGEiqYNwU+Ngz4nyAdLlVFrLM41zRhYK8w3cZ9x3zKihTy7gglL1QBtA9oB8XEJ+kBXxQ0QAkA4QhDcaT7OVB1w2Lr3tDY+Q4dmzL+/Vj2Sao/+QupLgMzBP4Ex/IOyGbcBoTOlShXqoMrtOlqSSUcOOFm6d+GMCZr6uYw1U6M0snmi1W0yqQloSFTsD0rhJrdkYGqDiU3okqkzAdbu1v2//ovQN3jXnPhD4CXz+dgEPF0+uhEgl/pq2qVVuWnpdZPdi3l08wTgSVCBxSjAqW34BVCp0b9gukEk8ZjaZ+rEWOhJUaJ87kr6p3rfipjspomRhOsN5vTEIADxbNSUJeTy5fobQpdwShBkCr5GDiDI0ivqzdirbZZmUSAtq/XFjtCzvV/el4ROniaI53UvW9HCy0gF/twobphGw6WcxkP31WMaZqqhzO90SeMsqWbEiX3YUoT2ZzS0RfHezzgU7kdqgPCNIfVE/9ZxKf4KVjgpSkZMfbcL4XZTK34INUMD1eIyLMpXK1u3c6 elw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Create a new layer for the in-table PTE manipulation APIs. For now, The existing API is prefixed with double underscore to become the arch-private API and the public API is just a simple wrapper that calls the private API. The public API implementation will subsequently be used to transparently manipulate the contiguous bit where appropriate. But since there are already some contig-aware users (e.g. hugetlb, kernel mapper), we must first ensure those users use the private API directly so that the future contig-bit manipulations in the public API do not interfere with those existing uses. Tested-by: John Hubbard Signed-off-by: Ryan Roberts --- arch/arm64/include/asm/pgtable.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h index 77a8b100e1cd..2870bc12f288 100644 --- a/arch/arm64/include/asm/pgtable.h +++ b/arch/arm64/include/asm/pgtable.h @@ -138,7 +138,7 @@ static inline pteval_t __phys_to_pte_val(phys_addr_t phys) * so that we don't erroneously return false for pages that have been * remapped as PROT_NONE but are yet to be flushed from the TLB. * Note that we can't make any assumptions based on the state of the access - * flag, since ptep_clear_flush_young() elides a DSB when invalidating the + * flag, since __ptep_clear_flush_young() elides a DSB when invalidating the * TLB. */ #define pte_accessible(mm, pte) \ @@ -916,8 +916,7 @@ static inline int __ptep_test_and_clear_young(struct vm_area_struct *vma, return pte_young(pte); } -#define __HAVE_ARCH_PTEP_CLEAR_YOUNG_FLUSH -static inline int ptep_clear_flush_young(struct vm_area_struct *vma, +static inline int __ptep_clear_flush_young(struct vm_area_struct *vma, unsigned long address, pte_t *ptep) { int young = __ptep_test_and_clear_young(vma, address, ptep); @@ -1138,6 +1137,8 @@ void vmemmap_update_pte(unsigned long addr, pte_t *ptep, pte_t pte); #define ptep_get_and_clear __ptep_get_and_clear #define __HAVE_ARCH_PTEP_TEST_AND_CLEAR_YOUNG #define ptep_test_and_clear_young __ptep_test_and_clear_young +#define __HAVE_ARCH_PTEP_CLEAR_YOUNG_FLUSH +#define ptep_clear_flush_young __ptep_clear_flush_young #endif /* !__ASSEMBLY__ */