From patchwork Fri Feb 2 21:00:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Desnoyers X-Patchwork-Id: 13543403 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C8E1C4828E for ; Fri, 2 Feb 2024 21:00:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 105206B0087; Fri, 2 Feb 2024 16:00:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 065496B008C; Fri, 2 Feb 2024 16:00:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAA706B0087; Fri, 2 Feb 2024 16:00:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AE4B56B0089 for ; Fri, 2 Feb 2024 16:00:31 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7071040FE4 for ; Fri, 2 Feb 2024 21:00:31 +0000 (UTC) X-FDA: 81748082262.08.4D8D6B2 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) by imf30.hostedemail.com (Postfix) with ESMTP id 884D68001E for ; Fri, 2 Feb 2024 21:00:29 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=uUAHHnSH; spf=pass (imf30.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com; dmarc=pass (policy=none) header.from=efficios.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706907629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qoFC8C6ZSnf/nETi8dojk/VMfXsfmFrumNn7+RHaPbE=; b=nFOYeyX6309+a+6sU1bWvvMXfp+fYVHvCwOSsozH0mwyQRDHpVa8o8aXBX39EJV4JZq39g SblsVg3hm48MPQb6s+MswIUEMo5JvMHy+ZJ/pisIyrJt2Ai2Uk76MNv3Bop0rWvXnYmGQt Akc910FjZiKsknP5NXCGHb5UkBxQ0eg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706907629; a=rsa-sha256; cv=none; b=NFkTIgesdLvVjgfIYyfcej+DhJoTFjsMj9Z7kfCiMuiPh9MfudL/6ji2/sT20j/RF3KAnm 9ia4HpTYFnnHD1yushmH8XI5Exb9Trs22OhgPyZdoV59Vaf+OeyOdgNMuUpUOXCMtYZy67 3UQEDzfX7afrltX5zupNIrojeI13jsI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=uUAHHnSH; spf=pass (imf30.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com; dmarc=pass (policy=none) header.from=efficios.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1706907628; bh=NIplNKYnPiSxsRcYozD6/Em7BpOZVdeSTtUJ6fu0NbI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uUAHHnSH9qyqiPFbxwBtx0+D9xq4cbcOGLgW4N3moWcT7pudTHalnE5g1pd42JIw1 E3TN3gqn3EUKS2dS9BzMQmTDoF+b7/+Qo4cwDn0a2ByIW+HF+RdPmI8Gicr0hw2PC1 rvL4NM2lV7/3fJAgKuzVhmtLD4sYUctQymj+dRbaw03MRctwLcGdqytl4bAfkLRnmT 4zEaxXtJqlO+Duz6P4JaEGwtf4+/NJP0OjTM0KP4jY3eHJU+9XKKJK07j50wLLNsZI 5soy4VlB1L6a0Mfw3iWgCtncLHEZ7CxNE1IQAbBR3d217g1gnazmhpUoUCZ9XrHKcd Qr321w76PHugg== Received: from thinkos.internal.efficios.com (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4TRSph2fcvzX4S; Fri, 2 Feb 2024 16:00:28 -0500 (EST) From: Mathieu Desnoyers To: Dan Williams , Arnd Bergmann , Dave Chinner Cc: linux-kernel@vger.kernel.org, Mathieu Desnoyers , Andrew Morton , Linus Torvalds , Vishal Verma , Dave Jiang , Matthew Wilcox , Russell King , linux-arch@vger.kernel.org, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, dm-devel@lists.linux.dev, nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, Alasdair Kergon , Mike Snitzer , Mikulas Patocka Subject: [RFC PATCH v4 04/12] dcssblk: Handle alloc_dax() -EOPNOTSUPP failure Date: Fri, 2 Feb 2024 16:00:11 -0500 Message-Id: <20240202210019.88022-5-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240202210019.88022-1-mathieu.desnoyers@efficios.com> References: <20240202210019.88022-1-mathieu.desnoyers@efficios.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 884D68001E X-Rspam-User: X-Stat-Signature: xaqfa9ejf17t4kycfhatwnjexw87fkbc X-Rspamd-Server: rspam03 X-HE-Tag: 1706907629-734742 X-HE-Meta: U2FsdGVkX19549NP6NnQwNJeXSq8RuByd5avBHObumBz85zq2BBFwSQZvGgL7+HtX4ad6TIO0Mc7vGODo9OpDzq/dxEA7UoP8QnUba+9xMdnkfCRFvIjL/gjTUnfctoldBmd8lX/oI4MVtspWzNt4C9cEJ7A9oMPp+6cXzw6BhxzFmvhKrAZv3eIaUCy/oirdhiXFWxazBDUSYEvhqgUQ4wBstdsLVsW/NoyZy2VsDcvtonBPX9WUq4qyJqsOSFaJVtXoujWHa3lo59lxTQVHNoRjT6ZteiFWNTdgZHSO3rRByEpcnFZjIlrFP9pR9l7s1PG4fTMjE1JMO3SgmyVctrJTvrtaYE9O+HV1yFKEaXX83jKnvoPW71H2RPk/I7c8uaEvS62X5vXgBnkhI4izemfOqYEYvqDt4sSNCAFDM+NsRyVyT7mY5v7vyYhTjy2nTm603WsVmrk1vj7+e2wM8ChtYDFiVGo9T/kiqqeFDbi/JmAJTJHyqaRAyQqL9NAACahtphsJ32e+47D4aRlFcTFj3PU2nf7BJKAKuyIPSWjAFkBg0LvAT50yF0G0R+DLdHIxJPo0qKuuV4+46+hmZKGOfxOfaCLngzZF/V2kPZGRWgMNEMDloUcw42UKMzRJOTfRe/LNKNUdI6fMMPmqtiVrJOXIhcnApjIf9p9KFhT6ddHDBl0Kjl3Vk3nIhvCcmsfYishdZFgAVjrKCbAayx3RkIKj7j8h+Cb2Imj0+Yyr4fxPwztXUapqC1ZW5aOQko3aXktR1e5FxjMYaRC7vZoG8YCSwdaiK0OR22jker7ukZ/E9SUdhTJ7QtH6YuQIHacUNrFlmxHByCNSAkrl1nwaiMH/GI/kKd+BOU1h0YC3wLC6Yy8vubGhttqRft5hckka+se23H3coTaoXyJH4fhIkXr3xLi61b9McDZlIgEBLs8O+KoVDmrs8KFzDqsRYK2Ky1ty7HEVZGTw08 yanQRIeB fUvJoYFwfDplm7/+DBHGSCJkZAH/w2RKB/zxtl9qHwX2L7X7QnL/Cn4xxRuaFKQdwFgntnx2X/3YENB0cPcQMFjz0+iKq2G+rLwJE+CTQwdztu1IzseuzBZSbP3MuYh/ktSqNkVVimwt4UKbSKvt05aZcrm6EwWkGIexmNI1FU1C9jLClMSNTfHuAvRviv8ldCO9xOMzajTwt+H7C9hLjpChn3gZUYb1vFPVk9uvrRY8hoe0pxrqEL8NSuni0seLdlX0R4SliJxo9M+hVxR0R0W2EfR36l1hnBhMp6KMdwycwsw03BuHbI86E2NaxAK5RZBvdmsJFsv7GJNkg4cpEopMYrwRFnm2qKu/OJYv+0c1C1gTvcHvYnEhpi3QgTxp4UxUvTOZGl9msl71H/ybQ9x2lruEokM5bGF/tXh3JeDLLeeGHprqfGr9X5/mqor53KQ2/gxFuwRByRgR+cOmlgxB2GzUJ8nR+M0UJvl90lS41Bq0wZiS725JZs/aucLdts2XbnZMjKc9xDbj+fG/2iOXZE9/Iecrdxz4j4T+pJ2BvUekFgvyH1pJRGLRW8c4TVjh2Udj+uccOJy0Sx1yKt4SV3R+3MEmgNgRgMfjzFVYnohnm+Yr+3CjSdo12iThkrx1xBQMpS/4MwnM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In preparation for checking whether the architecture has data cache aliasing within alloc_dax(), modify the error handling of dcssblk dcssblk_add_store() to handle alloc_dax() -EOPNOTSUPP failures. Considering that s390 is not a data cache aliasing architecture, and considering that DCSSBLK selects DAX, a return value of -EOPNOTSUPP from alloc_dax() should make dcssblk_add_store() fail. For the transition, consider that alloc_dax() returning NULL is the same as returning -EOPNOTSUPP. Fixes: d92576f1167c ("dax: does not work correctly with virtual aliasing caches") Signed-off-by: Mathieu Desnoyers Cc: Alasdair Kergon Cc: Mike Snitzer Cc: Mikulas Patocka Cc: Andrew Morton Cc: Linus Torvalds Cc: Dan Williams Cc: Vishal Verma Cc: Dave Jiang Cc: Matthew Wilcox Cc: Arnd Bergmann Cc: Russell King Cc: linux-arch@vger.kernel.org Cc: linux-cxl@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org Cc: linux-mm@kvack.org Cc: linux-xfs@vger.kernel.org Cc: dm-devel@lists.linux.dev Cc: nvdimm@lists.linux.dev Cc: linux-s390@vger.kernel.org --- drivers/s390/block/dcssblk.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c index 4b7ecd4fd431..a3010849bfed 100644 --- a/drivers/s390/block/dcssblk.c +++ b/drivers/s390/block/dcssblk.c @@ -549,6 +549,7 @@ dcssblk_add_store(struct device *dev, struct device_attribute *attr, const char int rc, i, j, num_of_segments; struct dcssblk_dev_info *dev_info; struct segment_info *seg_info, *temp; + struct dax_device *dax_dev; char *local_buf; unsigned long seg_byte_size; @@ -677,13 +678,13 @@ dcssblk_add_store(struct device *dev, struct device_attribute *attr, const char if (rc) goto put_dev; - dev_info->dax_dev = alloc_dax(dev_info, &dcssblk_dax_ops); - if (IS_ERR(dev_info->dax_dev)) { - rc = PTR_ERR(dev_info->dax_dev); - dev_info->dax_dev = NULL; + dax_dev = alloc_dax(dev_info, &dcssblk_dax_ops); + if (IS_ERR_OR_NULL(dax_dev)) { + rc = IS_ERR(dax_dev) ? PTR_ERR(dax_dev) : -EOPNOTSUPP; goto put_dev; } - set_dax_synchronous(dev_info->dax_dev); + set_dax_synchronous(dax_dev); + dev_info->dax_dev = dax_dev; rc = dax_add_host(dev_info->dax_dev, dev_info->gd); if (rc) goto out_dax;