From patchwork Thu Feb 8 18:49:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Desnoyers X-Patchwork-Id: 13550322 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C1A6C4828F for ; Thu, 8 Feb 2024 18:49:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38A9A6B0085; Thu, 8 Feb 2024 13:49:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EC4C6B0087; Thu, 8 Feb 2024 13:49:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02CF76B0089; Thu, 8 Feb 2024 13:49:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E5A4F6B0087 for ; Thu, 8 Feb 2024 13:49:26 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BCD6C407D3 for ; Thu, 8 Feb 2024 18:49:26 +0000 (UTC) X-FDA: 81769524732.21.AD420D4 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) by imf01.hostedemail.com (Postfix) with ESMTP id 2F21940011 for ; Thu, 8 Feb 2024 18:49:24 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=rGs7b1kF; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf01.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707418165; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qoFC8C6ZSnf/nETi8dojk/VMfXsfmFrumNn7+RHaPbE=; b=ku/7gMP6nr+dUGQVKFbLqeckg3PVT2RXeeIAueI4PbX2ihbLP6KMxs3Ct4mpdBzRa7py2D qtxR6HaN04zexaUeSiT+wJ1NArIujAWEldcvi/exhmZU8X9pjCoAuSQ7GLPgLvLIk8KiJG uYzoNALowJ4+/uS76cNXZqPbX0Ck8RI= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=rGs7b1kF; dmarc=pass (policy=none) header.from=efficios.com; spf=pass (imf01.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707418165; a=rsa-sha256; cv=none; b=b01llTomyXAUa3k4aUnwV/7g2iPGOS2DDZE7UeM4hMkG3r6r/iNyDpTuqwsarir/OQMF9+ HbfxtMLp9RjEAHqFSsgWmIJxkaC9kN6irKYYqIJSa8cn5HZTZUHWVGx0EHRq4Hp/idpoBP fwZJpgqeP0zCMYhi+TGgvIU2ptc9FlI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1707418164; bh=NIplNKYnPiSxsRcYozD6/Em7BpOZVdeSTtUJ6fu0NbI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rGs7b1kFhgfAs3N/uvEWI1LxOdWWwOf5Idgjm+vAqNckZQpPBHfp3mnqwBxXijrHv 5KiC01SlkwbHwbvsekSqj9SSiIfc95BaqD1nYMoY7nP0Mk3CxY2cdTsE6XvAKevwPP vnyZOaqMa+GfTPHHNezRYLo+7hkjmHDL8EOr/Q6EPiSPZ5iRUshHstOAdlIBni2RMp XgXFTCjlqGhkB6UpGo5vnJh10r7UGM3RRHCVc84K8RQBgvZ89az4CSg9N71n0g7y8o mYRgyniqWFk6i7vnViayymIyI1PE+SlxBZ1BUkhtw3NPOY38OlCnjyRF2bYF4Asfiy Y7nc3TPTaQzkA== Received: from thinkos.internal.efficios.com (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4TW5ch0pC3zY9Z; Thu, 8 Feb 2024 13:49:24 -0500 (EST) From: Mathieu Desnoyers To: Dan Williams , Arnd Bergmann , Dave Chinner Cc: linux-kernel@vger.kernel.org, Mathieu Desnoyers , Andrew Morton , Linus Torvalds , Vishal Verma , Dave Jiang , Matthew Wilcox , Russell King , linux-arch@vger.kernel.org, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, dm-devel@lists.linux.dev, nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, Alasdair Kergon , Mike Snitzer , Mikulas Patocka Subject: [PATCH v4 04/12] dcssblk: Handle alloc_dax() -EOPNOTSUPP failure Date: Thu, 8 Feb 2024 13:49:05 -0500 Message-Id: <20240208184913.484340-5-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240208184913.484340-1-mathieu.desnoyers@efficios.com> References: <20240208184913.484340-1-mathieu.desnoyers@efficios.com> MIME-Version: 1.0 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2F21940011 X-Stat-Signature: yaxhqgoj74ypztzhn1k39ubkah9pdg46 X-Rspam-User: X-HE-Tag: 1707418164-518666 X-HE-Meta: U2FsdGVkX1/7vocUevyJlQtSABtg0/BYMk3mRAm+xV0G2rWglDNlcoAtSkdiiR9/8pqrHqVAjT1rJgQxWp3fD3TyAlgShIhx8sk3gUbm5DIeZRZ8eQH/fjxBlWze8WSPQS8/4MHa65nZRqOcwoeiAtri6TvXI92e4BG/glwothSCF/qSzzX+Y+gEqDbTH8FliqT3xPmYpioMi1HoMaw7V0HLt8khy1T1rom5F80EgxoU6MAHTXEZr0GKmOMTMRxa3fkGALFO2XrwOQOIn7P36IIhTIR9FGUWcO8TcQ2QkSgdTNXTLy2ZQj9DnE7AqvRjg8ZVdxDpTp6xe1A5USGL2RtksAwJfPXA2l8UJmGhdVtwivADYk3fTdm/4f5+xcc7W1f3GIo/I/idP1RPfAg6pFmu5lgcl0TDRjHq/zYQNefNvyEQZvKY8xVz99NGUMw1Fyi91YtvcFBJUK88/KM4+EJGid29/k4dYcF0rIlrprLsGQNl+2bUfImRNZKJnFX0KHinPHtPi5tLONEzRdEJoCAlPPqqNoJyxz4FhEoO9LpFbYn60Cc/NYegmnSEcWrO2zXyOO+MNcVSTiS8Jx7deJu5rpVdVKeVPamHz/VnQcFjxBjhej4w4Q7pBt3eBh51UN94TxDccxBup6q6xHzM6v432UGcWCQP8IhIeXXOidrdMv56HkuAN6RykPwgBpp+/D5LgUS4hyhIMoDL571Uu3cGRYT9GKiqgDitR0xImFd66JLPwhagIA/Trz5kV3mhU07LpVrYNQ3PRR4w8UVnnx96TcV3+CZLttWEvZ2RMNa2O7qOJJp46+EEu1Sk2IF42+wPd7o6ooydrWvN1QYBF2BKR49LHK0CUq1hrzcOEH6ehL5W78YeduInOz8fCh61PDJEtowKilJ39iyPcTWMw0SwmaWjvxIxucuCoY9b4TZfWJUnSjZAHf2NW2DOeak6xN5tt6mdCHUIqCVhmOC yanpSigg jVx01pjXbR5qP45kSxP0es+i17LKtftPxQyejOmLpp8BsZIAMFfU7x/Sjf+I6Wxp4EVZOuFL+2gooAgP1GW+VNujeHho/G51cOnxb3tH9oxJrrBsYNBnk3dBvxM0+J8BTyzazS8KwA6p2b056DZUfGA0mh3rd17HNbOUG8flEmniKEwqnrIXepwL1Kut8xl3Osmve5wZt/Fi6vP9fukKx9+fRALS9MoWTc1fRYWVfFl1E/JV8AbCOxViYPKiND9zQz16LFiubdtKIh14jSPIUpiE9NcTyO6EvS7KDZtq6cS5lEeHvX67Safq1QJ7p6urSV/rS4Sgv/W89fsqRkUz5SyKE3d4pR/4Rxo8EpWvjSJ61laWkEJAqAYQheSjQNi5o7T2vCJyCHdzQvt9Z+TJQHOIRE2m9uiZuSG3i3WUJYcMaUtrKIIrKnBFMA1Mk6KNIJacnp0eZQcCOv6KXIJjfGOQVemj45pBpdFz/kWbTQT8UTcpvaz9kVWued5wIqIoNc2jP+NYb+jmQLb4fFNMEd53dgx4B/GccjP/ZbaKhRioGaH3EEtZyPBrkx106z1DNbAPXS3bpMyFEWEvtKoa2gu77cti07EhaXuSUGPhYVVCyN4FjX4oduGLChs5D5J+mIevUsNf2/yVyoxI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In preparation for checking whether the architecture has data cache aliasing within alloc_dax(), modify the error handling of dcssblk dcssblk_add_store() to handle alloc_dax() -EOPNOTSUPP failures. Considering that s390 is not a data cache aliasing architecture, and considering that DCSSBLK selects DAX, a return value of -EOPNOTSUPP from alloc_dax() should make dcssblk_add_store() fail. For the transition, consider that alloc_dax() returning NULL is the same as returning -EOPNOTSUPP. Fixes: d92576f1167c ("dax: does not work correctly with virtual aliasing caches") Signed-off-by: Mathieu Desnoyers Cc: Alasdair Kergon Cc: Mike Snitzer Cc: Mikulas Patocka Cc: Andrew Morton Cc: Linus Torvalds Cc: Dan Williams Cc: Vishal Verma Cc: Dave Jiang Cc: Matthew Wilcox Cc: Arnd Bergmann Cc: Russell King Cc: linux-arch@vger.kernel.org Cc: linux-cxl@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org Cc: linux-mm@kvack.org Cc: linux-xfs@vger.kernel.org Cc: dm-devel@lists.linux.dev Cc: nvdimm@lists.linux.dev Cc: linux-s390@vger.kernel.org --- drivers/s390/block/dcssblk.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c index 4b7ecd4fd431..a3010849bfed 100644 --- a/drivers/s390/block/dcssblk.c +++ b/drivers/s390/block/dcssblk.c @@ -549,6 +549,7 @@ dcssblk_add_store(struct device *dev, struct device_attribute *attr, const char int rc, i, j, num_of_segments; struct dcssblk_dev_info *dev_info; struct segment_info *seg_info, *temp; + struct dax_device *dax_dev; char *local_buf; unsigned long seg_byte_size; @@ -677,13 +678,13 @@ dcssblk_add_store(struct device *dev, struct device_attribute *attr, const char if (rc) goto put_dev; - dev_info->dax_dev = alloc_dax(dev_info, &dcssblk_dax_ops); - if (IS_ERR(dev_info->dax_dev)) { - rc = PTR_ERR(dev_info->dax_dev); - dev_info->dax_dev = NULL; + dax_dev = alloc_dax(dev_info, &dcssblk_dax_ops); + if (IS_ERR_OR_NULL(dax_dev)) { + rc = IS_ERR(dax_dev) ? PTR_ERR(dax_dev) : -EOPNOTSUPP; goto put_dev; } - set_dax_synchronous(dev_info->dax_dev); + set_dax_synchronous(dax_dev); + dev_info->dax_dev = dax_dev; rc = dax_add_host(dev_info->dax_dev, dev_info->gd); if (rc) goto out_dax;