From patchwork Mon Feb 12 18:29:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vlastimil Babka X-Patchwork-Id: 13553849 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E52FC4829E for ; Mon, 12 Feb 2024 18:30:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33A4E6B0072; Mon, 12 Feb 2024 13:30:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EAA76B0075; Mon, 12 Feb 2024 13:30:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16F616B007B; Mon, 12 Feb 2024 13:30:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0566B6B0072 for ; Mon, 12 Feb 2024 13:30:40 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B202A160B35 for ; Mon, 12 Feb 2024 18:30:39 +0000 (UTC) X-FDA: 81783992598.13.D92D64A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf05.hostedemail.com (Postfix) with ESMTP id 805E7100016 for ; Mon, 12 Feb 2024 18:30:37 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="0/hwuBum"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=b+U6b+pW; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="0/hwuBum"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=b+U6b+pW; spf=pass (imf05.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707762637; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=v5G/99tmVUbOuo9NvYuOOZiHrh75CYs7vqqYAovtwVs=; b=dRAFJyne/NAXrijVdkqDmIkv5GTBOhnun0741M/IIZhSoIIejCOeNRJfAiyj6ifIIL7EaB +2qak6Th7udrbbpAKgkZXXmv1Tch7U3qdzQ+0uGSstpJn7vnwLu6/ucUzmKH6/lziUtjKE ue4qpFoRipcOC/xjBDODLkhpdpAO3k8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707762637; a=rsa-sha256; cv=none; b=XFoM0XDNp5z2Ki3kJlENrZu/aTktPpTNyMcOqWtrrw/H8ZaCJI5r/xTUD3zUf1ZOBpk+OL X84UsSfRolSz1A6v5Qahjzrl2zNdlM1/tGiIL+ecE0RKcmYYh/zpCorOdyHaKM+8KJ0Hzz icqvoAVixIPxORf1bQIe58VGg61nAps= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="0/hwuBum"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=b+U6b+pW; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="0/hwuBum"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=b+U6b+pW; spf=pass (imf05.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D7FBF1FD57; Mon, 12 Feb 2024 18:30:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1707762635; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=v5G/99tmVUbOuo9NvYuOOZiHrh75CYs7vqqYAovtwVs=; b=0/hwuBumPqPbbsn4MvvwMY1ZlKEg9xSDTK7FjHXithOGgkM8TiaufL5j/Q2ergik+52SEG Ke+dope4YqdlhE9nXDp2nLRzCUeLF7EcSgrTcFfeMFdapAtutX6GQirvFNwLXN4/Jmcw2a 92lNWtuY8v15+LfeAaMdyEHyjfjRfLk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1707762635; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=v5G/99tmVUbOuo9NvYuOOZiHrh75CYs7vqqYAovtwVs=; b=b+U6b+pWz9q/ylIZfDXNiGN6Rv2EiarrxhbA26DI9vfzWtHN828IZZC1zQGa8LOwCp8i/Q wenw/aGqo09BQ9AQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1707762635; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=v5G/99tmVUbOuo9NvYuOOZiHrh75CYs7vqqYAovtwVs=; b=0/hwuBumPqPbbsn4MvvwMY1ZlKEg9xSDTK7FjHXithOGgkM8TiaufL5j/Q2ergik+52SEG Ke+dope4YqdlhE9nXDp2nLRzCUeLF7EcSgrTcFfeMFdapAtutX6GQirvFNwLXN4/Jmcw2a 92lNWtuY8v15+LfeAaMdyEHyjfjRfLk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1707762635; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=v5G/99tmVUbOuo9NvYuOOZiHrh75CYs7vqqYAovtwVs=; b=b+U6b+pWz9q/ylIZfDXNiGN6Rv2EiarrxhbA26DI9vfzWtHN828IZZC1zQGa8LOwCp8i/Q wenw/aGqo09BQ9AQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C0F8213404; Mon, 12 Feb 2024 18:30:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id dVXOLstjymVWEgAAD6G6ig (envelope-from ); Mon, 12 Feb 2024 18:30:35 +0000 From: Vlastimil Babka To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Mel Gorman , Matthew Wilcox , Kent Overstreet , Pasha Tatashin , Mike Rapoport , Vlastimil Babka Subject: [PATCH] mm: document memalloc_noreclaim_save() and memalloc_pin_save() Date: Mon, 12 Feb 2024 19:29:51 +0100 Message-ID: <20240212182950.32730-2-vbabka@suse.cz> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Rspamd-Queue-Id: 805E7100016 X-Rspam-User: X-Stat-Signature: je6rd61sa8yic6duyjxtp48wbbem4t88 X-Rspamd-Server: rspam03 X-HE-Tag: 1707762637-891417 X-HE-Meta: U2FsdGVkX19iLPMGKhbwc+qlOdLIzTvwMhhCj6XLeH3ikZLtrBjNWVeY4DnwnVwIag7G+Ay4UnvAkJYdxcyeYF1Y3Tc8snHyGLqK0dJaWzFQsskKBytys/59qJp2CM0UjS3wNhkrO/r6pBxRQdTpEa647rnXuprVT2m7BfPWyrXH2iIj8pWie8juIS/MuKB6o17kDe5IDPBmswb1i4mQZ9izH1wzfgpkaOEepsR+kp17NAGQ2JCMwJ5letkSaGfDqV1UCEkDl7vVBzjLUR5qGAjxNazO+PexO8vsAq8oGCVLkFmHuSY2uHHZr6kWREu4RjznG6XVU7ygphpbJBJZPnrRwtmorQBTL/ssFmUUaaz+Y+MwZUty8nDcZ5DkBDhnpTcPkLvnyH0ZxgULFUzS4zaQ8qh+MtJsDcNePvUPPjHd1eJslws5K/F2pQ1WNd1oqrsaBz381P0n5croZ0SagX3HEIgCFzFA4bkdXcgY4AaoRVcP59qAP7NbcfmOpbVhzhSGxxjaoYqn608RcD5bFAlC6ACrIA9m/bxry+W2hyWn9jk2d2OkoQCJcFoEmUcHCkoe37qrfNPVSitHHlP/4L3vZhCmLL1EEwQrbjxqINatCF/pApbrikNQIEjp0+dF+6YNgUQyhNosK2QNS434p7rIV8mDVnUq7DO70ZxT42fIJtJuppi68x7ng2qpKyQi9sZ1zPArDhPoXOnuUOj08mFATcAuki8hJuhJczO5iU7Jr6KzCSQN7VUFaknyWZuEzP2m+mhadhLsIAGeLP/lQRLzFyGjK2ybKJW7EbqTIJiaTwLs9/T/pVt3TgK+VBhd+FSKBkR9vjshPNzXzgXuRKP9vEb0AcCLzUQYtocuVZqefyrwJ16Q7t7NSHLBc+A+NiKURt2OJPE7Zuve+UlPs1UDCD0tm3MptTxebLSNgN2Pn/4rMT6uMpC/qs5CFUrppBhlfDVfk69MOTIymsA iaFUbI3C JqfIGExq+CdCj9tzCcy9PrzIkyWj0SDFMGwcehAWEZvbKg1IX9J5IRYRr+3+z3K3vI4AM1kIQ5kXmhtOeQxQIbLk+ka0GqhbjPqnyfZwmUtvrAGv5XC6ui0iI/+ZjPlPkLMpWSkAaWk3Cu+BWEuKCyM73sThlDHIpI8KP3dEXSZGjGbrckK6IlJXBc09KBaAMcODf0/l7XfN6B+HY3E+EqNJRWCYdtPh9rbRwOZVKLtksAuD6j+CAswLMm7L4R7JsFUuvOs/7xvQylrr4018/IaXmxngyygvI3trWrmYcBr4yI9RiXSVr4dG+x2tX/NmxgFiJRpH1c4Q659A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The memalloc_noreclaim_save() function currently has no documentation comment, so the implications of its usage are not obvious. Namely that it not only prevents entering reclaim (as the name suggests), but also allows using all memory reserves and thus should be only used in contexts that are allocating memory to free memory. This may lead to new improper usages being added. Thus add a documenting comment, based on the description of __GFP_MEMALLOC. While at it, also document memalloc_pin_save() so that all the memalloc_ scopes are documented. In the comments describing the relevant PF_MEMALLOC flags, refer to their scope setting functions. Signed-off-by: Vlastimil Babka Acked-by: Michal Hocko Reviewed-by: Mike Rapoport (IBM) --- include/linux/sched.h | 9 ++++---- include/linux/sched/mm.h | 45 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 50 insertions(+), 4 deletions(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index ffe8f618ab86..f2cb479f56a7 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1623,15 +1623,15 @@ extern struct pid *cad_pid; #define PF_SUPERPRIV 0x00000100 /* Used super-user privileges */ #define PF_DUMPCORE 0x00000200 /* Dumped core */ #define PF_SIGNALED 0x00000400 /* Killed by a signal */ -#define PF_MEMALLOC 0x00000800 /* Allocating memory */ +#define PF_MEMALLOC 0x00000800 /* Allocating memory to free memory. See memalloc_noreclaim_save() */ #define PF_NPROC_EXCEEDED 0x00001000 /* set_user() noticed that RLIMIT_NPROC was exceeded */ #define PF_USED_MATH 0x00002000 /* If unset the fpu must be initialized before use */ #define PF_USER_WORKER 0x00004000 /* Kernel thread cloned from userspace thread */ #define PF_NOFREEZE 0x00008000 /* This thread should not be frozen */ #define PF__HOLE__00010000 0x00010000 #define PF_KSWAPD 0x00020000 /* I am kswapd */ -#define PF_MEMALLOC_NOFS 0x00040000 /* All allocation requests will inherit GFP_NOFS */ -#define PF_MEMALLOC_NOIO 0x00080000 /* All allocation requests will inherit GFP_NOIO */ +#define PF_MEMALLOC_NOFS 0x00040000 /* All allocations inherit GFP_NOFS. See memalloc_nfs_save() */ +#define PF_MEMALLOC_NOIO 0x00080000 /* All allocations inherit GFP_NOIO. See memalloc_noio_save() */ #define PF_LOCAL_THROTTLE 0x00100000 /* Throttle writes only against the bdi I write to, * I am cleaning dirty pages from some other bdi. */ #define PF_KTHREAD 0x00200000 /* I am a kernel thread */ @@ -1641,7 +1641,8 @@ extern struct pid *cad_pid; #define PF__HOLE__02000000 0x02000000 #define PF_NO_SETAFFINITY 0x04000000 /* Userland is not allowed to meddle with cpus_mask */ #define PF_MCE_EARLY 0x08000000 /* Early kill for mce process policy */ -#define PF_MEMALLOC_PIN 0x10000000 /* Allocation context constrained to zones which allow long term pinning. */ +#define PF_MEMALLOC_PIN 0x10000000 /* Allocations constrained to zones which allow long term pinning. + * See memalloc_pin_save() */ #define PF__HOLE__20000000 0x20000000 #define PF__HOLE__40000000 0x40000000 #define PF_SUSPEND_TASK 0x80000000 /* This thread called freeze_processes() and should not be frozen */ diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h index 9a19f1b42f64..eef8fa5ba5de 100644 --- a/include/linux/sched/mm.h +++ b/include/linux/sched/mm.h @@ -368,6 +368,27 @@ static inline void memalloc_nofs_restore(unsigned int flags) current->flags = (current->flags & ~PF_MEMALLOC_NOFS) | flags; } +/** + * memalloc_noreclaim_save - Marks implicit __GFP_MEMALLOC scope. + * + * This functions marks the beginning of the __GFP_MEMALLOC allocation scope. + * All further allocations will implicitly add the __GFP_MEMALLOC flag, which + * prevents entering reclaim and allows access to all memory reserves. This + * should only be used when the caller guarantees the allocation will allow more + * memory to be freed very shortly, i.e. it needs to allocate some memory in + * the process of freeing memory, and cannot reclaim due to potential recursion. + * + * Users of this scope have to be extremely careful to not deplete the reserves + * completely and implement a throttling mechanism which controls the + * consumption of the reserve based on the amount of freed memory. Usage of a + * pre-allocated pool (e.g. mempool) should be always considered before using + * this scope. + * + * Individual allocations under the scope can opt out using __GFP_NOMEMALLOC + * + * This function should not be used in an interrupt context as that one does not + * give PF_MEMALLOC access to reserves, see __gfp_pfmemalloc_flags(). + */ static inline unsigned int memalloc_noreclaim_save(void) { unsigned int flags = current->flags & PF_MEMALLOC; @@ -375,11 +396,27 @@ static inline unsigned int memalloc_noreclaim_save(void) return flags; } +/** + * memalloc_noreclaim_restore - Ends the implicit __GFP_MEMALLOC scope. + * @flags: Flags to restore. + * + * Ends the implicit __GFP_MEMALLOC scope started by memalloc_noreclaim_save + * function. Always make sure that the given flags is the return value from the + * pairing memalloc_noreclaim_save call. + */ static inline void memalloc_noreclaim_restore(unsigned int flags) { current->flags = (current->flags & ~PF_MEMALLOC) | flags; } +/** + * memalloc_pin_save - Marks implicit ~__GFP_MOVABLE scope. + * + * This functions marks the beginning of the ~__GFP_MOVABLE allocation scope. + * All further allocations will implicitly remove the __GFP_MOVABLE flag, which + * will constraint the allocations to zones that allow long term pinning, i.e. + * not ZONE_MOVABLE zones. + */ static inline unsigned int memalloc_pin_save(void) { unsigned int flags = current->flags & PF_MEMALLOC_PIN; @@ -388,6 +425,14 @@ static inline unsigned int memalloc_pin_save(void) return flags; } +/** + * memalloc_pin_restore - Ends the implicit ~__GFP_MOVABLE scope. + * @flags: Flags to restore. + * + * Ends the implicit ~__GFP_MOVABLE scope started by memalloc_pin_save function. + * Always make sure that the given flags is the return value from the pairing + * memalloc_pin_save call. + */ static inline void memalloc_pin_restore(unsigned int flags) { current->flags = (current->flags & ~PF_MEMALLOC_PIN) | flags;