From patchwork Wed Feb 14 15:11:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jeff Xu X-Patchwork-Id: 13556651 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FFB3C48BC3 for ; Wed, 14 Feb 2024 15:11:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A9198D0019; Wed, 14 Feb 2024 10:11:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 607FF8D0016; Wed, 14 Feb 2024 10:11:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4338C8D0019; Wed, 14 Feb 2024 10:11:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 310058D0016 for ; Wed, 14 Feb 2024 10:11:54 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 03239120F5A for ; Wed, 14 Feb 2024 15:11:53 +0000 (UTC) X-FDA: 81790749348.19.2225D6D Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf18.hostedemail.com (Postfix) with ESMTP id 009A71C001A for ; Wed, 14 Feb 2024 15:11:51 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=aedJpqX8; spf=pass (imf18.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.210.172 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707923512; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OeOU341dpK7/pSwmZHIwR5hTdtPU0C8qFKSlDUuggDQ=; b=JUMwgqb1jszzDTpdE4RnYN2YMPQ9ZpoQPlRIgFQBn/6lgznlwak2R4F/BLiqxjvO6eFak6 5+kaKKu119AmfaiVNYjbhuqzuhRrPO2n8curMnXe659AIubS0S8P93m699XJVXS+OI+s/t F8yLlW2dzFHqAxnxnbMZPMcBx5m4TGY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707923512; a=rsa-sha256; cv=none; b=Y3CBtRbeTQd87v278fN/xy2NisPtswQhDMyjaKP47B8H+HWTyDeRPnghDXemKz1XmA9mjn iP/H8DEM+8gUlkARJGXUCRDKyI2SxRIfbuIlcyDoKR1IOqLegSRJ6sHXdlVCKxmIwfJs9K 8BLN1w1l27Lw745nhtANCSW+2e6gKlU= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=aedJpqX8; spf=pass (imf18.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.210.172 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6e104196e6eso1354873b3a.0 for ; Wed, 14 Feb 2024 07:11:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707923511; x=1708528311; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OeOU341dpK7/pSwmZHIwR5hTdtPU0C8qFKSlDUuggDQ=; b=aedJpqX86SJH+tg7/L9XG03eEeRi/gBdgYwnAoSCC5MwwB02FFXs3SAYiqXNFZBHd/ u8zTsi8kRYxE3bUBGMsX19ZrqMjn4ASKo4agBqtzSvHqKW1p7gnInRhqWzrr1vkxbkCH UqIht7gYI+JRo57Y5m4y19OfBnN2YL9QDeKbY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707923511; x=1708528311; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OeOU341dpK7/pSwmZHIwR5hTdtPU0C8qFKSlDUuggDQ=; b=EveaTo4h7m5y/Yje4PJe0/2FpxWbuIPKlirWRTJ/DAPBUPHoo6bljFWOYoRqUeuEvm Lr2Gormxbl8oKztiGZA7qQwnSjvudYq3HN/9tbUNqs/g1IuMFeRL5QGPNpIJ6AD3eE4R duDhay0t7+l4KbkjMO+eLPROA3/QR7YT+1rbkwlU4onXG2ueuBECa0KH8JaLKBqO4S+Q xhxgP0Nbg2h+eABAG+B87rGIvgsOFQPcezEES6DYpK+vmM4mLxfjrD6XkY7H8cLl9vvW QmfKN9SWxkXL07coaWvs785AR6K8eLuXMfSg4ZtzDZ1QAeJ8My/bUHkO/Te6OCSEXbt/ rrQQ== X-Forwarded-Encrypted: i=1; AJvYcCWSf0Kk2YNNX8matsxa7tPFxYaq/FyN5/Y/2edFTsgLw7k+DLP9FEQsdkRol/6dUznRWA1hu/48GCfxnY+mh5rAxaA= X-Gm-Message-State: AOJu0Yzaw17DUbQCd9HWfGi7Pq/gfYVGYKlR4LsjOL6Zz6txurQThrNV 8ZAUOxSabjQAIac3ud6aR0CU149SOlCMtsTFPgBXPK0o8WUO+ae3Cr+0Sj0Qag== X-Google-Smtp-Source: AGHT+IF4fmk7naPGR8TxwhNa8pfOTh7fhRpFbuE0eb/jb3WuH6PMiQ+VPjfiTPpPuqolWXtMYqGsbw== X-Received: by 2002:a05:6a20:6f8c:b0:19c:96e4:3671 with SMTP id gv12-20020a056a206f8c00b0019c96e43671mr3833752pzb.30.1707923510726; Wed, 14 Feb 2024 07:11:50 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCX0BGgcQPV3uP1lQPOUO28KGwWjMIVBV/p9Fc7LRZRg6amJg+l/sIpsmgWbG2aZQRNYcjE/YgJiWFHo2bNZb3sUbxn0R8Hn7r0uSeegQF7DDBGcpFCO4FrPilH7c0HKd+grDG/KtC6fPJbMdaS2/ljka+6eALg783sD7mOKOiUdUZi1//rgwVXwM/UF03iG6oKfkZKB1oTAmMqb50BhiB79WA433vBSw4aUVJp5GauMGMgo2bvwsWG38mkkvy1AUbO+/j1MsW010GRDBl+eILpPK20J8604lRBMMq35sc+4b2CYne4XRgijX1+QnvKBg7efvFgVxrJpYVveDqed/GMum1VHtJiON8wgLkmZjdrLwavgD+83luBhfUMpsgMhUZ/+AjRgnIr1NK6rxBP0CjA4D1Q/SMt0mb+/ZkdZfLVqBbOtOervrkKXHjztza7MXFDFFoxA02/0thwi6zFugdnxBj2Krxsm4B0Z/BgAJEGnqyZtE+aVL5i8I0qOGBahCjbAR3CvD2SBgW2Elc4F9SAiXi+plqnkz6a7/piIxFG2fUNIE2Qi14x8ixubhu7OIMTVqeIFahb3pVphMs+2Lp3dNvg+wFKk/mTpm3zZ3ehm+pBDexb9P3pvpSxD/kXYGaGrasdFlQ7QFs/PmKp+onBAiO+LWitLxE1o2Q950fPXaL7Yek3a1+nbtfIuvlXQoPSrplO5b2/jg/wV6HUFRoCm8CDoy83O5ymAdaicefVEQO4o8AkQRsRnmIrpqiGdSohX9NkL3wbmAwG/zy76zs8rc40= Received: from localhost (56.72.82.34.bc.googleusercontent.com. [34.82.72.56]) by smtp.gmail.com with UTF8SMTPSA id ll9-20020a056a00728900b006e05b63bf59sm9416083pfb.26.2024.02.14.07.11.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Feb 2024 07:11:50 -0800 (PST) From: jeffxu@chromium.org To: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, sroettger@google.com, willy@infradead.org, gregkh@linuxfoundation.org, torvalds@linux-foundation.org, usama.anjum@collabora.com, corbet@lwn.net, Liam.Howlett@oracle.com, surenb@google.com, merimus@google.com, rdunlap@infradead.org Cc: jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com, linux-hardening@vger.kernel.org, deraadt@openbsd.org, =David.Laight@aculab.com, Jeff Xu Subject: [PATCH v9 4/5] mseal:add documentation Date: Wed, 14 Feb 2024 15:11:28 +0000 Message-ID: <20240214151130.616240-5-jeffxu@chromium.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240214151130.616240-1-jeffxu@chromium.org> References: <20240214151130.616240-1-jeffxu@chromium.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 009A71C001A X-Rspam-User: X-Stat-Signature: 5hy96x5wcqewmubitynwn4daxo87ohb8 X-Rspamd-Server: rspam03 X-HE-Tag: 1707923511-838520 X-HE-Meta: U2FsdGVkX1+ackg6vsQx568YIwMaM+cJM2yxibG9mQsC3ctUECM0/z0OLbr+oZewtUz1hLXO2TkTTSdhK/kXmFujbQc9Nn78qduQrQKy/uU2rrAKzfujbSiMnNQg/l0C54rHYo3Q7+u3Yz/0TPaeofK2IQBYhyjEjAA4IfQPuFz2/Gw4dYktQRB7UcW1v6Zf3RV7DTBR8fx/flqRIMAox0/9/H/vnHiZIXBh0peuQd46+jtc/xWI6bRNMgjlurlESLZ/+YZP/rT00M+9vmteBAV/kZztmY4MZD7SjuDS2/nBhx9HGA4LG4X7HejY5o3oH4tU7D7Kbx8s9aGIJcSVTOyeJ4O3NySHC9VuvjbqAFCo5Q7lSbXagiOkd4fz8MxZRmHK1pZcpGgsoRiahqHRUVjlPe5Nas0sckUv7dnBh064oTIDqmmO0fYcmV/0QfbIradn8XA26t3rxkP/pACIXG9bckBdU686SXchepjl7H+sjhPlf8eD2sSf/cTZL8GEPwr9mtuT8qd5zL/gw4mF4DADG6MWPEZ5Hx5Yl8rLHNmsPN7EWPlC+Wvcvlgk4MUY5w3lE9Q2pTkh2yejmg6sI3pEQUkMNl1xGBhD2uzmZHhgeVvNl+j9T3+/yMagYK1+Tju3RfILNvKBtjgE4R2GT5yTo3uW/udvM27TVMEdgQYrf1OgzudHGmzztMixqwwIM86KstAMln3E5cCTyNYtyCA+Gp4KzV7p8Mcy4ZpBNTVqoZi71ZOhfgWOV5kM/yk1QJbxqlTMUgsDuWe7F4naoHrI8efJX3QqmYKFowAVsKQt4j6p+T5aon46IPY3zMOmi0XceRuc+R1UBfE7AfDBdRkmPHlxC3MlnHfU07VRtWv1d6XaUToxuSz1jPAhx+fSgMO6E4L1DRW1AarEpgTwTTGTUV66enWd8I5SjTtfapTDVsSGfix8xq2btjqTXChiJ6yZyIEl5TAzcwDsz0Z pQQCdPyQ eDq522DBQNQyjea44MtqCZSxN4NIstknOUxkZCXHTNPiUAGvWmCLjaqCVtrg2pD+7sJ6wuikpxRzKhB5j4RPqOMZGhLQ6UGr3+6AMnb5o4WxORDfCKhCbESvigMMH9mvvFUD13g00PeeNTF9JQH3YJcXYCes4zaXfb7uJ6sZZC96RHeUM2S+MjvXPIGOcFrofJ70v/lrLM8SlvKxy+VRbz6dPxabhgM1DVzZlXtCYFTFGB0N/VV38FUxUuWxUhbuaoI6z7Ojn9sKhkJkXZOBBWZwccCTgHu5GcX1Gw3YFKGzNYFNCeNAZfwVszBa98bEnVTQAKFpKhpi5zJRMaWAMUMb7kKpFLmrzmtRSDXHSrtqYYFN4qmQETCTKjwcm2d7aGUBQAS0BoLzwJrQDezYu4PeyDP4LOWTUjs70aenjRkfJWGIJ7a9NrGELO8dzrnRLjEdqDTY5BazfDPrqrSHhtdi0uuHtsNKp78TCaMjtDeZIiZ8sLh9ubTFIHDGJxaiQTIbaeMJGLu1sEmafa86z3LWkU6HIxKB/lDAYvLRZwA+ouRZCq1NSWXruRhBjPvjqTabQx0OGkQLChrjcrrnNtmzXvryj8qkMC0SyPY4zvRHy7JrbDxaxfsJc9gZUWUWNPB8+mAUJZdEBIvMPT/zprXmZ4g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Jeff Xu Add documentation for mseal(). Signed-off-by: Jeff Xu --- Documentation/userspace-api/index.rst | 1 + Documentation/userspace-api/mseal.rst | 199 ++++++++++++++++++++++++++ 2 files changed, 200 insertions(+) create mode 100644 Documentation/userspace-api/mseal.rst diff --git a/Documentation/userspace-api/index.rst b/Documentation/userspace-api/index.rst index 09f61bd2ac2e..178f6a1d79cb 100644 --- a/Documentation/userspace-api/index.rst +++ b/Documentation/userspace-api/index.rst @@ -26,6 +26,7 @@ place where this information is gathered. iommu iommufd media/index + mseal netlink/index sysfs-platform_profile vduse diff --git a/Documentation/userspace-api/mseal.rst b/Documentation/userspace-api/mseal.rst new file mode 100644 index 000000000000..4132eec995a3 --- /dev/null +++ b/Documentation/userspace-api/mseal.rst @@ -0,0 +1,199 @@ +.. SPDX-License-Identifier: GPL-2.0 + +===================== +Introduction of mseal +===================== + +:Author: Jeff Xu + +Modern CPUs support memory permissions such as RW and NX bits. The memory +permission feature improves security stance on memory corruption bugs, i.e. +the attacker can’t just write to arbitrary memory and point the code to it, +the memory has to be marked with X bit, or else an exception will happen. + +Memory sealing additionally protects the mapping itself against +modifications. This is useful to mitigate memory corruption issues where a +corrupted pointer is passed to a memory management system. For example, +such an attacker primitive can break control-flow integrity guarantees +since read-only memory that is supposed to be trusted can become writable +or .text pages can get remapped. Memory sealing can automatically be +applied by the runtime loader to seal .text and .rodata pages and +applications can additionally seal security critical data at runtime. + +A similar feature already exists in the XNU kernel with the +VM_FLAGS_PERMANENT flag [1] and on OpenBSD with the mimmutable syscall [2]. + +User API +======== +mseal() +----------- +The mseal() syscall has the following signature: + +``int mseal(void addr, size_t len, unsigned long flags)`` + +**addr/len**: virtual memory address range. + +The address range set by ``addr``/``len`` must meet: + - The start address must be in an allocated VMA. + - The start address must be page aligned. + - The end address (``addr`` + ``len``) must be in an allocated VMA. + - no gap (unallocated memory) between start and end address. + +The ``len`` will be paged aligned implicitly by the kernel. + +**flags**: reserved for future use. + +**return values**: + +- ``0``: Success. + +- ``-EINVAL``: + - Invalid input ``flags``. + - The start address (``addr``) is not page aligned. + - Address range (``addr`` + ``len``) overflow. + +- ``-ENOMEM``: + - The start address (``addr``) is not allocated. + - The end address (``addr`` + ``len``) is not allocated. + - A gap (unallocated memory) between start and end address. + +- ``-EPERM``: + - sealing is supported only on 64-bit CPUs, 32-bit is not supported. + +- For above error cases, users can expect the given memory range is + unmodified, i.e. no partial update. + +- There might be other internal errors/cases not listed here, e.g. + error during merging/splitting VMAs, or the process reaching the max + number of supported VMAs. In those cases, partial updates to the given + memory range could happen. However, those cases should be rare. + +**Blocked operations after sealing**: + Unmapping, moving to another location, and shrinking the size, + via munmap() and mremap(), can leave an empty space, therefore + can be replaced with a VMA with a new set of attributes. + + Moving or expanding a different VMA into the current location, + via mremap(). + + Modifying a VMA via mmap(MAP_FIXED). + + Size expansion, via mremap(), does not appear to pose any + specific risks to sealed VMAs. It is included anyway because + the use case is unclear. In any case, users can rely on + merging to expand a sealed VMA. + + mprotect() and pkey_mprotect(). + + Some destructive madvice() behaviors (e.g. MADV_DONTNEED) + for anonymous memory, when users don't have write permission to the + memory. Those behaviors can alter region contents by discarding pages, + effectively a memset(0) for anonymous memory. + + Kernel will return -EPERM for blocked operations. + + For blocked operations, one can expect the given address is unmodified, + i.e. no partial update. Note, this is different from existing mm + system call behaviors, where partial updates are made till an error is + found and returned to userspace. To give an example: + + Assume following code sequence: + + - ptr = mmap(null, 8192, PROT_NONE); + - munmap(ptr + 4096, 4096); + - ret1 = mprotect(ptr, 8192, PROT_READ); + - mseal(ptr, 4096); + - ret2 = mprotect(ptr, 8192, PROT_NONE); + + ret1 will be -ENOMEM, the page from ptr is updated to PROT_READ. + + ret2 will be -EPERM, the page remains to be PROT_READ. + +**Note**: + +- mseal() only works on 64-bit CPUs, not 32-bit CPU. + +- users can call mseal() multiple times, mseal() on an already sealed memory + is a no-action (not error). + +- munseal() is not supported. + +Use cases: +========== +- glibc: + The dynamic linker, during loading ELF executables, can apply sealing to + non-writable memory segments. + +- Chrome browser: protect some security sensitive data-structures. + +Notes on which memory to seal: +============================== + +It might be important to note that sealing changes the lifetime of a mapping, +i.e. the sealed mapping won’t be unmapped till the process terminates or the +exec system call is invoked. Applications can apply sealing to any virtual +memory region from userspace, but it is crucial to thoroughly analyze the +mapping's lifetime prior to apply the sealing. + +For example: + +- aio/shm + + aio/shm can call mmap()/munmap() on behalf of userspace, e.g. ksys_shmdt() in + shm.c. The lifetime of those mapping are not tied to the lifetime of the + process. If those memories are sealed from userspace, then munmap() will fail, + causing leaks in VMA address space during the lifetime of the process. + +- Brk (heap) + + Currently, userspace applications can seal parts of the heap by calling + malloc() and mseal(). + let's assume following calls from user space: + + - ptr = malloc(size); + - mprotect(ptr, size, RO); + - mseal(ptr, size); + - free(ptr); + + Technically, before mseal() is added, the user can change the protection of + the heap by calling mprotect(RO). As long as the user changes the protection + back to RW before free(), the memory range can be reused. + + Adding mseal() into the picture, however, the heap is then sealed partially, + the user can still free it, but the memory remains to be RO. If the address + is re-used by the heap manager for another malloc, the process might crash + soon after. Therefore, it is important not to apply sealing to any memory + that might get recycled. + + Furthermore, even if the application never calls the free() for the ptr, + the heap manager may invoke the brk system call to shrink the size of the + heap. In the kernel, the brk-shrink will call munmap(). Consequently, + depending on the location of the ptr, the outcome of brk-shrink is + nondeterministic. + + +Additional notes: +================= +As Jann Horn pointed out in [3], there are still a few ways to write +to RO memory, which is, in a way, by design. Those cases are not covered +by mseal(). If applications want to block such cases, sandbox tools (such as +seccomp, LSM, etc) might be considered. + +Those cases are: + +- Write to read-only memory through /proc/self/mem interface. +- Write to read-only memory through ptrace (such as PTRACE_POKETEXT). +- userfaultfd. + +The idea that inspired this patch comes from Stephen Röttger’s work in V8 +CFI [4]. Chrome browser in ChromeOS will be the first user of this API. + +Reference: +========== +[1] https://github.com/apple-oss-distributions/xnu/blob/1031c584a5e37aff177559b9f69dbd3c8c3fd30a/osfmk/mach/vm_statistics.h#L274 + +[2] https://man.openbsd.org/mimmutable.2 + +[3] https://lore.kernel.org/lkml/CAG48ez3ShUYey+ZAFsU2i1RpQn0a5eOs2hzQ426FkcgnfUGLvA@mail.gmail.com + +[4] https://docs.google.com/document/d/1O2jwK4dxI3nRcOJuPYkonhTkNQfbmwdvxQMyXgeaRHo/edit#heading=h.bvaojj9fu6hc