[v6,4/4] mm/compaction: optimize >0 order folio compaction with free page split.

Commit Message

Zi Yan Feb. 16, 2024, 5:04 p.m. UTC

From: Zi Yan <[e-mail]>

During migration in a memory compaction, free pages are placed in an array
of page lists based on their order.  But the desired free page order
(i.e., the order of a source page) might not be always present, thus
leading to migration failures and premature compaction termination.  Split
a high order free pages when source migration page has a lower order to
increase migration successful rate.

Note: merging free pages when a migration fails and a lower order free
page is returned via compaction_free() is possible, but there is too much
work.  Since the free pages are not buddy pages, it is hard to identify
these free pages using existing PFN-based page merging algorithm.

Signed-off-by: Zi Yan <[e-mail]>
Reviewed-by: Baolin Wang <[e-mail]>
Reviewed-by: Vlastimil Babka <[e-mail]>
Tested-by: Baolin Wang <[e-mail]>
Tested-by: Yu Zhao <[e-mail]>
Cc: Adam Manzanares <[e-mail]>
Cc: David Hildenbrand <[e-mail]>
Cc: Huang Ying <[e-mail]>
Cc: Johannes Weiner <[e-mail]>
Cc: Kemeng Shi <[e-mail]>
Cc: Kirill A. Shutemov <[e-mail]>
Cc: Luis Chamberlain <[e-mail]>
Cc: Matthew Wilcox (Oracle) <[e-mail]>
Cc: Mel Gorman <[e-mail]>
Cc: Ryan Roberts <[e-mail]>
Cc: Vishal Moola (Oracle) <[e-mail]>
Cc: Vlastimil Babka <[e-mail]>
Cc: Yin Fengwei <[e-mail]>
---
 mm/compaction.c | 35 ++++++++++++++++++++++++++++++-----
 1 file changed, 30 insertions(+), 5 deletions(-)

Patch

diff --git a/mm/compaction.c b/mm/compaction.c
index f21836ca243a..b2a570e00a8e 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1832,15 +1832,40 @@  static struct folio *compaction_alloc(struct folio *src, unsigned long data)
 	struct compact_control *cc = (struct compact_control *)data;
 	struct folio *dst;
 	int order = folio_order(src);
+	bool has_isolated_pages = false;
+	int start_order;
+	struct page *freepage;
+	unsigned long size;
+
+again:
+	for (start_order = order; start_order < NR_PAGE_ORDERS; start_order++)
+		if (!list_empty(&cc->freepages[start_order]))
+			break;
 
-	if (list_empty(&cc->freepages[order])) {
-		isolate_freepages(cc);
-		if (list_empty(&cc->freepages[order]))
+	/* no free pages in the list */
+	if (start_order == NR_PAGE_ORDERS) {
+		if (has_isolated_pages)
 			return NULL;
+		isolate_freepages(cc);
+		has_isolated_pages = true;
+		goto again;
+	}
+
+	freepage = list_first_entry(&cc->freepages[start_order], struct page,
+				lru);
+	size = 1 << start_order;
+
+	list_del(&freepage->lru);
+
+	while (start_order > order) {
+		start_order--;
+		size >>= 1;
+
+		list_add(&freepage[size].lru, &cc->freepages[start_order]);
+		set_page_private(&freepage[size], start_order);
 	}
+	dst = (struct folio *)freepage;
 
-	dst = list_first_entry(&cc->freepages[order], struct folio, lru);
-	list_del(&dst->lru);
 	post_alloc_hook(&dst->page, order, __GFP_MOVABLE);
 	if (order)
 		prep_compound_page(&dst->page, order);